From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74AFAC3DA64 for ; Thu, 1 Aug 2024 08:43:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 106C86B0098; Thu, 1 Aug 2024 04:43:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B31A6B0099; Thu, 1 Aug 2024 04:43:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBC486B009A; Thu, 1 Aug 2024 04:43:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C96C26B0098 for ; Thu, 1 Aug 2024 04:43:21 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4FC7AA04E3 for ; Thu, 1 Aug 2024 08:43:21 +0000 (UTC) X-FDA: 82403037402.11.0284F51 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf28.hostedemail.com (Postfix) with ESMTP id 771BEC0008 for ; Thu, 1 Aug 2024 08:43:19 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="M/52oewR"; spf=pass (imf28.hostedemail.com: domain of aliceryhl@google.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722501742; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=057qsfQo25vgSdyD+iBQubS+WGiFw59ECgKt87tVL5A=; b=D1oE8xKjkplBTbcz8TtCNk4Ovb4WVC/h9Y19qPop+3dELsxS6Yjow8KwA7jelA0Xu9lyqL WZK9jzF+QvUDiCLoqCeARLsd3Gq5/YZaoRw96JCsiCVhcpstMcdWuwD4oLj1yIngve9hb7 EGSFf4g5nPLgfU3S9EJWfAeqkaKoSnc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722501742; a=rsa-sha256; cv=none; b=uRMD5to2pTpW7mazltMvLKJVavii+Lfcag24PezfrFVLfypfqioTBg43by6Cj+Ck+wBkOU D/9GA/dveQZH7E8Ln77URLZmHnMaggXh6ima1sO8BZ9aoVLDr0opK8DHcB3clbLQK9RQLU r7xNDGuHdqqlfAL70nxDue2NeTVaJW8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="M/52oewR"; spf=pass (imf28.hostedemail.com: domain of aliceryhl@google.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-52f01ec08d6so9833866e87.2 for ; Thu, 01 Aug 2024 01:43:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1722501798; x=1723106598; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=057qsfQo25vgSdyD+iBQubS+WGiFw59ECgKt87tVL5A=; b=M/52oewRojX0exEuCIJtAgLweEYHdMTZ+SDkJBKh1uHKBvayQ4YBidCvtANXqGTxmO DSd8vI+LpCvpk5DC38R8/DLZz2rh92s2DxVrhwPOHsJknX0yJKtF1ktHRriTCiBVR1W4 MVyaP6tE3UopiqDzxBMdTn14FVfXXffGzaZNdcwCNBwJ6s+llqMW9UEmRPw9u1TcLEa9 lU/0HN0aIrept0erfHFVjDw9y1Oht6xd1ZLpKh2NLTyzCN9G1toKefrufHuli1Y2Kx/D wZCDMUgIA/kSdbPjmVKIFbFFrbUsX/zOgS4g2SSoeho+/CJMihXjKLnluyMVwYhAetsn ufPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722501798; x=1723106598; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=057qsfQo25vgSdyD+iBQubS+WGiFw59ECgKt87tVL5A=; b=g5oMAjkZRzw1yOAgeDT0X5lR31wDy58rdycIl3GEFvbdNNobD2N/JD+GLpyWSpA2jr YHFVpXottGymNMvE5MPv+gTesp5wqRO8J0iYAyMrggsY+M9HPz89lpAd5Idw0SIlQA5K TP4orOPp89zNNDuox0IiK0bfkp7KPW+3aB7bPjZ1ICBbAuXLXaUTJY6zWQa0yVGwsU4Y NosCaHpGhyVtPdZP2QEaarvlKmcpxa6cUDnv2Yq8Mi4TR8Q0zsewk+Gu51MKUsIbHN1p zkOeXpxFGSuTlNz4RCeFdFNJ06TIcYLXuunJm0/uaB4JSaVn6oofAszpEQUKnM/15+/m zCVw== X-Forwarded-Encrypted: i=1; AJvYcCUP3iMUj3lUKVLZKQnZnCV06pP/K1vzqnHyHKmivDbPnHXUZuapB7PUbYlNQa2/mAA8Gfdd60gTm1NzUG30LcYgUgE= X-Gm-Message-State: AOJu0YzJKPqOokgpw118aq3szQvkxcPfeU1oJKJ0NlrlQwYTXb1KQS3I gKGr/T733tY9LobYZOlMNiec50A4CFhX14audGU1Zv0YvumRyIBEtNg6FeHkbh9cOkel5UehuTR DXNuZYnr9Uv3FCzyU4m3jnUjLIWk/UOjFUKpw X-Google-Smtp-Source: AGHT+IENcEymBHeQ//Di7A/pvJi5huPTzBOnLqISBj+H9wlfHEJY13Wl4uiIRucbmw7OOtQPbn95aJ6SQzpDE5dbI48= X-Received: by 2002:ac2:55a7:0:b0:52f:441:bdd9 with SMTP id 2adb3069b0e04-530b61bc022mr813511e87.34.1722501797458; Thu, 01 Aug 2024 01:43:17 -0700 (PDT) MIME-Version: 1.0 References: <20240801000641.1882-1-dakr@kernel.org> <20240801000641.1882-7-dakr@kernel.org> In-Reply-To: <20240801000641.1882-7-dakr@kernel.org> From: Alice Ryhl Date: Thu, 1 Aug 2024 10:43:05 +0200 Message-ID: Subject: Re: [PATCH v3 06/25] rust: alloc: implement `Vmalloc` allocator To: Danilo Krummrich Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, acurrid@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: uq8ntsrfzpj739ortgzgxoysbn64ahpx X-Rspamd-Queue-Id: 771BEC0008 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1722501799-90653 X-HE-Meta: U2FsdGVkX1/NCbblU1+hH8a99klVqgHTwuIWP4ghruFMdyZSwab6ekPkdF1bhduOVIJoTzT1zv8wZ0lLHOjUbR/FYPauLfGxAR76XcBN10kNQZHRc6HrUBVPHw02LZPF1ZINzz7zEbJ/0P0ZO7jVoR9M4+zWtX6S1DfpOpvP1APrXEnMtUNciMc34SQppV3Dum0iW59O/fYUnAXnFNPBTxCh3b1SrYqkhmas2FynmtOCxcDUAQL8IQ0kljWkcQJS71Z9OeNt44hT8blZS9utTjmUEgsaJgnO5Kf8x7xotAx1rch4BhgAbXgpO3rCwizD6khl19XjI2Ef6He3dmd1a9EtXd5RULY2GjPs3yNV5JjekEDqCqJnglh8nUl0bKdG7v7OMu2PUff0vMAOlfUsPjLSyQfLCOJ/vmOpNPPQdX+/XaImT6L7ZF3zzME4MjbeHaBVltJQk3C6ml0oA8PElMUAOVsjGX0YUoQ3YlrTFUJsus+WV+ib7GeFl0c2RfiIL1bby+K3q8FWQ9fsOqkM0xgkkNHnjGho6ITh1UAhz9kPSP3kSN9gOCbi4Kp3IyU3xKmMeK1u6FQ5SsPsItxzBT92zKzJqvd92Ikc+BLuuoU/4zRu3vwFlkJ5qaTeeWVA8VVWdEjBVy9ShU6/uG/7TqqkRAGsaTqJsuZnGp90nswHrJre9en3rIFNduWEVf5gY9sDsWxHmaCu2Tx3SdkDupjiWugiVH00ZbvwEc9Gk5me7VNDa2rn4aTyYoXJNR28tWLnKuC4A4Yv3oiAl1LdJAoCn2C1El0cvxlqIXKl96XS/Izn2GMkd4R31HCXuJ0MP7bu168yZ3xNXTfMoujDp0LMSAjmvVjaDCRANZo/3TMCIrm9CpbNQS+UgPwG3wm1NjBXKF1JQJ+9r95JNV9dhVzjplMjsvVGdGUJmxdp6vi7+Tq/jccH1drc8RzLB5tmvoj3nVeAzv7DdUZOph6 dv5loiPz eCgWYQnNq39sdNmWvY1wQrkIW+niX9oiDUmcjglbK7knYPmotWMp3gdWU70EB9uOw2NSD6dzcv1zeHrHCoMeB1GJ/iBLKwUOfhPqZwbJ4ojtQ/q8iOkLsxo2w+TmZj2rh+Eh6Bme4qLEGhfz8fUzsAicIFAKB15e2cXB5IaUWhTA7Z/2CKz1IQIRvJ6Aa3UBUJM3Lj7lvJwtFWt5P6ob08NH8zOUHRny47OzScydLPquoxh2dRUqD341xjNC9C2gwJ1m6mUMqC9GgJejEeMJBNNpjjC755J8q3leDi69oHwvYZj7TYUkf2JB6Rz4Ig///kxMvu4tpFhWK0lQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 1, 2024 at 2:07=E2=80=AFAM Danilo Krummrich w= rote: > > Implement `Allocator` for `Vmalloc`, the kernel's virtually contiguous > allocator, typically used for larger objects, (much) larger than page > size. > > All memory allocations made with `Vmalloc` end up in `vrealloc()`. > > Signed-off-by: Danilo Krummrich One nit below, but. Reviewed-by: Alice Ryhl > rust/helpers.c | 8 ++++++++ > rust/kernel/alloc/allocator.rs | 24 ++++++++++++++++++++++++ > rust/kernel/alloc/allocator_test.rs | 1 + > 3 files changed, 33 insertions(+) > > diff --git a/rust/helpers.c b/rust/helpers.c > index 92d3c03ae1bd..4c628986f0c9 100644 > --- a/rust/helpers.c > +++ b/rust/helpers.c > @@ -33,6 +33,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -200,6 +201,13 @@ rust_helper_krealloc(const void *objp, size_t new_si= ze, gfp_t flags) > } > EXPORT_SYMBOL_GPL(rust_helper_krealloc); > > +void * __must_check __realloc_size(2) > +rust_helper_vrealloc(const void *p, size_t size, gfp_t flags) > +{ > + return vrealloc(p, size, flags); > +} > +EXPORT_SYMBOL_GPL(rust_helper_vrealloc); > + > /* > * `bindgen` binds the C `size_t` type as the Rust `usize` type, so we c= an > * use it in contexts where Rust expects a `usize` like slice (array) in= dices. > diff --git a/rust/kernel/alloc/allocator.rs b/rust/kernel/alloc/allocator= .rs > index 397ae5bcc043..e9a3d0694f41 100644 > --- a/rust/kernel/alloc/allocator.rs > +++ b/rust/kernel/alloc/allocator.rs > @@ -16,6 +16,12 @@ > /// `bindings::krealloc`. > pub struct Kmalloc; > > +/// The virtually contiguous kernel allocator. > +/// > +/// The vmalloc allocator allocates pages from the page level allocator = and maps them into the > +/// contiguous kernel virtual space. > +pub struct Vmalloc; > + > /// Returns a proper size to alloc a new object aligned to `new_layout`'= s alignment. > fn aligned_size(new_layout: Layout) -> usize { > // Customized layouts from `Layout::from_size_align()` can have size= < align, so pad first. > @@ -58,6 +64,10 @@ fn krealloc() -> Self { > Self(bindings::krealloc) > } > > + fn vrealloc() -> Self { > + Self(bindings::vrealloc) > + } Technically needs an // INVARIANT: The function pointer is vrealloc. Self(bindings::vrealloc) > + > // SAFETY: `call` has the exact same safety requirements as `Allocat= or::realloc`. > unsafe fn call( > &self, > @@ -136,6 +146,20 @@ unsafe fn alloc_zeroed(&self, layout: Layout) -> *mu= t u8 { > } > } > > +unsafe impl Allocator for Vmalloc { > + unsafe fn realloc( > + ptr: Option>, > + layout: Layout, > + flags: Flags, > + ) -> Result, AllocError> { > + let realloc =3D ReallocFunc::vrealloc(); > + > + // SAFETY: If not `None`, `ptr` is guaranteed to point to valid = memory, which was previously > + // allocated with this `Allocator`. > + unsafe { realloc.call(ptr, layout, flags) } > + } > +} > + > #[global_allocator] > static ALLOCATOR: Kmalloc =3D Kmalloc; > > diff --git a/rust/kernel/alloc/allocator_test.rs b/rust/kernel/alloc/allo= cator_test.rs > index 4785efc474a7..e7bf2982f68f 100644 > --- a/rust/kernel/alloc/allocator_test.rs > +++ b/rust/kernel/alloc/allocator_test.rs > @@ -7,6 +7,7 @@ > use core::ptr::NonNull; > > pub struct Kmalloc; > +pub type Vmalloc =3D Kmalloc; > > unsafe impl Allocator for Kmalloc { > unsafe fn realloc( > -- > 2.45.2 >