From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A864AC3DA49 for ; Tue, 23 Jul 2024 15:05:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 081646B0095; Tue, 23 Jul 2024 11:05:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00A3A6B00B7; Tue, 23 Jul 2024 11:05:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E144A6B00B8; Tue, 23 Jul 2024 11:05:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C460A6B0095 for ; Tue, 23 Jul 2024 11:05:49 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 78A8D401FA for ; Tue, 23 Jul 2024 15:05:48 +0000 (UTC) X-FDA: 82371341976.12.2E30B7A Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by imf18.hostedemail.com (Postfix) with ESMTP id 4C8A11C011F for ; Tue, 23 Jul 2024 15:04:53 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=qcVTK3Tw; spf=pass (imf18.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721747072; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7fDLpLWhI3bhX/1zNYsaTcZaVvzDKWENTn8dwHnt5k0=; b=1PJH0Gi/WE1CtKgRrXmCNE5gOKivSA7MlMp9iURDT2l07maw8IZ8zro6FAbSEZWrTdFCCV IhdrxA2kBr3kZhzGUrIfK5tTT9+rYgabTOFEGMbIMekV5Y8O5FTGEiTaYgaiLP7Mdjwwun QY/kzbhLJ/vNrAsSRu386o1v6i8XtJ0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=qcVTK3Tw; spf=pass (imf18.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721747072; a=rsa-sha256; cv=none; b=VreAaYlrPBmYsj+fvrpWkuJVawxKR73sXy6hT5Q9ZXN9qyEe7QjvOLgSSAOSRMK4UzpChy SM1+iLxQ6VUulTZHggGkfcO4Rs1znJat155ASs8J3SM304H4c7tcuyOKJ81UyeojLwWE4i DU2mcqImjyiN7a4Pvl8Zk8OIIoFCMJk= Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-368380828d6so2977865f8f.1 for ; Tue, 23 Jul 2024 08:04:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1721747092; x=1722351892; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7fDLpLWhI3bhX/1zNYsaTcZaVvzDKWENTn8dwHnt5k0=; b=qcVTK3Twzh1k8+ocKJrrFG6KcaEhQcrQkigfBza/m26Yrv5QIuqJFcLeYtQbDXOnNE gFmu+iZYNx4KlIqF23eHe8q5el+Of7FRWHGp480QIPVpo9lK77zI22BTFLrBErgMrhVh 5TVCenw6H+LTKKdGdrkKsX7fzv4aM9XNSl/qLUI/sKgOWyZyjgB7H4+f47miFNqNWoCa huH3ECWNWoIOmsCmEnGUORJgGe6Fj3bNXrUhXpfg7Gs5RzJD2dEPjBQmnJQ1A/ATI/UR GOMfwQeE3Yxd18VaL3cIZdK+Tq/a1v2bh+1XC9pAR9UqX1Agng8hJbK5LTHQUPNS3RjO oYSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721747092; x=1722351892; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7fDLpLWhI3bhX/1zNYsaTcZaVvzDKWENTn8dwHnt5k0=; b=SKVL7X8loPNjMTEd3f1HAn9QXZV7aqy9USbcCo6tQb2+XbDNuH/Jx0gxPt7KLK39Yr JvndRqt5IS1mHrNTwEWbTg3/ZC9ig0+lqzydYwoScNqD0JMrWi9FKaiWv9ZkOhv/BXJj R3pC+YpbUW96359b/72wPXrcsqRhT44+ZH142UBOeSy7p3f8amapKVn2uV4z2uDiSeEb DbIFeyCYG/IpNln6nwS9GIYuN70bFoFlWmX5t/Z9XwjvN11WQO7dngq0RocnCxXhZxlP rwNjsHWmbrTwfZJ+mLHqYQckEBkGkbdsVEv32dMB/46ZOfDGcfWhIRs9yepR+08Bebvf 2tSg== X-Forwarded-Encrypted: i=1; AJvYcCVTR7YYI2miNXvRJnlzZyHhw5q6y3WXUhJh4pp952SR6hwlm7cf16Qa2J18RuDvHS80xF9CgGwHpji9OwbFBUBc6vU= X-Gm-Message-State: AOJu0Ywo01w90tpbb1R6U+Y5g/S3JAMP9dd1OGnt1tsTumEHHrw0UynE MJVDV0CZ9URuhNcElOnZge4GIDFdGAsaGS3kw/iN6IWsQeBaVv89JQt6CqLtAW7ysRH9QLs5V6f +bF9cXwEDXXXLwjaNpJPx1nOLVqxOQNjL2qdN X-Google-Smtp-Source: AGHT+IGn/ROYNIhhGAwOKtA+EoK9/nAVYByn5CJh4yLPZB8FbZQynsJDHToZMNdq2XASnksxlFoxaKAWjK8MwqE3xRg= X-Received: by 2002:adf:fc0c:0:b0:368:714e:5a5e with SMTP id ffacd0b85a97d-369debf8bbbmr2714091f8f.2.1721747092088; Tue, 23 Jul 2024 08:04:52 -0700 (PDT) MIME-Version: 1.0 References: <20240723-vma-v1-1-32ad5a0118ee@google.com> In-Reply-To: From: Alice Ryhl Date: Tue, 23 Jul 2024 17:04:40 +0200 Message-ID: Subject: Re: [PATCH] rust: mm: add abstractions for mm_struct and vm_area_struct To: Matthew Wilcox Cc: Miguel Ojeda , Andrew Morton , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , linux-kernel@vger.kernel.org, linux-mm@kvack.org, rust-for-linux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 4C8A11C011F X-Stat-Signature: tzzcgnwcxc541sag4fd8zjbbidn5mndc X-HE-Tag: 1721747093-940417 X-HE-Meta: U2FsdGVkX1/U9ZiS8M4vjMLtAFWUEFEv57suYKJsYaKCGOivcThWUzrwIWhu5iis265e8CPmWZ/P45fiHxzWXQJcrLbR40FCgfarBujupgAZFpnwyX8MUHljwM4op0a1fJk101sk2iW1K6NbmXl9XvTSdWPYZpkDJU9ePJNekg+nZ3j5qn9KObZQkzsZZw2LYJaWWrvm4DLtogkFTGlESWgMKRbAcLwqSHqOkV28tImUYO1KJslowXUiTwgbGqr96mUmpAoHvo3Wypxw8vQ+UNavB5Qs/m7RbOayv/ftHhOmftt6Hj5f/33XPEvcmQsCAh9zcpw2e3bYwgUQDiTXtiWbIN2HVDF4u9/EGgFqBodUMRpCDd0SP6CA6eJ595jBcMqk1299M7ALnsreCCqc1+xsaRNc3KWu3Q/KuJaXvpsu8zq5BYe1rh6OpLdSdSpeN39Y4kZKa0Pe7ODJOVOBFPHWX5D7j+dvKozQM/IWw9l4u7Mm3oUNX/Djm1lLC59D8WIrXUSII5oV72ZMVCADhmfzeMeGAOBhpjFPLfP426Emu0kyqGxtG1Mg0jMlFAWn1BacEMN/X2MpwzZH5AFMwd0tXT5nXEbleBKm9VZDCPtY+Sr0H8rpDLWrGi+Xh/O4pvuriDWo8exZLCx0u3kz/OTFNAXaKq+s4WYg5dzxqhNd4ddzU8aMPv4IaR3XZcFieKrw3LSEYv4t/UcOnLtnc0dW7OvcQGOkzr45i5PrMMh5bmKM/j4/MdppcQdOkw7X/ukeREvtP4MHbgvTjikoOUFc/nU7nMHMJK/CjTakrveEHWrjT919hro9tQcuKkkTuAqpOJA5RIHFY88DlfZIpukiHHvoU/aUHBcuYGp351SitSiayxYJAEknLt/az+VlLPKd21tt3rRx4r7m0Ff1Gol04EUjuQp3d1oZedAlERiblTxamzxFfUkZc4fCdQMmc4oaOXE3REvcFCHsKK2 C5A2aXAI 157cnt8msTiZD9dCj1EWhog2uz75q4Gq+X6hLkws4iIn40IKsDSG5mU6l77Kwyn8NsfiZkkVuyStRwYHdgLAbMSyJ53rlNS3Xaevix6oM3GLJAfaVBblfOTty40aHW9Zs808s5xuhieU618meGgyWdEJFQD8L0+x6ozDoFIHSObrt2FI1wdWF3zZ9wO3f7WWlETWEpxVlWdQajhbQSSwCmwgadEAyYSsKoji4LXhNWKpGh6fN6nyvRtO/7ssBQbB1cShx092ZcxpaGiHlXvPzKdlGakhfv0UJZ6LV8fQBtNIj87W1rw23xJVeW39JlQnXPLeUEgTVuy6XPSIZ001oXwvjz4a+Gw3ZDQnV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000277, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 23, 2024 at 4:50=E2=80=AFPM Matthew Wilcox wrote: > > On Tue, Jul 23, 2024 at 02:32:03PM +0000, Alice Ryhl wrote: > > +// SAFETY: It is safe to call `mmdrop` on another thread than where `m= mgrab` was called. > > If I were reading the documentation, I might want to know if it's safe > to call in interrupt context (either soft or hard). ie can mmdrop > sleep (if it turns out to be the last owner of the mm). I'll add some information on that. > > +/// A wrapper for the kernel's `struct vm_area_struct`. > > +/// > > +/// It represents an area of virtual memory. > > +#[repr(transparent)] > > +pub struct Area { > > + vma: Opaque, > > +} > > That seems like a very generic name! MMArea? VMA? Certainly when I'm > talking to people, I say VMA. struct vm_area_struct is a terrible name > and I'd be happy to change it if we could stomach that churn. If I were > naming it today, I'd want to call it struct mm_area. Yeah, you're right. I should change it. Renaming the C struct seems like it would be a lot of work. For now, I'll rename it to VmArea to match C. Alice