From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08F11C52D7B for ; Wed, 14 Aug 2024 13:45:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 867416B0085; Wed, 14 Aug 2024 09:45:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EE826B0088; Wed, 14 Aug 2024 09:45:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68F2A6B0089; Wed, 14 Aug 2024 09:45:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 47F4B6B0085 for ; Wed, 14 Aug 2024 09:45:13 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C035B1C3A8A for ; Wed, 14 Aug 2024 13:45:12 +0000 (UTC) X-FDA: 82450972464.11.57724E3 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf17.hostedemail.com (Postfix) with ESMTP id CC7D94001B for ; Wed, 14 Aug 2024 13:45:10 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=fL2JScsQ; spf=pass (imf17.hostedemail.com: domain of aliceryhl@google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723643039; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7Tm7ietP2DEbsHclGJs+zY/mhyO7abDSx+hwPgbHPxQ=; b=iMs6D5Ry2fR7R347iskvvkVMEkbHTYt1Yj9ovw23WBgAf8pjAxDvboUqDQ3ScyF7dRDIpU evpYUNB3DWvBV6eCTM2WyP1ZGUYdT9kd14e5vF3OiBzcV2Dwm9Y0+0ZZA+NwskV42cpYgz 9WNqgNrcMNPiFXQTvBHHUiG6xV8PSRs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723643039; a=rsa-sha256; cv=none; b=Q9rIWvFLp7gLAJkfnYZSZVeu8jhNEbaRvHM0hZFK3hpNU5FPrTjv4UkIRKoF6KHkMGD32w 9ro6E/dbICJCzm9EPFUm4bKSkT64FmuapVOOGA9vuL35LJq/9Pm9tjswJZcXcxUXVPoBXB qOiiQpHb5BJ1pco422NLxVC+anyp1jM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=fL2JScsQ; spf=pass (imf17.hostedemail.com: domain of aliceryhl@google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-42819654737so49099895e9.1 for ; Wed, 14 Aug 2024 06:45:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723643109; x=1724247909; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7Tm7ietP2DEbsHclGJs+zY/mhyO7abDSx+hwPgbHPxQ=; b=fL2JScsQCmQNzymwyvnhpVbVeOUq6f5HKecMcz1cZxFDeKRYTITtY0cpuhRHCfst66 DK0/KmIfOrjO8K8wAvzPeW5JfQ9Hi7t15zjW7d/4Ipu+WMVdeqrUblg+bwAQD0Qs/Kww Bawy/XFkKQIvvZjXB9dl64SI2RPqWa+vicQfSgpx1x3VirHcuFIwogPPF7tl6mqRtdej NsJHq4xYb1WDBnf1g7+neNW9Hky47Prafq48RdEGxDCtW7mIt/bEEkBsfn2q0tPW5MmP +b3yHqmWAbFps0t3amYOSSpih+mtG1eSm71TXrskQirEy2sU6pFrGYzVdtxrwu6w2Xru ulmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723643109; x=1724247909; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7Tm7ietP2DEbsHclGJs+zY/mhyO7abDSx+hwPgbHPxQ=; b=Qk16SrR1IqkBN4jlIYfOeExvia69sOJ4izoM5zoAQ7dknLm8PH7Yf8SZhdU3kptldU /+xwFqFOsiGE3+MzNZFytUfwwwGpcfBIBDrFYaH6ti+kve8Nw6RxOUhpN+VagJpeIdaB 0h4QONp8xpY4T+hs5aCrdRJTG8o9lhsIyagvglrf6+KdwmMxUM0s+2Yw4oHyQKJQvl0o M7Ow/PDOoGfv+VUGC4SBkgv6cCfm5Ci7QS/m1/oTw3NrqSLXrHhJB7UQ1AgmbQWP/VYN 4ER3JHN4qm+eaHrYD1ai+z6t/wpbtvRP0QAtCOHfh2NZwLOQ5/r1FmMMZfqaFv1WoFal 1ZLQ== X-Forwarded-Encrypted: i=1; AJvYcCVbFLrv5MdYCcn3xxqobIgWsngDkKjGtgxtp3C68iziKimNC+0bCnPp+AkRFzjzYJuL/Gq4yVRY4NDe2WKIRyzfhJ8= X-Gm-Message-State: AOJu0YxmuVbBdaj6/Mgai+w0zUA/E0FVzvqpdeqQjdKQUwulFGhk2nDX eHnkJ+yqH9VNYNhp+Y5MP+RJ1LRTl4t76NQx0OWmaCLKYDYwtkAA8REDtnVzGTLOLiRMirfnwZo OMEnsf4cAIxmg5KK+RJ5JLJ2DjdgCqbn5+HEq X-Google-Smtp-Source: AGHT+IHQij7pFO3R9kwgjAYPf6467NH0BDlaDCLUFTSKxJTM2pMmM4ro5SVAftofS/83QLU/Ih24zY/k2aFjkewsXVo= X-Received: by 2002:a05:600c:1990:b0:426:6f27:379a with SMTP id 5b1f17b1804b1-429dd2374d5mr22536475e9.13.1723643108692; Wed, 14 Aug 2024 06:45:08 -0700 (PDT) MIME-Version: 1.0 References: <20240812182355.11641-1-dakr@kernel.org> <20240812182355.11641-5-dakr@kernel.org> In-Reply-To: From: Alice Ryhl Date: Wed, 14 Aug 2024 15:44:56 +0200 Message-ID: Subject: Re: [PATCH v5 04/26] rust: alloc: implement `Allocator` for `Kmalloc` To: Danilo Krummrich Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CC7D94001B X-Stat-Signature: bz4xphoa13yt1toebe1r9xc4g85inqjc X-HE-Tag: 1723643110-572019 X-HE-Meta: U2FsdGVkX19QlrGHKo8zdcmgvTXaX6Zcsa95PsioQBK22uqksKgcivI8H+GsoDRYCD9QCP+/XklHPut4+6BvblCE2tFoDeDM38FMY1spGX0XBvJ3VgAs5ROBOB8tw+Tn600rJkLze84fsHo7fE3Z2w+wwcTl8Tg9SvhtipJy3Vp/anv02GqeqQmlizmc4FRTJbfaM85lLobk8oCwINX4cD4eaH2Rf1N9U0VqwyioHlK7MIzKPb3vqr/xa6st1VnXXHPtXJEPdnr82UB2e9zRCLUgU6kdKbk+ojybxfHhspPk4zOq2aHRtYT/hXESpE3TOVaxiEdxwiTU4D269RP3I+HrNW6FDt8Bf/22Ze+s2PfsKtKjjgh6LcuwliSu2PXv34gd0DfumqIbzK0Sw4joFNts3MXlO2yhxAtep4m3ffpV72K84VUBIF4UlFZC3Nj/9E0FnsN/dctOgWG2UI8g4tGSEHDgjuOxCNANtWkQGT9+ghSWL9T7uTSs2YY5irwQow6a1/gW6mY/fcs1t2ZQDOytG9kfiNQ2BhOmzbA1+Irh1UdiZkhofceR9JWL6T2TFarJPcSz/59yAwi1R6bS1SYTJqLHO35QCTCEeQ9hExK5Is5VRh6JXfBEyZhY4j/mdtNCtBUqcvWHB7GB8CcbQm8V1ms2jmWPYo9NRkvUA2CAr0fXxYEwiEGpAhKSqf5ykDY4DJzeFLrA/u8n6cK1vqBRY70/iOOhxUEy2TMOvsqlIQT1krafzpXvIN+5+oNnBSM39QFUpS5iDVhaod4+yNpsrLGiM+itRTs4cKA/735b8wcxjc+4H13Y+0x9oOI5vqY73cTJP9Nno4jre1pxmUrN9tSMzZ+x3ZVqVzKRRjhlrxAqWmSb2XqWgpwmg3uEU3oFHWSlnjPvSr1AbM0KmouPN9WYg+x65JON4BA3elndaZYsBxtm+//fpQN4UmbUZuteEaiOACzXAtxfkoy TMHMF+Ho 0yIk1AXLymWy8Znx7ED3K4AB3QHYMCxlGZUFAhu2FXaR6CtRnV8kn7rF1yEQPL0ZHvNvy6SltX0Vncn7duwhR8aj97cSwDRaH//PtrOpxXUKcY1K7Rm+uHLXZjlNliXsC0y0U/+Z2cH2nHXPn9NZE2UXPdT6hrXrQGRVBYnMw6XZzXpnNhdELq75m9xcwaIZFWVw8ZI2ND+xMG2nuCZUo4+e4qicpQTcJ8OWGqd0EsK51/9AHncwpRlaFWkkrj/A3IxRPeh3aWrusN1owkfCVBENLk+/4SlUpPYwXjJxMRh0e/ec= X-Bogosity: Ham, tests=bogofilter, spamicity=0.005075, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 3:36=E2=80=AFPM Danilo Krummrich = wrote: > > On Wed, Aug 14, 2024 at 09:51:34AM +0200, Alice Ryhl wrote: > > On Mon, Aug 12, 2024 at 8:24=E2=80=AFPM Danilo Krummrich wrote: > > > > > > Implement `Allocator` for `Kmalloc`, the kernel's default allocator, > > > typically used for objects smaller than page size. > > > > > > All memory allocations made with `Kmalloc` end up in `krealloc()`. > > > > > > It serves as allocator for the subsequently introduced types `KBox` a= nd > > > `KVec`. > > > > > > Signed-off-by: Danilo Krummrich > > > --- > > > rust/helpers.c | 3 +- > > > rust/kernel/alloc.rs | 2 +- > > > rust/kernel/alloc/allocator.rs | 63 ++++++++++++++++++++++++++++++++= +- > > > 3 files changed, 64 insertions(+), 4 deletions(-) > > > > > > diff --git a/rust/helpers.c b/rust/helpers.c > > > index 92d3c03ae1bd..9f7275493365 100644 > > > --- a/rust/helpers.c > > > +++ b/rust/helpers.c > > > @@ -193,8 +193,7 @@ void rust_helper_init_work_with_key(struct work_s= truct *work, work_func_t func, > > > } > > > EXPORT_SYMBOL_GPL(rust_helper_init_work_with_key); > > > > > > -void * __must_check __realloc_size(2) > > > -rust_helper_krealloc(const void *objp, size_t new_size, gfp_t flags) > > > +void *rust_helper_krealloc(const void *objp, size_t new_size, gfp_t = flags) > > > { > > > return krealloc(objp, new_size, flags); > > > } > > > > Why are the various annotations on this helper being removed? > > rust_helper_krealloc() is only called from Rust, hence neither __must_che= ck nor > __realloc_size() should have any effect. > > I also do not apply them in subsequent commits for the vrealloc() and > kvrealloc() helpers for this reason and removed them here for consistency= . > > > This deserves an explanation in the commit message. > > I can also add a separate commit for that. I think your change would be more obviously correct if you keep them. Alice