From: Alice Ryhl <aliceryhl@google.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: "Onur Özkan" <work@onurozkan.dev>,
rust-for-linux@vger.kernel.org, ojeda@kernel.org,
alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, lossin@kernel.org, tmgross@umich.edu,
dakr@kernel.org, linux-kernel@vger.kernel.org,
acourbot@nvidia.com, airlied@gmail.com, simona@ffwll.ch,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, corbet@lwn.net, lyude@redhat.com,
linux-doc@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 2/4] rust: xarray: abstract `xa_alloc`
Date: Wed, 8 Oct 2025 16:05:05 +0200 [thread overview]
Message-ID: <CAH5fLghoDEKnpq6WaD3zzV9UHm6gYzYXCOG_Q=pOUomcNcQhPg@mail.gmail.com> (raw)
In-Reply-To: <aOZpwUD50MwSBycB@casper.infradead.org>
On Wed, Oct 8, 2025 at 3:40 PM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Wed, Oct 08, 2025 at 01:04:11PM +0000, Alice Ryhl wrote:
> > > + limit: Range<u32>,
> >
> > The Range type is inclusive/exclusive but xa_limit is
> > inclusive/inclusive. They should match to avoid confusion.
>
> ... and xa_limit is inclusive at the top end to be sure that we can
> actually allocate 2^32-1. Or does Range handle that by using 0 to mean
> that 2^32-1 is allowed?
Rust has multiple range types for inclusive and exclusive cases. The
Range type is usually used for indexing arrays where the length fits
in the integer type. To include 2^32-1, you have to use RangeInclusive
instead of Range. It should be possible to write code that handles all
of the range types without repetition.
Alice
next prev parent reply other threads:[~2025-10-08 14:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-08 12:46 [PATCH v2 0/4] rust: xarray: abstract xa_alloc and xa_alloc_cyclic Onur Özkan
2025-10-08 12:46 ` [PATCH v2 1/4] rust: xarray: move pointer check into `XArray::new` Onur Özkan
2025-10-08 12:46 ` [PATCH v2 2/4] rust: xarray: abstract `xa_alloc` Onur Özkan
2025-10-08 13:04 ` Alice Ryhl
2025-10-08 13:40 ` Matthew Wilcox
2025-10-08 14:05 ` Alice Ryhl [this message]
2025-10-08 16:59 ` Tamir Duberstein
2025-10-08 19:50 ` Onur Özkan
2025-10-08 20:45 ` Tamir Duberstein
2025-10-09 4:50 ` Onur Özkan
2025-10-08 12:46 ` [PATCH v2 3/4] rust: xarray: abstract `xa_alloc_cyclic` Onur Özkan
2025-10-08 12:46 ` [PATCH v2 4/4] remove completed task from nova-core task list Onur Özkan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH5fLghoDEKnpq6WaD3zzV9UHm6gYzYXCOG_Q=pOUomcNcQhPg@mail.gmail.com' \
--to=aliceryhl@google.com \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=corbet@lwn.net \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=tzimmermann@suse.de \
--cc=willy@infradead.org \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox