From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1536FC369A8 for ; Wed, 25 Sep 2024 08:27:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83E716B007B; Wed, 25 Sep 2024 04:27:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7ED956B0082; Wed, 25 Sep 2024 04:27:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B6936B0083; Wed, 25 Sep 2024 04:27:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4C52C6B007B for ; Wed, 25 Sep 2024 04:27:12 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E29FE120177 for ; Wed, 25 Sep 2024 08:27:11 +0000 (UTC) X-FDA: 82602580662.29.511C420 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf18.hostedemail.com (Postfix) with ESMTP id 1FD311C0006 for ; Wed, 25 Sep 2024 08:27:09 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=jeETuZ42; spf=pass (imf18.hostedemail.com: domain of aliceryhl@google.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727252671; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=25jgtKw05cLljXTa9ioZMmKXC7JJSPXQkmgPPZPPAvI=; b=U7cvlOKuMMijYO1Zi/CLqVosPdyTM1QrAN174JVpv1Umfaarf5CSyeIjuXUmO7k0SMTNNB NeAa/RbdnN2wET5Iz9zNp02sPzBXloTCZlVaSo2oHtVwez3+MfIwrsUuRrvl1xoX+pFckV n8hT68Wh40Ez29TH6g+drLzs74599zc= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=jeETuZ42; spf=pass (imf18.hostedemail.com: domain of aliceryhl@google.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727252671; a=rsa-sha256; cv=none; b=nGPEoO5yYGCco1j8VXlCaM/qDp5ncGriSO8NjEJr50j2VPXb50Fu6lfl862tI6EZBXGhpi 8ou3xFJPt40KNPXYS7lgjKRTPRE6KEN3cuuTkwIt0jcfVzOqQRJnJUBGON507yUwYhScOQ wgblb90EA5Gvep1NSqG2Z39HGdrF6CY= Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-71798a15ce5so495911b3a.0 for ; Wed, 25 Sep 2024 01:27:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1727252829; x=1727857629; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=25jgtKw05cLljXTa9ioZMmKXC7JJSPXQkmgPPZPPAvI=; b=jeETuZ42gbi4U+Gt90xFyfKmV0Vt78SMt9U3mssTkrJ6nuR7qhucjyGwYoeX4HJm3j tsUxOXFPML7T+clwHoD9CJy03uP7gbO4Rvm002kWLO1B+5buxBVOMAP5qdBfUkTrqMs/ sHC3vdg4L5AokCDv559flMuy4eTd9ClPFv6afXpQuS1EyrLmAgz6nwUj8EpdyNtHSeeL nW+hzJpLF6dJJ63AtvvzQTUshiuWMqHjDluzxvm+IqMsVTYxhrGYd4kFbb3fJJJgNFwN aBG6LVshBn99vE1aPvQbBCNtw+iYPe5Yg8gSJEvFlJm7brtkJQfJgXjNVBJB+rOaH3b6 lBRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727252829; x=1727857629; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=25jgtKw05cLljXTa9ioZMmKXC7JJSPXQkmgPPZPPAvI=; b=T9l0A1Z4SfgvN9MCMYxiifrTipW5WqS55pXlEQpBXSaDqQ4hZr5s95wlTeyxq1diEK MCZgjn7bVDdRfJHN7o2TkhKN1Jd4+c79hMlgSqIa6z9IF9GHjD9B9MmTtPOAXrytsqvl zbOhOTJp6pVQ3uJfeV+mgUjR5isEO4uEcUaHZVSGBtnwPCjmeUu+px9dBxPseLSCVcYr UQnFjsEum1bRBp0lQXLkd1GKTST6nTA8DA1Iqq06O9LFeJwjsZtZEChVn3Af2mHxSHaJ tQtZ/ql4I0tPF0VbXU8bQhcaMbl+4Mkk1XHJMNLm767HWCbWO0eLOVYHy8cForcAjfdi Fm0A== X-Forwarded-Encrypted: i=1; AJvYcCWUHMZyn+KqaJDk9ATvM+hyQs3RGXCLf9FsPC6O5r77G56kDK4hlJW3IOIqL2pwpX/VFAOTFBCpUA==@kvack.org X-Gm-Message-State: AOJu0Yx5youvEwIl34ndAONaKe6G1gymFDq1Pa7GM8xJv2q5Xlxcet2P My0y+gTYvmKPl7l6/b6zoi5ZS138E9XYYAtqTBD2wiwUAsdo41bRY4b9FifRwtgufAuc3UEtpIY TMBDkOzBXBHtqgDVQYhJZmifuJs8x/UiIRavq X-Google-Smtp-Source: AGHT+IFw8D9Y8iDl9QsdusH9uDD+9on1P4pZpj5dYIq2QFb7UqISOP9oyEzjwVQEFX4WwjN1p6C5EsUcCJSsDc+lbMs= X-Received: by 2002:a05:6a00:17a1:b0:706:aa39:d5c1 with SMTP id d2e1a72fcca58-71b0b21dda5mr2945661b3a.8.1727252828232; Wed, 25 Sep 2024 01:27:08 -0700 (PDT) MIME-Version: 1.0 References: <20240820194910.187826-1-mmaurer@google.com> In-Reply-To: From: Alice Ryhl Date: Wed, 25 Sep 2024 10:26:54 +0200 Message-ID: Subject: Re: [PATCH v4 0/4] Rust KASAN Support To: Miguel Ojeda Cc: Matthew Maurer , andreyknvl@gmail.com, ojeda@kernel.org, Alex Gaynor , Wedson Almeida Filho , Nathan Chancellor , dvyukov@google.com, samitolvanen@google.com, kasan-dev@googlegroups.com, linux-mm@kvack.org, glider@google.com, ryabinin.a.a@gmail.com, Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Nick Desaulniers , Bill Wendling , Justin Stitt , rust-for-linux@vger.kernel.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1FD311C0006 X-Stat-Signature: 7kus3qmx3qmxhmt6iob1dn8b87pyuxe9 X-Rspam-User: X-HE-Tag: 1727252829-32498 X-HE-Meta: U2FsdGVkX1+wmEWuqqSyFtyUfOczUPMN1HblHrJ+osTvZiQdAqtpY//RmsvQ6JRDkazthrIQ497XJz7Bsp98hJRXjpmI/7Yxpf26JTZMU+a2cV1KXQY/7KxlmJYEcHpYCjc+VrUKHXWYv+gAlRi6DktRzvOfPM+JxJWYpiFtdf9f4/UfozKiQb3GwBzZ4+FQPD8n4lzn/xODwk8ic9DcgsFcyUNDDEx3sFLMqo1JZVqdP6YP0DGd5CQfLex8yQp8jaosPy8EzObFofajwj/QCEiFblxnsTNozsaZmq2+jY0AdL1RiY+rKpJxc4nYiVqxz10Gm+qlSkHWOwNYEoT2pTcuxtwCk9Y0w792agKbwzA+8bilUqSp+NDjuzNTof29+qi1asotlGmBMK4NAqXwgg7EsMkSPRc4kw9AJrh+HcO7CMnQG/cTlG87+ImzKQn8Pp8QWDoVZxUpTAP6GtpTqq29hfG7UhYLCOOYVVwGwsnD0wM1w4u7CmsPYmILqlCWRdko9bUWz8RN9nXs978wX7Q7cRCmaMBpJpVvb7iFIBDXNMeTtJhg0lynSzqsTJkq5iSWOAOa4IH4/XWFFfUzgN0m9esmcPcob1RjBJ4nXAnxU9i+qEh1JWXbfH5fj5360Jj/iHJghQHbXpP7PEYf8RIkcGmwQjv8vpGGZ2jeJvV/8sbL3YZD5puvabg6QrP9u2Hi/rgfVb/jHFIiwdPSsH0Np7PnHhcehyXMDEUaZIGZRTcBw3uL9inVBCWF8UrkHwN4Ua2jeJPn0W9QuHFvGh2YPecCWSvnS27oFRqQJAqepu9B4AzDC3M7A0cXrTXKHQwiLkuMPu0hZguSwhU3qifMJ2UW027fAvU2fOZsX26RyyOjATcIiuFc+eFHl77uhgTQkQzDn/ey03Z1sASVVmO/iBQRC8j1+UK+IIIi7xgBFwcxZIEtXeJF6deW2W10RIvfae6wAhHGfbl2rl3 01d91AAx P/Iz5COX1PdoKLl4OS0VrDxFADWqal3irJ8zSDuaPyqB7j36yOXrIBWU5XlyPpJvcXGOHShB8NlVZSU2ywPeCTS5XFSpHKXwyctBeO+EFcmYp7jg42dRJr0oDULq/ZEymtYHZEIgD0yiyiv1sDManIM+9b2ISss78ptou2zlmRXwghKKtj4l/NBg4fSZpaZREtBn8QsNBLwjXM85LFjtKGGWMr+qg7Tb2ineWeYb9LOzNJLEa3q6XUtu7Pok0oNLV9WFTqttk+i0h0AHOFnliRuEXtZhndckPyWLz X-Bogosity: Ham, tests=bogofilter, spamicity=0.022299, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 16, 2024 at 6:47=E2=80=AFPM Miguel Ojeda wrote: > > On Mon, Sep 16, 2024 at 6:15=E2=80=AFPM Miguel Ojeda > wrote: > > > > Applied to `rust-next` -- thanks everyone! > > Also, for KASAN + RETHUNK builds, I noticed objtool detects this: > > samples/rust/rust_print.o: warning: objtool: > asan.module_ctor+0x17: 'naked' return found in MITIGATION_RETHUNK > build > samples/rust/rust_print.o: warning: objtool: > asan.module_dtor+0x17: 'naked' return found in MITIGATION_RETHUNK > build > > And indeed from a quick look the `ret` is there. > > Since KASAN support is important, I decided to take it nevertheless, > but please let's make sure this is fixed during the cycle (or add a > "depends on"). I figured out what the problem is. I will follow up with a fix soon. Alice