From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF304C4828F for ; Fri, 9 Feb 2024 11:16:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE2996B0081; Fri, 9 Feb 2024 06:16:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D93196B0082; Fri, 9 Feb 2024 06:16:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C80FA6B0083; Fri, 9 Feb 2024 06:16:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BC85C6B0081 for ; Fri, 9 Feb 2024 06:16:02 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 62CDF161018 for ; Fri, 9 Feb 2024 11:16:02 +0000 (UTC) X-FDA: 81772010964.19.C9EC224 Received: from mail-ua1-f51.google.com (mail-ua1-f51.google.com [209.85.222.51]) by imf07.hostedemail.com (Postfix) with ESMTP id 9C35940006 for ; Fri, 9 Feb 2024 11:16:00 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=13ImJ2Jb; spf=pass (imf07.hostedemail.com: domain of aliceryhl@google.com designates 209.85.222.51 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707477360; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ed++djY+4BK8SmyO+juBd+LCPHe4DjXsTTMrzEs49OU=; b=5Q1NEVCDufp444rEhm4Wpz5KwYRcMb8Mh7xz2cd7SRNHRUy6JXa/HYPDBb1rWInwsI3NIo LxssHkfO+IfXZoTqcDD72uB3RmMmuK9Zzi8F0SJfQlX2tDRHtsqT5PdCAaIge25i29Q8A2 E06gFA4w/CjRmIHSStBlok72ztCtKAk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707477360; a=rsa-sha256; cv=none; b=NQmiIyYTlsXGdu5wz3+ydJ4a9miRN5IUWLVtbkgl3Kn/EWA7G968yogr59NFTHEIlwb9WO JUwXzifDI52v+g/Zp8H8kA5u4VmXw6Wxxb+qjVrsGgp/0uP1lEarUb+9GZVMx0W2N4s9k8 wG0qx3FRZeZMNT5evZd2z6ub2SeufIA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=13ImJ2Jb; spf=pass (imf07.hostedemail.com: domain of aliceryhl@google.com designates 209.85.222.51 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ua1-f51.google.com with SMTP id a1e0cc1a2514c-7d5bbbe5844so395522241.0 for ; Fri, 09 Feb 2024 03:16:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707477359; x=1708082159; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ed++djY+4BK8SmyO+juBd+LCPHe4DjXsTTMrzEs49OU=; b=13ImJ2JbsZFsBWLW3yavVxyjvG7Up0Cyd7ppLsDXOAHwC8OysTBdGY6QaKftE7rISj KF4Zc+5qydDS/IaLr7/NtFwVva5mF89M1dupgv0mkdWTi5aI4SFjV33jCod1Gvk0jkUA OA9kr9Gs0BQBz1ddOsfxPRW6oejXM23PskIenSGOKi5M++DcvO7OCqKkgWvLmGJgFOdX AXpNAABia8vC5YcM+xGhW4QLJTgr6CEC3ZG7w5E50LQyfn7EyvbU/ko9wm6RdQaLSpT5 KUvb6hNU8tlQBV0nAuHHPGvQKQtKzMnnsX6W8ciNdNHL/MYkhSJ1xh8iTiyC/D/VvX2D 9x6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707477359; x=1708082159; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ed++djY+4BK8SmyO+juBd+LCPHe4DjXsTTMrzEs49OU=; b=PfvU/H3rWACiKqecBwpXOMWJ4usAVuuxkVzoLxsJEId+DVlu6fuuP0b6DDe7p9tJEZ W6UAG8/G8iQhaPigunEbt5MMxMSTR64rDpfa5+3MjRuv2ZPYdDZog835NRq5qcmI2TIh YOMOx82Zex/7eb18Us4J+ZhA/fZKLvgdAym/omECIBMF1dm4wDqykojj21uu41d4syz6 bY1nAixzLntf3Ex1GsJK05/V5/47Sa/YcbFlSuXVY/LSfnuqsBKUvVOV6jiaUcj7p2BG S2gvTQshz1R6Day78HV8AMV8npKJDLujiQUefz+KsZZ6tI8ChGuldXXjjJYlRnhcarWT /M1w== X-Gm-Message-State: AOJu0Yy0lvj7+7ePI2SITi9naijNNWmAfTFbzxdihbNlIw5prJs2uRIH ZTr0OfW9hykC6i2320lARl8TGs8MUzC7fmEETL1wzT71BjE+Tj8HkEBIM5olpenee0TlafbGqOp gL97GrKdWfJEh/Jf3nPFcJlUI/uZGN10n/R55 X-Google-Smtp-Source: AGHT+IH0++n+IHTTWPdJfvdvuEsjvhUJCSq1bKiKaAnFQLdwkCp91mU/3dxy8RDqz88HJr1OypbDDQyyy0IfIB2ShjE= X-Received: by 2002:a05:6102:1607:b0:46c:b7a8:4b59 with SMTP id cu7-20020a056102160700b0046cb7a84b59mr1154577vsb.23.1707477359448; Fri, 09 Feb 2024 03:15:59 -0800 (PST) MIME-Version: 1.0 References: <20240208-alice-mm-v2-1-d821250204a6@google.com> <20240208225407.11951-1-kernel@valentinobst.de> In-Reply-To: <20240208225407.11951-1-kernel@valentinobst.de> From: Alice Ryhl Date: Fri, 9 Feb 2024 12:15:48 +0100 Message-ID: Subject: Re: [PATCH v2 1/4] rust: uaccess: add userspace pointers To: Valentin Obst Cc: a.hindborg@samsung.com, akpm@linux-foundation.org, alex.gaynor@gmail.com, arnd@arndb.de, arve@android.com, benno.lossin@proton.me, bjorn3_gh@protonmail.com, boqun.feng@gmail.com, brauner@kernel.org, cmllamas@google.com, gary@garyguo.net, gregkh@linuxfoundation.org, joel@joelfernandes.org, keescook@chromium.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, maco@android.com, ojeda@kernel.org, rust-for-linux@vger.kernel.org, surenb@google.com, tkjos@android.com, viro@zeniv.linux.org.uk, wedsonaf@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: o83yfekrh3q74z3g7imbsyrhpyjmyjb1 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 9C35940006 X-Rspam-User: X-HE-Tag: 1707477360-835934 X-HE-Meta: U2FsdGVkX19ZkurMZJLvyqDPs1IomZ5bLvcYoWo7XOXdOQdP5/KO+WGvrhhERux+n7TW3xyuv2S6irs6eqksvXFRiNtFuvGBkVkm0aGG/WRhPk91xwPtKWCDH4uIkMQ9OvF0Uzek9iefpKA+g1NO05cvNm4HmYPtCl9GCLMtaYFeardgNYmv3nKwt3va9cvdElyiVN9DwbLDh/vrBP9KQ6y+d3Pr2TNpOpKSJotGC+S9ioknR1JDyM/TQ9u4AOJzwx+tB6WqTpnB7ZjhVp++ixJgMIz0DydjqoxNTae/ALzFOGhkCeXOmiqoeGjNuVF26qHXKtVy6DnBIVy+BPfxYNME+LrYeop1dDHvMkNDfd65twPmQQnz0HWDstdeQgp0yEdX+KwaZ5ftQdBODfci9MKDNOU3gJ83hO2jEJG8m3nEr27w5j+BEgJBnLWETDP6I0zSMytsEW5TO4AzlWJUBXzu2cRZl4EyxoGxD8AHTjkY054yq+H3eqsDIGRB5k97XW7bgZ8LELUzQEYecaGai82PVRcLkCFg4mrK29Jow/MR9Nld97hERqN0J/i4Q5iC/q/fp/wr2+eLTuyM8P09baS/run41iN6ZKPZf6AUse8Q/BYI0C+4rEnnKZeg84JTf6/MVgst7YQWtSJHgKINCSy2FJ42Yp4/kJEA6N/cF2e0mn7hYFtlZZVCeTZd42+uR/t9v6lALl++yPK0MaJ+9FKXRX6uGMNo7oqDicLveGMSix3txHqVANGUqcTSwYfkJdoos9R2mFhnWUI0GXk7hzTSkBnxV4Ojq3uGHo8rdthPCeFR9kww/2/QqhzCG8m2spqFld7e2YB4rtAt813KyLefWpZbQXgNunecW6w3mE0DAWo1MErkd7QTamv3XaI8WAs9Y44GgyTC7g6SLO0fvq1eONhRdFzvNhZ7UrQvdXg0PEWbK/qKxXWnBTGHxnEDPsuRHvLfTIVFL4vVChZ lN7A4Jmr 1dmG/jZ/18pkxuRynViCdogCQDkdjlPUGAurJ+dwYdhY+HJ5Lpbfsf98VsfXY/W/ySk4cns9MzYvurgarQUYnVgB1uDMSvZgjQkxzuC7tbd4ekYHkvtZ4+o6A5l95d4TI8yFFeSb4+NajuLpqA6tl07jpz44NnNPky6OkYLfJd2ktRwZauJTfecdIPSoPfatO1Da4ml53lqE0MlVtGpqvc0LQLOVrrv5ENagqJqscs0QRpWG1Hei69HrGe9hR8EJvTb2wSvSnogGIDTowV6JdUUqVJVJKeNXdq8A6F3a6eKW42nM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.003470, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 8, 2024 at 11:54=E2=80=AFPM Valentin Obst wrote: > > > + /// Reads the entirety of the user slice, appending it to the end = of the > > + /// provided buffer. > > + /// > > + /// Fails with `EFAULT` if the read encounters a page fault. > > + pub fn read_all(self, buf: &mut Vec) -> Result<()> { > > + self.reader().read_all(buf) > > + } > > I think there is also no need to give an explicit `()` for the > generic type parameter here as it is the default (applies to some > other methods in this patch as well). I'll change this if I send a v3, but I don't think it's that important. Alice