From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 268BEE7719C for ; Fri, 10 Jan 2025 09:12:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CC388D0003; Fri, 10 Jan 2025 04:12:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 97B978D0002; Fri, 10 Jan 2025 04:12:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 843458D0003; Fri, 10 Jan 2025 04:12:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 668198D0002 for ; Fri, 10 Jan 2025 04:12:29 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0C622C0942 for ; Fri, 10 Jan 2025 09:12:29 +0000 (UTC) X-FDA: 82990976418.25.0B62986 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by imf08.hostedemail.com (Postfix) with ESMTP id 2234F16001D for ; Fri, 10 Jan 2025 09:12:26 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=crki05SM; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=aliceryhl@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736500347; a=rsa-sha256; cv=none; b=EJvrYyeNjo9rFvGP3OTfSDCyxFYCws3iqvRgDEBtLZhZBsrZX1giVJ1T0Mmg1RfeXM6YuK +i4tQC5zMi5huVeHOTZa8WOzR/bJ3X+gteq9H9hexdP/p2n8Of7hE0LojncE6BttzHCLpX /ALZxApzI+7EWGMQJCS3NLrIBkCzd/s= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=crki05SM; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=aliceryhl@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736500347; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H4b42L6KbIlresi3M2UYWy431YCtz06cCAKaFnFwspA=; b=WbY06klOcV4efBTyJDS3bXOeZbkADeb3+un6N78uPCMfCn3ewEvX1miWvUDu5h6KuDoSqE VgxoeKaNr9EJvjV4m3MZI6IyXvMjt6yNfTYEABri8hmFfPJiBpl2rMlvvdaGRtdIrQPtLb YYsJ1ZImNSGEmPeyyBcDD0K3nXjv4io= Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-38a34e8410bso1008483f8f.2 for ; Fri, 10 Jan 2025 01:12:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736500346; x=1737105146; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=H4b42L6KbIlresi3M2UYWy431YCtz06cCAKaFnFwspA=; b=crki05SMmNYWfrChj+TqQGf5tCVKXwsXJq4EUbRTLrMvpu6xwq+QabJdZNYKO1L3Df G33D3/W83yqT3Bclp9W7W+YfMSnUHL/0hnVTidP/L+ViIGcmnJCeP4kLxP7QZTXVdIKL czPna1PBjtqz8OVKeCm1y+Sbnzy54kAkwc68JmjPg4E3FqBjvr4QYm9x/CSqDZZkwLNy j02JI8E3mSO42a9k4VkWJA/18oCw4pWWdOcNQJ1cfqdlEZYWuE/gZpANJscUpKqezdvP 7od9aBJZifuUz3f53oGyHZzfceZlYth2HWZCHPbQ7d0nrv00J5RhIJzKmC8XOIt/v8x5 sngA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736500346; x=1737105146; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H4b42L6KbIlresi3M2UYWy431YCtz06cCAKaFnFwspA=; b=BuIgYQ7MCtmsz8zKd5lBLUMZMBGQf0h62Ta9UauiWyg+fqAg67oj8wlqWDy1Ig4Uem MOmZwk4u96izGEBoL0akYVfp8fRO+oLpIcDoUmd0IQCMPCBnvnvrCSjlfGSe4Jc8gSFK 5uAbjmmR0dwa9FPx+0A25AwGPwujJt5RmORaFdYi98yab/u9O53s+/D/nT/TX1esI1KC bE8RMYTT/Qt4naNIO9TZ3cAaWo3K/wVms7cmug8fPIk+BHFe2rodG2bxBm2KnfkxU6BN 8FoE3DZe/2vvnclqj6K8/bRfLmmqlygziv+Ov8/dUYLAX6YCH5+tWcQX6blZDuYaU1Xk qnIQ== X-Forwarded-Encrypted: i=1; AJvYcCWvxM+8SKwTnbSyCOw9mGlvRjHoZ2XjKes12CoBNaZ2QHEB4MLwJxZMZ4/l6Ztpwt8wzLlbfLABrQ==@kvack.org X-Gm-Message-State: AOJu0YypbNLhmD5jWEwG0xoriN6JyakocDEmcPb+4nrIjScuITby6ytx F+nu42Mwp/lA0mtsjG6M628f++xB5zrLE6CT+wl5bFXFTTaKUQbMy0ZKz5FLBIVW/kgrejRZZJw lYalEN7BhM6Rh3qL5AYpMXB1rk0zIxV8SoJXc X-Gm-Gg: ASbGnctWBiXID5RuDE7dxkKayLhi5Qs2cXIzT/qL+gihPjx5Xp9at8ZludSkS7TAn2Z Ttn8nfJ238pjGBcwJjqzv53jCk0dzKu9T+M9OMYc= X-Google-Smtp-Source: AGHT+IFySzI+BGcnP2NMuhMgR8lRKa+RtHNq46rcyyGa1Y00CBnG/3YZB/Qawo14idnVDm4aC9lF85ZeKgfNhAR7ZHI= X-Received: by 2002:adf:a411:0:b0:38a:87cc:fbee with SMTP id ffacd0b85a97d-38a87ccfd10mr6475763f8f.14.1736500345561; Fri, 10 Jan 2025 01:12:25 -0800 (PST) MIME-Version: 1.0 References: <20250109185908.1006310-1-isaacmanjarres@google.com> <20250109185908.1006310-2-isaacmanjarres@google.com> In-Reply-To: <20250109185908.1006310-2-isaacmanjarres@google.com> From: Alice Ryhl Date: Fri, 10 Jan 2025 10:12:13 +0100 X-Gm-Features: AbW1kvYleI4UFSsRT8dWyctDXekiqvx2vlx-kCP8ycETrux9E4hkgEcWPCgVSvw Message-ID: Subject: Re: [PATCH v3 1/2] mm/memfd: Refactor and cleanup the logic in memfd_create() To: "Isaac J. Manjarres" Cc: lorenzo.stoakes@oracle.com, Andrew Morton , kaleshsingh@google.com, jstultz@google.com, surenb@google.com, kernel-team@android.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: dpwq3czma9gfp49zkwmn67jtsosrmcp1 X-Rspam-User: X-Rspamd-Queue-Id: 2234F16001D X-Rspamd-Server: rspam08 X-HE-Tag: 1736500346-252176 X-HE-Meta: U2FsdGVkX19dlBpWnEXkPyZVdMjiXdGG9HLR8e5WKjCCBdkiNGm65lWq6J90s08IVZ7+dv/3RvaW4M/2uLQhbj1xsEp+AmK2LfYt2iGtuVza7X6FDTQkcL3KWGh5qo4JXx8wXENsm8ENtAPj02fLMGA4q8/dJQxW/j1PZvY/oyCpWwP8Vd5voxVzZg44o0ErfhVc1pKI+CRewoZqnqVVN9yyqitRXtKiNAKWcgjRqJQYkt5RvsIdPn8djcAHd1o9KzVsKUp2SnWE+GNPzmuG8xbLUzSDsT9VqnqRAyjV4I00RfjTCMoyofbu+Y6BmWDyiD9ye9/IBuw+ifzH9X93nfsqvuvlqExJcEBPeC4tTgoovQ5JhHlHcDnltO3xAyXhpsGWU53/jxLe4uuOKHE5l+6aiVY/O4FLQ1ImkkIlLrFrLzb4fc2KSvlNvQstRMbT/eVsV0u6wHB/zTDLYOttBdJBfAHs0e51EX9bPvtzesFtVdyDHQb2ksfQK/oRpxA0+IIuwBlxwmE/yg3t1XiTXYdiBS/iaCKOdog0wk+I76cKr4WtqTxtqpw4YiW4Yq07bxSBE8FSPEPYMiPMal9C6Jd6gOBAxFIJ8TtRY1s2ydz/bVWcEth+pifqZG/LvGj1xFlKsF9xEJ3pZhzxYQeGjxgO29vAAv8nYwKWa/+h7WzYqJJVoOM3alBq0rU4FWx4/GlrQ2GzgXVXaPKDWYrILFx0X/Vpw+AxjJ3Au3Gmsgx9ZqlqTAAIMJuxHWo8nrVLfQ9ZeN35EP8/LAcJlRrhbr8DdmQfEm28Visl+BhQJUpBUfqAQk/sisBoedzJ3eI0KxRTvJ+ZhWJEaw6SFiGPcjhxQIymrCH2qnTNUbPXnk3QnYBx72CfJ1C1kFcjjJBEJzZX/IMi0r0KcfQC30l4aDGVJvydGd8zkCL+S+FAehTxjIGGM5W8fTIiNKsYMdHCBDa1I9mP4a3XOPooYZ3 CgFSgNi8 9NJF12h4QKSNteGGJ8voJxqYEZnqx67Wlg8LSNZJ9IPKHiizajPjT5hoNZTuFTcAEwxOGNCYGTCv/bDLb/1dc8fMOG8l4RN2ItlZkS7+rMbdAUR4AqnB3BitvkAD4kwYBOcTwi4VweC0eJetPklj3FN+HUv0LTBm6K1SpXZ78Pzg/FO73howx3yX1uS/EjiEMQ/Dbom/3V7S9APzEocHaxsvzFu1IEBdWqmTq2tNjfFLr90E1faow6xKz6dm4Fac0lkJdJgea+dExPpXDj1Bz/IICx0bpWzdgJNQg3kCVeUa3ctc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.076914, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 9, 2025 at 7:59=E2=80=AFPM Isaac J. Manjarres wrote: > > memfd_create() is a pretty busy function that could be easier to read > if some of the logic was split out into helper functions. > > Therefore, split the flags sanitization, name allocation, and file > structure allocation into their own helper functions. > > No functional change. > > Signed-off-by: Isaac J. Manjarres This looks reasonable to me. One nit below, but: Reviewed-by: Alice Ryhl > fd_install(fd, file); > + /* name is not needed beyond this point. */ > kfree(name); > return fd; This comment seems superfluous at this point, since kfree(name) is the last statement of the function. Alice