From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1010DC5478C for ; Tue, 27 Feb 2024 13:12:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 94AF228000C; Tue, 27 Feb 2024 08:12:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FA8A280007; Tue, 27 Feb 2024 08:12:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C31928000C; Tue, 27 Feb 2024 08:12:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 68336280007 for ; Tue, 27 Feb 2024 08:12:46 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3C15DA10FD for ; Tue, 27 Feb 2024 13:12:46 +0000 (UTC) X-FDA: 81837623532.03.A2DA735 Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com [209.85.222.53]) by imf23.hostedemail.com (Postfix) with ESMTP id A326C140005 for ; Tue, 27 Feb 2024 13:12:44 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="Dti/L0iX"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of aliceryhl@google.com designates 209.85.222.53 as permitted sender) smtp.mailfrom=aliceryhl@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709039564; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d3oWv3i2/XO5b533cdNomwEvxjqpP18WAK9tbqODocY=; b=DP2DavC/bv+kwdqx8MYNCBYqipPtzoMZPj+E3P0VV437clky3ltK4ic1O/i/v+jRR9kmnb ZJ/qGpujER/X8voxIL3E1CHwtCPuQFI7c/FWYdHnrvNn7fApcZb6HOdKnVZeh8Vv5HOCf8 b7VLe1t9Rn+zTO9xTz3272ejA4roRyU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="Dti/L0iX"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of aliceryhl@google.com designates 209.85.222.53 as permitted sender) smtp.mailfrom=aliceryhl@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709039564; a=rsa-sha256; cv=none; b=uLhx/Woc8O91w+YRNPrmm9Bc9pMBpcWkNaUUEO+G6M1z0jKzpPBuJ0YJ+FBmmNQ3IBlRNp 2LcGc4dVMV5CsR5+742k3Vxr39ZEZU5bo2n4eVA+kXEs9sMQ1UymEvh9YfHDBkCdC0WBnd 6RkcW+f4QdryYHw1VVRJrEZnYsMIj0g= Received: by mail-ua1-f53.google.com with SMTP id a1e0cc1a2514c-7dac7cfbea0so96402241.3 for ; Tue, 27 Feb 2024 05:12:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709039563; x=1709644363; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=d3oWv3i2/XO5b533cdNomwEvxjqpP18WAK9tbqODocY=; b=Dti/L0iXv2QYdANRR75APgTAMmy2IG5eCPxYCUsASJUO/V6JRL7gKr3cNs0WeKj6Gk eqIkyQzMUZpSvC4my0xNLSJepA64b++J9XMlmCtEgOE6Nlmj7LUHjUOfOHd4nJPh8MIn I3Jo+tQFvk2w/wlqePiu8d73/dxE88k3/8wqTqdckJzDtTorBel7M/PwFOq2GdZoP3CS 6OZOBCvdlCqVo+0TELajzB11P/ivcSQbd+2IOEyhyopZUgl6HEjNTlvHEoyBNco7XNAi MUx4OzrJLUEnvbRGXiFBAnUxHRpUX2FlVfjS9SH4r+oR5c29+vDrf2/u9xVW+8fLdkBq /ACQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709039563; x=1709644363; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d3oWv3i2/XO5b533cdNomwEvxjqpP18WAK9tbqODocY=; b=CK8noNcgFENvWGzAhaHESPz/PB2V23w2GRpqzR9D9X5eQtlzgf3SfOjAsJlCFC06PY 98pfVhdojeYaX0D3Me2NWIfH5MhkgJcH1mpJBwUFVHv6A4wdbOOaVZGvOTZ4GkhgwSOD trcwn1B1qvWc+NvC6OGLnBasRh8dgLUs08a8P/Zym+FSLDY4TurQ1SXc1KddkZ6HwIbw nERKoNiiRgkV2EBSpEjMU5uQuP6U96HPXTBI8Ih0tA7usD6wkfKRzeOkvseOHO3LuIiJ OykMBPjBLoAqwXx3JWYq3zo1VrP8LsNs01dotIfuiVDeVObuel6So3+ssPZmfkHzy4Cg s5lQ== X-Forwarded-Encrypted: i=1; AJvYcCXja7TuZmMYITmMYGo65KcKhiuKoI2hvKsPiZLBCX6y7Nrt3j1yL67sEJKzqsy4VP26DIodaCEaBpkiJHEi50p7htA= X-Gm-Message-State: AOJu0Yzm6ZtXdy9P6wHX6DUnzDK8H0mZCAH83Zhf0zQY8CYaO3nOWIT6 sa6yEjxCfEcQHwLiQIfd1WXhXFNKAQpdQlZaXsZihX/wzE0XHvY7R0eZGHUqqxeEY66YvsNp/4m zw5k2rPWrud+H/c6ph7OGgfJAxgSK1FtjUuSp X-Google-Smtp-Source: AGHT+IGb8+w7aoyXh4uQz6QeOsCbek+YflIJRyj5WX4xYPWLOz1pYVSvGdKR7Ib1S98g5iKsdAqah8qeTHVRcJgTseA= X-Received: by 2002:a1f:da81:0:b0:4c0:3116:e909 with SMTP id r123-20020a1fda81000000b004c03116e909mr6754352vkg.7.1709039563535; Tue, 27 Feb 2024 05:12:43 -0800 (PST) MIME-Version: 1.0 References: <20240208-alice-mm-v2-0-d821250204a6@google.com> <20240208-alice-mm-v2-1-d821250204a6@google.com> In-Reply-To: From: Alice Ryhl Date: Tue, 27 Feb 2024 14:12:32 +0100 Message-ID: Subject: Re: [PATCH v2 1/4] rust: uaccess: add userspace pointers To: =?UTF-8?Q?Carlos_L=C3=B3pez?= Cc: Greg Kroah-Hartman , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Christian Brauner , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Kees Cook , Al Viro , Andrew Morton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A326C140005 X-Stat-Signature: 4efdfzm9zgstjmnaj68cz4o4sjmmmz5i X-Rspam-User: X-HE-Tag: 1709039564-980485 X-HE-Meta: U2FsdGVkX1+HAXnSrFaPiWixGlBcuX4xN1LvcFhy7BrOLJf4OVFznBn/b7RNHyRxHVY2tvS211jAx6IqONOtr+QULq9hPSpSpy2Es4XdEtRW5EaeYHr6XbrThIEVxIQzKSyqJ0P7SGpX2t+PaeWdOMWX7t+MDFh35BBgJGMR8BWq7CT3WKWygmdbex60MouVagQ0S25fpQoWghpwupBefNf3Q5YzYNGycTl26UuOIQP4txa8XQFLWAzCRLUen5Mboc+B65CcHkxQRpY+OWh4RW1IFAxSPGYPbkyuNuVcL8eSCyBSmrj93F3ivjE1Tj1X2gyXSTGY3c6Kwc+zWgDzKyETzmLwI5WlZhUkeVAjC5QV0Hd7DgeKkjuV+6w+4keN7wVaVQFSgDDJ2agv/YSnd4B/xe/mM46QR71nvqrDPs7dk+EprTc5ybxoJdLBYW9i3R75FKdppp0gGKPyl/ycomiouKnhKUNYjAQJdF4T3YJPsrPka8gy0m0s52fdCGY3IpKb9YY5kh0ZzYOnslBOfKXt2I1mlPFJlgOY3em3L/6gaVNbRBJmEKMJU9dnzSWPZG0CSL8E3gNtPYrqrHHMNiOEFHa2vqgTZRsIilZ6KjUa2b+ZvZhgljzYKWi8Z1Mw3ISk7f2wKRC+9r9czeeThrXni6//eXEZFaZ1QugKndXuuSG+yn4EgIivqnA10YiC2MAcdanyiYk6HMTkCQbev9J03aSCMtdpL6w0Ykrf5V91a/I3KNfbPEoW7QHKeHfktSXhUuOq/SH8etKlnKnUN6edP3eE/tonYRETf684kcmjvKIPlwEYo9PSJQAccCBS7vAtbgvOodG72k5qkAnOto23czvbE0ssKwQKyEyxpdHOcXQvVO9z4VVCbhmvT5RYsoZbfM+VgMjnuBJ1Wz97JrGlR5MweNMubEdotJSMqa/hfduH4gZIoY0MRin2OG0/Xkie51uZ08uPIBBRPbN IWFx0VQC E8tDJoEXsxDnFclnyQnB7u/mMOg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 27, 2024 at 11:05=E2=80=AFAM Carlos L=C3=B3pez = wrote: > > > On 8/2/24 16:47, Alice Ryhl wrote: > > + /// Create a reader that can access the same range of data. > > + /// > > + /// Reading from the clone does not advance the current reader. > > + /// > > + /// The caller should take care to not introduce TOCTOU issues, as= described > > + /// in the documentation for [`UserSlice`]. > > + pub fn clone_reader(&self) -> UserSliceReader { > > + UserSliceReader { > > + ptr: self.ptr, > > + length: self.length, > > + } > > + } > > Just out of curiosity, is there any reason why this is not implemented > in terms of the Clone trait? I think people find a non-Clone-trait method higher friction than just calling .clone(), so this nudges people towards not using it if they don't really need it. But really, it could go either way. It would be okay to use the Clone trait= . Alice