From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9EE8C4345F for ; Fri, 19 Apr 2024 18:12:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FA596B007B; Fri, 19 Apr 2024 14:12:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AA5A6B008A; Fri, 19 Apr 2024 14:12:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 472946B0095; Fri, 19 Apr 2024 14:12:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 291E86B007B for ; Fri, 19 Apr 2024 14:12:39 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D9117A257F for ; Fri, 19 Apr 2024 18:12:38 +0000 (UTC) X-FDA: 82027076796.18.ADE0C42 Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com [209.85.222.49]) by imf06.hostedemail.com (Postfix) with ESMTP id 46EF2180015 for ; Fri, 19 Apr 2024 18:12:37 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=AUr5WJUv; spf=pass (imf06.hostedemail.com: domain of aliceryhl@google.com designates 209.85.222.49 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713550357; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pr4pi+Kny8bbVl+Iz+PAepuZ7kpgc/VuFcgkzz8aTw4=; b=7uJ9YUijRkikgq7GtQ7uQGjkv9GHRW+k7P07B9EhzvKwu6jYeKUhje4oz49Bi4OnlBjn/W AHhg8FBT8zpTfZdaiS4MSThJBeAPk1oncjJHCSIjotnfqks+svFQaWP9MMLJ2yKzUkELTw rEWyQS4pqv1ST0o8sI7v5ZUowTD1ENs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713550357; a=rsa-sha256; cv=none; b=cmwtrvTwZXY93h41qLR3i1UwXQd60UxKiQTg1VFG/+6CxfPXRSFy8bCju4oPsg84KQFk6y roMj1L6wXh5dyWjWJRTqv0NbulIOCbbdmEYCF/qgX82qC/hI0g/qDeOzMvP8JEvjDsA/Oa 6I+5xVPnd9GB5HjIfwRoSHwZzbB391o= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=AUr5WJUv; spf=pass (imf06.hostedemail.com: domain of aliceryhl@google.com designates 209.85.222.49 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ua1-f49.google.com with SMTP id a1e0cc1a2514c-7ec48a0306bso702798241.0 for ; Fri, 19 Apr 2024 11:12:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1713550356; x=1714155156; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pr4pi+Kny8bbVl+Iz+PAepuZ7kpgc/VuFcgkzz8aTw4=; b=AUr5WJUvXrIT3lrS0TgNLc453UHF3KbbY7HkLNorN77vfp6BrKYbAJWG4ntbwYkAzd oxQddlkGOL8yt1kcl7LQQqAVP5fbsVdujo9Vlz8JdsZSiqgfcx+8+bfWNnMLkgmG9m33 6cpf9ImjUY0XzEdNXPhOAKATpkDDJbS8YotmOk3KLFBuN0YkAV2ToOEOfdqxOn5hvyvS WEKAtRyx0SJ9DueRrfZCDpCqa+8lCoXBs3r8PkvTnRFBUoJw0kds5qddI3GoH03VFV9e c4RBkzxV4fuCBruXvHTG+7gUuXqL7IPIagPbLlp8JwSIeS8cL/M9lShjZihLe6zC1Qk6 RjnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713550356; x=1714155156; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pr4pi+Kny8bbVl+Iz+PAepuZ7kpgc/VuFcgkzz8aTw4=; b=OulYy5yo5u0CdWvWO2Xe1aEPyB8FRF/nIyyQ4SrN8ZntLtUJQIwNcj3vcv4b4BYV1W PfVUCAuQrYrBGEmdCxUuQpVE9kKrLWERE8O93w/oxsyRPX6HW0JozSJPOFxTdjHmxBCg LYbuslDeR8XOI3tQ+qOj68zGa0Cne+Bn4PtR5Zq4PKTq8eqXFVv9G+dONlmAjS/OkTky z2+FTW/zKOFUCEvUliYPt3qyOry6tUdqFFYaqS4z0JNbtH4QbH0zZWJLmAnDXoQcn7k0 P6u9ZlHlLKASKy5UXYsKwD7RPFqSwAoFG422u2XWcrn+HtEHPvIJsn/oeqDmeOwVv/Uy iKBA== X-Forwarded-Encrypted: i=1; AJvYcCWT+wbgbtjuTxT7OGkywnt7i/a7ta1QcUVhgLk803UWDwHuCIRTtBRkry4V7tp3fKOYtOraFY0sn5jItyalziiB05c= X-Gm-Message-State: AOJu0Yx/lO/t972BIF2/wIg+PzFG+4gTfso88uYJdgwbLZmkRWMZhfEF iYS94BKtpsr/dy6jpzQPWjJyA3FN34oOM2JbJVdG0BanCfWFTGqmnYs/4pZWicvvKq/1RRJ+too nS5ASjBXIKHRuVa1Gor3gwYCi78c8PqI3dFDo X-Google-Smtp-Source: AGHT+IGKWqj19fr6lCGVBtuwAdS9DytWE1K5v7+RkbOscyxSEB74jIiRfprxzzsCH+WqgTqKdbso+jk/KyNVUnSu+YU= X-Received: by 2002:a05:6102:2844:b0:47b:5f05:5a57 with SMTP id az4-20020a056102284400b0047b5f055a57mr8647652vsb.16.1713550356213; Fri, 19 Apr 2024 11:12:36 -0700 (PDT) MIME-Version: 1.0 References: <20240418-alice-mm-v6-0-cb8f3e5d688f@google.com> <20240418-alice-mm-v6-1-cb8f3e5d688f@google.com> In-Reply-To: From: Alice Ryhl Date: Fri, 19 Apr 2024 20:12:24 +0200 Message-ID: Subject: Re: [PATCH v6 1/4] rust: uaccess: add userspace pointers To: Boqun Feng Cc: Miguel Ojeda , Matthew Wilcox , Al Viro , Andrew Morton , Kees Cook , Alex Gaynor , Wedson Almeida Filho , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Greg Kroah-Hartman , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Arnd Bergmann , Trevor Gross , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Christian Brauner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: rup7gp6xodzg5r1ctzhspoyhnaotsquc X-Rspamd-Queue-Id: 46EF2180015 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1713550357-938763 X-HE-Meta: U2FsdGVkX19tuMpcaFZxqmU+TQmEDTa/zv6eUc1DLEDm1SPHsCwOScrFveGoncGxi19biZ9ni4bvls6FCV4gYN0pbMFFYwz+cZiGglTszpqdUqdVd1dlYXGc3ZECslr3aFi8ttLD6C9NG26uu/JzVvGvej+G3blqsMDzOCD8RvHLxC3FK098Pgmk5t3JumA1TAU9jdmuE4PtmlIQO6qu8kbN2IOOsI8ukDpDY4pvxCrYqdNtgf65+BJIQC2yoCkGKuCH/pJbY75SCICHVlf6n1WPhx3Z+eYd0SfslR0qanVZTJV3tXB91XmST00+PH5XK+5ke1S5DZ0bq0DA9WUMzahhu/kONPqz1KlCIMMWmubbbhUo37LNZnkNxrsPaJTfETRoJG+5Svq3JRz1V2Jho2fJXJH5SsHfK65G/F+ezWdmmI6WhK5wKwN/+8dLXeL/jH+5IxrOJ6qnIDr+700nJNKuWaFI8E/S7Rc88bBkRXPyBuflTMvl31fxvY7Vp/ChPPWcJmBjfofYnQVBGNJL+xiHFZqEtEwGif446ChcLeO5AdamebWxbjypDzNv8c/+ItL1R72FRBKdJH8X1hdD8lFYUI0x4f/nz+7irkV3xc34F2lKgfowKrqEl+qKxTIcesMxvvfjal8Dija+z2uUkltxrXgC0HzzQax9D0XiVmkpVcAoxJ9+7MRLmTZfZfrGA+M8mY23lt3WoUk169RmO9OU7RX1ScSNtVtKpUJTHC/Z+xUHxqGI31PnElusLx56WRxHpX0RyY4TAuyma2b7tRW2oPzfzl0B4wZ2ovFaQZuD3hu5ISWnbgisQ6MuiUypd05GDkn8SJ1QHI0QnMQSRByfEyu65/8jWOxvOA3vI5I6lxEHe2yL2Gg4cm9GqUpMyqEDsqmS1M8aWJgNiNxOqM9Rx1IziNrdKDoR8r9ADL8FLIob5JlA1gFbIU9kw59u4zd/ReV/A8mLQXCgAZp aK4KH0pG b9pa4hAFAV3+FgPSVXnZ1xjzBtRShixcHSuwbLHXh7jpLjrpQDiJAvRQcBjafOcWcBKkk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 19, 2024 at 7:11=E2=80=AFPM Boqun Feng w= rote: > > On Thu, Apr 18, 2024 at 08:59:17AM +0000, Alice Ryhl wrote: > [...] > > + /// Reads the entirety of the user slice, appending it to the end = of the provided buffer. > > + /// > > + /// Fails with `EFAULT` if the read happens on a bad address. > > + pub fn read_all(mut self, buf: &mut Vec, flags: Flags) -> Resu= lt { > > + let len =3D self.length; > > + buf.reserve(len, flags)?; > > (Reportedy by Miguel) > > When compile with `make rusttest`, kernel crate is compiled as userspace > program, so we need to explicitly pick where the `reserve` comes from > (Vec or VecExt), the current version will hit the following error: > > error[E0061]: this method takes 1 argument but 2 arguments were s= upplied > --> rust/kernel/uaccess.rs:296:13 > | > 296 | buf.reserve(len, flags)?; > | ^^^^^^^ ------- > | | | > | | unexpected argument of type `Flags= ` > | help: remove the extra argument > | > note: method defined here > --> /home/boqun/linux-rust/rust/test/sysroot/lib/rustlib/src/r= ust/library/alloc/src/vec/mod.rs:910:12 > | > 910 | pub fn reserve(&mut self, additional: usize) { > | ^^^^^^^ > > error[E0277]: the `?` operator can only be applied to values that= implement `Try` > --> rust/kernel/uaccess.rs:296:9 > | > 296 | buf.reserve(len, flags)?; > | ^^^^^^^^^^^^^^^^^^^^^^^^ the `?` operator cannot be= applied to type `()` > | > =3D help: the trait `Try` is not implemented for `()` > > error: aborting due to 2 previous errors > > Some errors have detailed explanations: E0061, E0277. > For more information about an error, try `rustc --explain E0061`. > > and we need to the following fix > > diff --git a/rust/kernel/uaccess.rs b/rust/kernel/uaccess.rs > index 39481e374c40..80f7e7ca2f5e 100644 > --- a/rust/kernel/uaccess.rs > +++ b/rust/kernel/uaccess.rs > @@ -293,7 +293,7 @@ pub fn read(&mut self) -> Result { > /// Fails with `EFAULT` if the read happens on a bad address. > pub fn read_all(mut self, buf: &mut Vec, flags: Flags) -> Result= { > let len =3D self.length; > - buf.reserve(len, flags)?; > + VecExt::::reserve(buf, len, flags)?; > > // The call to `try_reserve` was successful, so the spare capaci= ty is at least `len` bytes > // long. I'm sorry, what? This seems like a problem with `make rusttest`. Alice