From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E52D0C3DA4A for ; Wed, 14 Aug 2024 07:48:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E9586B0082; Wed, 14 Aug 2024 03:48:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 498D76B0085; Wed, 14 Aug 2024 03:48:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 388456B0088; Wed, 14 Aug 2024 03:48:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 19C696B0082 for ; Wed, 14 Aug 2024 03:48:37 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8301AC09AF for ; Wed, 14 Aug 2024 07:48:36 +0000 (UTC) X-FDA: 82450073832.30.0EDF21C Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by imf18.hostedemail.com (Postfix) with ESMTP id 0F9621C0008 for ; Wed, 14 Aug 2024 07:48:33 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="p0jOzkK/"; spf=pass (imf18.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723621643; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zRLxSfggsbxe3d7cfCO7JzeyIYzJnFmhVfUunHaRPJs=; b=E2Tl1f7lWtoDLY9Ft0GtfXz0enVlqT1GJ9tTZ5HNwgTDkhphFF2aTmmeaJpwmaR/s0MYOX RLWnkjZzehIvwzQQzCKl75fevR3WfBGctSE1YhY77fPcYMsXDeYWxlvxYeW7bMR3H2eg78 GMnfhHFctx3Nm3t6+PCh0AA+wKoLLPo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723621643; a=rsa-sha256; cv=none; b=JTKFYIA0Mds4+9FOVI635taHvCNWTeM4bwp+CsdC1UUwK6mbEfId/x2TBUL658JcW9aZH1 ljWVh0BPpJCR1dwmQ16W6dvJsWFv5oXj5mJFGu7S7Zbp+At48EV+jqkyXzY8DbIOKSnRye smJw+k3Onxd4B8S6m+e4/uksJGDoXrk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="p0jOzkK/"; spf=pass (imf18.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-36868fcb919so3712656f8f.2 for ; Wed, 14 Aug 2024 00:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723621712; x=1724226512; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zRLxSfggsbxe3d7cfCO7JzeyIYzJnFmhVfUunHaRPJs=; b=p0jOzkK/RWzCE7u7FB+H/cHnONKrjNXCAfbMWlQ4iXOmVU76pO06GsgU/Q2Fne3IV2 hMtf9kNISQ1UVkgUMvch1mkOkcXck9uUWxDBFbyTg/y/9z0Ibbghj8wp4hxtrmUtXW1/ MfRnfN+5Oajq/dj+x3aouHGTvtUbRZ2/51YgwEnCCJILlxDYEcZKDV2Zd+GjovUMWNM+ 59Z319EIC7TIz/h+QeX+5IW0ppx+zQoCVoDyQOh1Iz7Laiq3J5zOWqnLvIbBQTl/Da8P AXpNMMfh/F9ysnv2gBaBcyep975sFaeElHHcLSI/1sOvgkgz9lyprU5WGRt3BkgtHzyN hAtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723621712; x=1724226512; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zRLxSfggsbxe3d7cfCO7JzeyIYzJnFmhVfUunHaRPJs=; b=SR2bloP/bndqIIU6Ccnzrs4UbE4uKfw1/3RBTXE74hOnwagptveQ5soGD44ZDw5QeW YdExsl4fw4GTjlqnRL16IbcvsgKYMSDYBjNcBEQn4M1iFUQDFeHAbN3jG04fCYTbWI77 inQGYgyO//RabBF3iLkU17DGylGv5YQ7+FfALqRpK9rRUetM3KxaCVfuRz5OAhhQ/OGm WKsQUz9o7EAN0zz4JE+/NM4Qeb6iO5r0VCr9MdQTlDQc6FKDzhBvbPWVQUWrLqvVMeMb nG9E3jpcDpN14lOExiJsawuGUYwfq2Z7R0w25VDsCvyrGmJp45q/TtiSvbwhBwA3z0W5 utbg== X-Forwarded-Encrypted: i=1; AJvYcCWiMV5mVTecKAgBKoPTszxGWoSUhinDqbEq1ZHPQhbFSS0Os8SvTbUO0Oo2GYz1Xsq6oCn8Gtr392A04az+I4h3W/g= X-Gm-Message-State: AOJu0YxMDp+DoE+LkY1oZpN51V2pZeNyOoxaD9K3uDYgMCtJNXdQHgDB Nu+k+Jo/O9s0HJ/GUBJB6B+C3F1Oq3fLUxqhkmbsOMkWkGAyYUHMKQWfxiPIMe7koPMJuIN0Mdt dCsXrE+41MfoyYu5hqV2Az0AxTC4grFvcfBZt X-Google-Smtp-Source: AGHT+IFszK04DfhyjnHB8HAsiUvfKiYaTBLS5Cci2eet/nobda0BRm8km1MdiKanezp8dm7Kg4wNR4OK+iD9anVVD1g= X-Received: by 2002:adf:f5cc:0:b0:366:e9f3:c242 with SMTP id ffacd0b85a97d-37177756be4mr1218451f8f.12.1723621712012; Wed, 14 Aug 2024 00:48:32 -0700 (PDT) MIME-Version: 1.0 References: <20240812182355.11641-1-dakr@kernel.org> <20240812182355.11641-9-dakr@kernel.org> In-Reply-To: <20240812182355.11641-9-dakr@kernel.org> From: Alice Ryhl Date: Wed, 14 Aug 2024 09:48:19 +0200 Message-ID: Subject: Re: [PATCH v5 08/26] rust: alloc: add __GFP_NOWARN to `Flags` To: Danilo Krummrich Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 0F9621C0008 X-Stat-Signature: 64c68imuy3sqfzdgjpsxk96ib5mqhsia X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1723621713-598441 X-HE-Meta: U2FsdGVkX1+mW3fT4NauWYznzeEN0LmNPvlmcwipPLVt8vdI9OFE4njsAvkuu5/6Bas7OtpPcFxsgP8L0P80Pz4AHXlIyyKatw628EqT6ZI6ayBpdFGrMO9Iqy0HAl/AE5A6nyTZaF8fH81LERw8t6D8t8kcA3L3vFy33Zpd+cnb+qcmxvtofVFHJsdy/4s/U7Mdwrxu9GJdisfZzKhlBhiON7aZWdTa9o+IdSsd1sf9syr4RSfxV7k3oCKGt5zXfFyBFNMn+KI1g5UA2J4cg3O1CA2+gH+QvRowHqpxd48uGcyzkYGFLnZrDm4fHL2czjza3VTpPreJ/lhUG5tFm9G2Ka0hICBIxkuXBaqCTg/wck3WVc7GAalblES1ULMNmDzdWCNStD7fHMpBcuCovhFmjbhM0E0bhUyE6rQi25JrGoVRyIzY1tN6epTVqbL0lVWF447dnIAZ6FHjryZ07cme57n0b3uInvKXab4GGfr1CtXB4hj5Sp8NZlEm29kQ+JtDbiMRTd00E4EtX6+OCw124MqDwYH1IxzxbHGblF2i7MAHq/x5Ch4WhDY0xWhxXP3ov2ST8Ib5LnOBZqkfcKO84U7I3GEIGVEVE62mPhPQrDgweWIVebkwh4d+9vr78NZBNrXFACILg2tQQCBV+P37z2d6oJvA32MdAE57mPBF7irVmrhD+B7M9XAHQCjuGZcRI+JLvVWLv/yR1pVqHweP5NWxNdCiFcl5ipq7C4bvwNTIIMdHyZCFvV5c3xSELOBOb8e2BLD3C/WhUHKzOFtfBtRMdjsE2tHoZ2iWXEHM2Q0J4wN4YeFJjZ+GzUceq0BqMUsBJQz3OydNrF2oh59kyW/sRsQl9RlzrfkEDFYdQ8vRwC+q1cc+wUC9hvoXBkaMdMvgpaFFCCksWoAuuwMtswXFXMPeEqHZkuJWQjKidbyBXFkZ5BXJDR1pnajyUAc4CS4q401aD16jBq3 bPwksBC7 C0mYmepWUyWD2O8wmwWvYvhPd/4eBTvJEeEWMgfhBrRYS+2PD1+7qxfLfqwdvHOO0ex/L2szfyLGA2vr9vbyXvNXqpj+4E02FbJzrMUwyEtUL9Mrjm4LPPfdvrXHtLi/xfDq2pz9W6Btz0CwHuHQ709oONjMzlr6Rf0/BXbNfuoG++OVvXSoq0XS4LyChq0sJR7jtx+PMZZ/9PeGnpxYCkTTVbT2saUmqe2SVkiTVdjkfn3aoeyWoBeF9fhYAAbOgWIwi2w43eUW9j+QYYGmGm76UYyvT/Kjh0smh0WXMZYbNfMs1CkiNR+SeFjLSm+O6V8cI77mwdWuYVhqhUQYKAP/Qw1ot/0gOC/DLk5dBSD4PvtEbaCoRjt9bCg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.014460, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 12, 2024 at 8:24=E2=80=AFPM Danilo Krummrich = wrote: > > Some test cases in subsequent patches provoke allocation failures. Add > `__GFP_NOWARN` to enable test cases to silence unpleasant warnings. > > Signed-off-by: Danilo Krummrich Reviewed-by: Alice Ryhl > rust/bindings/bindings_helper.h | 1 + > rust/kernel/alloc.rs | 5 +++++ > 2 files changed, 6 insertions(+) > > diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_hel= per.h > index b940a5777330..7f781256fda9 100644 > --- a/rust/bindings/bindings_helper.h > +++ b/rust/bindings/bindings_helper.h > @@ -31,4 +31,5 @@ const gfp_t RUST_CONST_HELPER_GFP_KERNEL_ACCOUNT =3D GF= P_KERNEL_ACCOUNT; > const gfp_t RUST_CONST_HELPER_GFP_NOWAIT =3D GFP_NOWAIT; > const gfp_t RUST_CONST_HELPER___GFP_ZERO =3D __GFP_ZERO; > const gfp_t RUST_CONST_HELPER___GFP_HIGHMEM =3D ___GFP_HIGHMEM; > +const gfp_t RUST_CONST_HELPER___GFP_NOWARN =3D ___GFP_NOWARN; > const blk_features_t RUST_CONST_HELPER_BLK_FEAT_ROTATIONAL =3D BLK_FEAT_= ROTATIONAL; > diff --git a/rust/kernel/alloc.rs b/rust/kernel/alloc.rs > index f0c80ab78602..295107777a12 100644 > --- a/rust/kernel/alloc.rs > +++ b/rust/kernel/alloc.rs > @@ -91,6 +91,11 @@ pub mod flags { > /// use any filesystem callback. It is very likely to fail to alloc= ate memory, even for very > /// small allocations. > pub const GFP_NOWAIT: Flags =3D Flags(bindings::GFP_NOWAIT); > + > + /// Suppresses allocation failure reports. > + /// > + /// This is normally or'd with other flags. > + pub const __GFP_NOWARN: Flags =3D Flags(bindings::__GFP_NOWARN); > } > > /// The kernel's [`Allocator`] trait. > -- > 2.45.2 >