From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 347FCC3DA64 for ; Thu, 1 Aug 2024 08:44:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B89546B008C; Thu, 1 Aug 2024 04:44:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3A196B009A; Thu, 1 Aug 2024 04:44:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A28C96B009B; Thu, 1 Aug 2024 04:44:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7E7A86B008C for ; Thu, 1 Aug 2024 04:44:00 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3B4E2A3EA5 for ; Thu, 1 Aug 2024 08:44:00 +0000 (UTC) X-FDA: 82403039040.04.7BC4EA5 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf25.hostedemail.com (Postfix) with ESMTP id 3DF2DA0019 for ; Thu, 1 Aug 2024 08:43:57 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1dU9whZs; spf=pass (imf25.hostedemail.com: domain of aliceryhl@google.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722501781; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iP+wXHnrUpcj585wjD/GGe/CFFp7MnVySfl/FL8dnoQ=; b=2LCgrTGpjKVIo8QFAMShLoCiguXIAaQeMCmYdMTzWhPKYQ35PmQjh+qpu+lmSjHkQqdhWZ oPnJ/JDPNehFQq6sJ7YkOJ5HHvqVClcGZkaOg1sZoRIp+n1EJu0pu/so/Cm5EzeQfNnZ/E 1hrOpBAm4lxGabqavJ2XF9l7jPHoM/g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722501781; a=rsa-sha256; cv=none; b=J3+odWQBrNrlh/hwa6tBEmRMgehfeY3pLtDMHkbytLlZClrXEOuDHEbl7qNZA2XBpzrAfR 9AMFkj3s9dwtTF0dleXKaozER8F8QAP/fg26Dr5PYxtR1/1VcIqMVkQqHcJ0MffeZbwk+x bX/waMBJFzT/JVaGuHOMIbkEQCgPFlU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1dU9whZs; spf=pass (imf25.hostedemail.com: domain of aliceryhl@google.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-52ed9b802ceso8191004e87.3 for ; Thu, 01 Aug 2024 01:43:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1722501836; x=1723106636; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iP+wXHnrUpcj585wjD/GGe/CFFp7MnVySfl/FL8dnoQ=; b=1dU9whZsO/GXXcTnN2NElLv5qxR8tHf8Y8nwuu4ayxC0vg42pIR9qZtNIEmbhWYCv1 VmYXjgDVR2p3Le+ecaf/G6bUFRKD581QvhhGjKPTQrB8ryshIqde6ZFEGyKIBb3zL6xL 3uIw0XOldRYI1crotO+UJLNgniwiMHbvB3cSApT4abMSBUAv0gx14UseyLDmrzJjG3G1 +RAwX2jpGzRzV2W6svO8hjxIGE8I6qxS/QCbzVcINTi3kJ0VXTUIpzvcJhoOKRLMqNYT drb4b653ATvGd3sgpA2QU1PaqM941A3wuf3yzk9OZ/2JvIWE5bstUWy5DsRP9r0g+nV2 5vyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722501836; x=1723106636; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iP+wXHnrUpcj585wjD/GGe/CFFp7MnVySfl/FL8dnoQ=; b=fHw5kzZfLkveJqb9iVHz6mDqaF/xxY+ZNFXbnO7eihCsKEmpON+FuA6wqXivwd4Dhr 0i/eCs7piHwh6k9sEnukriXn/xfKRULH7WVOBkVhk4HHD7xATYLNfW6EtWtNaXPqA2U0 UYB+pr5A7urKRMn8wWYCitIV9okIT1o35hyRD7BRwhfibWvy5UegCIrSe+y5qfbQBmF4 Dyxgi56Sy79tgmugH9UqWdqmrTwogtjSnFmvelbZ3OEVH5elj32gBwoWFqEgdQF74daR JUfAgeMQ9ogoW4Z5QPe1RKGDh9LGRuyAP933Qm4g/459taz5uAExYC6RUWdC3yPjlOyB SqGA== X-Forwarded-Encrypted: i=1; AJvYcCU1045187GWZ2v6mcisCNfD3vvb1o9TmMcOYXP22S8fZ1Ydhok2QsXhz+2Z/ms7TDVOkLiGnDMNV0K/pgDFZzldTBM= X-Gm-Message-State: AOJu0YyFOl1WDMRJndvfa9cP8s0Gx8I796AhvAGtecGgGvdbA53Q8OPn YTGmmjH+Denn36n4rL+FnfG0rsEmEQYBkrQM+75RBz1UkOlO1BcaYpMskSUt8/3k1DGfby0R7FZ VhnVTJE9bO3RFpOw7tPhhSZOeMKZoPHdpLdcX X-Google-Smtp-Source: AGHT+IGdDsuI1EafN+ofyqULjxuCJRqqfXvKATrAaEwxr7DoXVNIozm//LiG1UZg7xqVBwAwG8F1llz4J7Ksp/P1ric= X-Received: by 2002:ac2:4309:0:b0:52f:cd03:a850 with SMTP id 2adb3069b0e04-530b61b8418mr887803e87.32.1722501836401; Thu, 01 Aug 2024 01:43:56 -0700 (PDT) MIME-Version: 1.0 References: <20240801000641.1882-1-dakr@kernel.org> <20240801000641.1882-8-dakr@kernel.org> In-Reply-To: <20240801000641.1882-8-dakr@kernel.org> From: Alice Ryhl Date: Thu, 1 Aug 2024 10:43:44 +0200 Message-ID: Subject: Re: [PATCH v3 07/25] rust: alloc: implement `KVmalloc` allocator To: Danilo Krummrich Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, acurrid@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3DF2DA0019 X-Stat-Signature: h5zrohtquo9sok3gkmy5a9kn7i8czs1s X-HE-Tag: 1722501837-492682 X-HE-Meta: U2FsdGVkX19iXjZhfrnNq6XkqkrOe8v3vgeqcilaWGPNDHO4M4AEm1tgywb78nGD2vvgMd+mN7szq0ld85YXSFRa2BoepV5sqLaenRXAjxkf6DPI4DQMcbGowwKcxn5T0z6yuMN5V9Jf8aIcXbdBzhAFfE0mg3dvbM5cfwJU2bJJUaeP9HL2HL8+mr8yIEoPRJUfQ76m2IBkJOk1u7MjCjEI8xNNsHu1E/KOq2odJd8ep/TojMSfWAsivgqMIj35GvWhyFEN5ov/2iiQMKK8UHhEBTSprmC2nEBM5ADFWkhJ9Yr3cjt+1E1oOAvWGJNOw/5sWdk9ELEmFaSRCROSxub5ZpJNVhDpUsv2O9KM4CXhH0iWo7p5xDmk3WNo1AKxkdf062U7m2NIgC9bdVwkg/DIE96jMWhxh/9jCPRX3TaN+ExfiaD9hwvs+xFaa3xuKIlF3Hm4C1y1JeYYxQWELMSfen3RkSc73cny+L9y+sOIMBt+deT/+2WW+Y/N7hJI6NI7jqTGqlAVN7CbdqgHt7sk7JxIDeB55hvUdj0BtxZ8KbPyWpBIXJQIbRBFr3RhIb84elOlaIlsAPGObeFx5YzYW4vXIHm/xf5GF98tA745C3V7Me6h5teOSU9+h5r0yCGk6FxURUwaa7EFXOR/aAiBJSE/8i4c1a1/jYSAbdRZHMpX9Eg6sT6A/Uhm5028LFXxfM2JURKJdPyLI5uRx7Mukhu0oKq/TuVA9xQUXB+qANisalQvnJi0Tyd0+/jvW/tH3U/XEK6ynOlU4swAhPk8C9M56OFSGszH+t6fsIz7y1Hh776zEGVcGTBrvG95TbwRFmnXOH3SJdjWSqrmypShBWsCXfmw0WQsneJUmJlAxPZ2RIrxa/3lAmt7Og4O2TMIywSzBFiEnKwFUg5BavFE6Civink0sA1dJ/w7+HnhIOZhpHsYzMCc40X8SpTmHH35/wHTLNl4yZLfots 9HlJN9yp TZaCAZb7YyKi5wSNul09NGzGPSGzszDCOHFFd7OdfY+F1H2KFCocH+dPlreV+HVwTFjWpuB+4z/BFprByCwRt8s7cU9cMUjjwvscYUzK32mBCyvQmhfs89bV3qTza5bsdVq7qs6TakApA36TS6yz6c0t1tOZ56OsNRsL5iCrgOL8mwSm/At6OJXoVd83uCe39scj2Do4OIv8yCj1vLVXhXP0UcpH0KJ6QC4LkH6F9IAZY9Iw5oOaWqM2FVnjII+T8zlrN90s5FU/Kqu1yYKRcJSyy+dE0RqLZcMDOSxSw27B4W9qHg6qJwiDbYfBBuwbFJOhw X-Bogosity: Ham, tests=bogofilter, spamicity=0.309513, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 1, 2024 at 2:07=E2=80=AFAM Danilo Krummrich w= rote: > > Implement `Allocator` for `KVmalloc`, an `Allocator` that tries to > allocate memory wth `kmalloc` first and, on failure, falls back to > `vmalloc`. > > All memory allocations made with `KVmalloc` end up in > `kvrealloc_noprof()`; all frees in `kvfree()`. > > Signed-off-by: Danilo Krummrich The nit from vrealloc also applies here, but: Reviewed-by: Alice Ryhl