From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2AB1C02196 for ; Tue, 4 Feb 2025 12:46:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32B846B0085; Tue, 4 Feb 2025 07:46:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DA526B0088; Tue, 4 Feb 2025 07:46:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A3486B0089; Tue, 4 Feb 2025 07:46:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F139E6B0085 for ; Tue, 4 Feb 2025 07:46:51 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 84BF31409D4 for ; Tue, 4 Feb 2025 12:46:48 +0000 (UTC) X-FDA: 83082236496.09.AFD30F9 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by imf25.hostedemail.com (Postfix) with ESMTP id 99528A000D for ; Tue, 4 Feb 2025 12:46:46 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gieuUAPo; spf=pass (imf25.hostedemail.com: domain of aliceryhl@google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738673206; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mZIhs10/E/7OHie6ls1kLvr+5pWu5vHwZfAGymSupLE=; b=0pueedmwXcCTVsiOnIF0Aa8DIjgAu5ficosVBFvMXhiO6CZivesi2VY2tCKv98Nl2oUOVc +oMtLHkGbNwaPJ6QDXQhSVH1da8gVnTM7zad53CREV6K7bEwYBJ2yH44HLDCD/Ei5pCQsk 18sRlbkeXrI5qPDJozBXOGRfpUnFaYE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gieuUAPo; spf=pass (imf25.hostedemail.com: domain of aliceryhl@google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738673206; a=rsa-sha256; cv=none; b=0FDuypiHY98aSMkg/o1U/la0qjLXJFPsaq1dlOTmz4w9DDXcVhyWTcKATKkyeEWAha/zZs VtlLkO2oWvc7pfrlBVVMXJKBCI61qI29zJPXfZ9TQzTiP/89Qg7LK/EduOHD0Zc+k7c4Im G329xY9TziIVRr990hHDxgqF8Tap3WE= Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4361b0ec57aso56728435e9.0 for ; Tue, 04 Feb 2025 04:46:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738673205; x=1739278005; darn=kvack.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mZIhs10/E/7OHie6ls1kLvr+5pWu5vHwZfAGymSupLE=; b=gieuUAPoFmlHTgBOlCXvzSHNKUDNHa69DA/HzQyaCPH6HpN+eBTc2uH+7RWDWuhSAb lrr0xRkGSnOm6At+RRKsUISQXuJvdqIPFMLewk7zLqjHJlKd3oHGvADS6xRVXCYYpeXG VFBABca0l/2eKrenoLQAoVypHjzc0qh3atIrG5I6fvdaJFC0CrDDVVO+ys1XatJjm3x0 1zMMIgEw8T5o8CtfB/Lk027tOm3/UKK/gudDQVGC2rIEYKD6IFlNlCG5A3yveDeCzkHL 3mb82aIhadrIuEj6Xc6B5Rzi/HZ9BdgGhaaSsAT0ccIZ5eMWajbP/pOa374CSIO282pb baZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738673205; x=1739278005; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mZIhs10/E/7OHie6ls1kLvr+5pWu5vHwZfAGymSupLE=; b=Vwp7PlOQwe2hs+HWB8Aco6vmH89Vi4xq09G1q7vyCT6JwqidRjKOmDrodwwAAfNACR 4RPZqU8AgTeIPc+cxEHdU7adjxyu1XfXqVbRQsynToStBKZCPPiTghAYNaz7bK+HZKZn mILKPHJlzBp0EBXG1vMubs5Z+AzDpGCxwzFrDPHI0pLT3t3Pw4vY3Wxq9OZtx9qqdAqO TUhx8cg34fd5b+795kLUnwEtSm8f/R97FF4E8z/lDB2daZRbGg0g6GX1rD0OYjSgqmwY 0tzISKoSRexbij4e0oJxGOufNhAsOzeIEZtRQ5jJwtvrroAnaehypVIutoTwmbNykSXt tDIg== X-Forwarded-Encrypted: i=1; AJvYcCW7N0BJm6dH7HCiRG/5TMF0QJIcb27lAjlxo94/WEmew08F0YtWxKqOnFg4fjYp7AfBcFNiPrGpcg==@kvack.org X-Gm-Message-State: AOJu0YwgtVygmgUkJPnMVDosXflS2s5IZRRYZ7hiMuF6WC5Y5z6xueOC yPjSzggdrrg1ZSmjHkrglT/wI4JpIa2xuHVQ7i8veiQ5sxDerGvyEsjRQ8aznN5QM2S81zCF+fq ciaLejA/vAVBORNuJgHuz/VGV030YzwkwJFNT X-Gm-Gg: ASbGncspnS64k9SQZBQi5yyR9DOUMopriSeN6p4oLi1WdYxdWjh4SuTW+3uMOrkxIWe ke6ekWFr+fJ+KLZOyLhgKx/Zt4BcMu2mWphONQASM2GwoupHMb23SDglIsFTDe/oCGaCUMcyTJp RVXlDexMhaO+W7HvQIsyPwfCi8uA== X-Google-Smtp-Source: AGHT+IEeMvDTzY/03dvwAU4Yl2RIOwMLjBmew1d3LH3owD/yOENufGbubw5j2/f4efwWgAcJ/EqJ0vGrCTbJSOjwLbY= X-Received: by 2002:a05:600c:5252:b0:431:44f6:566f with SMTP id 5b1f17b1804b1-438dc3ca9cfmr216084175e9.13.1738673205184; Tue, 04 Feb 2025 04:46:45 -0800 (PST) MIME-Version: 1.0 References: <20250203-vma-v13-0-2b998268a396@google.com> <20250203-vma-v13-2-2b998268a396@google.com> In-Reply-To: From: Alice Ryhl Date: Tue, 4 Feb 2025 13:46:33 +0100 X-Gm-Features: AWEUYZk27IDYj4WV-KphnBAyzxUYJ_cTBIi6I5kvdkOoZNqc2m-BHRJ-993o8q0 Message-ID: Subject: Re: [PATCH v13 2/8] mm: rust: add vm_area_struct methods that require read access To: "Liam R. Howlett" , Alice Ryhl , Miguel Ojeda , Matthew Wilcox , Lorenzo Stoakes , Vlastimil Babka , John Hubbard , Andrew Morton , Greg Kroah-Hartman , Arnd Bergmann , Jann Horn , Suren Baghdasaryan , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , linux-kernel@vger.kernel.org, linux-mm@kvack.org, rust-for-linux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 99528A000D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: wgggfbopni3u5crdq6xqdz47rjrsz8nc X-HE-Tag: 1738673206-570741 X-HE-Meta: U2FsdGVkX18TDu2M2yXAR2iw6hbpoMWn8Pz0zhgmZMVXN7kKzGLqdHI2G6Xco0W2q/nMRJceejggSfGmqvn8bfkVmLnyVZUWztPITsk0yOPxXMUu2XY3t2t/50khQD0WKm1XQAjqNuQC1NVNqp1DTRxMwQFyjthCm2Fhr42OnJcsxrq85Bt/Sf28lvBxiR1a4AVhLz5t9DSifS6fB+rCFjka3IUQIAs/QCa2bejylVLaLKObxTgMbdaDoJlyOZ2eL3a14+pvp3Fy4EI8IEfCg0WqGPUt832qw/QKdAVcGD8nosPLScH+qVRpCK3Ki/hAbAlDb6toSMeBhpvaFo8n2AwfucBCNrqRtl6I2prm7nwrHqxX58U58jrqhVbQuF45+0bHW5zUsEI81lovvhTd5ew42PvDIHUfQu3tJ54h26iO4cvFNj8CIeo8cOuDSEhcTfdt3cedb7trCexUrr644w54+3OuZ/7XCg7TION+fKhzy/0RpFwEREaNpuBVxcGpnh+tm+wFl884nzdNK9ooS0TEh7mYdyqRK2PIpTWUw/2sN/1KFimKJYsBlSFvu2kCVcTnKyowf3lIRQJU+VykOaFmqsEH6v0MsjTv4CdW+CoacRxH+z5pHL3ny2b16OR2pmCz2vEnXKzjp4zRn8vG9KW3cBykG3zJj/vAa4GSlezj1oLrLHJnwZ6Useb3P/n6/7kklW1nD90PNBHqLP4NRl0S5LtihaXMGAtLh5U5WoaPClpADQlA71Hz4NwWOPNuVWnNXkBsQIw0+99qJYhRQ8Zug15HxblIamT5sYF4G/Ymgv94Yx/wKFj5ga+WcG868TG44+njtR9/lDHbEZ/dQnNmbjO5J3t/ZpZzce4rddxKHHkohnH3MGOApjrcVLSUJifkdED407/SVecu+vCnRoig70phHXUN8TtUhDfXpsh73fNHV6+oSxRPcbSpBmQr21M0xZ0+Gnc1ilaV2Vp o3TqpvoI VQaSqJhOW3ejsfJVBlyqMIIQ27vb0WAy362VYd3w027bPveKiG4oS90mw8V+B1ih/nmd98nIMbVMz9jEIRAsF1pDOr9/2+nyyiD7szLrIldLxaLtN0JWWr2uSfx0GRN7euH2/F5G9jAqqTZLkDXgGjDfpr9J8ehAuaPnde1bxsynA9Allxh0hzrjTgzM6RRmKjNmuN/KO5zRGhV399R00G0kt5dmfHZtP+pngBdX31g5Qc83EjkjZqk4qiWuxVw97AvU/k9G0nqi17ROEZlxIXPEsKqsa0vGeZ3+W7OK8Lr9wFlysgvioTeZ1Y9vsCNqO0A6AfJTUKBITV/d3QdxOMnb8jykSajzYLekYpkbuCWAdorU= X-Bogosity: Unsure, tests=bogofilter, spamicity=0.500000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 3, 2025 at 4:44=E2=80=AFPM Liam R. Howlett wrote: > > * Alice Ryhl [250203 07:15]: > > Hi Alice, > > These comments are probably for my education. I'm holding back my > training on naming and trying to reconcile the snake-case and upper case > camel of the rust language. > > > This adds a type called VmAreaRef which is used when referencing a vma > > How did you land on VmAreaRef? Why not VmaRef? We mostly use vma for > vmas today, not vm_area. Is it because the header declares it > vm_area_struct? I'd be happier with VmaRef, but I'm guessing this is a > direct translation from vm_area_struct? Sorry missed this on my first pass. Yes, it follows the C name. Happy to rename to VmaRef. Alice