From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E918BC02184 for ; Tue, 14 Jan 2025 09:50:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76BF16B0089; Tue, 14 Jan 2025 04:50:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F5116B008A; Tue, 14 Jan 2025 04:50:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5963D6B008C; Tue, 14 Jan 2025 04:50:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 37B5F6B0089 for ; Tue, 14 Jan 2025 04:50:19 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C90ED120860 for ; Tue, 14 Jan 2025 09:50:18 +0000 (UTC) X-FDA: 83005586916.07.5D27B80 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by imf13.hostedemail.com (Postfix) with ESMTP id DBDB320005 for ; Tue, 14 Jan 2025 09:50:16 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="oB4/PTO4"; spf=pass (imf13.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736848217; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KTwukl8uOiX4y5FD75Tj1+wGTsO1S/cvv2mZ6R8n1/c=; b=DTdWCdDqYR1aBHe+APlSxV7A3kz9dwhlnDyl+J/XvzDjhfrkaEDBwMjNw0B16LTC0JTFTM Mla90hYulDB7jcdavivDT0D/AmHwynF6u3103SBjBkMBWUd4dgoXqrZl6cimszIT/8lZjC KuJxut8vggX8nxaNtraqmE/yr2+qFUs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736848217; a=rsa-sha256; cv=none; b=zrdAKbDY4vBCWLfQpUlgeZnmFDrzdJMxW9V9Y+yfZGRQAyKP/fzVJU5OW9NaFiWvFF1JBW 7vM0fESx0h3s+zdzdGdpdqqiLrxqs7PzpWsB72/Ezpttyx+7letFvMGRd5JMpxYBFL5Ofo qBZJdn5/TmdBNY+DmW4AtUiArFcmgrw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="oB4/PTO4"; spf=pass (imf13.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-38789e5b6a7so2852892f8f.1 for ; Tue, 14 Jan 2025 01:50:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736848215; x=1737453015; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KTwukl8uOiX4y5FD75Tj1+wGTsO1S/cvv2mZ6R8n1/c=; b=oB4/PTO4Ugr4SWyA1ddUeLS7FTNAOjgqo1oVlK/GabJHW+IWpBReQf67CXvRD7QiDQ C0DQ/DioyWh5FsVY116Rf2X0wZBgy3+ewADxi4j5BfaqQOTWunVCI47oL1SWMyDkINJ0 9BTsyMC9q6Xlv/HhCyqOOZlgDuHEZAvlHD4+hPqNxLsINkIgI1YWM/aeu1aqeOL574Ci 7Ab5QY6E3/097brsFwv4mPXsz4JulYe6t0GrXBWTOermrQAn1pTCjVwRIHkoMD42ciXV 2hKc4Qp2+Bs2wwfMPvzOqr6KhtOx/qwTMfmpSnXE64yxDuTf1a1rHL2DDD5sZdn/cbOm CTGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736848215; x=1737453015; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KTwukl8uOiX4y5FD75Tj1+wGTsO1S/cvv2mZ6R8n1/c=; b=kNMsxQAi5e2n5BlVA20jvqaeL5ol5QL/3KX9PhuDRklH2GB0bEikYLjZUUGUOoUul7 i944os44/dlvHKq3Dp6OqzWHeQYU6FyxpLrB137nZppZlC00GRFmUDxfC8YKntsqRolu SiA5OTZk0EcAdu6wJ2enTFBz4uHzz1cA42/sBQ5bv6ZSR6MU4eOpFSQ6YOsPrSVgqoVl mc0VcLPXpELzRyggjHKwQkYMgRQNka4Pq1HoaDr7EOB4UpvjuQLYuzpCElA68HtW3HVZ lObP5vVJPvuJhweim6jPDV32/9DBqE97N5pewqMNkev4r/M7FuqU/E4lyrIQFuP+Q22y f8QA== X-Forwarded-Encrypted: i=1; AJvYcCXsjPXkGd+Q1gtsmyn3v5tz0qRhUiP5Vc1YjWkU6gMlzCnXzMddFkEN5YwZM/yQGQZ1jrZpb8d4QA==@kvack.org X-Gm-Message-State: AOJu0YzCqeXV8v79l0h/g+KFqcXBOoBC1mvBJPD8Unj0N3C3XFtewtJN UCjPoQBBE+LOH3JyQrBQgE++GTXHQI6nH3u6kFKDC4yFjMx9Qp96OLtRdJoDIcofoadfQNP9/Wy 4mNzR6eTdPdeea+qBKRwGoyLqGZmNuIjlVuzO X-Gm-Gg: ASbGncuqBx3voQ37cS/cCRD0+QVUMM/KF3r4nPalVwHSTsnfdPsMj8wuyjlNJjPpsi1 4t9EUqSoZishLca95keu269wM16sXaXWJ+xbrBudlZscGY+dveetsPdb73sfCi9cyUFxN X-Google-Smtp-Source: AGHT+IGKzl5z5Ha3pO1yRtNB3GUeQr+rw3Ekmo6cq91+iIv18Us3DjGDX/jVaDV82Hu1TqkdZrRFwHqkHA0xgmPfkxY= X-Received: by 2002:a05:6000:156a:b0:38b:e26d:ea0b with SMTP id ffacd0b85a97d-38be26dea6dmr1638433f8f.25.1736848213829; Tue, 14 Jan 2025 01:50:13 -0800 (PST) MIME-Version: 1.0 References: <874j33ddxt.fsf@kernel.org> <51PsGz5tctBZlyC7TWAGRwZbM13r71BM1gtm1Y8F4j2w3FtKSXtkVrsvwILAqvSBPrFJzahyUVDum-JXO3yZUw==@protonmail.internalid> <87frlsbekc.fsf@kernel.org> <18bc911a-ede5-410b-9955-5382bcef975c@lucifer.local> <87msg09uzu.fsf@kernel.org> <8b803030-0ca3-4591-b2f3-bb9bcc2aca21@lucifer.local> <871pxcgg02.fsf@kernel.org> In-Reply-To: From: Alice Ryhl Date: Tue, 14 Jan 2025 10:50:01 +0100 X-Gm-Features: AbW1kvZk9d573jFK8FkPwpKd3ZWRv8D3huYFVncUO-UnxuorvJMOstGtGDK6cu4 Message-ID: Subject: Re: [PATCH v11 2/8] mm: rust: add vm_area_struct methods that require read access To: Lorenzo Stoakes Cc: Andreas Hindborg , Miguel Ojeda , Matthew Wilcox , Vlastimil Babka , John Hubbard , "Liam R. Howlett" , Andrew Morton , Greg Kroah-Hartman , Arnd Bergmann , Christian Brauner , Jann Horn , Suren Baghdasaryan , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Trevor Gross , linux-kernel@vger.kernel.org, linux-mm@kvack.org, rust-for-linux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: DBDB320005 X-Stat-Signature: j5r7s6meg4yjb3t3xzibwro7ik3ssiug X-Rspam-User: X-HE-Tag: 1736848216-278041 X-HE-Meta: U2FsdGVkX18lyj+YWWXMP3PO2Ri2xkdgt6fpcCnUBxMaQzKbyCbqH5CsBzU9rPU2VaFnC84LU5fq+6Mq7YFyfhenqGShocxx8W88lphq5Y3K3WD7aa8NTZ/d5SzDFtFerThvoFqMCevfSXODSCq6qaJZ8+WrATUJq2HEA5IEyP43jONIYuoZMhq32M7fxjsP4Kh+BqRhISEovFk4tTHIBeU4TlsqDyNOw27LFu1vzlDkgr+B7mjUbGvFpcZU7drRGsGXlNq39/gscMsFgzpQZphC0BNUwfX+3rWq+v/58PA/tTaHsGA0aJVbmtVf6by2aKNrI94d1PYJHijidn41WPMyiI8VKYk57H7ttIWC4ltaiSw8TVgaiWdrWGjRT6Jy3RKxpxheBjqqzo2Z+OtQ6D+gJNGEeRoyOJO3P2nFaDHrMxGoE/v8Q9h+rWikcZdbiiRBcPb4VrkC5L6Ow4UfFpppZafIwewcoVkBkJGXSXYz5X8BKCsVNBK+69i3K4neXQNHVfihpGtjXzRb3gNahSozk8A3f5kDYYxg+kRjJd7zqzrFUH9PyezkXMd3Lp9SqBxqnZJvmfbB6AYpEijrN0UMj/R7ZWk39sc/xDQCSiX6JgYfNOXcZSWCTRSZV9c+x3VO6gwXu84syewk9NjzSmk+hPVevRS4zuIINn9epBCxfiL1BRVXPzlEQg8yFM8iH99plWJykTnR4kENGAsMpscz7duX21CWbf6KykVHkFxTSWZBnn8lrVJxP5Jvly0ivCdpoL6U5pTOa9rBRYXsWNOklUufiFy6HV05Q/ieBWJfGIxm0fP9b/g4UBO9SEBTAPfws3NiC2uVwSBPbxc08a7VLmXHDP7a7iHjH9mVYiX8KKfu5wK3q16JmgflMpW/FD8EahWNG/4V1F46RsgCb855eb6vItNZt6lWKczBiLg8MCz1kPFZVrKLIKsBwe7MXOhBpWk0q9YQhGearb9 Cm4GZl5L 3IB4oU7ZlM7ORHJFoGRD9WnPEvX6WI/uAhLxi6p+2JQwQDU8jCOnCFQMMqy4hVC9U/4L6eZA60mq/TiSJHaNW8KljAGWjPgpcsJdgq4zfNr1/b8lQ7SfH6bfxb3tOGAfxUmOpdr2KCCpsyJvf7TBXvIHRZgw5+gTxmt0v0X/gvaHftjbW3owVoVJz81/oRK/iOff8PAd/aNRJDIUkzfEy+TfGpdtzdvXEttKCVFeH5rl/rY87wPK3mp4TfqJ6aNgl4LvhJqU/uz9yvbGNsh1l3I/I/mS0i+qqgOYSdUtmn+qOpmOE5+y5Xz39X5y5AQxs1r5c+NG/4HefJR5SMg7kf0tZ6A== X-Bogosity: Unsure, tests=bogofilter, spamicity=0.498969, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 13, 2025 at 3:45=E2=80=AFPM Lorenzo Stoakes wrote: > > >> > For a series at v11 where there is broad agreement with maintainer= s within > > >> > the subsystem which it wraps, perhaps the priority should be to tr= y to have > > >> > the series merged unless there is significant technical objection = from the > > >> > rust side? > > >> > > > >> >> > > >> >> How about this: > > >> >> > > >> >> This clears the virtual memory map for the range given by `start`= and > > >> >> `size`, dropping refcounts to memory held by the mappings in this= range. That > > >> >> is, anonymous memory is completely freed, file-backed memory has = its > > >> >> reference count on page cache folio's dropped, any dirty data wil= l still > > >> >> be written back to disk as usual. > > >> > > > >> > Sorry I object to this, 'clears the virtual memory map' is really > > >> > vague. What is already there is better. > > >> > > >> Would you like the proposed paragraph if we replaced "virtual memory > > >> map" with "page table mappings", or do you object to the entirety of= the > > >> new suggestion? > > > > > > I object to the suggestion in general. The description is fine as it = is. > > > > Ok. I'm raising a flag because I had more questions after reading the > > docstring than before. > > Sure and so I think this is valuable information, and indicates it's > probably worthwhile adding a little extra information on mentioning page > tables. Sorry, I'm a bit lost. What would you like me to add? Perhaps there's an existing file in Documentation/ that I can link to? Alice