From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EA97C54798 for ; Tue, 27 Feb 2024 15:57:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5030280023; Tue, 27 Feb 2024 10:57:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B00AB28001D; Tue, 27 Feb 2024 10:57:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 979A7280023; Tue, 27 Feb 2024 10:57:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 82E3828001D for ; Tue, 27 Feb 2024 10:57:05 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 55BDEA0C3F for ; Tue, 27 Feb 2024 15:57:05 +0000 (UTC) X-FDA: 81838037610.10.4E401F3 Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) by imf19.hostedemail.com (Postfix) with ESMTP id BCB341A0006 for ; Tue, 27 Feb 2024 15:57:03 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=CaWduTqo; spf=pass (imf19.hostedemail.com: domain of aliceryhl@google.com designates 209.85.217.47 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709049423; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zz63I5jGJam9ziTsehsBfrmLZXVDff45p8Sdh7Rb40k=; b=nK7GFvn4reRPXfsgMI3r2HwkxEJ4U872/NUfKIHfHTh1ImI030u9u40ZFvuvJhgqmWIOvA f61AhkJrD3zcr8qaoDnR5d6rvQGB5ZO5dS/BmRdviywvL9UgSYz1yB5fh0smC0ZSFhYlyu wuCMtPcaiJN1eEbjDGYzYFQphp0XArI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709049423; a=rsa-sha256; cv=none; b=l3v+OCsfOlM2txzOUggF2MygCyIQbhDW7tIHM/WifjehNVRM2MeKgkAAQdC2U/jURkH94Z iSSLstRmN0BT4pkn73I+693jGndJObDK1M+JKdd6aauqw3mme87peua7Y7DC3efCrpZYNF sXu/Q9Pj1aJWZkChpy3imrGVVal9JCU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=CaWduTqo; spf=pass (imf19.hostedemail.com: domain of aliceryhl@google.com designates 209.85.217.47 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-vs1-f47.google.com with SMTP id ada2fe7eead31-4704500d320so536111137.1 for ; Tue, 27 Feb 2024 07:57:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709049423; x=1709654223; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Zz63I5jGJam9ziTsehsBfrmLZXVDff45p8Sdh7Rb40k=; b=CaWduTqo6GeHOrBLervCQo2eNeMYxE0jysQxoOHfWWZiqKw8cZuG7vE3naTHuXxfhH P+gj4nB7VYJl41G0tcaf3bFc/rTpo+s1Rp+B/yW+I6kGTxkIazb55fz0gB46E8RPG+JM W5w0T3YFyjlUsXMAt0oOcVVHYePK7iMtdsiY65PsYen4bvA4u5ov9ug+G261Vc1kKOGn oQus7RYeOpYTeE+Tmz4nGdmdDnhug2OxWPJesaqiVUI9LiaJZTnqcuqdwxrSgFMdU7HE /i1sjgG+D8DQwaEV265MLgdIUbPyi9ZCONKPgWD+Au+OKU5DsBQVFbWMNcanlrrFZFif iXqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709049423; x=1709654223; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zz63I5jGJam9ziTsehsBfrmLZXVDff45p8Sdh7Rb40k=; b=XOCmOqRPddFEpFV3Rm8U1WD13Gg30Yzd81SxmPvecanmzphTKjhAo+El+k4HgYR+sY mr7Sctr0tsreO8cfDKu+xDgVVnRQox8a2iuUiSYqx6U0QJXcg4ZV7M2jjnv/wF/Os368 VDGkFb7GjL3Nm2mijM+wN84f65IDRGnwjlpxtyXZwmV7QexIdyDw2MChnhErBV8UVjmP 5deODYIHfhuOKeN2sYTdU6hkCCBN9JXKHiLKSMnl2h6osadVxoHWemDonv3vycRVAsyo idVdZw5Ju4N9CbMCP+epyCm0wLlQGn6s2bf1nrbOewIoMqKOjQ1Xz1g0Z/GzxxVIn05L 6XXw== X-Forwarded-Encrypted: i=1; AJvYcCX/ZspLBUmw3SVf+5h6TppdnVUogF+Y405BE09VNAyIctHzX6trnLIdu8kHS+gSYH7T3ucD1k+b36GjLiHTyY10X3g= X-Gm-Message-State: AOJu0YxM9tCPBata0kvQZtZIqABJZ71wBQr5hhkpFP0rrM4PDoWzTs9q yfqJm8BGN3WO0db+8zPviClBbKeXwoa7DLYA1fREHNZJeRlPkfZ9VeTaH6kL534JsF0E/nQPRqo 3l/4ET0e3vlApaN3Agq0K8qTwzkjePn2MCy8e X-Google-Smtp-Source: AGHT+IGb864B0KCLFtT9j0TGLsO0nGGyrgue73owoa/PB+tubylZra+Dcxo08UFSc/HUH0+ETPHEEz5iBt94o4W0Cnk= X-Received: by 2002:a05:6102:f12:b0:470:3eff:e755 with SMTP id v18-20020a0561020f1200b004703effe755mr9887738vss.24.1709049422611; Tue, 27 Feb 2024 07:57:02 -0800 (PST) MIME-Version: 1.0 References: <20240208-alice-mm-v2-0-d821250204a6@google.com> <20240208-alice-mm-v2-4-d821250204a6@google.com> In-Reply-To: From: Alice Ryhl Date: Tue, 27 Feb 2024 16:56:51 +0100 Message-ID: Subject: Re: [PATCH v2 4/4] rust: add abstraction for `struct page` To: Matthew Wilcox Cc: Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Kees Cook , Al Viro , Andrew Morton , Greg Kroah-Hartman , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Christian Brauner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: BCB341A0006 X-Rspam-User: X-Stat-Signature: exxqjj48a14abqauzki4mhzg5ifkh8pc X-Rspamd-Server: rspam03 X-HE-Tag: 1709049423-988066 X-HE-Meta: U2FsdGVkX18HDrAYt7jf6NUAvHN2i1eDHBbOOx8rjkdgyocqik1WCiVfs8g/rnjyg5nCkTD8ph/wJ4rNKBYXasB6bAB1t9AIDf6hURtEAd39R0DTXgL8kfD85SawloxDAA/XKb9UjbzQtfvZT5uEQKjoEoJXolp9OVu8ZpAnDbWH2cIqlFCZn4wHQkXxaumOTO18MtwE9cB0nG6L34mXmzMCRaK5qWLPzNmeeskBKsnYTcOfnAjh3VKuvhlK7Tq5nThZVcujQPtmkaCeN+toZPrUHb7sj5hHNV603z1C2QrFKULVlLWzjZ6HNp8tSYTQgrQOUwQbOWYAih6mV6bGJj9gV8SNXRT7Kz8cuIpdqA3n7x4d1cOMWGzljHmwsZmanUTNfXFswr7jBL3OP0EoEAvRsnizCpVjCLY+b2DUm1Z/ao9ghFd/WCIAdywMnVoDKqMuhaVC4HqV3mQjj6liKpqKZ7HZdlpoQq5pfgod/VMHAC6eCN3ZMzG7Q7gOCODfUKy+O38VrW9BOvDvnGFfkHWW9P3eBKkYxdnVINZm9wAML6rr2Tf1I928P5oUtGwHvpK4liJX4UIS6qZCdlv4wUr2dMK1KYwTpZwikl+sy9SRWPwOOHEGw8g9KPn5EDTGX6eNUD1LtNU5YDZXmbgTOHmAixtKmvHY1Aa5lK09Ux0LFgwlNXUrQDYpgrd2kY8C/UPEzLxkXxmJ/q2XKj2MJMvw+xqpI3aR3V3vUsQafJE+6JD5RFv8JqEkwOmpbTIWOGl/joZePz1eYcmjv7YCNXK2J7lgprL8Q9NTE1LFWINZCoO7kbkrXu8oAFT4dq1xdYHMYkrBZBYKtLz8Ir419nR3towx1bkM2PgI1aolAT9hj+K72fDZrFsF6u7lPEl5MQixnz0+qrBtT7SbOQG8VG3vr/wpKXrdbO5oLI9ur0tPimvgrKA0hG0Q9+8VK4qTPRC83RECRf4qtAAf+Hy GJZZpRrV dfrln9sZJysEkRH9+XDSEJ5AdFEjKB6xxh1gTOeYBXHCg4OI4UstTeYve79sY4Ch+FrX9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 27, 2024 at 4:37=E2=80=AFPM Matthew Wilcox wrote: > > On Thu, Feb 08, 2024 at 03:47:54PM +0000, Alice Ryhl wrote: > > +impl Page { > > + /// Allocates a new page. > > + pub fn new() -> Result { > > + // SAFETY: These are the correct arguments to allocate a singl= e page. > > + let page =3D unsafe { > > + bindings::alloc_pages( > > + bindings::GFP_KERNEL | bindings::__GFP_ZERO | bindings= ::__GFP_HIGHMEM, > > I thought I raised this last time, but this is over-specialised for > Binder's purposes. Many places that want to allocate a page want > different GFP flags from this; they shouldn't even be the default flags. > So either what you're defining here is a BinderPage, or new() needs > to take GFP flags. Ah, yeah, sorry. I never got around to figuring that out. I can change it to take GFP flags. Thank you for taking another look! Alice