From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A7B3C02192 for ; Mon, 3 Feb 2025 18:17:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3AF5280002; Mon, 3 Feb 2025 13:17:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EEB1F280001; Mon, 3 Feb 2025 13:17:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD89E280002; Mon, 3 Feb 2025 13:17:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BE734280001 for ; Mon, 3 Feb 2025 13:17:29 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 71635160351 for ; Mon, 3 Feb 2025 18:17:29 +0000 (UTC) X-FDA: 83079441018.02.644710B Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by imf25.hostedemail.com (Postfix) with ESMTP id 60A3EA000E for ; Mon, 3 Feb 2025 18:17:27 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=x5+wtnB7; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of aliceryhl@google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=aliceryhl@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738606647; a=rsa-sha256; cv=none; b=H6MMKAAbyb9czzNM52MnULLXG4OP8n14pN1z+vddr26WIpxpvm9uzynDh5bEmaD5mqIyIP 5qgC7W5o6VE2ssXTvsy+Oe+/qq0qay3qgyTqlmoouW8GO6sCbuyAMZUPnGv3KSLfSwXURA Tx39JvIsLmveNWKfLMNE0n6YUOXLH6A= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=x5+wtnB7; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of aliceryhl@google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=aliceryhl@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738606647; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VDkxzxcu7O1vOggBOzC4wE/NAP+zsMC3Yt4mKkAp2BM=; b=bACEmo4ZYFYyY3ig//rnphdA6UUymiokPll19DdLGg/fFUA/gPZ6Wmcu98SncP9U+0u1aA HiLfYIyGiMB4jD+YJT49uc3pYeBhRNA2/vUwRv4UnNKncm08l+50uo8PgkBKfyxriJTMQ1 jDi8tc7lUnPUuht8iiRRGknSJOWh4nc= Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-436345cc17bso35354285e9.0 for ; Mon, 03 Feb 2025 10:17:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738606646; x=1739211446; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VDkxzxcu7O1vOggBOzC4wE/NAP+zsMC3Yt4mKkAp2BM=; b=x5+wtnB7rOJcemQ5cHjhmpUdXAqn6akKa8wMwb6b0MkFB5dGMFy6hhRbJ9RhymK6gt fHPQgTSkHvByUnjZZVDcM7BbOxqFI82ygAcnm5Yep/5gN+kiDAUCw5WQqKs4a6qryAcO jWzEBonkOtFPh5wnsU8AJcG35adMmyAaApYKUDSNmaOrfM09+8Gc2I1XZxqjPBsNaOqq LWm0WK2nhJ+MPhkDfrUqMf3FwmPaLThDaKhR9/zh2Q1tM+HHhmRDjFcxqNGqsn3sISLW ntNW2ZtztxZYa+Btl7bhOTAp7T/qo2TS2iipEjhDJiRDCfEJBmTRbJHr095AOJsmIQaK hMtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738606646; x=1739211446; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VDkxzxcu7O1vOggBOzC4wE/NAP+zsMC3Yt4mKkAp2BM=; b=GAaOBSpaCijoRJK8pnt6dCq+q97avbC1Ey37tAtJDlNiwbUAfV8Ow75koC0KqciZDW A5tVWgjmmiEEZm+x1eWaeoGQEy96Eyek/LCs3wcdaPPZ+ogIo+XpmOfPexWtWUUbTXQ5 Ix9hV17apH07EMQYaHVJSZdRfC8NgFT2CImaDXdzKI5omkE8odd/8TsLzcMXcR9yGkvf DN1SppvU8ZVbjrOnDINbzvd5bHTdD9IOKPAnQvctFXAylRf6MWg0TBEZLYhZJcayoeyL wUDBcPOsflIiQUyFWTzmoUzKSyz1SiJgiE0/rb2iLP4cDcL2RlwRiu1wk3xvGOkKQgu6 nClw== X-Forwarded-Encrypted: i=1; AJvYcCUjm0EoihIDhlAQX7TabnNK6BDCIx6gZB4PdQgAFZhwYzFydgpeUbwKVQp5uZ0f1mgRbYKI/iEqow==@kvack.org X-Gm-Message-State: AOJu0YwQcpX0JhSsLEutNz0bknJ8VKoek2MXbP+HbWkev2XYonQs2gFG 8jc6U1+dds0EofDuBg5P/FomlAmBDNNF1LS2WlcutHo+jMC69cxw0yr+VRdlFpyOhrYMHbTVA/e UMiRTnl71hHAF4/H7IMdNC/ugovNMpMyJaJQ4 X-Gm-Gg: ASbGnctRF84/+kYEl/t0F4LC1ueCmX+5k6FzqWZdsE9AYqqFBepJBb86uVNIy8noRkN MrP4ogX1v9l7j6Zek9DtfrArysyQDxZXwLHx3epGTyShkRL4TPxdkMa/jO75FwtSZd5z6cB+yRQ == X-Google-Smtp-Source: AGHT+IFjiAANHpU4lYhLwjIj1aIzAMCx+jP5Z2qXe2xs3JQXXbYoy6fxWH9MRWQ5Z6+cy+ed9B9IBPZfiojUyR3Yru8= X-Received: by 2002:a05:6000:2c5:b0:385:e013:39ec with SMTP id ffacd0b85a97d-38c51930b44mr17922172f8f.8.1738606645674; Mon, 03 Feb 2025 10:17:25 -0800 (PST) MIME-Version: 1.0 References: <20250202-rust-page-v1-0-e3170d7fe55e@asahilina.net> <20250202-rust-page-v1-1-e3170d7fe55e@asahilina.net> In-Reply-To: From: Alice Ryhl Date: Mon, 3 Feb 2025 19:17:13 +0100 X-Gm-Features: AWEUYZmdD1lRFN2B0MxC6_5nwF3LFE7h8SGB6KozvokrQeCQEKJgmX-DPDC9T_s Message-ID: Subject: Re: [PATCH 1/6] rust: types: Add Ownable/Owned types To: Asahi Lina Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , Jann Horn , Matthew Wilcox , Paolo Bonzini , Danilo Krummrich , Wedson Almeida Filho , Valentin Obst , Andrew Morton , linux-mm@kvack.org, airlied@redhat.com, Abdiel Janulgue , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 60A3EA000E X-Stat-Signature: ra1rwr3c5mp4sixbdh6e8ub7fdashzo1 X-HE-Tag: 1738606647-162227 X-HE-Meta: U2FsdGVkX18RofffX/1pSXbbYFp894Q+/VVy8BW/TB8CHxhnEu0C8/etHcrQEbCJkppXTipd3yqdzmywcLVWe7vSDSD3PV/aQzQvkxnyW2hWH109FSYF+l1Q8lKJEF0QGCQqPChW3pTrQLKIxWJJCqEDp4RB60QNE6qA7ZNV/rjLrw7fFgL18tS9up+PMIvrXZ2qhgyDcKpclWV7j6+8OOji3OZCrnFB5uw+WfZf57dYfZj6chAUV85kRP2/qGWAPOHwUHazzrG7WHezixBFlt3XU83zpjO5/XkFRhFFjqK+w2hZnPJjx9v3C74HBWafrwzxPi/fvIqSgxP6Lj349UgZu/WEq9jiFR9y7uQRKZcsTvH2FJ++9EogJLft3LOAV2NRq4kKzYQPFujTa/AmDOd5Eoy4+KF1cTRgapMtnXIGmNl42mBunWUlwtNrqrjsan/MgkRr3ry9+E7jHYPHP+87pP+zyKDeYtCJQfehhEQ+TXNRJlgue5tHw48noVYyT8zOElxqNqgZMaltPOzQMG2pY8Bejr5zYW1wg0COtdecY5/OlJKVVxv23n7KwIyvOb4cYUCbyUjYtF1VmqcH4g/kBOp2ePQr5QgyLVTyH2WkOsrhJt+F9QkJMvlkx2BbVbJFcokEtVx6kxWTwfyxl14vsfAuGDMNKyTHKBURxaXcnAMxhK6z5Qrt+P49coYE70ymXRoAPlxeyfDc0fE31jMZciydqBQFKK69S2RzmwVrFJYae2ptgpKEjFSsaf3gGKP+TkpYVzM+Bsr3bMoLhjNhJrIlHAjbCanPY1vupau8e+FfA3nKn3qYo9mDkXk7XbVbROrRosKB0kulmA5uoF4DbS+Xm2RZ0xM1jVqX460x2SR49ZUF9vgAMDBejsOIwaLIz/TRf/0YUWlOHsosNAhhZyExbgk9aQurz90ayw+K6vDyaoXXQXelJv2fYaIJvhuTEO4IhrxVSzXP6HF 9iM83sKi xFJz+Szc8GT+59/UhPoDZVF+iXlOx1ZIkJP+A0yQzZ58OlsbL3obgSQmW8cFamVgmETKFxId/jqI8KZUy5qacaz+oC6cTv30FZk0Pf3O7ThELc4L9ZqpSwwerC/TrhyDAebLMkvA8P8IRzynRvrVk1M4TorckiYvLAS7wYlkABIk/ItsSIcyLC1aTT8zudQLKQ4GHvSu9yjzVvgHG7iRSG+KOs4ABoTgzzdCfgRrSaaeT5dbgtgEoNq2FfMiCb3edYKrE5VOktUnmvPDPcAagD/BNRVwr9Qmj5sld5wkSCCM1iZHE+58d9FAiR8qTfrkJi0wwiQKa3Owwk4o= X-Bogosity: Unsure, tests=bogofilter, spamicity=0.500000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 3, 2025 at 3:17=E2=80=AFPM Asahi Lina wrot= e: > > > > On 2/3/25 6:13 PM, Alice Ryhl wrote: > > On Sun, Feb 2, 2025 at 2:06=E2=80=AFPM Asahi Lina = wrote: > >> + /// Consumes the `Owned`, returning a raw pointer. > >> + /// > >> + /// This function does not actually relinquish ownership of the o= bject. > >> + /// After calling this function, the caller is responsible for ow= nership previously managed > >> + /// by the `Owned`. > >> + #[allow(dead_code)] > >> + pub(crate) fn into_raw(me: Self) -> NonNull { > > > > I would just make these methods public, like the ARef ones. Then you > > can drop the #[allow(dead_code)] annotation. > > Does it make sense to ever have drivers doing this? I feel like these > methods should be limited to the kernel crate. Not having drivers use this is the ideal, but I don't think we should always expect it to be possible. The Binder driver has a C component for the binderfs component, and it also has some code that's essentially an abstraction inside the driver that I was asked to move into Binder because it's so specific to Binder that it's not useful for anyone else. Alice