From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0FF4D637CE for ; Fri, 15 Nov 2024 14:01:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FC1B6B009D; Fri, 15 Nov 2024 09:01:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AB796B009F; Fri, 15 Nov 2024 09:01:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 173736B00A0; Fri, 15 Nov 2024 09:01:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EE1336B009D for ; Fri, 15 Nov 2024 09:01:01 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 82496C16A0 for ; Fri, 15 Nov 2024 14:01:01 +0000 (UTC) X-FDA: 82788489336.23.0F40A5D Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by imf06.hostedemail.com (Postfix) with ESMTP id 55638180017 for ; Fri, 15 Nov 2024 14:00:27 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=v2jFYsrR; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=aliceryhl@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731679080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VfVHZrGd4tsTjMi2xv8h9FRmG7Ah4ZiFj6Wn70prO8I=; b=hMNBJWw9WQX3VZ2vplY025MoERdGX4+ZCPEqlGkEa44MPDZ3qzysYn/8FAbD6oCwoN0hHt JXMc1Kd+mFuth0TfIbX2a9NlDfsHWhrqQ8LsdVEjwSlhuVBDJ/MT6/q7my+oOgoa4S2riZ weisQmYfD/Pr0p8YCniNvvBPId6PbrA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=v2jFYsrR; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=aliceryhl@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731679080; a=rsa-sha256; cv=none; b=3+Q/g5LLpdqmp0RyI8GbHPywnjfd+dtrx4ZvEvSKQvjnx/0V3iW5XA0xuxE2p7k5FgI+0N HOYYeAU+MCqoXD6kCc/+/hAuY79dopHIjegJHTrnFK6iqI7WJNwHLtbRYq6cQJzuZZiuYr Em/JzUy63+rbsLyHapnxRfxFT6Y+QLg= Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3822b77da55so236551f8f.1 for ; Fri, 15 Nov 2024 06:00:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1731679258; x=1732284058; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VfVHZrGd4tsTjMi2xv8h9FRmG7Ah4ZiFj6Wn70prO8I=; b=v2jFYsrRq/NxzPvtvtwiBiTOWnc06ZKBqk5jDsv2K+2O6vKUT01C7SA7pZqqd5WhMU s6EARBxcLTYPmwA8mZSy1k8AMYGIIbwQievKJXKQdOzE59l9NPqfpzcyRmMesJvKOdoC LTIyP/Gr59EB0gxexFdfmTPmsGMkWEt9vaN3tT3t7fc9qd7vrV/5Y7i7iUKbKzpb4l6K Ws++vGEt4TQGRHEws7iDzcxopxbdEcwtSCUUDfcnDbojiHw0GEXbnsW0NXg+m+JDizOG OslupcUtlnZpJ5w/aR5SLfN5yQbK7tnIQsJOciWDb+uwmU3PGXwFCqyAo7meFtCrYUdP vwbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731679258; x=1732284058; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VfVHZrGd4tsTjMi2xv8h9FRmG7Ah4ZiFj6Wn70prO8I=; b=RmZOiUlzF0TgBl4x4Qz/pBCySEYrAWTJ/jjQfnPfFjxAV8uT2epxa+V3mcUenQLdc9 xEtWbZWbIvZhyPjkMhufJmkJD+eeARRJ5QmmKNNg6es6gA5CNcaaWUc5BEEMTU/2oPFA fFuM1zzPjlHNqabe2luxiZsArxR3PZA8xsrwRTiSnE0FQZgaScB8aGs2QNLXm2C6LvPp Vjf7EZU/WpFtRBV+kSOqRUojPa8C43RhDEAPOAYbiOpwg6aKmcXCX8onz65JqaXlXvn4 k7QXSqKbT5J86Njj3OOKhewbEN84Sy8/ZcoaprquJWi95jj7AYZlsSTtU2l+cvVdwiFH Lc6Q== X-Forwarded-Encrypted: i=1; AJvYcCWO2hX1lyeSkHL6gwvO7eqaCMXJetcMoU9zZNt13Ul0BtluiJ7GlCZ7LlRfq0G9do1yshnstqR8Zw==@kvack.org X-Gm-Message-State: AOJu0YwsDjxe8VQG+4dHbIA1W0e8FZJNPWKQj+D4RLvrivWjoDbTWsVn sV1MJFNW9T1X2oFOJZ7Q/Q9xCiERheqLmR61bLaNRUaVyBg8I3RoogT0WibokUkTtGLEKX+NOrF j30F9pfHoMw+8uJU/Eyn/m+zOvXyE0p5Pe7E0 X-Google-Smtp-Source: AGHT+IFk8/GvWJwG6tNDd12MbN9MckIetCAQntsvm7RXN/fJBQRSRREZVjA31lahN/uOpJgQiKXbK33daKacZwaEsSw= X-Received: by 2002:a5d:5982:0:b0:37d:460d:2d07 with SMTP id ffacd0b85a97d-38213ffe4c1mr6588655f8f.10.1731679255711; Fri, 15 Nov 2024 06:00:55 -0800 (PST) MIME-Version: 1.0 References: <20241004154149.93856-1-dakr@kernel.org> <3b843e34-48f3-41ca-bd83-9bc137ca6c76@asahilina.net> In-Reply-To: <3b843e34-48f3-41ca-bd83-9bc137ca6c76@asahilina.net> From: Alice Ryhl Date: Fri, 15 Nov 2024 15:00:43 +0100 Message-ID: Subject: Re: [PATCH v9 00/29] Generic `Allocator` support for Rust To: Asahi Lina Cc: Danilo Krummrich , ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org, asahi@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 55638180017 X-Stat-Signature: 7s3c8nxjj5smiszi5wxj7yu6635341ab X-Rspam-User: X-HE-Tag: 1731679227-244510 X-HE-Meta: U2FsdGVkX1/y/evBjSraxnGM3uIiYKBMbW8dBygcA3e3FYKbyct5gSCAUo5I5BxN/mZapdJfd7WjGSERGl+GB0dtSAyM83KVFyl5s6GN4amtoU8hFm9GzbREUY/Ggc18Xvkj59Owbun6ubQc5P7U62RtXeNDlgF0FP71aMzoOurhBvOGvdJ6ueevvwc8G/zm8TZ4o80QNK0wXCeR9nao7Bnx9Jo4z8+WdB6eVt/NPBfKnx1iqi1YqyTp3WQ8ERXBppDHm6MSHafkPqV96g8qgZLF9gSWBU1lYg+v/QK8e1oddQxffpKZNfwyrNaaKwOTPJnzxFjYMrFvhYXDzv9crLC+G3WScd4KCi7Wn6HT8GpQ/SuA+ERI0DfJpIF8LL2NPaBQfEBjvweCbZPovCZ/fmE1oAl0kCP8VajO9TZUUi/Tf+ZIyKendHFeMAoQjzzukGxbjsVtDOXpQgAJyJmHE3wsoJi6nNPOm+bk5HGkJf27zngBr/vOr7E3sbKYoW2jj9fL9RsjDhfcMA1klOVB7h9jIfF10pw++Rrx9jCP0kKz+e/QLkIERINvjJB6FjbYSA+feND7yJBGbTpwDnKolU8OB9i0b7jNftvMsfO+9a7c+zMdJWLwGjSn6wW63ZVhsZUwBWE31bsWHf4hWb0XcuEN47EF3PVFdISDr4Mux/6GCk4XmTWGT1cVJPv72BJ0pHwrmz84/PrYKDSSCWMSJv8vLql2OsaAaTGbptt0ZQOVsZk8wEXHIY4laobkZ9oDsyQeeLig7U+mTjgko7S5+Wnftt+sSqo+sRWOdi0wArB4IL3E7kUvxhI1rLptziIovf9KrFjuPlePX0ifQrHZz5ygmW/gXv2AJEXPih/gHUQLR3cq8QXMBh0BFsyA3s4Bj4rhpTYO+jkcu59WXCezQUQdaIs+NEoaYh4vFB+TDBuf3qM3zUEgwT5VrpdR1ODZWcfVk9Sx4XljluQ/AFA bPCpcvqv DNukwkcV3Lq+AMiWo3RFcRuHCS5ixSBJ3gSmfbnKVh6uAsWMLsb/4MW1lrrys5uqJhW6vzW5pytfkthk5fQDw3Hwxl3t2GeoHkp6NZv65nVm/o8P8kg6Cx6DU0AUkqLrDMaODKVLH0bmS3T6jVk6OzwGfvVkQozMDZ0UtYN/FFG/ZlbLVUvhx/MRCTvNpPi37gw9AtuSwCRLWV+N+yksZ/raFDqBztozrU+rBGf5Y4Q6NF8k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.305739, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 15, 2024 at 12:33=E2=80=AFPM Asahi Lina wr= ote: > > We (Asahi Linux) noticed that this doesn't support unsized types, which > is a regression from the alloc Box. drm/asahi uses boxed trait objects > to generalize across certain object types like render commands, so this > breaks the driver. > > Is there a plan to add this back in? AIUI this would need the > coerce_unsized unstable feature, but is there any other blocker? We're already using coerce_unsized for Arc, so I see no reason we can't just add that for KBox too. Soon, we should be able to use the derive macro [1] I proposed to do this without unstable language features. The limitation that the RFC mentions for custom allocators does not apply to KBox because it uses PhantomData instead of A for the allocator field. Alice [1]: https://rust-lang.github.io/rfcs/3621-derive-smart-pointer.html