From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFAEEC67861 for ; Fri, 5 Apr 2024 07:44:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1AE5C6B011C; Fri, 5 Apr 2024 03:44:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 15FB06B011D; Fri, 5 Apr 2024 03:44:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04DF06B011E; Fri, 5 Apr 2024 03:44:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D4F5E6B011C for ; Fri, 5 Apr 2024 03:44:22 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 55F91A17BF for ; Fri, 5 Apr 2024 07:44:22 +0000 (UTC) X-FDA: 81974690364.07.69DC625 Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com [209.85.222.54]) by imf14.hostedemail.com (Postfix) with ESMTP id 81C94100002 for ; Fri, 5 Apr 2024 07:44:20 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=JXazRlB2; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of aliceryhl@google.com designates 209.85.222.54 as permitted sender) smtp.mailfrom=aliceryhl@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712303060; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SHGbtYE78WACdauHUN0T3sz6l7y4v0ZFIs1aCPJUAfs=; b=aR9zKc7GIxFXbdqPneV+WQrVqX/UtUFg2mRmpDtUYR1JG31oHK+ukkHARzjaCA11bp6RwP 73JvpHeJF3uqzp/a4pQeouTQF/Z76JYfVuuX6F1VvWHsfSL5eEwf9Aww7JxHszUZR9Ew91 yiYkMt48kgeafIRubfOms2o+zvjS2ds= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=JXazRlB2; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of aliceryhl@google.com designates 209.85.222.54 as permitted sender) smtp.mailfrom=aliceryhl@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712303060; a=rsa-sha256; cv=none; b=GPdkJvAJ1txo150Za8JdahMOmr6qI3eeYzvb/fYoACBVkYklYBlF3DxfHdP0FIemuCSbiS nV1Fx2F1yuBNOdQaPhATd/MLUO4egdEJDvntsyPMPHe3vdkPRUGOtbwjEwVPTCEu6oznds 2FhFlGR7Iohrl8uV7mQVnGHIE3TWv1Y= Received: by mail-ua1-f54.google.com with SMTP id a1e0cc1a2514c-7e5f9c15d83so135178241.0 for ; Fri, 05 Apr 2024 00:44:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712303059; x=1712907859; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SHGbtYE78WACdauHUN0T3sz6l7y4v0ZFIs1aCPJUAfs=; b=JXazRlB2Hf3MYDHDDpI2AwaUR2AkUQPYTix3q6Jg9TQy4vtyaCmKztZWybp85zb4Ey Yk4pYjKUgpCrqs7ap1NMeQaoT13ziKwRZEDWIRbI5Hebn1RBJ1HfrkfR7TRfAq7NtlX1 1mm6y17kZn8D4CbRW9cTMDioBQP/6OYIeL63ITkR2NDytAxVhHMmzw/lSySSEwA7fvsU OOqvwq/df7+55S7cMJLz65tWBTa6ZCi/5dhuCGIMp+RzoB8qc2tdALLUT5yBwZ6jw7da bUXjhnADaiZVkV706f9ylmj5UdNDWSftp90Q3GaCJsWuC2+iyLOowmrgM1D4XQEFFQ/R d01Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712303059; x=1712907859; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SHGbtYE78WACdauHUN0T3sz6l7y4v0ZFIs1aCPJUAfs=; b=hKpY48I9rN8ZPP1dwwNQDpUz8jOwzCbGHKR6732R91qMoQqQALju4FZAKmYqYZQYtc tQ8EkXbgdR+vQ/eOEMEHjvAzbhxPAgR0/TVAdvyWe08ExTEKLKpoK+j1/c88UjgeZ3sq IPOgkQretaEbo5W2HeZfrI7ORU7L2UwG6dxPPtCI9F8rYqAGrOTpO7hmMv/dp6DUHHaC hjNFkUjwddgZpbcvwVCfe1DPnud7HwWxQErgjGFOFOJTvSuQ8kxEMbYsPmavNmEMZR0i xsZ2eblv9fOpQrv3g1OUPC/bGK3blznYy5+AFw+Jir2eHha/5gW8nXUFU3b0/YvL4lVl tIsA== X-Forwarded-Encrypted: i=1; AJvYcCVcfpr4hEB1X4op3UaSnunR/cpTwjB1/vRly22BGSMVFDB0BwcGw48DiDN8PjmjQVi0rbp4KYMbb8oCQ5J54DQDXlU= X-Gm-Message-State: AOJu0YyV6WicjuPN00pLhjJ1XnayAlK6y1l5i9YEYK3ZRKacBAECXr2S Z19rWu9qPMb2yBLoVBMXGEJHq/v89l/veBovwOFvB+RnQK9SlCWSBlVJ1nORJ7daUNdtJs1wjYp QTQsfQrUKoK7umzIRC4NB8UtZeOf5bA2GV9gF X-Google-Smtp-Source: AGHT+IGMeMqrXZ0hb7q26iSJbPXd6dY3rpQtcLC3/bDQAURqKv3BShFGpUtYoVqS9r2ldERtJ0iVFeg0BVc9I60Wl/c= X-Received: by 2002:a05:6102:512c:b0:479:c401:824 with SMTP id bm44-20020a056102512c00b00479c4010824mr1516533vsb.6.1712303059454; Fri, 05 Apr 2024 00:44:19 -0700 (PDT) MIME-Version: 1.0 References: <20240404-alice-mm-v4-0-49a84242cf02@google.com> <20240404-alice-mm-v4-4-49a84242cf02@google.com> In-Reply-To: From: Alice Ryhl Date: Fri, 5 Apr 2024 09:44:06 +0200 Message-ID: Subject: Re: [PATCH v4 4/4] rust: add abstraction for `struct page` To: Benno Lossin Cc: Miguel Ojeda , Matthew Wilcox , Al Viro , Andrew Morton , Kees Cook , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Greg Kroah-Hartman , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Christian Brauner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 81C94100002 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: cdyq3xnqw1tasibnq4pjpajyhs4zrd9o X-HE-Tag: 1712303060-491824 X-HE-Meta: U2FsdGVkX1/gacmoDWuSsFLk//JhumAxv/KQYaMhFpvFCFJfrUYPI0wpkEuPpXXSoliDZnct2I6sJWb9Gsof7Z+Va8QTIisY7fJvANfzKg2l8/cLMTX98l/pV2ddGFb6BC8ybUtMT5Gi1uUcbgm1KW5TYr2LP8WOvWY+roqJRZGvspaDBVSOq0/HpE9GvLE3aM1qNSTdp4HezH89t7uXe6EXe/5Ym68PWYk039CKsWmSd1Os4K4aKZOs/lpdJa6ZfyQIbCfT9g0UzgSJ6P1scotq2XYu9iK7IrHmJObmQ4n14FMlyQ5jfmFIzYEVSaRBVAwn+ixWLd5J+jHjikM0lzTxSHJbGz2CwEN4jTm/OtYafKzZuxNXfWvSdqTn0DCw3b+pysxv6QnW+srFYgquv3e1zJhigZwIIv6u0Ek5rEbvsu39zuE3hOQnX2FXOoINDvU5odPCB1xX/F1jmJ47pwMRGYpz57xQBvAveYdDBPv1XiQ7PQFtoxPpX6AeDQ5MCPI5sPX3QZFzUCVlkA1RTXpYnQFlHa3Tqk9tYdcpFX1oTTARPuBX5f7n5BuxUwZbGis2Mv+ywGQPZdfSwgb7y9EBrGQqBTjFhrpHS8Ux5kwBJDyAzUAQpxmLyWzuQCIUKAQxASHL+QRqCZK3sD67w17+bLy7eOm0/V2lpS/qEX9NKGyZSd3VkoxXbmXT0yzfr+CRjvborDhdCQhI+jrf7XR3N8c5buUGr6gzIquZ0WzV06ECB+i/PE0e2LxjIQ+HBxntyuxvNaD7pob4LvFNt/Vm90XiK1oXmMneYIgA2zewRxIn5U6v8opBt8rnNU5u5G/kxQETU/59Kq+vZx7TvIuuhOzqcrcggTeoD/3CvJQkXlTBeQ4Lrn8zsKwHFpJ2WltpPWx/DZwS2gETT5o9sMJP3utkvVl2zoFuvxIyZVHnXogi7vQ1ESrDdLBzWNrqa9r/7lDnGkTAEBK6MAr bDM6z20t F/TrQ2ggPqnRIRRBA4efSPbMO+ygunGCEQbXD5DPKKlTP0slIxmJ9yX1ABB+GLRZmmAromjqi3B7Ketzy3BLUStC0gwzmNMlBHadx2VN3o2W8+naaoLi01T1qJaFvc9S/cVAv6q4hQQUC71A0ppaHlXUoWPsx6NCxK3ubwjXIEloOVIZUKSAQHWG4TnKvxd55odpGlTYYJQHr2h79X8DaQfZDU2Jt60GoPkDF2I0TFmFyaaMUneQcMj40V6Ga3IiQ35hLyqBiqPsw7Dk1NANfGcxnsX0JbrxrzAP2tf9UMZoDvhUHi24vJYsN3z7zZXJjLb0tM8tMs2Om9HQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000119, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 5, 2024 at 12:33=E2=80=AFAM Benno Lossin wrote: > > On 04.04.24 14:31, Alice Ryhl wrote: > > +/// A bitwise shift for the page size. > > +#[allow(clippy::unnecessary_cast)] > > Why can't you remove the cast? Bindgen could decide to use a different type in the future or on different platforms. Alice