From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB2DBC4345F for ; Tue, 16 Apr 2024 09:57:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80A966B0093; Tue, 16 Apr 2024 05:57:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BAFB6B0095; Tue, 16 Apr 2024 05:57:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 683106B0096; Tue, 16 Apr 2024 05:57:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4A0416B0093 for ; Tue, 16 Apr 2024 05:57:18 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 116601A0A82 for ; Tue, 16 Apr 2024 09:57:18 +0000 (UTC) X-FDA: 82014942156.09.B316AD6 Received: from mail-vs1-f48.google.com (mail-vs1-f48.google.com [209.85.217.48]) by imf26.hostedemail.com (Postfix) with ESMTP id 50F1514000C for ; Tue, 16 Apr 2024 09:57:16 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tMjq3pbx; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of aliceryhl@google.com designates 209.85.217.48 as permitted sender) smtp.mailfrom=aliceryhl@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713261436; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NHiCoxCRUNDM+U/esFCAFumYpu6ndbBWZi/5QFnqRTc=; b=DYQ+hJiBoz45Wn5ltNYfkx9r8el2DjKh2UvmOqT6ZhlZShEg98AxpQLAqRkRQwGeDQErsP yyRij3aVBTaY8TxoEE+RA+zKyht1P3BS0yQAhQ6DqnxvNzf1ud88pjmCIGt8pMaW9/jjTE Lc56mIwQ1KDBQPeEXl8YDDkXP/Mm8VY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tMjq3pbx; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of aliceryhl@google.com designates 209.85.217.48 as permitted sender) smtp.mailfrom=aliceryhl@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713261436; a=rsa-sha256; cv=none; b=XWU150rjhUvzX5LyqjP0BRKLBaAQm9brqSLSMv/eVTc58DQQg7TV3m3PjEvVyFl0BwaUUX N2TI0ZEP4LcRalHfLHhvtOAidySxt1CiNJ32+JahKp+4y23owVsUxs1Hyuunwwb5zzLOpI 6377PZxKDe2qqx5ocaPRjD2W/Zh9NRE= Received: by mail-vs1-f48.google.com with SMTP id ada2fe7eead31-47a404c6decso1113704137.3 for ; Tue, 16 Apr 2024 02:57:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1713261435; x=1713866235; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NHiCoxCRUNDM+U/esFCAFumYpu6ndbBWZi/5QFnqRTc=; b=tMjq3pbxUVJMWQ17YxsWx6fJpZKLn94qjFRQvaTdB0ple7G4lZf+8P+/dM8z9dbxsd zHcdf1bFOkuimdHa3F3hWYi3eamK4VldbDXSvpwrggetGUpsoDKGKtt61Bpa8qPfItmt TVqBhyuQ5eWslWkT5HoqyZxsjhvJhE8ajRWhrECvVosgW+JHfIIUd7jxp2qfiEIbOQl8 CVKy1p8dwJGOIvM82TBTbYft8bGLsJ1bHoW+VG4/ec0x1F06n2VqJX9oXEtU3ukvMTUx DoE/M7UEIN8ZwWTzDs1iQ8DGDWQ35a2/NvnOuSLAsUeW7dDbClFlgNzJ+VuOuYM2RYNU jeww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713261435; x=1713866235; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NHiCoxCRUNDM+U/esFCAFumYpu6ndbBWZi/5QFnqRTc=; b=TIVwKu5gt8tsSRf2bsUBC07gxjug47aasrQaSj4+mH4cafE4csKhxQEzGamcxkKBzi XtY8fEHzK15BEaSf1jcYQt69UbCg0nbeD6rnaA1DyWI7XAxZWioZJfbdHFgrUy34Yw3Y jbURjZlH2QhUYMYTQZH2KgZBYCNW8Uu0d+SrFb7jWgbEFyeI0SkIXQ8k9Q4tO4dGikAw xXYGeD6KhOHpLhwjyGAU/vPXUMRlhs0csQP8BfjLPrbpVozXbml+baK/QsCFCWlQx4v8 eiQuQyFVq4DAXcYzhQQNw1jUI9pJTm1Dum+91TKaQK/UuhJYmK4jsWyapLKbyn7Kp3AA fK1Q== X-Forwarded-Encrypted: i=1; AJvYcCXFt0M4xjiloEp7jqXu0c1xJzP31S5zh1MdjsaD1qa5F7ORBwtd0p2PbmshZBozBk0HYyScmf9trCS94HGsMAVJxAY= X-Gm-Message-State: AOJu0Yzuf7LkSwVNiilcQkW7xij4gL9mn7QV1/9mxYfhgRQ7Ae67gIVo qfpG4MReGEfiiowOKNBA95PuZ3ytpzt7gZO4az0jIup1ULS+JZupBuWW3pvALelIGB1/X1L3/K9 e7gypjuD0wrhFP1IhR88Vvhbi9ZOzu0oRKsZW X-Google-Smtp-Source: AGHT+IEPsW05phYUIrlx5Uy8pAv8kP3cZvEoCRY/OH7h5cbl24CtY5s86HrRZB2SYuf+ooWwSmXNWVN1t06Z6diHe0c= X-Received: by 2002:a05:6102:dcd:b0:47a:296c:def with SMTP id e13-20020a0561020dcd00b0047a296c0defmr11930644vst.29.1713261435254; Tue, 16 Apr 2024 02:57:15 -0700 (PDT) MIME-Version: 1.0 References: <20240415-alice-mm-v5-0-6f55e4d8ef51@google.com> <20240415-alice-mm-v5-2-6f55e4d8ef51@google.com> <202404151605.6EFC791E@keescook> In-Reply-To: <202404151605.6EFC791E@keescook> From: Alice Ryhl Date: Tue, 16 Apr 2024 11:57:03 +0200 Message-ID: Subject: Re: [PATCH v5 2/4] uaccess: always export _copy_[from|to]_user with CONFIG_RUST To: Kees Cook Cc: Miguel Ojeda , Matthew Wilcox , Al Viro , Andrew Morton , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Greg Kroah-Hartman , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Christian Brauner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 50F1514000C X-Stat-Signature: 1k58giix3h7dh8x3s5egnaey4g11p95c X-HE-Tag: 1713261436-477555 X-HE-Meta: U2FsdGVkX18G/2+hifK4uZdg+KHiT8R5Q9vS8CgtwmptSrOdkJCYSJzSB01ZgfCZ/XIPgXWdHcdEa47VU9e3TzK+q0TUytcLz5bDL4/+xLY66QxcAadpeEEWL5ohiplm3ZAxpOJdU3+rmt39HRuj96+QL6VFWo5+UVxdF1SEUF2OaPiZ5/R62luoag8R6uQEl31wt1L4WRWsDQPfNwbFxrSgUFp6QeY672KE3prXk20vFQLfoi2B+sFkMJ8GxiEK720Y7cEYP6vSvTjnedRzSdv0qkFIpH5iASJABlxz6oqWQudd48D3I3vNIjgU2C/ehJRXdxDnTp9TaXdyNF5ODR/xaDoLzNQEVUjgiBb9aY08R0nRHKDcQfANDMoW4RspC14fDh6Mt9IC7l56esOx77O8wjois5aWQgNfRc5RlcRc7msirmL83e9NFSJcvuxQCGZloPQHUrGE0eH30syCeOfa6/OIc5YYxMehJOZW6RLwsfS/smGkWPC7rty6eARj7vBXipBcJbCqYZAzNrlHQbI5c7x4TJ8HzEFjYHnBQ7Av3QbrnYrBhC9gmuBPWCryAdDddVpsllHqaVxitLTTMw8/eGj8N7yI8PsnRKBCMzGijvXzvwMxm5t2EIpRM9C+LiAURB9EHIqGitjwI2DJTG5wbici61jjdh4+gOG3GSNaBYoDNgcS345rr4seis/gY5vg92QWvo67yqVsu89S0zaTaI3/+2HddVR5gqVKRPOzF0DyBuvje6b+MfvOM3wIu+MpYvtMGBuqzrjmEGqfUhRW8gDRaOpgOA8ZTnxO3uX5p2axoUNK43JVuZq4uK24VByiYXIaNw37qGyQ6VMcAKVHe6AYCGiIosNwNTMFhonBrKFmbJuKu9KTkILTrdpKQKnCt72CtZjR6Bjr1uQPKRySh3Yf45wJ3OcfPqnnduxDMtSHeZtFB/sJPJ2sqdSjeYKibZ/0keAaT8lQIov 7aOaJjg2 /sORzqHz3DVGcwx4Qm/lBWGVPK0SjmN4MZzoJl3fL8kBQghoG/G0B+A2ZnDiS/G4CMV6nBNBs/J0L6jSkIrJJ7Si6OrM/9dH2opKfkaK6z+M+Js7lBnar4+kQp3SLa/BhJww7LnnceKP8GKCvoZph5FppeUpKipALkUmR6B4ZAR32oAd1E3KhognIR/k29OodSbth0m5ghBP9zMbspsj8lgayy0xcZl2H4LYqruQ34vHnbgWcqGs9c06FXVFjgO6ueiH1UW3g2n0649YtTo6tyKSR3afrkQ0Z1x0YTk9kQ+dVljHFcE8N1sMazMAIUassA+grwHl2WVlhK79+rfCNLo1KBxY3BNA1OXOwDBz1jLd3KpjXLAkjdEiTDqlljVrvP8plZ5BwVr/V3C5ZllmbZrnTk0Cwf46/31D4SgCaz3b11vgs82u4HbPWqx1dBRKm9u0sa3eRdhk25LghTr6vZ+Al5g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 16, 2024 at 1:05=E2=80=AFAM Kees Cook w= rote: > > On Mon, Apr 15, 2024 at 07:13:54AM +0000, Alice Ryhl wrote: > > From: Arnd Bergmann > > > > Rust code needs to be able to access _copy_from_user and _copy_to_user > > so that it can skip the check_copy_size check in cases where the length > > is known at compile-time, mirroring the logic for when C code will skip > > check_copy_size. To do this, we ensure that exported versions of these > > methods are available when CONFIG_RUST is enabled. > > > > Alice has verified that this patch passes the CONFIG_TEST_USER_COPY tes= t > > on x86 using the Android cuttlefish emulator. > > > > Signed-off-by: Arnd Bergmann > > Thanks for the updates and the comment on testing. :) > > Reviewed-by: Kees Cook Thanks for taking a look :) Alice