From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20D57D6EBEF for ; Fri, 29 Nov 2024 08:58:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91CB56B0083; Fri, 29 Nov 2024 03:58:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CCB16B0085; Fri, 29 Nov 2024 03:58:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7949B6B0088; Fri, 29 Nov 2024 03:58:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5D2C86B0083 for ; Fri, 29 Nov 2024 03:58:43 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D94D540DEF for ; Fri, 29 Nov 2024 08:58:42 +0000 (UTC) X-FDA: 82838531916.18.F6CE011 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by imf12.hostedemail.com (Postfix) with ESMTP id 8753D4000E for ; Fri, 29 Nov 2024 08:58:37 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gDOfI9j9; spf=pass (imf12.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732870715; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RiMRUUT2M7xVzatty0ZrzXrnlDpHODfPfP79MfeCsvw=; b=RxNoVIhpIS+ZiwRaI0frX7dxIVMo4p5WPJ/0fI6JorURXu9YxYwi+5oc0tpfylZrDMTuNy XvbwYJmRv34qNL/Z/mUDUMMvMkF5eCDaFYz0XohTMJc8IXtAB02707IKELKisNZkwTyH+i mN3IcStjqoEUSKfgpoiDs5/6BJwsk70= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gDOfI9j9; spf=pass (imf12.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732870715; a=rsa-sha256; cv=none; b=zG8LYXkZynjOJPVlYbKdP3tOPOU8mRbHjSM2z85kIsOwcQ9doJaV4XKMXcc8yomNZT4tyi HUaFmdS8g0e9N0R8+eTye9rrPK2lOBFm+U5RpoDCa+mmnwawONejtiDlcJBxCZuPxl3eA0 +v5Du7XWn1WUvHO9ioUlw7yovRZmfms= Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3825a721ae5so977144f8f.1 for ; Fri, 29 Nov 2024 00:58:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1732870719; x=1733475519; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RiMRUUT2M7xVzatty0ZrzXrnlDpHODfPfP79MfeCsvw=; b=gDOfI9j95OnhcxJC106xlBCoy1Bo6ZPZlR3ltS/+e5vO2Id9NIB6PjmB2hnABq6ZmY LCw6BUZ3P/XJCxS3q/uaJXqJP35JJwEIrqC4v9gt+qVxWO0xO3R48cmUp9q5wiyvD0Zc bH510lcBgKIjIcvE3IGDcVf4FnpEqUhAPg976ayja3zhYyP4QlWFh2FzZgF/vyhwz8lL QcbdD1DNgZLep4bCdsmSot5AmCOscPQB6hDgkjfK9uBQO1Vi0CSyJUw/KAAmzpRu5o8N Lkb++9EH1oTnbjjAeHnAdW5DzlYdMS+nSM3MQpCUWa84iN7UkumLhJ6cQ6vZtzORTLiT 5qNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732870719; x=1733475519; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RiMRUUT2M7xVzatty0ZrzXrnlDpHODfPfP79MfeCsvw=; b=D0ASgVhn43+8B4p3iMNZey/ssTQ/AauoRJfVzs46TXa5Hpf8EcLLjrqEvAowGCwdJ3 GHzqkZaZQpQu2G6qOy0rE+e8E8CezryoYiFY3xUMWfYZeo8ar/vKNFFRRFA9YwCxnkWS AyYWzCUgnVMI7XLFY8kDrs6QRSM25Tv/B9PiJRRXGXivyWuflkIPYsw9729JihuLOHVU pExxt5xxnBPjRBE0Xcwt41S9sSyh2MtzY5OpB6RWZvvnqyeqhBghgGH//vjIUcno7NwR C+lv1Zbr9vN8Mt0s3HM4sDOYbi51cG3V4QMeVcg6AaV6mA90579O9odc9R26z0pSzi2N pGqA== X-Forwarded-Encrypted: i=1; AJvYcCVe9xgC4AyJPaIuopd5nRDNhzHnSGBjKDYvjOZtSuh+Frbj/xKBlbyhCmnJKo7mccgo2MorlM18mg==@kvack.org X-Gm-Message-State: AOJu0YyQ7yBH0Tyj1VoPOf0Gsxf4vorHiZDIJGxuwXxER9TbUMcRy5M0 qsnLkNY0VEcDwZKPkSWmP0jYKMqLMZ/wpHBBSSG2544TTGiYFQQg+0NVZ/TieF4lxHPM78a6GK6 kD3x+SENXJootgDPrVsbbE321QtnQVwK9h4j1 X-Gm-Gg: ASbGnctcsQg/X/45urB9y4VWSYJuenB9ofRjz1CZBSt/IYsa4AZhPwz/i8A6DXexAO/ saE1TWMyCjSGgNP0ScPd3PM2ekAy4NYnUp4O2e0AKAGi+6NqRZrPByzLaBcmP7Q== X-Google-Smtp-Source: AGHT+IHZfE+MvE59g3GUbb6K8cSnEsXzMx7JEog6LGr2L2lWRogqLF0km2dm7xM7vKZZ+7cUaT+QbeJVrgf31YLfu3s= X-Received: by 2002:a05:6000:4008:b0:385:ca48:2852 with SMTP id ffacd0b85a97d-385cbd7c28dmr5175022f8f.13.1732870719463; Fri, 29 Nov 2024 00:58:39 -0800 (PST) MIME-Version: 1.0 References: <20241128-list_lru_memcg_docs-v1-1-7e4568978f4e@google.com> In-Reply-To: From: Alice Ryhl Date: Fri, 29 Nov 2024 09:58:27 +0100 Message-ID: Subject: Re: [PATCH] list_lru: expand list_lru_add() docs with info about sublists To: Matthew Wilcox Cc: Dave Chinner , Andrew Morton , Johannes Weiner , Nhat Pham , Qi Zheng , Roman Gushchin , Muchun Song , Michal Hocko , Shakeel Butt , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 8753D4000E X-Rspamd-Server: rspam12 X-Stat-Signature: wbkphmeqrpeh6c73ie6o1eyr6zrr4s3k X-Rspam-User: X-HE-Tag: 1732870717-294701 X-HE-Meta: U2FsdGVkX1/qe2YTyfvtNF2VGJ9M1/t+JWJHyZWx95LOPZ0Ge3JMka3XyYSE1Mjx4Zk+yKDA2BywalyXxvgn7L0/K31dsc7z3CCPQUMUiElJrbPeNBJhRoPUsfrW/nOcswu1pjVJ4t2jYzpT8PZcubhZHAD9IPL7+6yZl9Fbrma4wbnDY15XpxOv8m2ITqpBFLuk23pPbIe+ZK1au+YVfNXJXhCCC5h0IWIKigsYDiq2dRcn/X+MxYiIBGACcyVUqFVmuF2uHOhlx0NwSMTc1k7SwI533hcyX8ana3kk2ANnyk63hYxlov57UgNaIRzhx9b8UuOSDGYoae5OoVOR0sX1bStRsEXLkpdl2qHx/csySuq9eogXZSzmRiZ8A3Mkiu9koVkUQbO9OXyytna2trYKfIyHSyFzTVGz/XrqN+BrHgoub5txz/wyIdWV1qzrO75tEOWxelkCY/Thj0JmBceS/A8bNAYbcNMr/UbuYaytPtmEOp/1dJm1wznIZB6PC4YZyFAkcJqU5bqizDeTbJjRhAWZnkVVqsZHKUv+GTGDBX0aZFHmbe8qL9zg03CfgRchyhL1qIWxYGtkFSBJzVxqC9KEmh+PxUWYE6+tj0R+8odHpa61VVUcO9DHwHjGSGS3Nr/Lpbe5utCjO/rLtjGKLnJ/eVAF7GMGYdsfOh1G2rOlcSEtk9fCpI+9DZBkD3+a+fghCUfvpzeBAZYg1rRgkm1jj0vgF9dWgzLmxza1b9iCQVReFDCFJW+B9sM53L88Ry97TQILX8Qa7vGKV3mLcd/jZryjB8hLsC3SaKrzB1Op6Tc5F0M/MGhvzbze7s/WmVHeg1OH36LAeyKziEvByGsQZTb3FSTwDAe5sTi1BKV0C4L+4Rww7av6+hKl12nua1decw45EfPj/fnQKDvuIiSyNMQczdsi4C9bb7UEoE6SIZ2G0/o8sn29FDP7XgoxJjlT1acCQ3wLBuR oRHzhgt/ wclI1SIRUEksb1nvLfvWNnRWOoJgKMBAD6gOKU+XwdL61D+IDAAytrBKPpggD+2SIWpDZFcH+nhQNBIosQ6h0LNtFIXqN7+SOGQoZHEnWAk1z//oOP+uaXgLB4dg3ooyoZH+40erLyfV1UspP6gjg3k+h+vKbM9uH666k650zIkxYSx+RS+Yir2rtyY/+qNuU4KgZb7LweCSBOnvHHgA5K89+v9reEprJynsiJqgepsMnsvLJRVB1EGG00vviQjMpRVDlWiwX4HtHEk7S9yhh6wM7VdEsE5R4Ssjzo3NuW+R3O/s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.047957, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 29, 2024 at 12:05=E2=80=AFAM Matthew Wilcox wrote: > > On Thu, Nov 28, 2024 at 12:12:11PM +0000, Alice Ryhl wrote: > > - * Return: true if the list was updated, false otherwise > > + * Return value: true if the item was added, false otherwise > > This is an incorrect change. The section is always called 'Return', not > 'Return value'; see Documentation/doc-guide/kernel-doc.rst. And I > think it was fine to say "list was updated" rather than "item was > added". They're basically synonyms. > > > - * Return value: true if the list was updated, false otherwise > > + * Return value: true if the item was added, false otherwise > > Ditto (and other similar changes) Oh I had not noticed the "Return"/"Return value" change. It must be a copy-paste artifact from list_lru_del_obj() which already uses "Return value". Would you like me to change that one to 'Return'? As for the other rewording, I thought it was slightly more unambiguous, but don't feel strongly about it. Alice