From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42D5FC54FC6 for ; Sun, 1 Sep 2024 23:41:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E6748D0059; Sun, 1 Sep 2024 19:41:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 698458D0052; Sun, 1 Sep 2024 19:41:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 536608D0059; Sun, 1 Sep 2024 19:41:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 361FB8D0052 for ; Sun, 1 Sep 2024 19:41:21 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D04CAA17E7 for ; Sun, 1 Sep 2024 23:41:20 +0000 (UTC) X-FDA: 82517793120.16.C79AC55 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf01.hostedemail.com (Postfix) with ESMTP id EDC4C40004 for ; Sun, 1 Sep 2024 23:41:18 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DP1NFnOr; spf=pass (imf01.hostedemail.com: domain of smfrench@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=smfrench@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725233985; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0OptCrhRONfMIpYiriIyIArvvwMoZ9X5KBzqF2jB2C8=; b=72qHXgGBc4ZFJuXY1ekZZ1JttGI4HFgsTUyAQPDJPx8yycn9BGWs8G1eC+wsmglOJGJEmL vcYEQD2OZc+6iGXLNrmtPc58uKa+OZEvjDE0iM0wW4F8nEL34f/TzUVmV0btLBcEzA6cv0 xWgM52RMePDnYiY/wSJtRGSP22YEHkE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725233985; a=rsa-sha256; cv=none; b=uaWlss8mzG8utO7647YhdlV0yidzkNMFQ2HHmw4oHzFz2xrygtZYJaZySQ9/hwe0NCEB6T qqSrs/ZQ80PonadS+OAkSVZVFOV+C+MwU0kXme/gvev07jPe5aSDVzZppNr2t3ts1vWLlQ Xwf2Iir9x3uwV1QzH/hqveFrV357VtE= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DP1NFnOr; spf=pass (imf01.hostedemail.com: domain of smfrench@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=smfrench@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2f51b67e16dso40417561fa.3 for ; Sun, 01 Sep 2024 16:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725234077; x=1725838877; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0OptCrhRONfMIpYiriIyIArvvwMoZ9X5KBzqF2jB2C8=; b=DP1NFnOrTdqsT2FR3ecmPpdvtHMQSkRuzhQ22iwUBBWGOeW8+wqLxFNtHpep56d2Uz vkCkbErtEGzWeNr9avGRjB58lYpASGnXyk9qJXZpnfiyYpADloTeiu8vT4EH0NIiA108 HsuJ7YvSiScLhs6Sm2lo+3pGMhUqFLpFDfxPcizbBpu5mFNbStS9K6ENnmW6BUjSBOKF FDPENkcUH5WDLpUHDQAK1V0yTyuleRWxXXX6TcZxRQ/oRynL4kcU+5X61fA6kO1J/6Wu vLCnsRVNLuR9UXshqfUDQP48Y9vnYeI5hKijNUXWfNoGJ+6NfhRc02IdcGwVBonfU44M mOhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725234077; x=1725838877; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0OptCrhRONfMIpYiriIyIArvvwMoZ9X5KBzqF2jB2C8=; b=Y93KW66FNAVXkbofBMOjrmjcIpC42oOyn1wz6Dwuhpt8Euv0nhwMrfu0l/3chvwn1V 1vrbVG8VifBmGibNU99hRhhRiFetEMl5x7T7LI/t+lW20p0UghT+rpJLoJj140EgVetm Ea+WKhyDTF4sr+6qI5ETx4h/3DwS3WipVUTjfvoQrh067LxLEZK3onDzOfruiw2Zopz7 77d9FSl6Kjs3a8oG9CmccQnBnazm8Rnc+8GpL+DexIIJK0kHuQTBO47snY4exram8z8m XyJuvZlzh0QOTQcnFUB8OlpXaBhqzX7w1RSX85iH7Gp0raqDLyXaIpFj3uH+cCHXN+qz uKOA== X-Forwarded-Encrypted: i=1; AJvYcCW4Rg2z6C2OdrM8KHt/OJJJxFBe2wDEPGkBHH6tm4vaNFcIcIlbGxntLeTP/sIB8GR+tKwLXrD6YA==@kvack.org X-Gm-Message-State: AOJu0YyI67LTE1tZcZFvg3rDcJgvncbNsWdPAOAYXI3oHPkWdWI4eioA TRpafOEW+2brxccfohMChTa/HUH82gK6mdU22KJFcTzMIPoYSMXhaZLzo5DSYSv7wKH3tFTLvkP SyYJWz7Fl6JJCTGntMIu4fE+CMJc= X-Google-Smtp-Source: AGHT+IHrpw2kTpvaZiyKJAHMxmQ/fhZpxqRdKI1vFWTY9ydD57nABAkwYo+y3SH1kUAvMU7Md95wbwacKxJ+67IyRxg= X-Received: by 2002:a2e:be29:0:b0:2f5:23a:106b with SMTP id 38308e7fff4ca-2f610890868mr90286721fa.34.1725234076595; Sun, 01 Sep 2024 16:41:16 -0700 (PDT) MIME-Version: 1.0 References: <20240828210249.1078637-1-dhowells@redhat.com> <20240828210249.1078637-5-dhowells@redhat.com> <20240830-anteil-haarfarbe-d11935ac1017@brauner> In-Reply-To: <20240830-anteil-haarfarbe-d11935ac1017@brauner> From: Steve French Date: Sun, 1 Sep 2024 18:41:05 -0500 Message-ID: Subject: Re: (subset) [PATCH 4/6] mm: Fix filemap_invalidate_inode() to use invalidate_inode_pages2_range() To: Christian Brauner Cc: David Howells , Paulo Alcantara , Tom Talpey , Dominique Martinet , Jeff Layton , Matthew Wilcox , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Miklos Szeredi , Trond Myklebust , Christoph Hellwig , Andrew Morton , Alexander Viro , devel@lists.orangefs.org, Steve French Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: j9e5s5ipfjijhmue8f84cwtubsqaw6eh X-Rspamd-Queue-Id: EDC4C40004 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725234078-68513 X-HE-Meta: U2FsdGVkX1/BTBlcXpvnoJs47syEUqHx3HoxfJvtN3N25YmQPxCDzeABWdD5wTzMMdnusdWL5ZDUUW3f7TqoB69Fq/ihUHPEn2iUhkB+5qXc3/U+kvxryPoES+WvtLVk2wcCywljHttEnWHzeI6HlOmIuFPF6w5vIFQ42jdpYAFniFp2h+lsQ3qtyukvBICJJls7z9tEUjZA9T5u7yRzbxU9U8Dwrd2SpfsSVwiDGEsQLaM35q+khGT38gRbyX3B/VPASWJbkzZuweEmoRETY895TfPYvz5AhDyWskLDspkdUDXW0/X8nG5IVvOj7wD6gyHahGkVM7jb6h3rDTAoAVQMaoqRssUAQNRJEUDikqowfE8A6nFTOeMR9bVA5h5yoB8G80hVhauPOZFXa714SHr63cwGmU/wFI7HwC8cYT/w9pkzvBHQZewnBuNCI8elbL25ga9Xrhf5Zui/I488MipbEH3s2Rsat50PwJouvUg6k59lP6lljP+E08ydc2V1MrV59573TKHA0xT/wdJc0wyuC49XCux0JbrnRhgtXSZBVSs49NAs99/Yp904T9+55NOyedijRxAE/MfRBOacj1clTMA9M7JKOTa14cxVqQSW1UzWphmSVlhTIaI+htaSf/VOkQUWnQv440NEktuCMWrTGgwz2r6tdlG/KT2avzLNQ1J+LL8AkH2O1m9xLCC8nq5/Hlw5RIqS8O3DTkilzxdqS/mBmF6yMTLq4XyLjfJuXEGWJ3DqbpS/iq3UDAL6fADEeDwdydJhdKtYCaM9RjFURHUpV4wRb/s25AccmZn3IzqO8t9Dv1d1D3KWnoXG6+QQAUkZs7+h2ZGG/N1qLXn4jcfUwAOudIWZqOukCkDuT+2J8ybdCgv3lPstHLS7Pyl1uKcfn+OXE+Ibpt5Vy6SkZb0yuuUt75lK3VKzRYBlH4vgxbfh/EuiylTLB8q8PmfSpFVddUZn96jxXFE Qrb2vQr7 MXz1i/yY+jp15dRd3ZL6w+0bQ/hoHO5o0c2phrUWh/u7astMLiQlD1lIsr71HsUB9cOLY+QcrvAM1RPzF3FHRaP7EyEcrhQr+cqPCR54M/FwSU2mHXVOYpb86gogpacxWA50CiLkMRXSaIRLQuTkPEG0PX0FOa9gmSL5559fZjjwfjbgViE2QmCNjlGfnAhOcSy/i2vjinvc9/M0wrIDm+5qXBxOhxD2kVr2agswro1Q3hfpGcltD1CoFmQeUzY3R7ZzwAxGSz8xZl6VY3/oPY/VWgmHvUxMM1wCL46O9M6zd2Ps93iRgcKcWLpG7GyGlDRxo40MkMxYirEfIeT6D5rM8ZJq8kgk/OV5GONEC4ICFdkmLRFGo5ZKmLyeqWC04Nr76nslzlmE4iwWdCqm0wg9JEJFJENF/BNIYyA3tIkYZk9UVJH6fdailQw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This looks like an important one as it fixes multiple xfstests see e.g. with the patch: http://smb311-linux-testing.southcentralus.cloudapp.azure.com/#/builders/3/= builds/213 vs without http://smb311-linux-testing.southcentralus.cloudapp.azure.com/#/builders/3/= builds/212 Can add: Tested--by: Steve French On Fri, Aug 30, 2024 at 8:12=E2=80=AFAM Christian Brauner wrote: > > On Wed, 28 Aug 2024 22:02:45 +0100, David Howells wrote: > > Fix filemap_invalidate_inode() to use invalidate_inode_pages2_range() > > rather than truncate_inode_pages_range(). The latter clears the > > invalidated bit of a partial pages rather than discarding it entirely. > > This causes copy_file_range() to fail on cifs because the partial pages= at > > either end of the destination range aren't evicted and reread, but rath= er > > just partly cleared. > > > > [...] > > Applied to the vfs.fixes branch of the vfs/vfs.git tree. > Patches in the vfs.fixes branch should appear in linux-next soon. > > Please report any outstanding bugs that were missed during review in a > new review to the original patch series allowing us to drop it. > > It's encouraged to provide Acked-bys and Reviewed-bys even though the > patch has now been applied. If possible patch trailers will be updated. > > Note that commit hashes shown below are subject to change due to rebase, > trailer updates or similar. If in doubt, please check the listed branch. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git > branch: vfs.fixes > > [4/6] mm: Fix filemap_invalidate_inode() to use invalidate_inode_pages2_r= ange() > https://git.kernel.org/vfs/vfs/c/c26096ee0278 > --=20 Thanks, Steve