From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB62BCF9C71 for ; Mon, 23 Sep 2024 23:17:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63E156B0085; Mon, 23 Sep 2024 19:17:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5ED126B0089; Mon, 23 Sep 2024 19:17:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B4C16B008C; Mon, 23 Sep 2024 19:17:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2818E6B0085 for ; Mon, 23 Sep 2024 19:17:18 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C1665AC43D for ; Mon, 23 Sep 2024 23:17:17 +0000 (UTC) X-FDA: 82597566114.05.08B3260 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf29.hostedemail.com (Postfix) with ESMTP id E48C512000F for ; Mon, 23 Sep 2024 23:17:15 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nBtos+EI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of smfrench@gmail.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=smfrench@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727133339; a=rsa-sha256; cv=none; b=ltcUIpYfjLEg8RcgbTh2fly+H0CgkviRjtQ4+m4umL2k2ioGqd3d44NJ3ZpfvyHyV9PV9v cRF1uCD3C86d65DP7YUqq2+9cPzcMSTAE9NobsdA4M4ACvJv9MWy+x+DKx4P0hPFv1Mmqe LHbo0nEGwue0CGIpB5UH21piYpTIHa0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nBtos+EI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of smfrench@gmail.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=smfrench@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727133339; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ngRtzW5JM4PktiK1i50Y+IhfPwDmKMxpAqupnEmiErk=; b=qaCZIYUoxBFsGHFREjHMxusIXFbpBNqP4629KgSMOQkW7yYLh2DupKL6cxIPIPeiD/R4Kz 5B0aRypWhFvESe1pI4LTTC0UNltfFHDlx/Nfzik716FizfKieOGxzDZq9nsgnrYsK9BPNN ydSS5QZry0lDBTL13t0F3Di/47CbSj8= Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5c4146c7b28so6189057a12.2 for ; Mon, 23 Sep 2024 16:17:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727133434; x=1727738234; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ngRtzW5JM4PktiK1i50Y+IhfPwDmKMxpAqupnEmiErk=; b=nBtos+EIuDXotKLPu+jdX28tLmoaMLOGjavJMlIrrPdEQ1dbGngyNQqNys4RdejqVt vSNykik0b0vben46IKNeW4dyW41+QYjA3ARjJKTM+7e5Ve88vP5XjjABPv9BOdie85Ns hi+P2V/HSfBb6Wajf8Nj+7NrDRNqP9mgGwGo6TArXryxykStAs2bSZda9ki7hsf0mDGb 3e+1kh2EgdJxAkGnLXSyMoQDKlNhVpbhn7mxYEKiRGmh1iPimeI1DZcHW5lYjgE8fszR xqk0SJq4qNXzCUr8/R4qZvP83lp0n/VG+I+u1aoTuZiFKPDu4xl2AdHMGzuGIn2Mo7We Z8WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727133434; x=1727738234; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ngRtzW5JM4PktiK1i50Y+IhfPwDmKMxpAqupnEmiErk=; b=kHczoogt+VvQF3GOWdatIA4RvB6AmAHJL2gPar/g9z/LZ5DxoqfXokdiuQwrQWYWwL eXXZoZlJ+5aIa3BYR6SvqfoZAourSIEvOVZpIkhT74rIndvHl2eIy+lqTu1crVkPGbmn YHlIHU4l2dd0WI/EAAf4UZJApuJS4DozhM4eT6pQnLTJUMu9GcFukLwMoyEc2NtvRTnS Tj0DKufTlC61+3R+zyI+n3hVfN6kura714gVtD8JEZcJ431F4xOfLqrsqbtd7DUoeMe4 E2K4uDw4dQSw8hhJS2gz3R/2yARDVsW1oROSwYSU3P4Td8uJdA8G5zfd6y0INJeNSug2 TaSQ== X-Forwarded-Encrypted: i=1; AJvYcCWFnCvcz3A43E1hBBCU+Tu16o5CDg+nh7GW2EWuWRTH9OrX37hAx2Rkpe4ywCWEBRQITnUOl14REA==@kvack.org X-Gm-Message-State: AOJu0YzZLfLaSc1weKB6flJPrvOzCHqtESE3tdUvRF+JvtCwVzLwoXiZ EcQUAsv3oT7DlstjWMASDZ/TUy7ovZg9FxeGR/a8fOB1er2RFfGldoVBYlo43etvF+O28A48ePZ fGQXUWkETrEhJmPBPIy+6aL9bYB8= X-Google-Smtp-Source: AGHT+IH8LipBtLSxEtozQ2rg05n3Ixckwwsb8tD+R3wx/CmXcuSVcLfSG+Z/gs1ubLzXvUowuTAPkX6CdLZ8O6/puxQ= X-Received: by 2002:a05:6402:3506:b0:5c5:c2a7:d53a with SMTP id 4fb4d7f45d1cf-5c5c2a7d69amr3583016a12.12.1727133434103; Mon, 23 Sep 2024 16:17:14 -0700 (PDT) MIME-Version: 1.0 References: <20240923150756.902363-1-dhowells@redhat.com> <20240923150756.902363-2-dhowells@redhat.com> In-Reply-To: <20240923150756.902363-2-dhowells@redhat.com> From: Steve French Date: Mon, 23 Sep 2024 18:17:00 -0500 Message-ID: Subject: Re: [PATCH 1/8] netfs: Fix mtime/ctime update for mmapped writes To: David Howells Cc: Christian Brauner , Steve French , Marc Dionne , Paulo Alcantara , Jeff Layton , Matthew Wilcox , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel test robot Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E48C512000F X-Stat-Signature: kigh54ouiebqnkpkm37jo7ed9a1e7euu X-Rspam-User: X-HE-Tag: 1727133435-121276 X-HE-Meta: U2FsdGVkX1+NwTM23ZVvMFOktiVmAjpxYJG88V0ARhDuMpnizVWgVKKsjt/pRv8WFFc4PD6AvOZYKXZn+aDSd3uqb1xSy5SsZI3iLxmkkZyIMos9kqi+eSyZ3EUAZRczMi5StxRoPOqHP44LzIsqNfjWm+kpd2+lES8mdWwwCussi5zMbeUBkCmuMzPcc+Ivs5gAENBHB2o3ynf1DWFVJB6ow6IToxYphfBpqvY3gi0mjsNVHb1/FXOu6QIo7BI5+/9k+PmnfEfltOOB3PVPc7jdZ8v9LCkHXu4Qtjyh2ZLB6zVsy8po/3O4rpHEvAkYI+aUjaYexWA+1Rfhl/vFZXEV2IIApxxHbopR+PLS3ROConbdMo606ljQ/WD77EakiOCOVHlxDr3gm7bvdHUwNXPMtW2HQaV5lmZ9bp8VcAzJarU7UQtEffZwclp+DjIvQHB8Jl53OiH/oemG//i+8lQC2ocmZ1DHjZxBLDQd9U+kjdrhb/u6MwtJja+DurCApJYkZLQ0mUoPz1uHxzMw/SDaO9fPreQy7F+/Il2H2qmhWtO2uMuL1nCyTsC6vX/XwXRwQvzErgQaiC60us7Etmy1Sybg7rfAwgnBBKehciJiCmNuWUQYgO0NpDuJg0aD0bb6NXEZXBYzm73ihkjdYwQucp0oVDW8JTw/8SSYGGIy4jJToVBuNbucDOIrfApPTk1by5FzXQJMG0rIBJkXz9dMGJGSXWLXGdxZ5UYhh/QtVv0Ti0H+Pqss2D6zVw2OT/S1kyZj97dVUhsHZhUALZ+fRvtVdHajhDj+eXiZxxSd93ZJMIBt2gRIh4/VeJpHOCMwBHq3j+v91lXRFTKHVIkUDBj8yr2kJpI2giTkjXFfHIVKC9AQxacGIHgl9XSpc+s050Ib467U+ZwZ5oGh+exeEeGoiJWauB57QXvTyeu+NVwdJ6KGSfZYyOIXuCdEw5+zt+/sE9YqEZA84Z/ pJzbWjL4 JRSw1zyn1D2m9Iy8ZBuLbDXdbaeQV7WPBRYFz5P6va3mOgo5q7Vi8mujiykTViryibgtlNWDHo6uCgkXPoZr13sI8AbqJ6dIDFD0UkaK7iPEnEZM7vWcQb8hmyVR1QYOIhXweiA5L1VEPAeO9lJIcmppz5qt36C+HP49Xi3sLqJUmiXM7BBs4nbShBO4F+8c6E68M6HrM8geOFRPYAjilmOuH1uOFyo+viXlHmzCymWWY4iLzFpCgtK/FOKVlT2J1E5Z/FrIVL9dY5EYdDwK9gg25OWnWjr65P3YI9lbQqYB0iw7K81tMZ6EQrn/WIF3tXhoLRh6pkMT7lGcpHCRUayiUz1lTMe6t8rX00utKn4U6gq4kKAFCy/WgN6bE8k7xhA7BZmuF0OHGO6jFMj4gcyf+ff/FNDQcOUxmTJ7H2xLsZVrggZuAXJROprbsCRamE/TQEUcTfBcyps3+QO7KK2+CXCEmoBytEr+JXRZPlOGTs04+Scsj8GOiOjcwatzE/E6C X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: added to cifs-2.6.git for-next since it is important as it fixes a regression affecting cifs.ko On Mon, Sep 23, 2024 at 10:08=E2=80=AFAM David Howells wrote: > > The cifs flag CIFS_INO_MODIFIED_ATTR, which indicates that the mtime and > ctime need to be written back on close, got taken over by netfs as > NETFS_ICTX_MODIFIED_ATTR to avoid the need to call a function pointer to > set it. > > The flag gets set correctly on buffered writes, but doesn't get set by > netfs_page_mkwrite(), leading to occasional failures in generic/080 and > generic/215. > > Fix this by setting the flag in netfs_page_mkwrite(). > > Fixes: 73425800ac94 ("netfs, cifs: Move CIFS_INO_MODIFIED_ATTR to netfs_i= node") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-lkp/202409161629.98887b2-oliver.sang@i= ntel.com > Signed-off-by: David Howells > cc: Jeff Layton > cc: Steve French > cc: Paulo Alcantara > cc: linux-cifs@vger.kernel.org > cc: netfs@lists.linux.dev > cc: linux-fsdevel@vger.kernel.org > --- > fs/netfs/buffered_write.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/netfs/buffered_write.c b/fs/netfs/buffered_write.c > index d7eae597e54d..b3910dfcb56d 100644 > --- a/fs/netfs/buffered_write.c > +++ b/fs/netfs/buffered_write.c > @@ -552,6 +552,7 @@ vm_fault_t netfs_page_mkwrite(struct vm_fault *vmf, s= truct netfs_group *netfs_gr > trace_netfs_folio(folio, netfs_folio_trace_mkwrite); > netfs_set_group(folio, netfs_group); > file_update_time(file); > + set_bit(NETFS_ICTX_MODIFIED_ATTR, &ictx->flags); > if (ictx->ops->post_modify) > ictx->ops->post_modify(inode); > ret =3D VM_FAULT_LOCKED; > > --=20 Thanks, Steve