From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE091C7115D for ; Thu, 29 Aug 2024 02:48:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 776858D0008; Wed, 28 Aug 2024 22:48:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 724B28D0001; Wed, 28 Aug 2024 22:48:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59F708D0008; Wed, 28 Aug 2024 22:48:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 347D08D0001 for ; Wed, 28 Aug 2024 22:48:00 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 789981A091C for ; Thu, 29 Aug 2024 02:47:59 +0000 (UTC) X-FDA: 82503748278.18.F658ECE Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf16.hostedemail.com (Postfix) with ESMTP id 99A6918000E for ; Thu, 29 Aug 2024 02:47:57 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WtIR2o5D; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of smfrench@gmail.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=smfrench@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724899657; a=rsa-sha256; cv=none; b=h+bPbthHWPh1i570hkWrNm1vkjKU13C7PHQ6hcT6/Q3KpV6ZxJHzlIFzffEcZCunw5cQPX p2RZ/tWJO5u60A2MHqcQGrgmma/YIhM5Gq+Z4n61dUIhAnWo63hX04zltrhVpiW4nvQNx7 FX2IiYmyIT1OUqTx/iy6hZ2s9tr6fi8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WtIR2o5D; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of smfrench@gmail.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=smfrench@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724899657; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j8nW60xbKKK3BMmTEpx1vfAUyDbucJTsTqvhOF4FZ8U=; b=7e5t5P6qoqWTL96BobZyxLHWeXGZ9jqwdYZKjo+CIqX24Q2TK4CsspPjFT+UMTIxRxHuQQ i/FxMwyuBQGfEqJBeJNQZ1vrpG/XxUxr+V1M0w1hyMxR+YeFlIRpIPu3Uq/sCKqEDIPTrx YWe8ac4ijugAw9USlyPPS00bTPxedsI= Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2f025b94e07so1566501fa.0 for ; Wed, 28 Aug 2024 19:47:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724899676; x=1725504476; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=j8nW60xbKKK3BMmTEpx1vfAUyDbucJTsTqvhOF4FZ8U=; b=WtIR2o5DnkUfhDxgmNJYhr6sWbTgnETF84qV/m6I6ChSNOYNVVdm+wLjJzVH+dZVud 1KmUaRbCjAiN+pnO/d0YJVSHNOGjkerfBaeAWcr2DFn6YE7QXQPfmFfBAlMetCFgJ0o4 TD8FfAUV295Xol5xnvbxQvwFd1kfIW0WZu2Y9lplibO3d5tcelfjSlWV/sQWnjtue769 8RDTTscGhn4QkzI2/Pcm2JODXucwv50NlJ2gPnExw2uAZfgM0BNkypAT735pZGPyS/+2 3FSe9BvprloZBzKcTHf+EqQP7P5piq5Qf8MHLhts5tLWve9MOvOSbh0E5bmx384OLApr keNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724899676; x=1725504476; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j8nW60xbKKK3BMmTEpx1vfAUyDbucJTsTqvhOF4FZ8U=; b=HiTdA2/bcIdLxORXjZ/7HlBad5ftaDcDUKX5GgrWoK6nIvqPidPB0/rIjCswIqe4X6 SukMdsZL+nWJQGhkZmiXzwiU/KU+TUNb24d+Gze1Ts8FpqcAOW/ZbSIaS1byiY3012Na wiqczYxG/krVCb2fzdIXFlHnWyjTxnGQbhiE586OibtpUnPUOTBedHaLLgp16AcRUsmt dLNJ3TqclQIWgWF4xX4Uy4l89kfEx7qaByj5K9n1vr9t6a9janSO55e59lDFOLLsZTeT tsNdU15IiF0Fws5zSiCVV1AMOReWY1uiO3ZSuJAAitax/lU+nXEmPrc/wJ274U9kygZa FM7Q== X-Forwarded-Encrypted: i=1; AJvYcCU0Rxb72o+I4U4J3jttvGc3WeeqtsIfVsempC8jGjSJo9hRXe5vcbXdnyKqwUz3Z9ViRDF91++o0A==@kvack.org X-Gm-Message-State: AOJu0Yz2Rrce9Rjrwkw2KwBiJR77fEpf6gynRjK2t5daIJW5WDpKbPpS dSOZcy8/FhZyUBNOPXFvCP7zDI+uZfeAeO3jaKe/Mh8xJMLQdSyIiAIul2toXaoeUpcjcZQMG0Z Orvmj3S8fJ8nzTF3+F07gO9EFkKY= X-Google-Smtp-Source: AGHT+IFw6YFPE4uQg6imkFHXMbxtDADWvwTRJd5bZLVgOFxAE0atjLaGwN/Y3Vs2U2TCttK/XyhsIPdmUPLmGEsItEg= X-Received: by 2002:a05:6512:1055:b0:52c:db0a:a550 with SMTP id 2adb3069b0e04-5353e5aae01mr710771e87.42.1724899675197; Wed, 28 Aug 2024 19:47:55 -0700 (PDT) MIME-Version: 1.0 References: <20240828210249.1078637-1-dhowells@redhat.com> In-Reply-To: <20240828210249.1078637-1-dhowells@redhat.com> From: Steve French Date: Wed, 28 Aug 2024 21:47:43 -0500 Message-ID: Subject: Re: [PATCH 0/6] mm, netfs, cifs: Miscellaneous fixes To: David Howells Cc: Christian Brauner , Steve French , Paulo Alcantara , Tom Talpey , Dominique Martinet , Jeff Layton , Matthew Wilcox , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 99A6918000E X-Rspamd-Server: rspam01 X-Stat-Signature: 8nr16w5uzz3x4u7ikenfsokjb39e6cqh X-HE-Tag: 1724899677-196424 X-HE-Meta: U2FsdGVkX1/yg4Xdw+Hw4NHC3nORp+LjUpeXJ0SHbp3YzUL9HCfhvS7Nc/Bkormbz+4bqxgB4upRqyyZ/qsUtuz2Eyv1REHXPAAuMxVTfEuGisT6B1+4OrtcJPxqxvRnw+E0jhBCelCEwgEsoFvE8O3B0OXJvqezaoUs8EBqD6MXMnEPzhKnH5xPcS6GoN5pKwGq2FpYh0WfYofVyDD62MDQXsQVKHIBRjma7oyYD1loTZHr+yMk5QSUalABZ1Y0BzyNOp4KF0eAdrlrcs3eSfd7+bgp7ht77HYOoZpZcPJYJoYGh42aYlMsCU/m9nTovfGaNqGw4JiQQXzkbWzUdSeThjDYxKiyjofMBifraEUrSRpzDrn5JmbjAJ3yvK2BxhSeDNewJ3Zx5ftGHuSjE8lEZsJRkfbZPIPK0b5fpD0F/Kx1OvJ0ziO5M6KtjyM31oaFmejVz4fCOY8cTl2v5N8KbfkIVGkkLZrqlRAGBAnK3yRbaXYMh2hjvMcA7xrztrdr7iH1f5e6yN/5Cis4aKxkHaCayVLEctZVgTkcY2GxvXXGgDNxMPd7sytTscO8SLC7Phmx5elQGrkrD+4XobY6nOflaNE2FI+gmbn9Wn+TcFXXsCQRsJRWJ52MyAFeTh+FaGJnIlm7AntzrM167gfji8mr3AnHm8MnC6BYODUe75Z97uxBpYHYWmev/SFEkTB2bBAeW6e0RckgO81bzN6qDHVowOVZxFVZxYwHXCp4CQd3XwR6V/ZQheNSqZk2w/Tj23ZnuBz7aGugpQwssAW6yB2LJP1aXtp1qqzyS4ohJ6TINvYbBNWRanmC7vRdS2rc2fSI9VLzvK+Gbzwi8PjcB9W7QWR2vWOOh3xkPgGgmRS+VzHfM6GHItZIP5Gc95wvKFV3rqdzsJYtUtl5tyVGcRv1wdI93TPlVu2UoyIVcqBI/e/31P5UjAUi4V+McyENfCaz3beEXB2a5pA Ah2e/3fZ MVCOAJk73LA4ze1fDjA60Va9/eps6iCkOy8fKbVp+5seBwx+M53mXqlhF8Nz2EN9uSqt++eE2C6BzBmXHg/FB/Q+0/FZpkePPq6ISML5lTjC6h+wP5pjvwbqR3hIjleGZxypGW5daPFzoS0NNQDE8hKVftWUGsrwDOQZPv+S/n7ChLCDdmQzePy7hYH+AYU2OFwfIUn3rCAttz+9L3Fs6qCKseiINhf5xU0aGrHmIY7zNOriBaE6+g3n5JknXeS4HmHQ+6LMfMR9JvCc6T9GYL1sAkaiuRB4zg/6WMqkqjsgv1KakMxjGGiYXtwfwqp2W25ZFNQznVEpjl4OhAU1zkwG5Uf+w4MH7OKdzceRkr1C+hSsZUlQNz5iIfin5tOILiBGHjEhaZacSKAUpLRZBOTVVG6g+Z2kj1kX9qOybHtnZplc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: testing is going fine so far with David's series ontop of current mainline (I see one possible intermittent server bug failure - on test generic/728 - but no red flags testing so far) http://smb311-linux-testing.southcentralus.cloudapp.azure.com/#/builders/3/= builds/207 On Wed, Aug 28, 2024 at 4:03=E2=80=AFPM David Howells = wrote: > > Hi Christian, Steve, > > Firstly, here are some fixes to DIO read handling and the retrying of > reads, particularly in relation to cifs: > > (1) Fix the missing credit renegotiation in cifs on the retrying of read= s. > The credits we had ended with the original read (or the last retry) > and to perform a new read we need more credits otherwise the server > can reject our read with EINVAL. > > (2) Fix the handling of short DIO reads to avoid ENODATA when the read > retry tries to access a portion of the file after the EOF. > > Secondly, some patches fixing cifs copy and zero offload: > > (3) Fix cifs_file_copychunk_range() to not try to partially invalidate > folios that are only partly covered by the range, but rather flush > them back and invalidate them. > > (4) Fix filemap_invalidate_inode() to use the correct invalidation > function so that it doesn't leave partially invalidated folios hangi= ng > around (which may hide part of the result of an offloaded copy). > > (5) Fix smb3_zero_data() to correctly handle zeroing of data that's > buffered locally but not yet written back and with the EOF position = on > the server short of the local EOF position. > > Note that this will also affect afs and 9p, particularly with regard > to direct I/O writes. > > And finally, here's an adjustment to debugging statements: > > (6) Adjust three debugging output statements. Not strictly a fix, so > could be dropped. Including the subreq ID in some extra debug lines > helps a bit, though. > > The patches can also be found here: > > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs= .git/log/?h=3Dnetfs-fixes > > Thanks, > David > > David Howells (6): > cifs: Fix lack of credit renegotiation on read retry > netfs, cifs: Fix handling of short DIO read > cifs: Fix copy offload to flush destination region > mm: Fix filemap_invalidate_inode() to use > invalidate_inode_pages2_range() > cifs: Fix FALLOC_FL_ZERO_RANGE to preflush buffered part of target > region > netfs, cifs: Improve some debugging bits > > fs/netfs/io.c | 21 +++++++++++++------- > fs/smb/client/cifsfs.c | 21 ++++---------------- > fs/smb/client/cifsglob.h | 1 + > fs/smb/client/file.c | 37 ++++++++++++++++++++++++++++++++---- > fs/smb/client/smb2ops.c | 26 +++++++++++++++++++------ > fs/smb/client/smb2pdu.c | 41 +++++++++++++++++++++++++--------------- > fs/smb/client/trace.h | 1 + > include/linux/netfs.h | 1 + > mm/filemap.c | 2 +- > 9 files changed, 101 insertions(+), 50 deletions(-) > > --=20 Thanks, Steve