From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6774AC27C53 for ; Wed, 19 Jun 2024 03:48:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5AE9D8D0071; Tue, 18 Jun 2024 23:48:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55E578D004F; Tue, 18 Jun 2024 23:48:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44D288D0071; Tue, 18 Jun 2024 23:48:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 271058D004F for ; Tue, 18 Jun 2024 23:48:31 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 85437160CC0 for ; Wed, 19 Jun 2024 03:48:30 +0000 (UTC) X-FDA: 82246255980.27.D48825F Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf25.hostedemail.com (Postfix) with ESMTP id 9F3DCA0013 for ; Wed, 19 Jun 2024 03:48:27 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Yyefwbsf; spf=pass (imf25.hostedemail.com: domain of smfrench@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=smfrench@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718768903; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WTs878KkXlqzxGj0uXlKXHSIubOq6sDbDNm56Av1SWw=; b=zv2hDIE1NYC9BS8rqUpKx9deSN8IjoLDLtrJMp8ke7w0QbyIJ2VsVw8kqacuedDNoD9rd0 1v+c4QqSUJec2eXhPORT+szIK+ihUUqc1N9yV2IkkLyBPKtPBrsIqBtFD5nPmBYZ7x64Wr CgQZ8VcSmQ7Zb9VLUI2F7XZA0mYn8SU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Yyefwbsf; spf=pass (imf25.hostedemail.com: domain of smfrench@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=smfrench@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718768903; a=rsa-sha256; cv=none; b=lemS+ubcm1OwxXcyyhZO5l+4i4cgUX7m5BCuBi1y0aKBXB0jg1QO5lKUARlkS4FtsyxpQa P5BHKokeWBvQGi3FvVD0LrSbGO9g0TOJGsPHT3YSQDES62b8qgH8SupBVHfRi4otO2Bj1C DvLHgnVaY4AOD5+uOgpkfGBty0bU/Hc= Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2eae5b2ddd8so4062381fa.0 for ; Tue, 18 Jun 2024 20:48:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718768906; x=1719373706; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=WTs878KkXlqzxGj0uXlKXHSIubOq6sDbDNm56Av1SWw=; b=YyefwbsflxdmDcunH9F06PTvklu1M5n7cAcwMNUHQzP+/k2WIKHLKWIQALiLfYOkHT u9jBf17cLSEa7yfIwYffdsqRc7+hMd39LB9WMGCUAuAuwoYy/1BRlDACv4olwGx3TXD9 O+ziDPzS6HWhyH7zy+gfA+JIWMP8IhFd+SH9InCtF/dk4szFW0kjYKpKndjNc8Zz+5Rm 2FGT+DKISUr4T29KpZJcywpKFly8uuAJ9ULWE0xuq7QmG+XyI2Y08kOA4nXsySjcWgq5 IXrqeTYlaFgXV/0i6VdD4NIOW8HcVrEUiEfw8BBRaIrqbNGLVrCXJbdBsiEh3JDM+94r 2WbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718768906; x=1719373706; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WTs878KkXlqzxGj0uXlKXHSIubOq6sDbDNm56Av1SWw=; b=SPxF7uTiYvyTJGX+naNlUcltcbenr5B+DUue8aWEHRBnggP5PKq1EcAFHN1m5XA/g2 tEfECiRfyw5upEju+1bEf38GePr1Hl29nGjIz4VsY77N745mysTmLuzrdmshN6JhmP1E dt7yhU9wp7qGTGRkpc11C9MaVvCRvxoUJf4lQLURmsHs8pb09jjatfRQfFC/Gq/USx2w 5Kx5907oN8iN45AYU6rmzMxxi1i9RM217NdI0uQiw8XD7LUsEidlFjCvl30ssyLJWB1p MVkjy+JF7LuLiF2TlW6U2SZn4zt6qn6AAo6tcMsyqE5RRAT4CmuNd/5bFH6nes5kyhcw QDXg== X-Forwarded-Encrypted: i=1; AJvYcCXcOJy1p9ZVwr/Tkdzrq46tb8U5qV3X3NmKHCnjc4083GwUDO2BH8lUXclZBJ4ZawoCuRazrldHb822T8cezCbtlh0= X-Gm-Message-State: AOJu0YyiFCqKKcqSFAxAM/Z5neW2T46Nvey/H0m1qN4+f0A44prl6poZ NZ9FPQd49DGVu/NSNAaM3gLgDKCSRt4oSPjI1SOVwpfVBCIsdcALgWmbURhXk4P4LLVNf/vNdHv H0LgLa+WFdD4/jNXkhjG7IRtbLLw= X-Google-Smtp-Source: AGHT+IGjAGLvyYuDf8LuG/E/dDXfEI2mrgjgklDd7BSafpgR/EBEDzQc41Yy0M+KsNQKzIhwYIuf9ka/esO/dm8BZfk= X-Received: by 2002:a2e:9d90:0:b0:2ec:3747:fcc4 with SMTP id 38308e7fff4ca-2ec374800b1mr9524231fa.5.1718768905387; Tue, 18 Jun 2024 20:48:25 -0700 (PDT) MIME-Version: 1.0 References: <20240618072258.33128-1-21cnbao@gmail.com> In-Reply-To: <20240618072258.33128-1-21cnbao@gmail.com> From: Steve French Date: Tue, 18 Jun 2024 22:48:13 -0500 Message-ID: Subject: Re: [PATCH v2] cifs: drop the incorrect assertion in cifs_swap_rw() To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-cifs@vger.kernel.org, linux-mm@kvack.org, sfrench@samba.org, anna@kernel.org, chrisl@kernel.org, hanchuanhua@oppo.com, hch@lst.de, jlayton@kernel.org, linux-nfs@vger.kernel.org, neilb@suse.de, ryan.roberts@arm.com, stable@vger.kernel.org, trondmy@kernel.org, v-songbaohua@oppo.com, ying.huang@intel.com, Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM Content-Type: multipart/alternative; boundary="0000000000000e83b4061b361242" X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 9F3DCA0013 X-Stat-Signature: n3ssczeoa7bf3esh68os7wzg5bacdm5q X-Rspam-User: X-HE-Tag: 1718768907-221176 X-HE-Meta: U2FsdGVkX19hNTefSv6kWfEOV5L1ZDX9vj/X8j6LD1brEySVu51iaoBcg09JTXZZ/t0k3g2K5uA2I5e8ypR5Ab3YEK8U2UwWGOfj3/rcig84VVXNPAbg9+OWwQrtCSe0aZHMk0V6jLEeeufinPUZdqircX1i2wS8gNiwFD2CJFxtgCPmEKy51cJuYRSmKFdhHwtGzn9XO/qhTOHv3ADQ4WkdjSUj9RuNntxekx6cNVhaDeLJuR4oj8MzxFPf7U80JrqKVurXATJLP7Dv5oTxL4sOqhGT/RWoXSew7qzsr9ETmzWg3igLj19pDWxURHK3dbZ2o8A1SfKalw0Re9baT3dMg2NaMkb308GeRT2KyoWeItH3vhLx3KUqMmIUwqUA/x70bLVw5sLh6a5FN1VUBB6KfG97OaMfVTuZ3thn9ZefXc1NOHf90yGCo02+Z79Pq2jX94dROOE4WNjYIyNSGqseznwqXxss7iASJbQ/h9pdpHAt9ZRliHcVWqVCKxql7XIBRqOnt3K5wOVRNgHQC5KOHpZTM4liyJi16VykqAtW7vvGHzIlnBArtXnG5PCOUJIN9mLK7VFY5rjSLE49yvEAEZvAD/xzuhN/pBvF/SgdyOf0foczxZC+qi1nd+dQeRn4YB1Ue/E91vt17TkIytqiC6l1u8yERRfKx+fuZyclbsBJj6syBtco6L9Et1OmmtDJ7+fRNoxd31c4F7DagdiNOV4skZAlTIIMiPCefPIfTbGv7neMEJ+J9WeMoa/o+a5YQOLhqUEmQJq39At9Wu9G+bB2pucj4CjKTA+GX19qNtSk3EJ+QIsBQtaEcYABcywzEmQo+ikyoJqIEu+nx8IMRpMqcJDt7DVDDWHlatFaUOyS3+a+/jUI+Q7iQ0fE4eNCdxy10PaQKEuNfYmmof1qqoeXbnNYw/gZ4QCq0iIIYx3twI+SeCP2UrNZkaINvBG7VDBSCE/YXL2ezfl Sl2z2kDR V54+6oxpezVc2c9wNlcF7oE+TQNuGz8ySh3EwMVtSSqicfOPIhHCsoBi9AYNcvj1hKBKt+mA/H+A7Bbl51ixwyw6Wv3pwQr8BwhdFJxC/1njRsY+Su1tVzOHVfSzPzzxQOsJNVQJ6qAm4pIecXWnYQj/OrNwpEVJ6Ki1Ro5Zq+FwM07bu+v94d2wCifdbGyRC/8ZcASt1oy2Fj/yYJ4fQLwi/03/KJxIb+iPLsdKQ7CsbDA6ZFq5bnqgCgufSFKNpXbmVxK743aXT7MUvr0BH+ZzhfOd1tB3UQCK4pOsBzLoZvfS2AjF5F7XIBGlTfp/7xiXLmHDdraheRm7dOXD6M+sJDkLmkz4RMN3t4WFVMvJJlbV6kHCF/mqBlBAmFM8MaMfrMwrkYv+EUYFcFmdSKsyTzP6AgwK+5jtQkA1Odnbis5wefsO8ubaQhGS4HhyVYoTDTD65F0cW4AtQbKPH9412QajZZ9shonReqt/PMagLIgma8pf3aEtbrIhYcvC32vuGHr4E4JtV1yQbT2gma6aeUWXfdNSdahgtCscX2gceyXJuDjIovPTsOAZsshecG9OeSMM9MFpXIEIkIlW4evps10tNlbdwDa/rc8DFRYF7xA+AIxX1sQwpuRT0jAffnTyIiLtTckaZA8trnkNVkA48o80nqIezU3fGorqvdOMJW5eCt+LBdknfnD5XrhYS3+7G+Pi0F3n1xQ5ZUZvdIQNb57rOSAQdmIledcPzBSuvC1H0Lf4u6JAAcfjvOQ6rHWaAZCBJWCp3JNnZ7gQiYI60oge1w1IJGXxXGELwxbcHK5088juibc3c0QTx/MgYp0+vnAituZhHD10= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --0000000000000e83b4061b361242 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable tentatively merged into cifs-2.6.git for-next pending testing and any additional review On Tue, Jun 18, 2024 at 3:56=E2=80=AFAM Barry Song <21cnbao@gmail.com> wrot= e: > From: Barry Song > > Since commit 2282679fb20b ("mm: submit multipage write for SWP_FS_OPS > swap-space"), we can plug multiple pages then unplug them all together. > That means iov_iter_count(iter) could be way bigger than PAGE_SIZE, it > actually equals the size of iov_iter_npages(iter, INT_MAX). > > Note this issue has nothing to do with large folios as we don't support > THP_SWPOUT to non-block devices. > > Fixes: 2282679fb20b ("mm: submit multipage write for SWP_FS_OPS > swap-space") > Reported-by: Christoph Hellwig > Closes: > https://lore.kernel.org/linux-mm/20240614100329.1203579-1-hch@lst.de/ > Cc: NeilBrown > Cc: Anna Schumaker > Cc: Steve French > Cc: Trond Myklebust > Cc: Chuanhua Han > Cc: Ryan Roberts > Cc: Chris Li > Cc: "Huang, Ying" > Cc: Jeff Layton > Cc: Paulo Alcantara > Cc: Ronnie Sahlberg > Cc: Shyam Prasad N > Cc: Tom Talpey > Cc: Bharath SM > Cc: > Signed-off-by: Barry Song > --- > -v2: > * drop the assertion instead of fixing the assertion. > per the comments of Willy, Christoph in nfs thread. > > fs/smb/client/file.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/smb/client/file.c b/fs/smb/client/file.c > index 9d5c2440abfc..1e269e0bc75b 100644 > --- a/fs/smb/client/file.c > +++ b/fs/smb/client/file.c > @@ -3200,8 +3200,6 @@ static int cifs_swap_rw(struct kiocb *iocb, struct > iov_iter *iter) > { > ssize_t ret; > > - WARN_ON_ONCE(iov_iter_count(iter) !=3D PAGE_SIZE); > - > if (iov_iter_rw(iter) =3D=3D READ) > ret =3D netfs_unbuffered_read_iter_locked(iocb, iter); > else > -- > 2.34.1 > > > --=20 Thanks, Steve --0000000000000e83b4061b361242 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
tentatively merged into cifs-2.6.git for-next pending test= ing and any additional review

On Tue, Jun 18, 2024 at 3:56=E2=80=AFAM Barry= Song <21cnbao@gmail.com> wr= ote:
From: Barry= Song <v-song= baohua@oppo.com>

Since commit 2282679fb20b ("mm: submit multipage write for SWP_FS_OPS<= br> swap-space"), we can plug multiple pages then unplug them all together= .
That means iov_iter_count(iter) could be way bigger than PAGE_SIZE, it
actually equals the size of iov_iter_npages(iter, INT_MAX).

Note this issue has nothing to do with large folios as we don't support=
THP_SWPOUT to non-block devices.

Fixes: 2282679fb20b ("mm: submit multipage write for SWP_FS_OPS swap-s= pace")
Reported-by: Christoph Hellwig <hch@lst.de>
Closes: https://lore.kernel.org= /linux-mm/20240614100329.1203579-1-hch@lst.de/
Cc: NeilBrown <neilb@= suse.de>
Cc: Anna Schumaker <anna@kernel.org>
Cc: Steve French <sfrench@samba.org>
Cc: Trond Myklebust <trondmy@kernel.org>
Cc: Chuanhua Han <hanchuanhua@oppo.com>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Chris Li <chr= isl@kernel.org>
Cc: "Huang, Ying" <ying.huang@intel.com>
Cc: Jeff Layton <jlayton@kernel.org>
Cc: Paulo Alcantara <pc@manguebit.com>
Cc: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Cc: Shyam Prasad N <sprasad@microsoft.com>
Cc: Tom Talpey <tom@= talpey.com>
Cc: Bharath SM <bharathsm@microsoft.com>
Cc: <stable@= vger.kernel.org>
Signed-off-by: Barry Song <v-songbaohua@oppo.com>
---
=C2=A0-v2:
=C2=A0* drop the assertion instead of fixing the assertion.
=C2=A0 =C2=A0per the comments of Willy, Christoph in nfs thread.

=C2=A0fs/smb/client/file.c | 2 --
=C2=A01 file changed, 2 deletions(-)

diff --git a/fs/smb/client/file.c b/fs/smb/client/file.c
index 9d5c2440abfc..1e269e0bc75b 100644
--- a/fs/smb/client/file.c
+++ b/fs/smb/client/file.c
@@ -3200,8 +3200,6 @@ static int cifs_swap_rw(struct kiocb *iocb, struct io= v_iter *iter)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0 =C2=A0 ssize_t ret;

-=C2=A0 =C2=A0 =C2=A0 =C2=A0WARN_ON_ONCE(iov_iter_count(iter) !=3D PAGE_SIZ= E);
-
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (iov_iter_rw(iter) =3D=3D READ)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ret =3D netfs_unbuf= fered_read_iter_locked(iocb, iter);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 else
--
2.34.1




--
Th= anks,

Steve
--0000000000000e83b4061b361242--