From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 224CFC52D6F for ; Tue, 27 Aug 2024 05:03:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 937EF6B007B; Tue, 27 Aug 2024 01:02:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E7B86B0082; Tue, 27 Aug 2024 01:02:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7AF386B0083; Tue, 27 Aug 2024 01:02:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5DEEB6B007B for ; Tue, 27 Aug 2024 01:02:59 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F0B591215FB for ; Tue, 27 Aug 2024 05:02:58 +0000 (UTC) X-FDA: 82496830836.05.31B38B4 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf11.hostedemail.com (Postfix) with ESMTP id 14B724000C for ; Tue, 27 Aug 2024 05:02:56 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZqnwhrL1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of smfrench@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=smfrench@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724734957; a=rsa-sha256; cv=none; b=k9iicwpwSpxOKltufD5xahxHm8B6ckJOZr3Hd9Xkwr3DO+VvFGy12U4VLZArboRsgTWUdR sCpa5vShcfjmQ2k+qinI5JrVQujgDLdgIj2wBVEyLaeiqFrWSLzPYo8cXS9PdrUc1UOrXN 8HM8xsbHpyqiYvYAZyx085mNC2NDPYM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZqnwhrL1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of smfrench@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=smfrench@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724734957; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G1tPrUcxqAg1dhruM6WccigDNxnQ/dFY9k4RpKAhaVQ=; b=cChDvikaKYRkEIVCDL2hOOpm30JC6BWd6zhRykp601/083ORgcXGVN8MN657wDCIGwRe0e fkoLgDf3H2oSrUPN7fXRpxzhLzpigB0QK0sxPEGFX9iQiWe87lI2TxQSEG63QeSjQ/0hTX HzBWqm4uJaFqJD7FRtIFKTqc0DVaRYI= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-5333b2fbedaso8364752e87.0 for ; Mon, 26 Aug 2024 22:02:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724734975; x=1725339775; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=G1tPrUcxqAg1dhruM6WccigDNxnQ/dFY9k4RpKAhaVQ=; b=ZqnwhrL1+I4bG2LGh32zWPuU30y8zGYY78x0kHB50H+w4pB81XaTxA9fcp2JWMyLOz 5IQpeKIh5rtO6RmtRL8vtrMlF8aaQg8E3axqwjJuzWGKnu1mERGs+NL2Qdwj8TMu4Ctl AzZYitbFIak3bDjOAdL5/bZHLy2DvlncstfzZ/eCb3ts57XJEimjWz3djzuHmvM3lTDH 21ra1bqilwK9VkzCkLFfB9VK4aeXWoWX0FbTFGdurs8jaovOyzXa2lbd63wNBAW7H7R/ Ov7CkvJxVnzl7lvi3SOjTQui3R4pXqlYCyiXsQUqGunVh72073DxbXosLRwdz8RfhpXN 2HSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724734975; x=1725339775; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G1tPrUcxqAg1dhruM6WccigDNxnQ/dFY9k4RpKAhaVQ=; b=Xkh3oj5YsxS4NCdvBFmDcDQKYFmHZHPVXYjut/I3n+pY7df+hTZnRvSLoLMqhFRBbI J71lOxtzeuBt9pFHcxomvsHKl8LFUVy3PcU+St0eU+TeWABLTCEIC6kD6NuXuBjimd36 fH9qItXT4hFT+IiCp7MJsV62quFJnbP37ZOz28LQDb4HMUJZjU4mJ+RIzNviGfnALcbu LP0xUvCVAPPmWRX0gh9o0dnY3RvW9OYao98aAs679/TjoyIrukjaZwIWZNqwkZwfU52F OUIgxq8PE/4i2lzY8PdlSxSWohf1tTTyBME626P+tfUa9nxz4/9BHjco0hiY9h/aRjAo HB6Q== X-Forwarded-Encrypted: i=1; AJvYcCUkPf1l3PBjjcdSMFVJDYoa69cqZ9VAueEI30FWb8NfTKI7eaE9M0InFwhhQ0xhnX6P4Md+gu072g==@kvack.org X-Gm-Message-State: AOJu0YxIuGKBPQ+WsrDAKQedZeb4tS/M3SVfMGd4dTrvNG5/nxqTx/pP R4rm33M1NW3yUOuO93TZpPu2TqLWfXf4P8rRs8oU0uPbczFcXtFds+7wL8QJngIgSxmmwVRoCPN sSWAWx0+n1keZGFAiEfUWZ50OP3c= X-Google-Smtp-Source: AGHT+IEOrUFWw153PpKJ3xQn15rauhXsECsIYW+gk4XwZMm21Fv4vuqd+UVgtsNTZLpMz8YCZ3pmYmlPkiXIS9hAPok= X-Received: by 2002:a05:6512:3b27:b0:52e:f2a6:8e1a with SMTP id 2adb3069b0e04-5344e3de28emr1038984e87.29.1724734975021; Mon, 26 Aug 2024 22:02:55 -0700 (PDT) MIME-Version: 1.0 References: <37fncjpgsq45becdf2pdju0idf3hj3dtmb@sonic.net> In-Reply-To: From: Steve French Date: Tue, 27 Aug 2024 00:02:43 -0500 Message-ID: Subject: Re: [REGRESSION] cifs: Subreq overread in dmesg, invalid argument & no data available in apps To: Dominique Martinet Cc: Forest , David Howells , Steve French , Shyam Prasad N , Rohith Surabattula , Jeff Layton , linux-cifs@vger.kernel.org, netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, regressions@lists.linux.dev, Christian Brauner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 14B724000C X-Rspamd-Server: rspam01 X-Stat-Signature: wjk34spo9gbrbhjdc9gzi7ayyxcqpofh X-HE-Tag: 1724734976-129331 X-HE-Meta: U2FsdGVkX1//qmrfC0vDH+ttQXj/azhoGPIvzbS+O/C/TE2Uq81AVSX0tbfNJLxPr4G3z8LyiUaKP5Oi14CUx28Zc4ynBPUtXyf06WLtQAB5IfCOGz3IimtewNAB5FsbtRPFfeITTCnOhQkUTLDl+6DuoQa8f3ZoPFkSL0E2ERnBN2nNXYeoA18r1UXa9ZGRW64shigfdPlSXL5FIuimc5VnUqSAKGVfhiNUYshp19qU+Cmol1Kz9Q3U7AajpsBYX1LODv3EAZepkINuYImJG+tQv+mWvmYtM+YFGykS29gw8k4jNmyvbKBy8LqWgvMT+ISaYXJmsU4QZsaVtSi4/123rNAUQc9AiC1kI39r39yVn7YcOUfg0l3hE74TTxoHXD9r6/qns06QPMSBhUWw6UwBw9LfS5rK/ime0yLoCMmien6lNq0c/bV+Wo5KGX8DQSCgELe5bnjRQInaDzzuea9RoU5RSPeATdHM21mm4WJvOakuLDxldIk7xPc3dSw6nmM7nKIEZGtTTqkcbY1ROGBddHlfu4ujuqxuPtEr4ZeiMwQWxjOwZqhDqHoXqfpHX5zfE6c1UGneqnph3r52dcEjWFVqn4QmQi2tM9nEjSF+Db318CysyUWh7mxYtPcRLl+p5cfp+yBKqCOF/47Rv/o8QDP+fG7ZPXQcEul7wLa4xVRaceOrrUBbGQyDGMkyvWPYkQNfvLmk3P2mn+MnUQClnFkfAQlOuzKjJNtLniH+mnJufiLw1L6jFnc/jKxFL95nz8h7vmSotKYYHsBw67oUaU74llsT8TTI+kp35zhQ7J+qkKbCH5BkMmVH9kznzl+3sYv1MkSG9jPbyO3xzszrziaDDrsUMplz9G1nG3Ng2EXIcSXWwmplKI/wQ0SJs2SUXGyn7EdTy644ib4UPI1wiy8YCIT2WgyiFEcSuRSzk4H7Ra1UkVlsNHvNkn3BsCwzK6KwOp7FtyYeJrR ngdNaAMG AAJFOdqVG2IJLp7fg/XwyLtnA5fgRjYvbj7gAn9872hOdDaqapf/xZnm9AmRsmIVc5GyZX1x3GC90M/LqAfa8uN6mKkcjIuTdg4O+io5dTMr3+ZdhNxZcfmKlNZTPP8Up293zCufNFcM1SB6jz1uP44chBTNepdCWnyBViilbH5OfUsgnXJyAH31xxE1+ePHGqa8EEyuqEy6AJvtgMOc+h0NxwRhtr6XN5WUm6pT62bhvjzMn2DKy7XTof4YKnUPmkwzXsT0hDo4sd/QXvmS7TbHITVvN9O9XVdZeTNZJVVPolBkhBFvrDDt608aUCXCpIQPc3Wp0tZpGCwsz1M//tLw123lHDCuNkbsuKbU5LdgJJ4ctLwMY2w5w+tBWBzFL2WsEPUtxMemVelRvdF5g4mA7Cwjh3vfh/ibKXnIBdv2EML31zzI4tgHL9rJ/n3Gtwg0axNdaELY7QH2LyngsA/XOuCBgrdTiETHOWhA7bUKFpCsKqX3ekEOgwsXqOF1dqmsN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000024, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 26, 2024 at 11:38=E2=80=AFPM Dominique Martinet wrote: > > Steve French wrote on Mon, Aug 26, 2024 at 11:27:33PM -0500: > > I have also confirmed your theory that the regressions (there are > > multiple) were likely caused by the netfs change added between > > 6.11-rc3 and 6.11-rc4: > > " 9p: Fix DIO read through netfs" > > > > But reverting the cifs.ko part of that patch alters the error but does > > not completely fix the problem, so the netfs change is also related > > David sent a bunch of cifs fixes including this patch: > https://lore.kernel.org/r/20240823200819.532106-8-dhowells@redhat.com > "netfs, cifs: Fix handling of short DIO read" > > > I don't have any samba server around to try myself, did you have a > chance to have a look? Yes - I just verified that David's latest branch does fix the problem you reported (ie "cat foo" and "xxd foo" on mounts to Samba) I ran with 12 patches (listed below) of David on top of 6.11-rc5 (and 3 unrelated patches from my for-next branch), but most of his patches are not in linux-next yet 540511907bbf (HEAD -> for-next, origin/for-next, origin/HEAD) netfs, cifs: Fix handling of short DIO read 76b6078dcc72 cifs: Fix lack of credit renegotiation on read retry de7b2d4f8789 netfs: Fix interaction of streaming writes with zero-point tra= cker 0d718d75935d netfs: Fix missing iterator reset on retry of short read eb54e19d9cb8 netfs: Fix trimming of streaming-write folios in netfs_inval_folio() b10b7505454c netfs: Fix netfs_release_folio() to say no if folio dirty 5fee95cba515 mm: Fix missing folio invalidation calls during truncation 68c4ccecdf68 backing-file: convert to using fops->splice_write 65a5aad19a17 Revert "pidfd: prevent creation of pidfds for kthreads" 3e99ab871c90 netfs, ceph: Partially revert "netfs: Replace PG_fscache by setting folio->private and marking dirty" 06f646e2d0d4 netfs, cifs: Improve some debugging bits 416871f4fb84 cifs: Fix FALLOC_FL_PUNCH_HOLE support 017d17017436 smb/client: fix rdma usage in smb2_async_writev() b608e2c31878 smb/client: remove unused rq_iter_size from struct smb_rqst c724b2ab6a46 smb/client: avoid dereferencing rdata=3DNULL in smb2_new_read_= req() --=20 Thanks, Steve