From: Steve French <smfrench@gmail.com>
To: Dominique Martinet <asmadeus@codewreck.org>
Cc: Forest <forestix@nom.one>, David Howells <dhowells@redhat.com>,
Steve French <sfrench@samba.org>,
Shyam Prasad N <nspmangalore@gmail.com>,
Rohith Surabattula <rohiths.msft@gmail.com>,
Jeff Layton <jlayton@kernel.org>,
linux-cifs@vger.kernel.org, netfs@lists.linux.dev,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
regressions@lists.linux.dev,
Christian Brauner <brauner@kernel.org>
Subject: Re: [REGRESSION] cifs: Subreq overread in dmesg, invalid argument & no data available in apps
Date: Tue, 27 Aug 2024 00:02:43 -0500 [thread overview]
Message-ID: <CAH2r5mtCi52Fd_OZE_8Fnd3SmTsD3SUkj1CEsU6jw38wTuxskw@mail.gmail.com> (raw)
In-Reply-To: <Zs1YKh8H0dEX126X@codewreck.org>
On Mon, Aug 26, 2024 at 11:38 PM Dominique Martinet
<asmadeus@codewreck.org> wrote:
>
> Steve French wrote on Mon, Aug 26, 2024 at 11:27:33PM -0500:
> > I have also confirmed your theory that the regressions (there are
> > multiple) were likely caused by the netfs change added between
> > 6.11-rc3 and 6.11-rc4:
> > " 9p: Fix DIO read through netfs"
> >
> > But reverting the cifs.ko part of that patch alters the error but does
> > not completely fix the problem, so the netfs change is also related
>
> David sent a bunch of cifs fixes including this patch:
> https://lore.kernel.org/r/20240823200819.532106-8-dhowells@redhat.com
> "netfs, cifs: Fix handling of short DIO read"
>
>
> I don't have any samba server around to try myself, did you have a
> chance to have a look?
Yes - I just verified that David's latest branch does fix the problem
you reported (ie "cat foo" and "xxd foo" on mounts to Samba)
I ran with 12 patches (listed below) of David on top of 6.11-rc5 (and
3 unrelated patches from my for-next branch), but most
of his patches are not in linux-next yet
540511907bbf (HEAD -> for-next, origin/for-next, origin/HEAD) netfs,
cifs: Fix handling of short DIO read
76b6078dcc72 cifs: Fix lack of credit renegotiation on read retry
de7b2d4f8789 netfs: Fix interaction of streaming writes with zero-point tracker
0d718d75935d netfs: Fix missing iterator reset on retry of short read
eb54e19d9cb8 netfs: Fix trimming of streaming-write folios in
netfs_inval_folio()
b10b7505454c netfs: Fix netfs_release_folio() to say no if folio dirty
5fee95cba515 mm: Fix missing folio invalidation calls during truncation
68c4ccecdf68 backing-file: convert to using fops->splice_write
65a5aad19a17 Revert "pidfd: prevent creation of pidfds for kthreads"
3e99ab871c90 netfs, ceph: Partially revert "netfs: Replace PG_fscache
by setting folio->private and marking dirty"
06f646e2d0d4 netfs, cifs: Improve some debugging bits
416871f4fb84 cifs: Fix FALLOC_FL_PUNCH_HOLE support
017d17017436 smb/client: fix rdma usage in smb2_async_writev()
b608e2c31878 smb/client: remove unused rq_iter_size from struct smb_rqst
c724b2ab6a46 smb/client: avoid dereferencing rdata=NULL in smb2_new_read_req()
--
Thanks,
Steve
next prev parent reply other threads:[~2024-08-27 5:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-25 23:26 Forest
2024-08-27 3:32 ` Steve French
2024-08-27 4:27 ` Steve French
2024-08-27 4:38 ` Dominique Martinet
2024-08-27 5:02 ` Steve French [this message]
2024-08-27 18:15 ` Forest
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH2r5mtCi52Fd_OZE_8Fnd3SmTsD3SUkj1CEsU6jw38wTuxskw@mail.gmail.com \
--to=smfrench@gmail.com \
--cc=asmadeus@codewreck.org \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=forestix@nom.one \
--cc=jlayton@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netfs@lists.linux.dev \
--cc=nspmangalore@gmail.com \
--cc=regressions@lists.linux.dev \
--cc=rohiths.msft@gmail.com \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox