From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFC39C4707B for ; Sat, 13 Jan 2024 05:21:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28A6B6B008C; Sat, 13 Jan 2024 00:21:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 23A7C6B0093; Sat, 13 Jan 2024 00:21:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DCBF6B0095; Sat, 13 Jan 2024 00:21:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EEC4E6B008C for ; Sat, 13 Jan 2024 00:21:09 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BE294405A8 for ; Sat, 13 Jan 2024 05:21:09 +0000 (UTC) X-FDA: 81673139058.25.95DC0B9 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf10.hostedemail.com (Postfix) with ESMTP id DA6C0C0006 for ; Sat, 13 Jan 2024 05:21:07 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=E+DKtXaG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of smfrench@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=smfrench@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705123268; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0ATnlsK6lgODy5NUJw0CqklMcLHoFP3eiosAXvJ+YZ8=; b=VMiU6/PcSSObFyeP6WgRqti1fSYhuo9gN+eROwZkEo6Y/rvNaQaUyq+dhIWchc0pUYKxD7 BXCEOXn7zK2EwpA3y3Ty7Du7k+MLtNJYVEcOEfRrP01s4X+n46S5yFvf65xRIXMFIoWDPX dmYPyn9+p1ANW+MvK9wNwDz035vFgBM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=E+DKtXaG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of smfrench@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=smfrench@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705123268; a=rsa-sha256; cv=none; b=Uz0x2UJZdw0AKx/ZK9XNdK5c5w0xSpQky4InvmnqZqBepuK4rCcL23MfMsw5yqnUTTaGyE Zuc23NFeKMlPCYKFEhYXW7SjcswXTGRAqPNwkwAclgVOADFpNuu7xLfKkmcH/Ts4fAcC8T a0cu0cup5jrF1AyRlcdQvEr90t2YR1o= Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2cd880ceaf2so29134281fa.2 for ; Fri, 12 Jan 2024 21:21:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705123266; x=1705728066; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0ATnlsK6lgODy5NUJw0CqklMcLHoFP3eiosAXvJ+YZ8=; b=E+DKtXaG69pUQlDK/bh3Qe3wVyztmjrvx1cHTJEu85qd5TGgL6TtVShujs2kD5Mn26 2lh5zwd5RvEDg9zLG3X78hA13w4p4MTPqj/i+8lC/JloDQkRTVU5YVz/T12fwvXmuElo B91zg7VqGTpcHGh8cl8usQ1UUWhxJICzoNGA3GXqdh0GiGYf52en0ilHuunD0c3GG7Zd RhgqFmt/bQY3luLRu7YAQs1pU3/Sz4wA6QKGrgoxaCB239z0+JBPPw2vYyXlRynGt3Jz En0MY6+XhTt1dif6S3Wisudi/dd8qCiplqudLe34yEkPaCKCGO1hRdDhE0r+gviG8F03 rDRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705123266; x=1705728066; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0ATnlsK6lgODy5NUJw0CqklMcLHoFP3eiosAXvJ+YZ8=; b=k9penogQn8mMD31fDHe9U24/zDpA7HGR1CJR9orF/31VdBDgHutdOWsHQSNFC5DUtg AQ7JfXPbQm1low8cNBtFDnaeQrcp/dbQMM3J8gTIHQQ02bW6b9y4G4ZmPCm6gts/3GDi UATV/o0pXv2yGihywXNOUpIj1bSv/7du3HYqYgLuYi24+C/ghrTDewRVnXVi8+k9IbbL xeF9vwFfbQKxC7I3Rt4JRXL100MAUjb6ev5UCNSumaDF2na/Q64hByJ42HjuwSu61At+ Lu46waLB2bUOw0HC0WEhVjscZSywFn28Y8BRYN3TFa0Fv+Q3ZMN1S4pVQb2yCLeuqHo2 EgWQ== X-Gm-Message-State: AOJu0YwzCdkbeGWIZ5NVLvVBVI/+uDw6b8J5UcA3tTp/9dtf8zYgIT44 DA0XmpGUTUXYO3nr3Pp4L2h03JNZZ213tE/ArmI= X-Google-Smtp-Source: AGHT+IGCHxLEubxnG2m3vwrmBVwifiZKUYVAjT/HRvQ/RzuLq1/miwRy49cqvtFJ5+zeaGIE6C7aZvijkBc1kV2oIYw= X-Received: by 2002:a2e:3816:0:b0:2cc:ea7b:e6cb with SMTP id f22-20020a2e3816000000b002ccea7be6cbmr1080625lja.105.1705123265618; Fri, 12 Jan 2024 21:21:05 -0800 (PST) MIME-Version: 1.0 References: <2023121124-trifle-uncharted-2622@gregkh> <8e59220d-b0f3-4dae-afc3-36acfa6873e4@leemhuis.info> <13a70cc5-78fc-49a4-8d78-41e5479e3023@leemhuis.info> <2024011115-neatly-trout-5532@gregkh> <2162049.1705069551@warthog.procyon.org.uk> In-Reply-To: <2162049.1705069551@warthog.procyon.org.uk> From: Steve French Date: Fri, 12 Jan 2024 23:20:53 -0600 Message-ID: Subject: Re: [Regression 6.1.y] From "cifs: Fix flushing, invalidation and file size with copy_file_range()" To: David Howells Cc: "gregkh@linuxfoundation.org" , Salvatore Bonaccorso , Paulo Alcantara , Shyam Prasad N , Rohith Surabattula , Matthew Wilcox , Jeff Layton , Steve French , "Jitindar Singh, Suraj" , "linux-mm@kvack.org" , "stable-commits@vger.kernel.org" , stable@vger.kernel.org, linux-cifs@vger.kernel.org, Linux regressions mailing list Content-Type: multipart/mixed; boundary="0000000000008bb767060eccf210" X-Rspamd-Queue-Id: DA6C0C0006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: gyee5a3eqfag16tw1cikz3e914d5asgc X-HE-Tag: 1705123267-732396 X-HE-Meta: U2FsdGVkX19dD9fV/cyuNhf7V48VuX+gjYnacwyWnrmF6jOYJLHEOw3N1uI66q0I04Gvmhk8SnXKyzw4IA3U0dXGMW3ZMyk/wqUjZWV4zcvYZbpW45xv5pYyoT/t4LAodZYxKua0jBn8aReI7YBH6bKbLzmlYWZu5vTpn4xxYeLG4jLibgMRgqyZq9loFXp2KTewn42k3oscoDdFdz6YQT5C0gTgkmlCPDC2C2wUL7yqNIOsnVFCi1lLNi+Aoe3g7bttxc3vOV3Gya/cPcFaKOyxvTfQBDScvZ5tCUscnBxxI6Q4aqG/tw1yBz/Ylio+SKdElzPFy6LlSkfbDpTRaFRGunGwPKFqrbkCH/zxV11CrEIepRC3oa1wHcDQZe0icx0C9L6HfOmU/ZYNbrraHVOGoShw5ns/Jc1QTvmZ28s5paJjJINuYfWmyLqZBZDD8LkkmE5E9jwV8cQIAczHMcY1hNIGm0PN1LuKscTL6Qc1SAN9HlDxPrSx9qaAxO04iLHy6A228ldVHoA1dPEjT/2/2kDeRxz2Y619coBnxKVHyKdgG/SksEpSpZdK1Uv3ogM/HirNGgFKitR1bLtPGzOo8QFzCyfVjBPQNJzn2uZaVpn5gs7XaA/hkHMqX3RCGLMFg11GNDNfDYav8TkZlCWfW5GFxB3FrCBGy5DAQy+lMY3nRl/q2RrA76v0vA8VYWsvU2NP/dbdPMvYDRYbdrQT5qYmSViWWTL7KGMwSe/Q0bB9ovsb11BHcTWXgIMYJbQVa3VVa67jzz2WiuclMBeSdvh3oBiSh1hwnFtHsaQIMfLtopR/2i7oO3MoitRD1/0qaNOuj40nSvK0r9/rz6jmdlL+SzYXVqRJR459eaAy4dR1JUWdv3zrw+ktXA0bQIuCXGPfg1XTKH1miCWOg1maleM6/ga5gYTcqHZfcq4wdeAHI5DErdNrlvIIOFUMS1s2R7YzcacUCb5ghS+ oVtp+usq 9nk38k+T0ye0jtUq0u2irEAtfOkR3jIrOSPDv/PS2bBXFWr+1GVc4i/Sty5oT/JzyPpwmsuHxO2e2ijAuzpX02EdtdFsELZPTDhFNw91VUwKIBxft1PIHA7KHpbwe8b29Y5yOr3LXEYBRiO9GSucfZQ468+1+WIQPFd6CV+5jAoCrAgZwJ7ZFUWKt+UfvzIJFIjBwcJh7OLFw1FNGK+K93sXOyXbqnAYX+N7D0gS07t63kiMRxx/wj+Xh6gGw/NGwiwwbEBFZI7Ms8PTaHIYCdPUHYCI4dcuZA5WOCqBd5TsU7YuaGaxtYelOW3NFoZc4go71IIputFc5/7aWZv51WjThiugjj2QHkOlCFF6nxHx1zzuNBfDzk4WHkFhbdYRRGVZGS//83cCAnT+wES/8VjXNOokvcO2q86UmeUBRAJ2C8bqxNZM247d8KVEvcTPfXcZSipAkkWBjuQ86fy72GgbnvbyQ67vdPiSERdbb1gSzV0fZWQimgG/egmAsg3JOLgbn8UEbTBdh/Y54YLCWqCQDVoI1TN0AF9+xEkQ+VNOk/ou1XckDl1uSFEXiDfRsOuKwi7LVzsl5JohZ66R5SpSrA5ysWIWZ7UMDFC/D88QmyC8NaxrLOzDbrn89sY1QszH2FjUgDGOPbGbTv+4Ati5NbcKxEmnkH6teQS4uZS4jGzFPbSHtw6LgfccIf/hM8mbBO04a8cbfrK+ZsfaUYACcTmnxeJV2uB4gS9R7y3Xw93adYu4PqVvl6pxMiNFhExY33hBCGOrLjbwgvqeA27qyL840WE7ona7MCH8y1ymRHoKxxsXS5Tg7FH2N3cesGw/rjy5VY0thQbqa43e6Q1vwYDWL197Ez7QuTA78x67yVqePQ/5Mp9LnxbMgAenWtCdFYI7r9ZtJaEqwvBybY3SerA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --0000000000008bb767060eccf210 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Here is a patch similar to what David suggested. Seems straightforward fix. See attached. I did limited testing on it tonight with 6.1 (will do more tomorrow, but feedback welcome) but it did fix the regression in xfstest generic/001 mentioned in this thread. On Fri, Jan 12, 2024 at 8:26=E2=80=AFAM David Howells = wrote: > > gregkh@linuxfoundation.org wrote: > > > I guess I can just revert the single commit here? Can someone send me > > the revert that I need to do so as I get it right? > > In cifs_flush_folio() the error check for filemap_get_folio() just needs > changing to check !folio instead of IS_ERR(folio). > > David > > -- Thanks, Steve --0000000000008bb767060eccf210 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-cifs-fix-flushing-folio-regression-for-6.1-backport.patch" Content-Disposition: attachment; filename="0001-cifs-fix-flushing-folio-regression-for-6.1-backport.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lrbmcxfm0 RnJvbSBiYTI4OGE4NzNmYjhhYzNkMWJmNTU2MzM2NjU1OGE5MDU2MjBjMDcxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGV2ZSBGcmVuY2ggPHN0ZnJlbmNoQG1pY3Jvc29mdC5jb20+ CkRhdGU6IEZyaSwgMTIgSmFuIDIwMjQgMjM6MDg6NTEgLTA2MDAKU3ViamVjdDogW1BBVENIXSBj aWZzOiBmaXggZmx1c2hpbmcgZm9saW8gcmVncmVzc2lvbiBmb3IgNi4xIGJhY2twb3J0CgpmaWxl bWFwX2dldF9mb2xpbyB3b3JrcyBkaWZmZXJlbnR5IGluIDYuMSB2cy4gbGF0ZXIga2VybmVscwoo cmV0dXJuaW5nIE5VTEwgaW4gNi4xIGluc3RlYWQgb2YgYW4gZXJyb3IpLiAgQWRkCnRoaXMgbWlu b3IgY29ycmVjdGlvbiB3aGljaCBhZGRyZXNzZXMgdGhlIHJlZ3Jlc3Npb24gaW4gdGhlIHBhdGNo OgogIGNpZnM6IEZpeCBmbHVzaGluZywgaW52YWxpZGF0aW9uIGFuZCBmaWxlIHNpemUgd2l0aCBj b3B5X2ZpbGVfcmFuZ2UoKQoKU3VnZ2VzdGVkLWJ5OiBEYXZpZCBIb3dlbGxzIDxkaG93ZWxsc0By ZWRoYXQuY29tPgpSZXBvcnRlZC1ieTogU2FsdmF0b3JlIEJvbmFjY29yc28gPGNhcm5pbEBkZWJp YW4ub3JnPgpTaWduZWQtb2ZmLWJ5OiBTdGV2ZSBGcmVuY2ggPHN0ZnJlbmNoQG1pY3Jvc29mdC5j b20+Ci0tLQogZnMvc21iL2NsaWVudC9jaWZzZnMuYyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAx IGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2ZzL3NtYi9jbGllbnQv Y2lmc2ZzLmMgYi9mcy9zbWIvY2xpZW50L2NpZnNmcy5jCmluZGV4IDJlMTViMTgyZTU5Zi4uYWMw YjdmMjI5YTIzIDEwMDY0NAotLS0gYS9mcy9zbWIvY2xpZW50L2NpZnNmcy5jCisrKyBiL2ZzL3Nt Yi9jbGllbnQvY2lmc2ZzLmMKQEAgLTEyNDAsNyArMTI0MCw3IEBAIHN0YXRpYyBpbnQgY2lmc19m bHVzaF9mb2xpbyhzdHJ1Y3QgaW5vZGUgKmlub2RlLCBsb2ZmX3QgcG9zLCBsb2ZmX3QgKl9mc3Rh cnQsIGxvCiAJaW50IHJjID0gMDsKIAogCWZvbGlvID0gZmlsZW1hcF9nZXRfZm9saW8oaW5vZGUt PmlfbWFwcGluZywgaW5kZXgpOwotCWlmIChJU19FUlIoZm9saW8pKQorCWlmICgoIWZvbGlvKSB8 fCAoSVNfRVJSKGZvbGlvKSkpCiAJCXJldHVybiAwOwogCiAJc2l6ZSA9IGZvbGlvX3NpemUoZm9s aW8pOwotLSAKMi40MC4xCgo= --0000000000008bb767060eccf210--