From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67F5AC2BA18 for ; Thu, 20 Jun 2024 04:41:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEF238D009D; Thu, 20 Jun 2024 00:41:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9FBA8D0066; Thu, 20 Jun 2024 00:41:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D40568D009D; Thu, 20 Jun 2024 00:41:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AB9248D0066 for ; Thu, 20 Jun 2024 00:41:48 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6CCA1A1717 for ; Thu, 20 Jun 2024 04:41:48 +0000 (UTC) X-FDA: 82250019096.06.E10003A Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf28.hostedemail.com (Postfix) with ESMTP id 8F7B0C0017 for ; Thu, 20 Jun 2024 04:41:46 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SwWjM64Q; spf=pass (imf28.hostedemail.com: domain of smfrench@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=smfrench@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718858502; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cgJd7HYHtK7TDJGQXUw+tE5fIHbnoSCDFuK+dDsisZ8=; b=x27Jze9kcJvxg3X1uENDzie22gjICR3ktwhKv3Qi7cwfDDUhrG/13emQwVGwi1m0LhDJ1J IOMGJlSQmohDIotiL3DxMIsT5HEj9yly3bJsYSR6D0/MG/WIEoF/7vaPtF3axcLDmbFXl2 LB3OS5G4T0tEuH83PVvpOz8MhRg9SrQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SwWjM64Q; spf=pass (imf28.hostedemail.com: domain of smfrench@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=smfrench@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718858502; a=rsa-sha256; cv=none; b=083LQAk0Fz37t+AQuRevM2B+E7z0R5u9ZawOvwsL9u/YjOLL3ZtW4rW+dA17KEzTmXkU/Z MdtCA+j3V5SyGR7X7RnT14LoDtSawyOObm+gHZQufatLGU6aZqWqiErajhz2LCTqRG5E/O lCH7/bFyCotUVff0DQCcJX5nt+9ZtUc= Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-52cc671f170so1322668e87.1 for ; Wed, 19 Jun 2024 21:41:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718858505; x=1719463305; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cgJd7HYHtK7TDJGQXUw+tE5fIHbnoSCDFuK+dDsisZ8=; b=SwWjM64QE3UuU3/m9feP2vhgHT3dYvdAeJIokoY3NSAsFy+3ddnxych5CxAktPFEva ECLdqjx1gLZrENzFlmUiQKEcD6WczGNG0xpxD6V/cexb86ReXZOc3D/xp3S+4XXIh7OJ z3MWa1u8FmS9tc+IZl8fJVl2Q0eIEo1NBzaYhL2iVUhdEl7MhpuXbmcA9fH61aBb3fnN r+4IDSvgkLzMNuiN5BJQdi4O8iNCKrvJce+8jz80lyDut3OLXnZU2CkxB6g+wwjZeXuo BWlANLO8OrSt61pfn96GQGICq9++QK2Z1uvWMQ1Xu7qg3eDuD5wK4R57Y8VStdi3/ZHD l4Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718858505; x=1719463305; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cgJd7HYHtK7TDJGQXUw+tE5fIHbnoSCDFuK+dDsisZ8=; b=TurhE6zI2zP/emt8QWvu3nadsrY1k2bn6l47wObFNcM9Vr+ebZGqtiPy+//UxRdsJE VRoYgPxFIL0DDP5X7pYVVQCRSZLAhFf3B7srt6AlIOMw0AkyOG5QDnkTG9xxW53FCEIv tmr2xB69PW/BEy8yIbYai5Zv+nEKzQrb7Dofxmh3DMKSQITSylKnGKyPTYQ4U9T80Z2j 14UvhKGfPnxiXvGS6L98ZdCfSJ22mLP1IOmthR1yAurXU3bAc3tRmPq73vof2dEiyD5k bSnovOuguWWuepG01AJNh4+5AfZGyvXoM0+TGqV/mbE6+MgFAFSTxV1wSiuC+cUCC6eZ 5LyA== X-Forwarded-Encrypted: i=1; AJvYcCWgNLI1DMjiZZeSpbLfueKPx3wTuQlhy9zH5K3Z4B8hR2eZF3fLce/DqTD+hdBGe6OoRYHnz/4gjRe+BYfg7Klk2ac= X-Gm-Message-State: AOJu0Yz5i0qZ/l6v3ujUMjU2HiNrUHNK+G3QkCTKQI3N2d6mj5j/yXSy J+pHR7YimVbZDNhyIu6ffPPkNlT/gv4LP9HksOa1W25x6dk5W2jDWxD4P7wJ4xq4PXYObfF1PYo wBGt01xa0HOXa0p4WU8A7gdmQn+8= X-Google-Smtp-Source: AGHT+IGsgVUsaCAtek/iW0jZyA5fxTdcBbbh+m8RYw/TVqPJPyJ6ykHlolz5nhN3mWI32ygtxX+Nkz0oR6SYgiiUjwI= X-Received: by 2002:a05:6512:e9e:b0:52c:82d3:4725 with SMTP id 2adb3069b0e04-52cc4aed3a3mr2252892e87.25.1718858504683; Wed, 19 Jun 2024 21:41:44 -0700 (PDT) MIME-Version: 1.0 References: <20240618072258.33128-1-21cnbao@gmail.com> <20240619182350.f4969d6dbb8549d309a5ae92@linux-foundation.org> In-Reply-To: <20240619182350.f4969d6dbb8549d309a5ae92@linux-foundation.org> From: Steve French Date: Wed, 19 Jun 2024 23:41:36 -0500 Message-ID: Subject: Re: [PATCH v2] cifs: drop the incorrect assertion in cifs_swap_rw() To: Andrew Morton Cc: Barry Song <21cnbao@gmail.com>, linux-cifs@vger.kernel.org, linux-mm@kvack.org, sfrench@samba.org, anna@kernel.org, chrisl@kernel.org, hanchuanhua@oppo.com, hch@lst.de, jlayton@kernel.org, linux-nfs@vger.kernel.org, neilb@suse.de, ryan.roberts@arm.com, stable@vger.kernel.org, trondmy@kernel.org, v-songbaohua@oppo.com, ying.huang@intel.com, Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM Content-Type: multipart/alternative; boundary="0000000000009749f6061b4aee01" X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 8F7B0C0017 X-Stat-Signature: nicys71hfc9rgicnrygw4qu4kdrdktwn X-HE-Tag: 1718858506-681326 X-HE-Meta: U2FsdGVkX19PcDyz/UPWfFWPTzURAykTjSFtyIcVFOK5dmaP6kdZ0+3iHby1jlgiTtG7+tY0YWgy2acXpe3XwNmyhHGb5n3sq4K8aviwfC8vgAlnNnRpjXI5XHJrvBiN4j+dpQuZHO1DA8y0zRWHCVHy4ZOwkSKjbVGQ++M+ftGvBBfG4dk+5JDzmXUDqW3fvrkG1u7SHH2ZfrUkuS4wlRTvZUV0ThYbWBIjiEBmEiVneo+0qb9qQyiaYRottphUc3TvoAW8YQ/ss42evBxqI9MValwy2tqro+UuORp8g4FEOXHwKiPAuF/w+GAewCmBStd1zOqtdUdEitVTG3ARWeFPyHD+pdpR4MBhAmjIOkbBGGU6WsVbBkOhp6BRfqTU4bNVEB54OG7FGYRgjBdeEZFMpy1Yft+EXbkKbhquFPib6d0xTGO8/auN07/YceVS+CXtpDdJVqUAlKR7ai0I5aybrFxIi21EwoyoVJ0jTXjYyR7IBwODuFv2E+OfQ4AxvuYvQNSuf//3x2qsPRdwJO/uDOm5313m8qTtBLd8KJyrcbWdysaHf0L7RZtsRblpWRYVDrrlmrfonn19yLAmBOlglh4Crck5xmEpGa41JhQ6jKqArtoWEv5cX0TY4lyZeU+Zbvu5M93C7fMTAi4WBVjZ0JYW043Dq625deIeV/TAQdNZxatqp4MMM/76Lqs0V5L0K4n/nfW+cFWAp0CyQunaQ9v3huRrR3pUV4WCL6c7Bk6dNr9wHUdsAm1gZTb9+0NBiuGmP48nmE2EphBJrgcjCTO0oZO0hgEiiBRIW8rsT8gMphSRDR2KiVK0aDH0TM0bhyrcaOSh2+bSX2srCRCMtcMY3Q/tz8+hVjs+KpTGXbKgB2B614IBB5s1IkWvrhkFxZShGJCjVmnaRySDmmgUPW0xGCYx5yAxM+pPvYsOAoLdUR/ZcXLyTdWVfFwxqCbtyzv3VH1sb5xv1lX v6b165BO 13eUycBCDmIMxoGnY5mIWZs+WLSbRZTAKdMnewWU2j864tXf5WLyLwSdwRzTvTnFxwXI1H9PkSMPztMwLmx07eabheHjRokXeQAzQCUpwf9gcn+NusI0FIvM6tzweDkiah8xpCeu97V31tN8xRLwa/Wb4Jr07xH22f0RqYNzQvTYUmv9sLm2iYmFQj6ifCp+eHrpVIa6sovD8HAuWvyQVzedPCTybwjAo9YWGXi/NoWwQyF1sG67dxyEx8M+WEOeTF0KJFMc/tkqLUSNGsIlqNX4eL6lYot7PKBhxDy3/rnJVGu72Pf8JSyg1hnm2lCdXaUCn/qvPzATlwko9p4qltSs4Zo3yLiKSI3lmCKqDIY+DbKA7Xb1jygr4eN5edAdOrfv2GNNTGCiG89N5On5zJrMXEr+VxjslwOOnuo7g2RAgd8OrlR/JEQ12DUlPle52ijmgMtT7VGLprmrOzloiQcBpvk3QTeorgCs7zg2RoLIR+ch4tgJhgZghK67GBv9kz9j0K5+QAKx+7D/1R0gq6pmmlkilZeqIao6CNRcx69TPanxs4THz9oWbYjm5z1YARtiJzOQeOlEX0eOicpj7ITRW8TVvVrYUB8gDkrsAaXP3C/Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.074868, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --0000000000009749f6061b4aee01 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jun 19, 2024 at 8:23=E2=80=AFPM Andrew Morton wrote: > On Wed, 19 Jun 2024 16:44:15 +1200 Barry Song <21cnbao@gmail.com> wrote: > > > On Wed, Jun 19, 2024 at 3:48=E2=80=AFPM Steve French wrote: > > > > > > tentatively merged into cifs-2.6.git for-next pending testing and any > additional review > > > > Steve, Thanks! I guess you missed an email from mm-commits. > > > > A couple of hours ago, this was pulled into mm-hotfixes-unstable, likel= y > > for the same purpose. Will this cause any conflicts when both changes h= it > > linux-next? > > > > > https://lore.kernel.org/mm-commits/20240618195943.EC07BC3277B@smtp.kernel= .org/ > > > > Will we just keep one? > > Either is OK, but I suggest a 6.10-rcX merge while retaining the cc:stabl= e. > I have at least two cifs.ko patches to submit in a few days upstream, so am fine with submitting the patch if it tests out ok tomorrow. git.samba.org - sfrench/cifs-2.6.git/commit --=20 Thanks, Steve --0000000000009749f6061b4aee01 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Jun 19, 2024 at 8:23=E2=80=AF= PM Andrew Morton <akpm@linu= x-foundation.org> wrote:
On Wed, 19 Jun 2024 16:44:15 +1200 Barry Song <21cnbao@gmail.com> w= rote:

> On Wed, Jun 19, 2024 at 3:48=E2=80=AFPM Steve French <smfrench@gmail.com> wrote= :
> >
> > tentatively merged into cifs-2.6.git for-next pending testing and= any additional review
>
> Steve, Thanks! I guess you missed an email from mm-commits.
>
> A couple of hours ago, this was pulled into mm-hotfixes-unstable, like= ly
> for the same purpose. Will this cause any conflicts when both changes = hit
> linux-next?
>
> https://lore.kern= el.org/mm-commits/20240618195943.EC07BC3277B@smtp.kernel.org/
>
> Will we just keep one?

Either is OK, but I suggest a 6.10-rcX merge while retaining the cc:stable.=

I have at least two cifs.ko patch= es to submit in a few days upstream, so am fine with submitting the patch i= f it tests out ok tomorrow.

--0000000000009749f6061b4aee01--