From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C6A0C433F5 for ; Thu, 21 Oct 2021 23:16:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DFD036135F for ; Thu, 21 Oct 2021 23:16:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DFD036135F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 75E056B0071; Thu, 21 Oct 2021 19:16:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E6836B0072; Thu, 21 Oct 2021 19:16:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5878A6B0073; Thu, 21 Oct 2021 19:16:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id 427036B0071 for ; Thu, 21 Oct 2021 19:16:03 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 029EF181E7263 for ; Thu, 21 Oct 2021 23:16:03 +0000 (UTC) X-FDA: 78722004606.02.104787D Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf04.hostedemail.com (Postfix) with ESMTP id 579715000303 for ; Thu, 21 Oct 2021 23:15:59 +0000 (UTC) Received: by mail-lf1-f43.google.com with SMTP id n8so610943lfk.6 for ; Thu, 21 Oct 2021 16:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NGd3ZBTVw8WerW8TiXkapULoiLMOJ6XxJFj9gFvuuSU=; b=b2s6FHWu+usXqQrC6G5oR1QXzV421vmzu616cj0TNoasagpoWnKOEKbYxv6lwcqPeI 3rORErL7fa/RFd0y2Vi9iFsS945DYpKaBv5nii1hrDWFRTJAvwghzmPtEJj+WMAEM17L /O3Sh1kCF4mjJgVQs5ZVXMKHMXWjelDAnQuriR3P4qbXBgow863UHNut4GWOwsAcq3R8 LkWsfmC9oiosn2tFEKgiUpbhG4Nj1FZGqH8d5l/mF+MDgVDszmLDzMmBdqz5dfZydR6W CwiG1vdp59S9FmUIPQ76gL5GOhXou9LfjHasOMDZ9f3WorvSSWSHDMjI2c/fnqLqoXEM 8naQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NGd3ZBTVw8WerW8TiXkapULoiLMOJ6XxJFj9gFvuuSU=; b=Nc+GSocGMLYlz3LRhoKQFqgeaLFJPq0bftdkm2z18X0zYov1sIaMkIQ9SXbGTHiaFp Th9JaQx5WzNQ35Wl9bkrbSD2NKrtRXZRg4WBq5cdrRcmqV/zyOqEg13f6G4B9IDfRk2e NTjHZxLN6GlgPEDsXQCYSMB4vzcDtVqLiLq6Q+eOdq5ur2rNaJbt9amTW3okJlAei/dr ih+nUeYGo+02lnATmMpqAjclORFI4pVbn9Mzg9gr63wws3v3GEW/Qc3GVFcYRkDX+Te0 MTuVMGL8fhAkdVr7QJu5/yTUr42vLbTyOHucMj3NubCM/C3iiZx0xb+GFVJcXQNNcJy9 O4/Q== X-Gm-Message-State: AOAM533joeRIPwwccMS+DkNMp53pP/nKi4YIyQh/57+DLITmDJD6jD1z mY3ymFQOen59PT6IzNtPBHdIQ7W+EAKpd4x9qpk= X-Google-Smtp-Source: ABdhPJwZpcQ1KdeVcaHk764w6WspHm/7cDejlBv/A5lS6M8tifVYkMndPvZos9ePSqOr5Sy9U5NwiVeDSIz4sIygGiM= X-Received: by 2002:a05:6512:3763:: with SMTP id z3mr8185733lft.601.1634858160588; Thu, 21 Oct 2021 16:16:00 -0700 (PDT) MIME-Version: 1.0 References: <163456861570.2614702.14754548462706508617.stgit@warthog.procyon.org.uk> In-Reply-To: From: Steve French Date: Thu, 21 Oct 2021 18:15:49 -0500 Message-ID: Subject: Re: [PATCH 00/67] fscache: Rewrite index API and management system To: Omar Sandoval Cc: David Howells , linux-cachefs@redhat.com, ceph-devel , linux-afs@lists.infradead.org, Anna Schumaker , linux-nfs , Kent Overstreet , linux-mm , Matthew Wilcox , linux-fsdevel , Dave Wysochanski , Marc Dionne , Trond Myklebust , Shyam Prasad N , Eric Van Hensbergen , v9fs-developer@lists.sourceforge.net, CIFS , Latchesar Ionkov , Jeff Layton , Steve French , Al Viro , Dominique Martinet , Ilya Dryomov , Trond Myklebust , Jeff Layton , Linus Torvalds , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 579715000303 X-Stat-Signature: rz39hyjkzxgxjq8q7ubn1ftzmfipk3sr Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=b2s6FHWu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of smfrench@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=smfrench@gmail.com X-HE-Tag: 1634858159-799619 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000042, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 21, 2021 at 5:21 PM Omar Sandoval wrote: > > On Mon, Oct 18, 2021 at 03:50:15PM +0100, David Howells wrote: > However, with the advent of the tmpfile capacity in the VFS, an opportunity > arises to do invalidation much more easily, without having to wait for I/O > that's actually in progress: Cachefiles can simply cut over its file > pointer for the backing object attached to a cookie and abandon the > in-progress I/O, dismissing it upon completion. Have changes been made to O_TMPFILE? It is problematic for network filesystems because it is not an atomic operation, and would be great if it were possible to create a tmpfile and open it atomically (at the file system level). Currently it results in creating a tmpfile (which results in opencreate then close) immediately followed by reopening the tmpfile which is somewhat counter to the whole idea of a tmpfile (ie that it is deleted when closed) since the syscall results in two opens ie open(create)/close/open/close -- Thanks, Steve