From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A2A0C05027 for ; Fri, 17 Feb 2023 17:48:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7609D6B0071; Fri, 17 Feb 2023 12:48:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E9B26B0072; Fri, 17 Feb 2023 12:48:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B16E6B0073; Fri, 17 Feb 2023 12:48:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 47D7C6B0071 for ; Fri, 17 Feb 2023 12:48:45 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 196B81A02C5 for ; Fri, 17 Feb 2023 17:48:45 +0000 (UTC) X-FDA: 80477519010.21.4ECEA4B Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by imf20.hostedemail.com (Postfix) with ESMTP id 521921C0008 for ; Fri, 17 Feb 2023 17:48:42 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RimT2oCo; spf=pass (imf20.hostedemail.com: domain of smfrench@gmail.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=smfrench@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676656122; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W82mtufaxCxYaCrOwsWwXEqkQ8P4m8alQaSwlsBKCQE=; b=gxjLjt2UzsQ78qQ3gqAgMrxzVsjHsi/Z7bAOtJRfkOXuzBX+SD08GHM7pdpv4OnWUt1biY Io7D+WcfUjynr/dKg07P17pt3jK7HANJ2GYeFrhwrzIOhsQI+Frz6jjBmpPK9xFvl8xlfu V2HCriU3S2qZ0P0hBkcMPPNKXzAaIOM= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RimT2oCo; spf=pass (imf20.hostedemail.com: domain of smfrench@gmail.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=smfrench@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676656122; a=rsa-sha256; cv=none; b=tPIZFxChkrJBX4AOJkBTQLp3143Tqg24jyHzJp42p4osuf+DL5epA2vyNXktER+3bd1eMa 7DV07Dv1j/1j4o2aEDJIA5o0KpbPqyR5BKM1rJT/ff8Xlt0GX4Ax005yyWzOc1LCcuzE6c w1nnxwFoHpEZ0NlM+h0I3HLUouOnD6Q= Received: by mail-lf1-f44.google.com with SMTP id i13so2745742lfe.1 for ; Fri, 17 Feb 2023 09:48:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=W82mtufaxCxYaCrOwsWwXEqkQ8P4m8alQaSwlsBKCQE=; b=RimT2oCov4P2FJhzEMVzK6vAiZ1gzLQ+s2iyY+NBElRkyquEhBySqKaTrFiClN3Q5L tc4BrLdaY/OzDcL8amvmaZWPWdQ29gctSOMhZYz00WwaVG+tKgqs9a0ZOrPBcQdOZauU 4eHv8uCS2ezA6q1tCzEtShJ0lcitKPXVnXs6b4z+J2wS0/IRMtfn/yjH0SSTaPK9A/J5 2ELTVzNKbzdyrKU0wEKbfPTf629znz/I3HfzV0bSoeErirN2hQn6zDbQJwkEZSod+M5s 2XzWNrgf/6UxcM1LExMCpG3ohyVuDIhCxkEmyopQDxfD7YU5yQXzh/3R+DznDDXV4yjr Yz5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W82mtufaxCxYaCrOwsWwXEqkQ8P4m8alQaSwlsBKCQE=; b=qD8am8ugp0NCYX5u9VHOnB98DuyFuokOtXjFF7DGoo4XiOQR96hlCjt6rMcUxZqYt6 ExMKqh55zkftKBBCcqo0W9hkti8CXFf7/CXZlcNayou9jDpxe58LqpOBLjvi84O5w5k/ 19LSBQCZa4Nw1jIxX4SmBOdWU21uiPpJ/kj5Qc/y0aC/2Riu5Wco+74TYgUHMaoTtw/Y +LOtSkcoRcBgkStOCOH0rAf0UfbMTcZpMoNKbij7cYLC33o731kqt1iAPysaLFDYJ/QT iadeN3nLJE5IPW78J3dnTZcBwMJMuWEncPkT1VRn3ypBOsVOOlY3JNv3cB2EImiEqNAs WJOg== X-Gm-Message-State: AO0yUKXzn7d0huDa/onM0swAOtSZ0zTfb7N5n5wIMPz/ttb5ug+A/t9u 37XDlrHyXRkl3cALJtmtWHDfDfOPfPyDQr7suSY= X-Google-Smtp-Source: AK7set86i6m3Q4viJu7w21vbC25QAPfZIb1xUe2TG6mkfmZTyneWDww3gkbjTM2kzGZ0bcI9FudMJJy97KppSFxu5AQ= X-Received: by 2002:a05:6512:501:b0:4d5:ca32:7bc3 with SMTP id o1-20020a056512050100b004d5ca327bc3mr646949lfb.10.1676656120238; Fri, 17 Feb 2023 09:48:40 -0800 (PST) MIME-Version: 1.0 References: <20230216214745.3985496-1-dhowells@redhat.com> <20230216214745.3985496-15-dhowells@redhat.com> <4008035.1676621321@warthog.procyon.org.uk> In-Reply-To: <4008035.1676621321@warthog.procyon.org.uk> From: Steve French Date: Fri, 17 Feb 2023 11:48:28 -0600 Message-ID: Subject: Re: [PATCH 14/17] cifs: Change the I/O paths to use an iterator rather than a page list To: David Howells Cc: Jens Axboe , Al Viro , Shyam Prasad N , Rohith Surabattula , Tom Talpey , Stefan Metzmacher , Christoph Hellwig , Matthew Wilcox , Jeff Layton , linux-cifs@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Steve French , Paulo Alcantara Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 521921C0008 X-Stat-Signature: 3teq46kw7wgu7mm874a74fibnduso794 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1676656122-511860 X-HE-Meta: U2FsdGVkX1+yPkZj/OPH+qGi9kkxxdRMLAdwatWJoktKjKYSYZ3HHLBJcnDrO8Tet0ivXZgeLYGhWpGVc8F5/A5IYRO6tcAC/TvbYOb75aD7B9s0F/zivnReNraMbJS4QG1R+uI/5YFqPAQETO/e/mGXbBjmUkP7+7+G9R5ZR9GGVhRiY8x+Ddz4+Yi4eC4DpwDju25HvM86bCcs5+NFUYSJTRIQ8MwGd03SHNPt4UBQPIQEkkZEwKLR32zMah99rT1okPcAqaw3fgdFcNbnfq4lKKim0mTbavBN/w6kGgLT8PNhoLnND0mGzi+VSRRWzWPJF/83KTtV+EvnZ8w2qUT+DYFbiC6JQv7L3OhvzqZuUMGcTPQeudeVBvxzwWd/S3LmPDLViBlRUCgyj+PCDLB2yDpsJnSmOGCS9iCRe5rLXCNz6ODrkdpblVksgZRmpQMJR8sKoxMqoQe2eAfLV3Dalmw0RsLEAoroUfZchKGAgKyqnn2t5OncQpey0rORQUdQRGJMelyZQndgBrvZMewxqW3f+iDyHyDaA0J7A79J8pCsIubB8NI8VIABYU4/1zGdwVGRi/QnGiy3cqImO9XK8E7GDbBm8yFRzW1qKLZpxFXdqaHRa2y+YMc2bPuI8V+kiKBYF9IsXA2Ybm2/bI0TWmbn7s+y5M6OHvXm8mEdnr3ocz233/R5jOHVBBwapUpti3TMvJa1SjuOOi3GbrAIdvKbA0F9rTxSJSsuZJvlxt5ntEzmRVqTTyZwM9+u5/LnfJr7vcJbM5OSZHJMnZNXfrjGlxQPuPb7+d/H7W6w+0k1Bh99HDRT+WZuVFtbRuiacu6POLE8VgEZR9ew5auq2U6aFHivuMj1wQvlzDcgggoU+GVV/MP6+cDihQFCvDxXod/e8xn8L9pVXPuYFVigT+VaY+i/vz5/2GIR+uRZa+xhLIiw3yFfGqIUugWKzh96ssQDmLH6Fi1Wa7p thOWsELk MUE7RuZihsgEpEMNVGuoBn0Q601wvIkFpBs/MzJULADgdhc8L2rqV6CXs/es1Sc73ClDALSU2hoU3/g8qSCB1P8KnaYznxmvzyvclpYMS8Wb5DPx/71fz1OiM31AjN7hzomh/EkIspPsUwekPSUKJoQsOI4x4RagBi/GqRPia6gv00LAxVo6hiD4YAVhwdVtlHJomHskyMrs6f626EE1MkEl2HSKY6SximLmcHRlegGnkZlDKPVWDsByc3TtL2PGxw8wtmVYB7PPogFcymdWTI56WxXbLbGkZF0V9HqdHYGFkXev6UEhBpj7mlK4Lf8h6a5UZmJwwNWfOqmniQAud6ypjXLbzTwG1DGq7ilfj5TRCMCAnkLRD/Mo7eRq1IxFkQDNjYZgF9ZZUL4EVAT6OiK+oP8i5mny7W0DJ1Yb+paNgEIH5mjSR0+ZUHuorH83Yv2Uql6zadf3ePxiElePXyk2QNL6cgxNkghDCdQw7twtiNebuWT+b03jI6jbnApqjfY8JdT6AMAkyKnJbLjsjmo/aA7vd6EH2MDAjsqbM1v2Wz64= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I don't think that those are particular important to clean up - but a couple of the other checkpatch warnings were On Fri, Feb 17, 2023 at 2:08 AM David Howells wrote: > > Steve French wrote: > > > WARNING: Consider removing the code enclosed by this #if 0 and its #endif > > #627: FILE: fs/cifs/file.c:2609: > > +#if 0 // TODO: Remove for iov_iter support > > ... > > WARNING: Consider removing the code enclosed by this #if 0 and its #endif > > #1040: FILE: fs/cifs/file.c:3512: > > +#if 0 // TODO: Remove for iov_iter support > > > > WARNING: Consider removing the code enclosed by this #if 0 and its #endif > > #1067: FILE: fs/cifs/file.c:3587: > > +#if 0 // TODO: Remove for iov_iter support > > > > WARNING: Consider removing the code enclosed by this #if 0 and its #endif > > #1530: FILE: fs/cifs/file.c:4217: > > +#if 0 // TODO: Remove for iov_iter support > > > > WARNING: Consider removing the code enclosed by this #if 0 and its #endif > > #1837: FILE: fs/cifs/file.c:4903: > > +#if 0 // TODO: Remove for iov_iter support > > These chunks of code are removed in patch 16. I did it this way to reduce the > size of patch 14. I can merge 16 into 14 if you like. > > David > -- Thanks, Steve