From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16D2EC3ABAC for ; Fri, 2 May 2025 18:38:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E65F66B0089; Fri, 2 May 2025 14:38:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E13CD6B008A; Fri, 2 May 2025 14:38:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8E916B008C; Fri, 2 May 2025 14:38:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A68616B0089 for ; Fri, 2 May 2025 14:38:00 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 987F4B8F84 for ; Fri, 2 May 2025 18:38:01 +0000 (UTC) X-FDA: 83398827162.16.0A5AF2A Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf14.hostedemail.com (Postfix) with ESMTP id 95771100003 for ; Fri, 2 May 2025 18:37:59 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=P4lwGM0o; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of changyuanl@google.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=changyuanl@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746211079; a=rsa-sha256; cv=none; b=XZdeMtJFZvB3613IqxLLlX9NF8X2+rCHyo0HxnWg9CUVFJU1V70bWuljlllV7Bw11WqLtS wAhi2uUxY64vUSWjXaZ0ZHet/rKOpIPlvea2o4IGfbb3E6LIwO40xCvrCPzvZ63e7MaUxh biDkqDc9lW+p3GmdG+FBqCGl0IjTkyc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746211079; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Szvh9FDiAeZV5KMXY9XpVOO+pU/TH0kKZBG6xbyHs1E=; b=TUG3s5vzR5SJZJx+Db/BqPJwJGoGjUKIioXLFVYSDY3eI0VKhQ7H5b3wT5f678K2IcXqtW /DCESjS33+SYpzRvmfWC7lBwXed35VUkrCurTK3mdqAzlDA14L84NtxCoozQX1N/mtYSla +y31x5S1Gyft5e4fJxjlDye95l41lD4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=P4lwGM0o; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of changyuanl@google.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=changyuanl@google.com Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-ac28e66c0e1so252875366b.0 for ; Fri, 02 May 2025 11:37:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746211078; x=1746815878; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Szvh9FDiAeZV5KMXY9XpVOO+pU/TH0kKZBG6xbyHs1E=; b=P4lwGM0oIHfR2qtZ0KFmjAOr0HR/+IRfiIkLgLTYA2dJkBbOkawUyhivGeCjI3+GxI KPAf2G2ImSODfvOG99PnJG8ABJjX/2IugD4CPKkBb62+zZpsIA2VLY+OSuXKK25Bm/ft mqcmy0NrBvMC5XQQTJA50lrb/dpGa5D3JR5XrGpjSBJ1qbZDNen/7o4XUy4tpn9opt0z MdOuKKX/5plSSZteVF0U1yc12FZNGQTJV+y0rDEL3NRV4F6FdXdMmtevzVkY/ypN7gmk Zit0P3VXD1xeIn07lEU+v0KIItWK1ECp/KkOvaezvlA4tOrycX7s0nZnECUEqfIXR7al e3SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746211078; x=1746815878; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Szvh9FDiAeZV5KMXY9XpVOO+pU/TH0kKZBG6xbyHs1E=; b=vt7nXsdzQxuyd7FU4kEL21mzMq+GxVRPj/6oT02aEGrl/XnDphatPnTQS9HOS1ROf+ a1sgrOb1Nc068J8wp72ctTx0kTD0tofkdKFKVf9koA2wt/jLpHuOLEzOY/fmR9aTuP6L ncm01JEmy5SmQsgbLunwVeKBAlmVPzU6As78I01ur8eZH3d1pVSiBH49z6X0PdHojpcA 49N4UIVA7syUkaboCbkTUUwL8liOnM/VK4i50471m8nrGJYrq4Hfpoo5tkmEgmmFprGl R/d76HGdT4SpKsc5yd994YqZ8xZklNCL2hugzXLJCwmGbT0jvMGYVmHxmaoPd2UmL8tw oYaA== X-Forwarded-Encrypted: i=1; AJvYcCXg/82VDOn3Y6yLKLCoRBzM8X5Hwb8jSCeUdAyTNQ24RapHoX8EEFngOG8GK+iPwB7U5lhol+OqGw==@kvack.org X-Gm-Message-State: AOJu0YxWsieYXvrcas4cZrALf4Xe+JqBikh1jm7K4qwEFrZcolulxsbC KcG+/bOKsDfeoz1gdFykTlJsO5g+di0QpjsQdgZZGoA6xpwy+jRYxeaQMcb6NlAFEpZPEFmWb6o 56NgF2/AvXr3RN7SHnGvnXcQSDBFA8lvA3WYI X-Gm-Gg: ASbGnctBfbped8rVOsscRy0uN+hR0StA22ukNp/rTSLEVjikirJw9E4PlVLQfu0RbWK GIpK8JOnEtpUGp9fUb2UvAom7LJdXJgh8FG7LIKcNyk8PakeDRayVzCK0YAGh4kuGhH2g6R5GG4 Z/qYCRKqhwFLBFUIeBfKI9nSYDLe7EYm976Eji9yWsZsx6siDlYQ== X-Google-Smtp-Source: AGHT+IGwGEcGt7qt4y6UtHsVIeUZAmZUDbWtJ+Ey7gGLeSPt9gI0iA5XJZYC4rzHLcT2CmY4/egmqxuj7aqEk5l5ENE= X-Received: by 2002:a17:907:9812:b0:acb:94d6:a841 with SMTP id a640c23a62f3a-ad17ad8096cmr430432366b.16.1746211077663; Fri, 02 May 2025 11:37:57 -0700 (PDT) MIME-Version: 1.0 References: <20250501225425.635167-1-changyuanl@google.com> <20250501225425.635167-7-changyuanl@google.com> <20250501173557.1880f3aa8694352e0eb153b4@linux-foundation.org> In-Reply-To: <20250501173557.1880f3aa8694352e0eb153b4@linux-foundation.org> From: Changyuan Lyu Date: Fri, 2 May 2025 11:37:20 -0700 X-Gm-Features: ATxdqUHZQf1uwj7X5bskxFA1vT8WH6Uhw3YyifuFYUsYAjHkndnVOqhZb4vCKaQ Message-ID: Subject: Re: [PATCH v7 06/18] kexec: include asm/early_ioremap.h To: Andrew Morton Cc: linux-kernel@vger.kernel.org, anthony.yznaga@oracle.com, arnd@arndb.de, ashish.kalra@amd.com, benh@kernel.crashing.org, bp@alien8.de, catalin.marinas@arm.com, corbet@lwn.net, dave.hansen@linux.intel.com, devicetree@vger.kernel.org, dwmw2@infradead.org, ebiederm@xmission.com, graf@amazon.com, hpa@zytor.com, jgowans@amazon.com, kexec@lists.infradead.org, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, luto@kernel.org, mark.rutland@arm.com, mingo@redhat.com, pasha.tatashin@soleen.com, pbonzini@redhat.com, peterz@infradead.org, ptyadav@amazon.de, robh@kernel.org, rostedt@goodmis.org, rppt@kernel.org, saravanak@google.com, skinsburskii@linux.microsoft.com, tglx@linutronix.de, thomas.lendacky@amd.com, will@kernel.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 95771100003 X-Stat-Signature: d5ypxg5qd95q5486nhinpi5ayqywmfgu X-Rspam-User: X-HE-Tag: 1746211079-24956 X-HE-Meta: U2FsdGVkX1/BWr0ZSpLJUrnCu/jWqdB/u7MfcO9bDv7xJmVtitCLRD3BIBLntLNjSRoeOv4DyceltEA+EdUWK5/s6uv5i5vsHxshY6wA8T813V6KHbFbjbBRGOtLyFXuIRzaz2FLUticjTPrVDpxyBj8iSMxTSlLvoUenA2GEZNb4XsbSmolzZddwwcUYkKWe+VvxqFAnjM45k0f7//DbpmEEh5yjAdnQaHXO4QvzkSszMjQrHQ40qrVFQU6EI/WTtLN0KgZ7JIow5WNesuK2JFvOApgpG2d+XP6fgLrDdpoBfr8uWFQhZYSJVshKEUvySIPL7dt6NpX6D50Tv5O+RqW76sAb56untUTscXI5HG1S9vdvqRIVDgBXxIw/2Nn+9FZ6Y4b4J7VVzlFa5tAaMOVsM9CfUhGgQSREAZpMUXFDOJDmA5G6Xn0DsMbJL5LopU6ZkdvUnH4k9qoqzvqnJDzDgeYEuIurTS3SF7GXps/16wfoXwSyVEyB7onCDnr3EMKkgy0DN23yXvwW1WlB4uV887Tzyx82gPrtKB2GE4OpJegYav/KcO1zkI37lRwGEdY2+6DLqnaxxNezEEvCazPu9Pu7gRO/obs3o85tbEzJqClikTlTpzjrOFzINs0wld5Fex1/vVUID2gLQomHVty/xwXAfN/xFnZauZngt3hcBlyhM3+B2TwKgCgnxrdLeqlOOl3QhuT/sLgecQWQKdNOR7/2+gtEq5u58t4tQkSAw4phsdqvH2pnFqLIJ34PdegnxmtMDRWVkyBpcSxcHZl5kBiMbqcszMNJW/fewwq9oSlbQLRuLdyov2MRsa3HvxdVwvq7I7qP6XF8Q78izt+cuu/kg9nQa+KcTJL0M17dcCkJlWL60bKIfmMJjjCFMpb+8tb6Hkwsdwz3PCuYCukQ9D1Zb8xMlpK4D6/7zTC01Pnspsv8B7wCpM4o/K21S0MWO8fIv27u4mbI4R vsHcCjrW 0hSlwP7OIzRY3A5qEFaW1hd7B1S0CHshE42tQmsMjlHH9MozWlAiaNf4sGbaoZtT+u9d0uuowA/tetR+Jh7hJersRUxLTMVmKc0SjbkQCfcEXS+DRndn5QptAT/u4WJB7hDc4q8ovPcjqWaNDldYFnX2GpNyAgIyoY2o8XriIxVJtdTQzLueL4beC9htnFAyqXG+lQmr4Jz2eaepqamp0B1GDn4M4KCFnC15+6+gxeChsNqgVFL21b5X6nrXOIcZS1ypHIsy8Wj7bvIBETRt05MnrX2h97STYbUc9MoHz1cx1YBImDufuVbFGcOrpgDFZ2977 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 1, 2025 at 5:36=E2=80=AFPM Andrew Morton wrote: > > On Thu, 1 May 2025 15:54:13 -0700 Changyuan Lyu = wrote: > > > From: Arnd Bergmann > > > > The early_memremap() function is decleared in a header that is only ind= irectly > > included here: > > > > kernel/kexec_handover.c:1116:8: error: call to undeclared function 'ear= ly_memremap'; ISO C99 and later do not support implicit function declaratio= ns [-Wimplicit-function-declaration] > > 1116 | fdt =3D early_memremap(fdt_phys, fdt_len); > > | ^ > > > > ... > > > > --- a/kernel/kexec_handover.c > > +++ b/kernel/kexec_handover.c > > @@ -17,6 +17,9 @@ > > #include > > #include > > #include > > + > > +#include > > + > > /* > > * KHO is tightly coupled with mm init and needs access to some of mm > > * internal APIs. > > When resending, it's best to fold little fixes like this into the base > patch, along with a little note and the author's signed-off-by. Thanks for the suggestion Andrew! I will follow it next time. > I shall queue this as a fix to be folded into "kexec: add KHO parsing > support", thanks. Best, Changyuan