From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4153DC19F2D for ; Thu, 11 Aug 2022 08:29:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC64B6B0073; Thu, 11 Aug 2022 04:29:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A760D6B0074; Thu, 11 Aug 2022 04:29:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93DB78E0001; Thu, 11 Aug 2022 04:29:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 84D086B0073 for ; Thu, 11 Aug 2022 04:29:57 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4C245141547 for ; Thu, 11 Aug 2022 08:29:57 +0000 (UTC) X-FDA: 79786638834.20.9A4D100 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id D64B340193 for ; Thu, 11 Aug 2022 08:29:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660206596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5zwB8RRPPBklna2VPR8/MnOJ97E1gjZsjroyCLMcD44=; b=BnSRk2iDJYdf3Fi2aChhIDmGgM9Rs2L5ieZCa9GSjzKxsD52hq7d0XGSX/4ONw76RcBt5z ZG7FuqTO544gyIjDEyjetNqI7TK2D35PiCVyhFP7Zrcn+NqMZ4AnLhjZ8GZdotoRsIm/VK E/pBMpUBff0DhqL2kjOqJPmFJLIguK8= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-653-gST5dqExMuSOZLvGOauWfA-1; Thu, 11 Aug 2022 04:29:55 -0400 X-MC-Unique: gST5dqExMuSOZLvGOauWfA-1 Received: by mail-lf1-f71.google.com with SMTP id w18-20020ac25d52000000b0048af13b6ef6so3797815lfd.7 for ; Thu, 11 Aug 2022 01:29:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=5zwB8RRPPBklna2VPR8/MnOJ97E1gjZsjroyCLMcD44=; b=YivcyAQR116FCIAziQgyBWVi8zSyUPhLsvf3B2wvSvlaj+J74mNUVyUc9vN4APP84i URKukrPguJQyrsniLn73Zl3DPoeJfPlKLDLFmamiy41/zytJFz+5EUdExbWOFkXntHgh 0USYLMfgd5m31E/yX0pR9NFty9brddyiQ6dLVsiSDkxMadr4wLgG0nOx0q+0JFvzyl+v yYCeojCL+DrGyaapH1TbYyP/4lEMaG1RRyNop2KCEI3mIbcspZO/G8gVGwIrAXyEx6V0 sMLtD0HCw1jkXvh9r0o4rY6nS+zirYh1+BD6TuZKEqCK/ChGwy51qgfXBxR/BquaNYuA vyDQ== X-Gm-Message-State: ACgBeo16VBkD1nedzEWOKkOc/hoDkxc2WfiqRU2+bHZAGm37X2y58pCN p7Rq0fTMabAEr/pEfP7lzwSgpyGoZcmMv2j4C6dIIXYg+YuaEFvGsTxVGFimDint+DlCOwMHbC9 hur63DrPwg3XxjstEkqa0ZRA+03E= X-Received: by 2002:a05:6512:3e1e:b0:48a:f315:443f with SMTP id i30-20020a0565123e1e00b0048af315443fmr11952653lfv.519.1660206593916; Thu, 11 Aug 2022 01:29:53 -0700 (PDT) X-Google-Smtp-Source: AA6agR4K/MIeDVc/7YUsDy0BAh9v/jMmZR6FPK4DL+l1rTkmhLZY4jIha1y8WqlKNUc6N+RTMK2NbDFIGW3lUVRhoYM= X-Received: by 2002:a05:6512:3e1e:b0:48a:f315:443f with SMTP id i30-20020a0565123e1e00b0048af315443fmr11952638lfv.519.1660206593571; Thu, 11 Aug 2022 01:29:53 -0700 (PDT) MIME-Version: 1.0 References: <202208111501.5PSP1WaM-lkp@intel.com> <20220811081217.ugn7vslc2nlqv6l3@sgarzare-redhat> <20220811042124-mutt-send-email-mst@kernel.org> In-Reply-To: <20220811042124-mutt-send-email-mst@kernel.org> From: Stefano Garzarella Date: Thu, 11 Aug 2022 10:29:41 +0200 Message-ID: Subject: Re: [linux-next:master 14849/15097] drivers/vdpa/vdpa_sim/vdpa_sim_blk.c:201:3: error: expected expression To: "Michael S. Tsirkin" Cc: kernel test robot , llvm@lists.linux.dev, kbuild-all@lists.01.org, Linux Memory Management List X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660206597; a=rsa-sha256; cv=none; b=e1u3lCnYoTekcmg8uT8MfIyJYMXQOVJgGrXQ75sBUjOM2P6DZrKMERepH5CLEHHSibh96X BkxtWwWC6V2JrZJO/TyQhd2EJK+zkHklOY+ZF0qzKxFBCvxaG7lLpRY2vA4i++8whzfUL0 yN1Vmy2Igpk8i7BpnpyIadrF5ODn6H0= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BnSRk2iD; spf=pass (imf12.hostedemail.com: domain of sgarzare@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=sgarzare@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660206597; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5zwB8RRPPBklna2VPR8/MnOJ97E1gjZsjroyCLMcD44=; b=bBJsxbLSQd7QZO4SP1dgPZdYZ4MvFkzZM3Ilnn4/PfvCct3B9JeSHpn7YC5T9wI+6dR1UQ wOXS9oh3u95AczRSWzoWCN5//puEn0NbdIzg/2sdC4ZKrL7X9TDQ465muDvF3Lt9X87JtB Mx/6ICzuYv4JevlZSrzMoK2eQF+i43w= X-Rspam-User: X-Stat-Signature: w5seerzag5c61od5633e1gscqq5jmgyw X-Rspamd-Queue-Id: D64B340193 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BnSRk2iD; spf=pass (imf12.hostedemail.com: domain of sgarzare@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=sgarzare@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam01 X-HE-Tag: 1660206596-284158 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 11, 2022 at 10:22 AM Michael S. Tsirkin wrote: > > On Thu, Aug 11, 2022 at 10:12:17AM +0200, Stefano Garzarella wrote: > > Hi Michael, > > > > On Thu, Aug 11, 2022 at 03:46:35PM +0800, kernel test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > > head: 40d43a7507e1547dd45cb02af2e40d897c591870 > > > commit: d79b32c2e4a4e66d5678410cd45815c1c2375196 [14849/15097] vdpa_sim_blk: add support for discard and write-zeroes > > > config: i386-randconfig-a015 (https://download.01.org/0day-ci/archive/20220811/202208111501.5PSP1WaM-lkp@intel.com/config) > > > compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 5f1c7e2cc5a3c07cbc2412e851a7283c1841f520) > > > reproduce (this is a W=1 build): > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=d79b32c2e4a4e66d5678410cd45815c1c2375196 > > > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > > git fetch --no-tags linux-next master > > > git checkout d79b32c2e4a4e66d5678410cd45815c1c2375196 > > > # save the config file > > > mkdir build_dir && cp config build_dir/.config > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/vdpa/vdpa_sim/ > > > > > > If you fix the issue, kindly add following tag where applicable > > > Reported-by: kernel test robot > > > > > > All error/warnings (new ones prefixed by >>): > > > > > > > > drivers/vdpa/vdpa_sim/vdpa_sim_blk.c:201:3: error: expected expression > > > struct virtio_blk_discard_write_zeroes range; > > > ^ > > > > > drivers/vdpa/vdpa_sim/vdpa_sim_blk.c:204:25: error: use of undeclared identifier 'range' > > > if (to_pull != sizeof(range)) { > > > ^ > > > drivers/vdpa/vdpa_sim/vdpa_sim_blk.c:207:21: error: use of undeclared identifier 'range' > > > to_pull, sizeof(range)); > > > ^ > > > drivers/vdpa/vdpa_sim/vdpa_sim_blk.c:212:60: error: use of undeclared identifier 'range' > > > bytes = vringh_iov_pull_iotlb(&vq->vring, &vq->out_iov, &range, > > > ^ > > > drivers/vdpa/vdpa_sim/vdpa_sim_blk.c:222:38: error: use of undeclared identifier 'range' > > > sector = vdpasim64_to_cpu(vdpasim, range.sector); > > > ^ > > > drivers/vdpa/vdpa_sim/vdpa_sim_blk.c:224:43: error: use of undeclared identifier 'range' > > > num_sectors = vdpasim32_to_cpu(vdpasim, range.num_sectors); > > > ^ > > > drivers/vdpa/vdpa_sim/vdpa_sim_blk.c:225:37: error: use of undeclared identifier 'range' > > > flags = vdpasim32_to_cpu(vdpasim, range.flags); > > > ^ > > > > > drivers/vdpa/vdpa_sim/vdpa_sim_blk.c:202:7: warning: mixing declarations and code is incompatible with standards before C99 [-Wdeclaration-after-statement] > > > u32 num_sectors, flags; > > > ^ > > > 1 warning and 7 errors generated. > > > > I'll send followup patches to fix this issue and another that I found > > building with C=2 (virtio_blk_discard_write_zeroes fields are __leX not > > __virtioX, so I should use leX_to_cpu). > > > > Is that okay or should I re-send the original series fixed? > > > > Thanks, > > Resend, I dropped them for now. Unlikely to be included in this window, at this point. > Okay, next time I'll build also with clang. FYI, rebuilding with C=2 I also had this warning: ../drivers/vdpa/vdpa.c:811:19: warning: cast to restricted __le16 ../drivers/vdpa/vdpa.c:811:19: warning: cast from restricted __virtio16 I'll send a separate patch for that. Thanks, Stefano