From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44EEAC02196 for ; Mon, 3 Feb 2025 17:55:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC0096B007B; Mon, 3 Feb 2025 12:55:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C700D6B0082; Mon, 3 Feb 2025 12:55:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B37616B0085; Mon, 3 Feb 2025 12:55:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 95A2C6B007B for ; Mon, 3 Feb 2025 12:55:57 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4194544B94 for ; Mon, 3 Feb 2025 17:55:57 +0000 (UTC) X-FDA: 83079386754.07.0604767 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf23.hostedemail.com (Postfix) with ESMTP id 4DA16140015 for ; Mon, 3 Feb 2025 17:55:55 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bYvrBV3g; spf=pass (imf23.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738605355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SAQHvdvrqS5BkvseXrC++pTbIaALiULGra7PwXB+XpQ=; b=VX6m4fU/8CKxK7M81q/WQpDkSglC/amGE+gMiHnDRNkaza75XaiWSw9uP3VmNMOw0kjlb7 j1M8Ts6LDZ3qE9mLH0IqYp5v2EC3d38LydcMwXOoWQRcZnPdBxhNpot/akXoxIamGDqCWo iGNwa9IKDTZBVZa1L/InWYxDmxeFAP0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bYvrBV3g; spf=pass (imf23.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738605355; a=rsa-sha256; cv=none; b=n3hbwdAZ270lTeLzir8GK+3VURGHkfMe+hnfCLB3tQjy7M/ewPHresdwndqgsPqo6rVNLw e/nM7n3xVCuS2Zepj1MFhcghWmyy/Tx339qGpD5gK00yyIJP/yVWdmYWNy9ZzhNt6aG6P2 7MtWMpTTHy0odT9ogx0xjvPlaKDkAm0= Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-ab69bba49e2so709648666b.2 for ; Mon, 03 Feb 2025 09:55:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738605353; x=1739210153; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SAQHvdvrqS5BkvseXrC++pTbIaALiULGra7PwXB+XpQ=; b=bYvrBV3gf64mPOC+NXyQpiTfeH8LX3FTbs+y+aPooX7t9E2yX3f3a5U+1U9HbAz2UY /kiveU09vASh/7SAlQbwa+JQuT5L76vkS3qbzMIGgj76+ik4DOVYYKu9enYGdGbJeZxM ThW9efMzIYnl7AsNHfzWwbjri/UBn7LWs/FDSNfCBudCUWPr3LlDU9UuTzPNCmKZ3IH7 +Waib2atHSxwF3h1fw2TqISRatZ21/3iFodrBmDb5aBz3bPNNc3zOQsJZRP99GEjvx7a SyPkWGudv0BLDs77cbLH96fkdZdzopAN5v9iRjudxLdHuH3DWzvaIcnFbRbBKLatBnco BLzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738605353; x=1739210153; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SAQHvdvrqS5BkvseXrC++pTbIaALiULGra7PwXB+XpQ=; b=U2Z/9zry2p77EneRDbJc/9Pvc1TqEofK99iMfTVDjzaa+Tb93zJ5HT5xICwrQzXS20 o0Ulh4WzRmzPNtfkX6ZUz/ZjqYQClTmcpTmRGQ5UXseh8/+GzN4tpaPfPfdh0K209EYJ Ka+JuKd86KRksvn+HPqbl/OSm5yiOaKK2fzqAK/3/wEXXkL1eT+ZT3tO8Hlsc7pJ1SOB 2Lfb3MBH//6SzasPjWQvpgkS5X7E2Pj2u+kSvWQXt9D/A7uSAf+syHLrtRZ+V4UNFpUh /DfyapsIHo4gZym4W8TyKa/VlzVowOM65e2JYm5unjEpgEQPbJi/eTrBncVAj8o9ppnu w0DQ== X-Forwarded-Encrypted: i=1; AJvYcCWvTLEsh+CBui2HKiLFXNN5Sei8kF/Wp0YwPJyCobQSG9I6VDfyyLc9nYjYFYNRWRYswJIm3kAhTQ==@kvack.org X-Gm-Message-State: AOJu0YyOABCB5oYX+xiXwF8aKBR8pXjRSUz7E+SIyJMJtGOOGmkm3N4q C89kE22YMhK0AAd+fOqtTtd/zU7p8YzJb0UOM3d1RvsAVOYcDbNbNcGmCDGdYxKD4psqQAII2rv Zgj5rIOCAf9A98QhgPT+OeARN+3M= X-Gm-Gg: ASbGnct5syxWJxf85XyuDsxSI0K4X+3CRqCXDcO+Yqp1QmnZyLurW8joYNxQSUsz4Nn JW2S8IGI7G5EuFRJtVnKfzQPmvMI7IWLwEQMWkhh37RhQcFo0YCt5N1yWy6c11IymypTlLKI= X-Google-Smtp-Source: AGHT+IEtm/SX1sQBNwg57zqZoD5XtCJMb4nE0ceLKF1Zpom0tPPv1Q3okJvhClprHDPRLznwwtLCyvMBTlNODCOQnPk= X-Received: by 2002:a05:6402:a001:b0:5dc:7374:261d with SMTP id 4fb4d7f45d1cf-5dc737427bfmr34603992a12.7.1738605353193; Mon, 03 Feb 2025 09:55:53 -0800 (PST) MIME-Version: 1.0 References: <20250201163106.28912-1-mjguzik@gmail.com> <20250201163106.28912-2-mjguzik@gmail.com> <20250203175123.GB1003@redhat.com> In-Reply-To: <20250203175123.GB1003@redhat.com> From: Mateusz Guzik Date: Mon, 3 Feb 2025 18:55:41 +0100 X-Gm-Features: AWEUYZlbvHvPufmBaHPz_csfz_c4fuvAVdfpLeRzOEKCPVQGg4LsT_Gr6u3hzVE Message-ID: Subject: Re: [PATCH v3 1/6] exit: perform add_device_randomness() without tasklist_lock To: Oleg Nesterov Cc: ebiederm@xmission.com, brauner@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4DA16140015 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: hext9gz7kuqwmfhgoyt8sndwwuhkntiz X-HE-Tag: 1738605355-708937 X-HE-Meta: U2FsdGVkX19quth+8Op5iAikUnbgTuXGsA/GjpXOsQmIY5nmpSGZBQJEV7eK2m7MIVNtFEZyzipTFrlHzCc7HVKY42qKrlHbdD1tTR9RrSOpcRDzsheSztMWfPvOICulBRGxAN0q3Mr9QEdY2gQPNStiy6Xsx6qs6teCNkB4BOY+Qg2xivRpsBsFNzkIF4WyAb+Q46Ro8f4RcheMBZL2r0E/hQ/ueYtIOa0AiinZYfruGTynYWp2wt9WO+KeqgGutUutok0rbJrB1G3mk4o51W3TnbLJ/2+SoN2HwSt2N37slXbwcFv9zZ99n2wtAUXiZzAlHE+2j0bg11i/qs4ya1IWCfVsCOa8bFheNGBY7S2BorRY05An9pDyUd2n3XeX1FtwW90W218yFcK6G5OGOJA/WsPHmbBBU8PjWwUi74DTFwExKjXMCGe/zYTdAvboQQ2oJbhuNAy61/y4B19rLfToCTx4PWa2mxLaHW6kf4dUG12TNXh9e6oQ0Cjp4OjJudfCB5v027mNgtTD40oAjq+pr+oqSNC0E7w9GwbJ6mOfPfn/QdwfUhPVyNpW6kYZ84x89W0WpYdKfm8eqOtwqPU55bGUk0D1nHGXVIXCjTDf66+DWGY+KEZ5EL1uK9ySQ3beXrGWFSA+vYAJLzzKTRfmKB+iPvG5Prxn875BE0foUMLktRtAahQQSq3rw+S8st/jYg82V/mlMN+c1rM1FDUREkunnX8DLD8npmF4BtxTrMPcBTv5D/P6xz6VpADoBz+/H1TKQY+PCBi2xvxm4G8oMfAfcFZeMtZfhViAnkJjyo0LuTxRquit2cECi4ZC7zj9Bxx+ynCYmNDXru/d+1hTXE5kPPp045fElIINoaFsufozH+u77q7MuAL3QpePCeDCRROjKT5lnkcFAOIFiuR/HBqt0r7P7kEPdXmQyn9uu+WUeRG1UNqSyKPG+q3vv0yEBiYKR4qnvCN7QFo c8x/Tpu2 zOTvtWVKyn3icljwdDUU5hYoZZj7syhQEpT/S99QrrubCPWv8x6T3OyIMwuCb1A2ezcRj3GqRM+Ayw0GcnzcwwrBsLYO+qfBEpBPiHq61vlzt9hIHqfozBAgyvJWHJv/Qb2gM10SLO6PDaq5eOvW2fZWMIkNCYkootny+PaslqiZwZSlKlV1w8UbR0FKmgYHjOZN8ufAsvHLYgVqQZCkfIJWrF2Zj8AEzecZfrnd7bSILUASk16BJ1jjRXXNiRZVmu+2EO8aPLi2MhlUeDWeHyDnPnPP8rhWkqJFANHybFyTDYuIXdJiAQKmyqZTDoIEzqims2YXIuP+fhYIYmTBzw2iI6WcZFTgBD9dEkha/qFLCEUOCCOF2l8FTG8FJGWcICx1PtyEFLkllXz9EB9I2v+o8wWvkcErtOd/Bq+aQ7pskMQNxx/55aVd1sQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.362038, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 3, 2025 at 6:51=E2=80=AFPM Oleg Nesterov wrot= e: > > On 02/01, Mateusz Guzik wrote: > > > > + add_device_randomness((const void*) &p->se.sum_exec_runtime, > > + sizeof(unsigned long long)); > > I won't insist, but do we really need to keep this ugly "(const void*)" > typecast? and perhaps sizeof(p->se.sum_exec_runtime) will look a bit > better? > Thanks for the review, I'm going to wait for Eric to chime in before doing anything here. As for the thing at hand, I tried avoid messing with it in order to reduce discussion. :-> However, we seem to be in agreement this should be augmented, so I'm going to do it in v4. --=20 Mateusz Guzik