From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B84F4EB64DD for ; Mon, 7 Aug 2023 10:48:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA3926B0072; Mon, 7 Aug 2023 06:48:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E53FF6B0074; Mon, 7 Aug 2023 06:48:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1AF88D0001; Mon, 7 Aug 2023 06:48:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C30116B0072 for ; Mon, 7 Aug 2023 06:48:56 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 905D0A0715 for ; Mon, 7 Aug 2023 10:48:56 +0000 (UTC) X-FDA: 81096985872.24.821F44A Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) by imf14.hostedemail.com (Postfix) with ESMTP id CEE11100015 for ; Mon, 7 Aug 2023 10:48:54 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=gzo6Nysg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.160.43 as permitted sender) smtp.mailfrom=mjguzik@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691405334; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZOqvjYpL8TOY1VQyCJX/k1Wl0dCAzqBeX1FG+QU3ZR4=; b=AUCODbMJC/GhhzH4olhUSmWuISbjI/vStPiIdxGFzIj7NpxJpXGQVDCOi2gb61G3WXhbf9 X2UgcLSD96V7C2b4ISk08ugkvglcQKcwsP/ADtbslYv2hAP55VfSVOqFVKmo59sCZNPl7b /l1gRhCbPjjAUHEkR3SPCkpHN4zUqJQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=gzo6Nysg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.160.43 as permitted sender) smtp.mailfrom=mjguzik@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691405334; a=rsa-sha256; cv=none; b=UcxxPXuIHzz2HArcvF8nO5/u7YkfjULsvxj8Qb0zGQSTnYkJixmX3bykmei/Ga4UH3ayFj BGY2qXzJluHfsHnRqZKsenpBk7QuJvW+aQ1hSQekovoSoSyH2ILwM5fM6q+Dg6d686C4bq MWe2bSbw4qt8ukglecVZwhYa2ev3+Lw= Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-1bef8f0904eso3168811fac.2 for ; Mon, 07 Aug 2023 03:48:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691405334; x=1692010134; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZOqvjYpL8TOY1VQyCJX/k1Wl0dCAzqBeX1FG+QU3ZR4=; b=gzo6NysgKKweswL7UjeFF09Y9Ji9Z/Uf35i4LQFrP2/dcJDHC3DI4879BexeA91mcm z57MKJY/ByZcaAqP+krUXrut6lJ64eQqk0AA3hgN1xtyRpnbXOM6Ln+Zb96JjxqS82pB fJUSk81uyUh5w8E+a0TWGnYrObQqTwoE5qbBSC0u2Lc8xRhqK/qh4WHRgzhDCCuCFBcY lgpKrODnkD6Qud5xAGpvV6011VAjCDlP1uWz1egqTmfmGSJ/OdeyJ3MLwv/jY5R7qrKL G782BxQ/6StluxlFjNdYHp+3k1l5bOaBIirjO4NHAsLhFG7yxjnxIGmleMJbf8zUHT/c 6aIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691405334; x=1692010134; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZOqvjYpL8TOY1VQyCJX/k1Wl0dCAzqBeX1FG+QU3ZR4=; b=WkKrTTSJ6TSwxrB4rv7lvj1z2sx4Kxz+v/tC+TENNjoBqEmJPKMCxOpzJkVXLRpE7z AwWcJp1YKiLZFlLl186yBV9A2Rm9zck1dv2q2uxgt4GCbDpe9DReZJHGMuoOxbXDosAm T5XFDs75S10qwlXRHg+ZZZg4hIk+m+T0aeWozPkp8T8umjV3DIF53shwmCVWArVzzxrr MMC8yAAkQkgUCy2HpvGzSnPVYFJi9Qgc2kkVIOltqAQ8o3PRt63l/kO6v+xzsDU0Mk/A qfWB2QVBxE2cjFNErd73ejYO+K+FeGp8VsRqKu803cUsM381QxkwTBnXrPwiF2JMsJpj hIXA== X-Gm-Message-State: AOJu0Yyrs02e+iukz1+PtFqpXlwz01pJoWmvVXPqrX6ixJBC0qgWnwVP as94j+MHW716TW/SPfcMPID7Wq0hl7oYhTuiC3Y= X-Google-Smtp-Source: AGHT+IE+8t6WZmXSA2gENA1tNwHAJ+VRkzEbu+o+tPqzLzZjNhYYW9QWCVRwSEdItXD2Ro0U1Y9LHJOpP+xowR4bSgc= X-Received: by 2002:a05:6870:d0c4:b0:1b8:5d9e:638b with SMTP id k4-20020a056870d0c400b001b85d9e638bmr10052976oaa.43.1691405333876; Mon, 07 Aug 2023 03:48:53 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac9:7b87:0:b0:4f0:1250:dd51 with HTTP; Mon, 7 Aug 2023 03:48:53 -0700 (PDT) In-Reply-To: References: <20230806231611.1395735-1-mjguzik@gmail.com> From: Mateusz Guzik Date: Mon, 7 Aug 2023 12:48:53 +0200 Message-ID: Subject: Re: [PATCH] mm: move dummy_vm_ops out of a header To: Matthew Wilcox Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: CEE11100015 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 8wez1t3uowjqrmyqxi99fq9fcnj6pzyp X-HE-Tag: 1691405334-742830 X-HE-Meta: U2FsdGVkX1/2t0ZVKYIPs//x04k2J372KbJ5Ju82TsN/Z8b1QnLs/taPuxTcUhe1Tq1Iu9u5ChvhwLeLKoLP5iJgqoo+ZjnCcmrpXUPCCFFnPcUSmUPs2pQdhIITdf+R5r6IxCd+Umdaf4bhKlKpfM405NRJ0UvQVcj8eNJxQL9TFuD0O+num1i6d/ilsZitM8OAruFa8lxMCNezoE/gPNjqUln/8yCJEbKS8C4rAWIrFiKHBHHPz1gs3yYohQe0azM/krjRy5ajmTW3jSP5Ny73rocSCdQrt7emJ1AARoa5uQcsrNv4r3oLfOdZlWiOEoP8pBL/m1Y/mw5zqeq4Vq/5zdSlOu9K4o/RKd3zqLBsN9CSVPsdafmvx4vVk0oZIstCJoZUD2PAi/1vSztFp9qTTdv8N+kubhcT4/a1mv/AF4/2tvD8B8Az8Bt/sz4U6wyDIspGB+REk957cFSLlrxEOCe7G221uyT1BeF51MDLHMWm/zbJ9yM3FI5Tg0SeSeUAfgbOxtma+lndxPNHTtMcEWn0prLhL45Uh+zUAsPNrwLgsfRWCL/YpuMRbCCZDe4E+u7+RFKYotOReyOB+Wwo+WFOGaGO1jCcPdZcvR/T+t82QcS2VikHEr9txY55YQrb9lOiIMgFncATl0yngfxCgYotnATLG/R9fUwWbrpa6DkU4krn+uMB600/7mQYwyS0inzt1a+9JC0CTDrMAg4zCO+jklJOjF1mVJvSRX0k8OfUh+aQChfcBU9qt7s6grQ0zswwr1lw8tOHznQRuGIdODR8vLBw3MkNxtm6pqK6waIDBxAQRtHOKQWhHPDKAyjo3BHhbB22czVRSctpPcTG1ZGO1XVOWmngOOh+ka0JTJvTIYmO/0+VIfqiydlLSL6A4NacVb2QUOExaZAsVKZrAFEbNMS9gSOPq5dfS6Lta8ogfQaWd0HbBYkCNclJlS/NSXZsMSjhwHUjfI5 QwK7gXvp Q/LxzD2CdlczZ81WNtaf8SxWHqeS4jGSf+RPl2v71g66rKYlbG+3Q2sfhbPQNAKNjaNcLJlzYUnujYHeiYOIecOTq5C4cL5QwEZ+jjbWl9eNLKiGMEkJkj/xNxXRfGjWjBooEn7YQn5b2MsbjznE/T/+MU3s6XiWbhsmIjrPKgn+tNsEv3bZMiiBnv45Qnc1num+1I8G+M1L96PoIjQlVKh98yZILk3WU5IZ4kD2f9xa8PRabPR/Egcs8JC9+oziu16c4apTCtbBxNZuqxrNv+rv31/T6cr1LXYN/eexDsrqUmp81BwlShSGAc1i+pHkRZ4Cq7b/YWHQVlYk4ea5F9w/TJplY6GDC3tMd+xRtWKkO8n6e4ySK5RKIXSq4QBz4mYmulycDND5II3gbkiHdTGyLX5hK89VN+EBn3ZR+ldC3hlh2Rt2DQkgm03E4WxWeMkIsXB71AbwuUdPBgi4GcUNOzQTLdICj1Vfh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/7/23, Matthew Wilcox wrote: > On Mon, Aug 07, 2023 at 01:16:11AM +0200, Mateusz Guzik wrote: >> Otherwise the kernel ends up with multiple copies: >> $ nm vmlinux | grep dummy_vm_ops >> ffffffff81e4ea00 d dummy_vm_ops.2 >> ffffffff81e11760 d dummy_vm_ops.254 >> ffffffff81e406e0 d dummy_vm_ops.4 >> ffffffff81e3c780 d dummy_vm_ops.7 >> >> While here prefix it with vma_. > > It really shouldn't be prefixed with vma. Other than that, I love this > patch. > I think an unprefixed global is iffy, but I'm not going to insist on semi-cosmetics. The one thing I expected people to complain about is the location of the struct. The mm_init.c file was the least bad choice I found, but maybe something else is preferred? I'm just trying to avoid sending V3 for this patch after someone claims dummy ops should land elsewhere. ;) -- Mateusz Guzik