From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F9DBD743CD for ; Wed, 20 Nov 2024 19:48:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC0AB6B00A6; Wed, 20 Nov 2024 14:48:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C71196B00A8; Wed, 20 Nov 2024 14:48:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5FE66B00A9; Wed, 20 Nov 2024 14:48:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9809F6B00A6 for ; Wed, 20 Nov 2024 14:48:06 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 55C62140BD3 for ; Wed, 20 Nov 2024 19:48:06 +0000 (UTC) X-FDA: 82807506684.07.AAFA45B Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf08.hostedemail.com (Postfix) with ESMTP id DC3C616000D for ; Wed, 20 Nov 2024 19:47:29 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LYpgwtzb; spf=pass (imf08.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732131838; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0Lo/kZvQNQE+R2Vx1FWC1P/Kjp3Xt+Dk8cqzo4Z7ln8=; b=d92FEvXoe+y9b3+sgBKdzLM3ON1Oqh6H4zevgewjNSU65Yxwow9aOjbXb//qaAaYBKYa+T Cg39Ya4/d5S8N4mQdO2Uzz5SYikLsIKrAwLbYXXnyW/6pobjb2ddCjgHhgT9jTrLfQZmH5 iPZdHpHjYrZSOfj19RkiIgGjtg/aQf0= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LYpgwtzb; spf=pass (imf08.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732131838; a=rsa-sha256; cv=none; b=wZI1gQ9mHM7t5JdjSt2atDrDulENBaHNr5Tl6ln4DbOEKeqwCWpKPb0/kJ3nfopFmSJ0Ib HQblh73u1P0lDCoHqp77yFOWC1al5jPOr0jUu1g0eWevoVgPJJKfvt3XGoW7N1/TFfjbS5 m8FN6l+jy1R4UN8eBBP7W7VyNm2SCkU= Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2fb559b0b00so1657351fa.0 for ; Wed, 20 Nov 2024 11:48:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732132082; x=1732736882; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0Lo/kZvQNQE+R2Vx1FWC1P/Kjp3Xt+Dk8cqzo4Z7ln8=; b=LYpgwtzbalarRyI4Ga71ZX0dgMC7mT++unqhHn+G4ROeiDBz3PSmBILZ3k0c/BHcoo fi7vRcI9fZCe2Qzk9EqJnFl3joSkKi1yvb57oG5dE+70AyIONgQzSfaLOyGpyw5HIObE qT3CL9wcvqUofYhPkd+32DOV/jUyMr9SLq7rBJJzPBPgfe3SJqJRvbz1GFp448vHwH57 jqLUn4W+hWO2pli9JoVdPwDsmBXDW5vZSMRwXSiKmvUBzh4GCnGVdmaDRa0GTcWqsowm toQmwSDUky35aUP0vKp8GfGY9DqF1/2tWvg5NDrK6fXUxNdjRmxlvN70vS6Ik4QIAlRr WSxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732132082; x=1732736882; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0Lo/kZvQNQE+R2Vx1FWC1P/Kjp3Xt+Dk8cqzo4Z7ln8=; b=CPsU5sYzFoG7reK0oLVIxT0+TwaR7Po5ubrK6xwBKC5guW4Agw53We0whq0uox3soQ z9qrhRkKrJz1P59/Ly0BAfVVnTcJHhNWi3ztHik7Q77U0VNz5u/xkBuR4JfNeU4GDE7y oTp8Y+bvO7SGg+OUlMoy6oEJ8lDz+nic1hMPJ+XUTAczwNxeeshaPQh8+O5JlmV+hdV1 o61OsjQK5OkiAnJSX3qskNTevJ2uJ7dTarEcERACSr038wzRaAJdSDZl5bP2viwmDwJ0 H4vDDHWW5YcuRPeaLzKSMceox3EC4fvQffMSU5REPR5B477hOeBDEyC1niPJ1xlwKDMB TgRA== X-Forwarded-Encrypted: i=1; AJvYcCV5Pwz+n/hiOEi9JPIInyB8iaMkLkRFRMFYbdAELnOr6F6pqD0eQ2yGCmHHAULbipX1Je1aBrxu5Q==@kvack.org X-Gm-Message-State: AOJu0Yxk3MZkjr4UBE+sv5ZMmi2Myl7g0LpPtGYQ/wGI49zA47JqPD15 nWwJKHEFqI5YspOqh+08Hd6VhP0S7fhyYq/KqOhn7QXt0bbufG5RmGf8fsTL3sFEjvbvWT6u2uH /sJzoAk8g11mNZj8bYH3jsgxe7dw= X-Google-Smtp-Source: AGHT+IGTfArAZ13mpiOO2SvdLo5EAkhf22bPd0jLhEBjn43o+OJhGiIsD49VHIWNLOW5OIe+ZoDj5eU36oniMb2Gv4A= X-Received: by 2002:a2e:a58c:0:b0:2fb:34dc:7beb with SMTP id 38308e7fff4ca-2ff8dbcc0bemr23118331fa.12.1732132082284; Wed, 20 Nov 2024 11:48:02 -0800 (PST) MIME-Version: 1.0 References: <20241119094555.660666-1-mjguzik@gmail.com> <20241120-werden-reptil-85a16457b708@brauner> <20241120-eisbahn-frost-824303fa16d9@brauner> In-Reply-To: <20241120-eisbahn-frost-824303fa16d9@brauner> From: Mateusz Guzik Date: Wed, 20 Nov 2024 20:47:50 +0100 Message-ID: Subject: Re: [PATCH v2 0/3] symlink length caching To: Christian Brauner Cc: viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, hughd@google.com, linux-ext4@vger.kernel.org, tytso@mit.edu, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DC3C616000D X-Stat-Signature: 3eeyeedxdyx8yweyn7kfbc8w894frr47 X-Rspam-User: X-HE-Tag: 1732132049-269965 X-HE-Meta: U2FsdGVkX1+uxiKDwVczdp51X2sPC80mQFPyG4X/DSRTKQSm7C3mDcGxiOeq6D0YplF8s8lo608116+gAbyyCr4sPgO0LzsaEJEgj7c1SPpGgEi8BNXU9T1wrymKkfjrQM2Bdo48CQK+BAufPxsXUkEw8ndZh5IcCw/ubIhOPSaFsY35QVz8Xm34GTHvFmRR2UXeP9K7slEv0OfMlhRlRDGwqdil3PrAIgjMiAHVUmAGPvHQPjMJ/Eb55IKGQCG5q8g5FykDyO+ZenWEPIfIvH6alhYm/49gFETM8szdI8qvPYjnXVVuT19AMlVb5yqgURciFaLP4d/Sbfcuxdt/pa9VTELUUuyYzf83yvOyHfMFOyIq+BZcD2p0NVC5JQ2AuDaXg6gKtNpqkFsf5UgUfTHMSwyg3+hgSfq4KEm27vPzzQrTZatCeZnPEN02eD5EupTgcYtQF18K1RaYV3ZxJlRGrRHXvLhAxhMvu0QERkTzB/nvJNKLYEigoecePDHAAqY8lktjSneaNaC8vQOTKbXAgSJBjIrahbhNfNi4VRioFZOSuU6Ptk+E9gsJt9+6K7CyIpzu80fJMhjkVWblZDL5tN/2F8VmftJpfSdcw8Xnv0TkCPcr5/0YsfvbBxOuOERCksHWtAYTEJjGRGtXbwGs+o98XjiEMKvBk3BqXMmW7SrMmQqdE+UqlIvQQpcVayb4A3gDQg4p5tDLTTp4hjExsIYmjlJ9JETcxunYZ8XLs8+cC+OMp3EEiTWy2Xcuia261IIHvzGXFhCddtxkD3vAaUBt2ttuuZFh/J6Tv3bMSBcGtXVa+P8DOplU93THUFcDrsGNk3HsKwOXSuWSpjxcGm/lPnYjlwlmWVUc4UwxTlnuWsEuyQGxz/teE8D97D4b2EtjrJsm6D9DDfU+ezUm4+DDXSNqX+PkLIQwX5+FAH9f/A1MlGie2oT06D32wklNy1ICmwkmFdUtXE0 XzU04Snt zpRp5YHj/taBMyT7IgaqGggzZCRed7AP7/aHM8Zt8W/giqboEUQCl27Zm6lT8mvSIa96vWvmxsrgDjbZNlNCugfVinDSarwKhSAO7Y4SnRA59WeJhD9MYdzVFewNSdkh278BfHLn+GlgT0mrqJw2GmDOCxcmQxAXLBVbuq+FAYaJq6d4cxKwFnd5DmcukyXWCPbSocqMeQEtTbN2Tzhz45tPHtyqMWK28vY8ZeCd+EAp6RyweCuBY9rU9IQhQk4GiXCzV27khTmZroT9jbCXll2/45/LBk/u/gVTO0SgktsbxF1BboaXp7vX3GdTOxBG14IuRYqwA4bMYi4Y26RYsazYgKhs2V15x+h26+KXN4JjvE3g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.435248, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 20, 2024 at 12:13=E2=80=AFPM Christian Brauner wrote: > > On Wed, Nov 20, 2024 at 11:42:33AM +0100, Mateusz Guzik wrote: > > Interestingly even __read_seqcount_begin (used *twice* in path_init()) > > is missing one. I sent a patch to fix it long time ago but the > > recipient did not respond > > I snatched it. Thanks. But I have to say having *two* counters to check for each lookup is bothering me and making me wonder if they could be unified (or another counter added to cover for either of those?)? No clue about feasibility, is there a known showstopper? Both are defined like so: __cacheline_aligned_in_smp DEFINE_SEQLOCK(mount_lock); __cacheline_aligned_in_smp DEFINE_SEQLOCK(rename_lock); Suppose nothing can be done to only look at one counter on lookup. In that case how about combining the suckers into one cacheline at least? Sure, this will result in new bounces for threads modifying these, but this is relatively infrequent compared to how often lookups performed and with these slapped together there will be only one line spent on it, instead of two. Just RFC'ing it here. --=20 Mateusz Guzik