From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13A1FC52D7B for ; Wed, 14 Aug 2024 11:06:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60F9E6B0082; Wed, 14 Aug 2024 07:06:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BF556B0083; Wed, 14 Aug 2024 07:06:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AE656B0085; Wed, 14 Aug 2024 07:06:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2C1BE6B0082 for ; Wed, 14 Aug 2024 07:06:33 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E29F51A0DEF for ; Wed, 14 Aug 2024 11:06:32 +0000 (UTC) X-FDA: 82450572624.07.F5C7DBA Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf16.hostedemail.com (Postfix) with ESMTP id 0F25D18000D for ; Wed, 14 Aug 2024 11:06:30 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CZU38ZeS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=mjguzik@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723633532; a=rsa-sha256; cv=none; b=hG38U2PDeEZb44lLq8gvRLtsj7ZpdBDHD2BvBdCwP+3LUR69+EtkA0ysmgU+3wVkrSmHAZ CcRJFIooyi91+GY8z74YGkYdpD9cMtDRwmBZID6PxX0lAUzkdtaQzrmZX1/3xe2Rq1W2tX nU+Yi14sX+2o5XrBHHkMIKdTS3qTYhg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CZU38ZeS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=mjguzik@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723633532; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=37k6zoJGI4ySfWeQa+WNWY1gPNVBQcPCdoUsogardSg=; b=k2RGNx2POK74dwyaRF/SQsq+Fx3r0DZzO04b2FSRuMVg6gp/uj8DRtq7F+DUmmz0Kja8Fg EWkiVic0rTXBpHJY0EtRSV91LshJ5Zbss6Uc4ue0DrMv/E+MW/wuV5DFmLFFujMXw+qClK 8+cA40g+Vo/h+KQPPp8DIH4ezGjPetM= Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5a156556fb4so7652190a12.3 for ; Wed, 14 Aug 2024 04:06:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723633589; x=1724238389; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=37k6zoJGI4ySfWeQa+WNWY1gPNVBQcPCdoUsogardSg=; b=CZU38ZeSoA2j6JEGfjs+LgKuIJDktQH5KRS4QR3G+2D8VTtpdIar5/hzzGM4KJavch IrPOB1jYuun+nocfTto7l1sGn+470susINaBFlnQv47IFuU2fQzakhTmG+m7skLz+Yx2 u+DSQXZqQ/2o18lwI2jn7wjkuUzgDFJdPxbRqzFRbZcbz+bcb0g0Gs+5HvAy9faoVqIS YGCDX/Fb5lb9BYpWag+PSfXueGFcyOXxcr7T6T/H4o5wNAO40pmn6SXJqTuWhBuV0h0v On6pQKJe+04kKJTT4/nennLMaLCjImwuGE2REjzzLS5tsNALR+aMy8muTIkuvniJKVAL Eoew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723633589; x=1724238389; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=37k6zoJGI4ySfWeQa+WNWY1gPNVBQcPCdoUsogardSg=; b=UXGdUWkA+1Vb8cw16SP9zms2Y+Na88YPPQ7BjFmCb0yUmpMXX9qXJEz3+5S+HzDBXx GpfHLwgBoWkz3knfsTBIRfGJ6KRDEQ7KIH3rrRql+g0vKwbL9vjMBOATTkITincdpM/M KGUTdwfr+Sl0N7go+yoZJu1yTPr8SXd0nTIPX0jGWJJqj7c3vb7mUD2MXOTAtc7tPb8j LibCwGYejZ8HWuK36trRKPz0DRtNrjlbyE68+22z7ZgK/NbLN6iEue1R8vimHSDyX2fL V6jJcrGhgcZZGKQcoJ7CDxnpfXdeXVkoK6lWbS6HeI7PBhXya8FyEdEp//YQoZQ9FrY5 c9Mw== X-Forwarded-Encrypted: i=1; AJvYcCVJJNYgsQfc2kgI/A2W0+/oh1X3f3Y3PMShuCghZa8NOdlcP1PWL4WRmmARFT+Hz9mSYYA35PVYdXzTGmQqM+zZO24= X-Gm-Message-State: AOJu0YzkTkFUi4MSxWs2JH48VTU9VROHkz9tgvUu3mxJK1/Vb5Yf0Asi KNSzMMs9QgeunIXCJi6Zs3kzE4/vZniBEYapAWwYWbM+BfFs5QugDprwvtQ+3G7xa3nSDvw2VVE 8gAQn47jNajXH6y5ijoh/H3+ajFA= X-Google-Smtp-Source: AGHT+IFxno9/G65dhVjx9wlF+xu4tEDdgzUpJUbvbTdDjN+mgCawXy6DPLVolNNzGcxoDLTcEYyfGJZYqxfZiWA7z2c= X-Received: by 2002:a17:907:c8a0:b0:a7a:b73f:7582 with SMTP id a640c23a62f3a-a8366c120e5mr172158566b.2.1723633589129; Wed, 14 Aug 2024 04:06:29 -0700 (PDT) MIME-Version: 1.0 References: <202407301049.5051dc19-oliver.sang@intel.com> <193e302c-4401-4756-a552-9f1e07ecedcf@redhat.com> <439265d8-e71e-41db-8a46-55366fdd334e@intel.com> <90477952-fde2-41d7-8ff4-2102c45e341d@redhat.com> <6uxnuf2gysgabyai2r77xrqegb7t7cc2dlzjz6upwsgwrnfk3x@cjj6on3wqm4x> <5a67c103-1d9d-440d-8bed-bbfa7d3ecf71@redhat.com> <5c0979a2-9a56-4284-82d2-42da62bda4a5@redhat.com> <817150f2-abf7-430f-9973-540bd6cdd26f@intel.com> <116e117c-2821-401d-8e62-b85cdec37f4a@redhat.com> In-Reply-To: <116e117c-2821-401d-8e62-b85cdec37f4a@redhat.com> From: Mateusz Guzik Date: Wed, 14 Aug 2024 13:06:16 +0200 Message-ID: Subject: Re: [linus:master] [mm] c0bff412e6: stress-ng.clone.ops_per_sec -2.9% regression To: David Hildenbrand Cc: Yin Fengwei , kernel test robot , Peter Xu , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Huacai Chen , Jason Gunthorpe , Matthew Wilcox , Nathan Chancellor , Ryan Roberts , WANG Xuerui , linux-mm@kvack.org, ying.huang@intel.com, feng.tang@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0F25D18000D X-Stat-Signature: co57mk5n63szmj6zw7kg5nmdffnbsyiq X-Rspam-User: X-HE-Tag: 1723633590-868179 X-HE-Meta: U2FsdGVkX19i6gYnbevkwojwCmIVoH08v7nZQHwpfmC3M/e3uDDYoLwbFiH88ci7Ec6doYbbzA9KZembWM6013KAwguhs5/tIyMVVh5rsbG+BhWn/0GI736ukqrT9QVzXIvTe7+gwGQh7c5hSW2l6uQe4EJAEmADkMBoqE6IjaTd0K95In6+Kjwy8LpghckkyenUI0B7iKi8bqdvjD4+bevOzYvMUf6f+MHdoY/+gl4f7+fu89wnkqD8BbA4kYN9DsD7Eesl3G88Hm5/Qvas649KbY722hnead6k9b6bLyUiNr/5jc8pVxxIBBTaUg4BQOg7IZpgVnE4jYFa8prno7jc8QX3Fy0V+Ieq5Bwpzl8kM6P/5vVlpWavQaspBACsNMeMD9lMIl36EAmPXWahmkFRqllj3QLOfvvPTtHIWwOpmaC2ieR+NgiqbdlhrsqjQmLo0/C/T3uh44UoOnSDAue1l7CyeiAGhwVRIvHTZtmEREam4PjacCEaO8kNlBj1V1i9uNb2tJrnX35Uck9Y2CUZG3XlC/hRxkxqjJaGngNlwFKkFEnabdWQc3kmuKky5hsC1Iwz3ucoG6PKZJf0PCzcan6ksO1sFbWfjNIk5DEVxOski3dfkdOUgH8+S+Y7ZqeWvZ+f3U3a7ySp8+xaa/BWFqvCXeH55Uxn8gC2A3QgL5bEPCVZowEgk+OUiIbxZlX4j/dLVOmygU0DuRgvgP1gr/ha4oedBDXuz+Xu9oLlZDKNG30QzbCowqep3eVMzV6GDRGfysaDKDUZSTLi7EKjAcaOIEXWir9HBsrQAgkfeJ4u7/tVFLMl7Kv6EIHtRhyBHVxNv0TqJ3eqt3fpFuOlWM6bWC/MnYypNwwIHgXmaK0EYzbBrm58re2taLupsqTMzGssXjyJ9Pz+B5QdkcOCFjulymmspMB3KS0OgvYAoYvomlK3T98+rE8ZqFEeQWB7U7YU/8pWKdq2RGT P/+SFHX3 cifKbhw86oFQu2CeFEAH5/vbgvQLeivCnYM51w6bS6iZfeKEbXEEEIQ5SQv6yBdFmv5ZPeC7yu9fLizO/bn0IoZpGP8AIoMxq4/c5839nYy/1SCQ2hSwCCyeXAFX67rN/1Us2qNCLhynwrxe1HjKaVDKydK/Fuz4wTdbVu5XNLnu9IYkg8lu1r+T+UaP59x8noiwb+8JzfJFmqQQ2xg7sYmUmHI2x2GJf11ZA6XRPVxzkYuACXcjkxluK5T5CL20bHg+e6A+silSD7/HJAn4OnFebRr1ESWOzI+ecmziWFZ/iIBGtcYqzKY+kUDbvMSvUrAME8qETr1OhMJKi1GzrZPPT2ZqdYDbqgvhanc5gCr8sFtpv1mSoOlblAWDtW/sblnhzXpCotDQYsCbjGI9wsf+RUAn+P1zUbvZ0mM9ubMCEnl5E9A5GqKjmC3rnqVToGdo0Ihvq0SbFxjFEiCXtxMg0+w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 11:45=E2=80=AFAM David Hildenbrand wrote: > > On 14.08.24 06:10, Mateusz Guzik wrote: > > On Wed, Aug 14, 2024 at 5:02=E2=80=AFAM Yin Fengwei wrote: > >> > >> On 8/13/24 03:14, Mateusz Guzik wrote: > >>> would you mind benchmarking the change which merely force-inlines _co= mpund_page? > >>> > >>> https://lore.kernel.org/linux-mm/66c4fcc5-47f6-438c-a73a-3af6e19c3200= @redhat.com/ > >> This change can resolve the regression also: > > > > Great, thanks. > > > > David, I guess this means it would be fine to inline the entire thing > > at least from this bench standpoint. Given that this is your idea I > > guess you should do the needful(tm)? :) > > Testing > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 5769fe6e4950..25e25b34f4a0 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -235,7 +235,7 @@ static __always_inline int page_is_fake_head(const st= ruct page *page) > return page_fixed_fake_head(page) !=3D page; > } > > -static inline unsigned long _compound_head(const struct page *page) > +static __always_inline unsigned long _compound_head(const struct page *p= age) > { > unsigned long head =3D READ_ONCE(page->compound_head); > > > With a kernel-config based on something derived from Fedora > config-6.8.9-100.fc38.x86_64 for convenience with > > CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP=3Dy > > add/remove: 15/14 grow/shrink: 79/87 up/down: 12836/-13917 (-1081) [snip] > Total: Before=3D32786363, After=3D32785282, chg -0.00% I guess there should be no opposition then? Given that this is your patch I presume you are going to see this through. I don't want any mention or cc on the patch, thanks for understanding :) --=20 Mateusz Guzik