From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98738C02192 for ; Wed, 5 Feb 2025 20:58:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FA8B280008; Wed, 5 Feb 2025 15:58:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 28272280006; Wed, 5 Feb 2025 15:58:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 123FD280008; Wed, 5 Feb 2025 15:58:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E150B280006 for ; Wed, 5 Feb 2025 15:58:27 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 69AF3120B77 for ; Wed, 5 Feb 2025 20:58:27 +0000 (UTC) X-FDA: 83087104254.08.61976DB Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf08.hostedemail.com (Postfix) with ESMTP id 8C99B160007 for ; Wed, 5 Feb 2025 20:58:25 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nE+WxmGI; spf=pass (imf08.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738789105; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LFtFpiQi45n5NJYuVtm21fvpqTM5ytcVeKgjnkRWfq4=; b=j4saSQE8xc6BcsHoFEI4DTmUrfZ1T4WdqHu2EfMG/rKJm+71GF45H8DdT0Yr2dezKB4d2v xQmrD4A+MVmulmsmNMulMM4eQZdd69U+/y4JMjF47cAw2MdsUgKxZp2eFVw/vIY0XQVSbo bKNNgoxZ+89dW990Bo5mKdZnQEwvNyg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nE+WxmGI; spf=pass (imf08.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738789105; a=rsa-sha256; cv=none; b=MteKMkU7CCHSm5JKPI+4N1DZ3r7aErEPIzWvVPwPPoqQZmORIT26qZBdAh0afRrlcpeqYU wMnjUgCsHrOvZvRmcv15c+omD+qkoOPAdqFJeRjcazrsN9+XBKryy+JVmPWifpDzPidu7B MX4d7zNlraUibz3OzFtCp+1BMsa65yo= Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5dcd9c38f66so2470428a12.1 for ; Wed, 05 Feb 2025 12:58:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738789104; x=1739393904; darn=kvack.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LFtFpiQi45n5NJYuVtm21fvpqTM5ytcVeKgjnkRWfq4=; b=nE+WxmGIh98IHr/bG2MH9VcsT3qkmZ/u8xOcIoWDlnsjLNVelE3PlH+dBgOo3dAEBB v8TyrkJWKBdyGO5/YqkjGspojh0tye2mLLuqk2+UNhIHDcDNna4ftRnf/7BTdDWaqCGD ShsS/TTi3EZSQbqmdDtUaZbBGC586sSDbyEysLX4d5R9FKMkMsG3/iLplDhKtqvBWyKQ 5QdvxCZGTFPzNXO0q+QhYZkmxRYLs8IOdHenL5ianma/KGVsoDEalhuUyYjNN0q7PlEB 7dhd0mK4kjsARixGtqtfbIdkossycjZNR/+DOrzY4q5v4uRIzxxlc29zVBlJXmCHgKHI dx7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738789104; x=1739393904; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LFtFpiQi45n5NJYuVtm21fvpqTM5ytcVeKgjnkRWfq4=; b=Bkx8kOIpQNH0mzHm/0wEXl6ZaKL9DhNc1BHaqqjUV3RxptRQOb16pkvtPLcjjXM6Zg EDqCJzxG/6p4mA+HURvwO39Jei3evAWbc1SiD6MjE0YNg0Hv/DSPpuUrm60nMkDlMvJc 1VTKZZSXw9TkyZyMDRgOZv2ThNY+eYcVpf3ndDXrG8LahHwMu1npDhi95hJDVD51//U2 VuPS7cHt1IUUprxOLy6/sKIIeHTAXqjVwIDluVCzAvS+hUATXmVo29GWZIxMuNP+NNHj i6u9yQdwf/31TQyj6eWo6JeRcHXuBd+5ZyuZeH1hFqP9G5X7bgiefN3moXOTCKhaHePu 3gUg== X-Forwarded-Encrypted: i=1; AJvYcCVJEonY34TS8iy3B8+pH9Ag82RnlPQIepbGsIlCuaniT/soFJ+YRJq54qBwQjSEepukJq27EdBw1w==@kvack.org X-Gm-Message-State: AOJu0Yyfc1Zl5d5ptL2AAETdL+Mt2/xMWwJW2kugexLmyp0GUc+RU572 BeowQI7L8YWFU76ebxg5uMprykbaFw5pxWGKjDx8HWvCJ7abu4AvZ8nBbb99c7PESmEGpxOha61 XTyDb4gS6SwXXQthOysX60lLN6UA= X-Gm-Gg: ASbGnctsgll+s5hm9Isw9xP0hgJs0ZYQEzqNOMZTy1f+PY+0AILh/NcBi9dF40lKFZb VGK/YUq98jMbGumwC6c9hgBQvV3kryECB22ndMubhc2BRKk+/xMQSJgF2pXyUkCZYfmHeH7E= X-Google-Smtp-Source: AGHT+IHaJtIkCbhRnM7T0U9sFzys6SSEzNFeiS4vor7SeytR0GDNyDvvBJEV8yXc9k6XtQmUPqjVxsUvc/jUeTHme08= X-Received: by 2002:a05:6402:3807:b0:5dc:eb2:570d with SMTP id 4fb4d7f45d1cf-5dcecc4ee72mr841059a12.2.1738789104002; Wed, 05 Feb 2025 12:58:24 -0800 (PST) MIME-Version: 1.0 References: <20250205193221.402150-1-mjguzik@gmail.com> <20250205193221.402150-4-mjguzik@gmail.com> In-Reply-To: From: Mateusz Guzik Date: Wed, 5 Feb 2025 21:58:11 +0100 X-Gm-Features: AWEUYZmPPYI00--ydo7whk6-VBzU1Q0LQcOBF2Pq12KpaQsF6sdK5giJAb9EVuU Message-ID: Subject: Re: [PATCH v4 3/5] pid: sprinkle tasklist_lock asserts To: "Liam R. Howlett" , Mateusz Guzik , ebiederm@xmission.com, oleg@redhat.com, brauner@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8C99B160007 X-Stat-Signature: qppmk9e6yye37q5a1gcem73y8brzhm16 X-HE-Tag: 1738789105-939393 X-HE-Meta: U2FsdGVkX19gjr4dEtgTwgx+gkGxCnLX+G939A0+5ZxDE7nhRQvAhl4nzTlCtxhFZ8ll8AAQn2iBG5eiJW5wVNf8OmslertfUrQ5sQfq2bq/vvnwnUMakox8Mcfep4Gz1yz/tD5SNKpX3tafGME3ngZ0NqtaHbjie//Ctu4KED9z8GVJOtFzt7F2813bvXw+PorSXNfZ3AiU8wzivIlbSSfNHb87N6ijc7IXYZMv+JdaePK9lz1OrJqnVL9fI9/aNXSkbv81qvrVNh0rEa3vtE1qdaSOf9nT9DSt4oclZj/fDItuQCGzGQpLY/IYj9P+I3rBRu2McCNf4XxdpSVGArwcdczDyaQQkqqW5qdIqQpJnyPPnzL6EqT9d45OiwDxJSjNHBempenpojKFXgkeYR2zRpVjw/VOb+irejE7gb3lSe5OZZz/s31blbguKaxG0p5yoHODsLHkzkXSU0ymVibR/7W1Xg/i779K1rIIBZjZ8FPzAPY2FiDUCUkmoDHs1ao2EO/NNWLUnEMF6YG62vMQ/wsQmqGtTrZvG8KncYcBq2nd0wHo3ZzUa5/3R1f+oApsEQlclTvHlKOg6MmghL9sDQGWjtkc+mxbRd3aXV2iAIJDX2+HielHSnDs1yHu9ipyb/gqjmTqzRGOYPuX2Fs927631zjtIx4m+wkCPFsqeyi/4sJY7r34Do2NZn/+DyNPY2ltPABpvgDobOX4d52zdtr8lxc1sVSWuOal2qBH7rCgI49OT6WxoMvvQtJp9dIiYpSLE1lXT4zs85eroIbYfy31jsqJDlIe2KrpROO1DuUgrtwBuFH/YMzvU/KgFK/KzlEJAvJvZJ/+ycB+FmAqBIFo1lGC2ikEy6A4zme4mGiE6vhlCfA9XIO61H2EV2cMC/phwZH0WfUEU1qqdXCGz8ZiKoBdJ3lJeI/flTA6kdKu1iEv+eWqDkVc7S19vE/1kAmbpg47FTnKZkZ 23bM5NIK bBI8zTh7F5FNZSGGUF5VOqp9lGUVTPhiLQwFROQ3BzW6jLu4X8neCNX/rIHKrkahvp2cn3fGxfAXteHKPfYPysVNI5r8fRNFKi1250enBvzvlK2kLx8Tbfoee2QHwAkBqxJXBXadYF9qfrhXfsAC3xexBDsgs656q9tejidLWkyDWvudoNSI5rsRv7J8RYo1GsdAVf6BFFmy8vgdzy/kzEgpuRsPRX1Ok1apjeawn+rO7LtfTwScdsz02+MLXeSSqF3PHdGHo81Lb7e9Hq1vsCi6JuCHqUW6GECG2R3ZwilBV0Eoq3wxDs8IutuM/g+rE1nn8aoEYluq5JuRuc+cHKWAQ/83pWUQMmS65WX2aXn+htkADZ0vR1e+mzY3NoOs3JNEqJ7U38sX8bLiDELhggg/bPfanEscl9d84 X-Bogosity: Ham, tests=bogofilter, spamicity=0.169481, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 5, 2025 at 9:42=E2=80=AFPM Liam R. Howlett wrote: > > * Mateusz Guzik [250205 15:34]: > > For this specific case I don't know what can be written in the body > > given the really self-explanatory nature of the change, other than to > > spell it out(?). > > You could say why you added it? Is this something that was seen > happening? > I guess this is a cultural discrepancy, if you will. I spent most of my time in a codebase which is very assert-heavy and if anything you would need to justify *not* adding some, let alone for locking. Plugging a gap of the sort would not require any explanation. The kernel has numerous examples of mere comments stating that a given lock is required or no information whatsoever, which one can only infer from context. I'm assuming this predates lockdep. Given that lockdep asserts are nops on production kernels there is no legitimate reason to continue like that (or *avoid* asserting on lock state) that I can see. I'm going to sleep on it, type up a sentence or two, maybe reword other commit messages and resend. --=20 Mateusz Guzik