From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09CA4C54E60 for ; Tue, 12 Mar 2024 12:44:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47C568D0048; Tue, 12 Mar 2024 08:44:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42C908D0036; Tue, 12 Mar 2024 08:44:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F3B28D0048; Tue, 12 Mar 2024 08:44:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 203358D0036 for ; Tue, 12 Mar 2024 08:44:12 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E71971C010D for ; Tue, 12 Mar 2024 12:44:11 +0000 (UTC) X-FDA: 81888354702.09.1612553 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf27.hostedemail.com (Postfix) with ESMTP id 1BEAB40006 for ; Tue, 12 Mar 2024 12:44:09 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Vh7Sa11m; spf=pass (imf27.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710247450; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qGx1SAuuMtMPbkqKhMFRhqHlJUlfDVpupNqFcCtt0Xg=; b=GP5vPCNfBY0Z1WCpp5gDt7j/Lv/sk+YF6nmY9hZs06VYA+/tWLI1tVMnaB0QJwnb7OzoIx 2+M8V3gyMQH2pKEuGuhAQkzbQ7ujVEU0l6P7fr+PXFsdmmoOA2iOE2GAL/MnVyL5SMsJAn HXu2FddE6l6BMXwOK5ySsB3jlKP5iOE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710247450; a=rsa-sha256; cv=none; b=S9xfCYD5RaTRDZqdNF9C793ohPDHNga2/uY7FW20arRWbrdOto6x35fzPQLRwMovBiC2r8 DhUhnuz2madbRSizenRsYu5p0n4bALJhZO8L+Rmo/YylYGQhhrtgJzgJxL32T+xYIk9Thz WnDgxPovLK26qWRUJEy03px+NCKMWcA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Vh7Sa11m; spf=pass (imf27.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-56877761303so603503a12.3 for ; Tue, 12 Mar 2024 05:44:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710247448; x=1710852248; darn=kvack.org; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qGx1SAuuMtMPbkqKhMFRhqHlJUlfDVpupNqFcCtt0Xg=; b=Vh7Sa11md2MNWES69We/Vp42/XAL+1SH0ZKl+AW7dr5xMl5mDZlxS/6XTIwnRKqWmb sqXpAua6Ox7nrgpfW0fF58A7CxtFZjzsnf4Xf+pduH6zFnDu+4w5HEu+Vsq/cZQbpQvu g5ujVqk7sNCdQOOc6D36qFVZDrF6lCCUJ3dFHxRz+sfuorlWxTrRuCWB5LDb3AhImNJJ p0mq7sR9eNEC/wvifBwa6Cm8A9eizQ51LGI6lRGObPmMbh+tN5U7xj836Zz+qgBkYd/8 1+niKsmSCCLU34/qvyg6bvjvk/fLFpnzvLY2b/1DSBvhzH6A2HxLxzOfoPdjO86hhm54 P1AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710247448; x=1710852248; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qGx1SAuuMtMPbkqKhMFRhqHlJUlfDVpupNqFcCtt0Xg=; b=DotxiA++1IJSKgYAb6R5s5COXqOn3wTfHUuMCvk94kSmp+VL0Ig0D/6OO7bxeLrh57 JKrTzum9g9pl6K/cAvwGxBTqyC44nICWLpPduUj+aUHpvpacIF5QjNz6snbHjjI14oRk /I9oN32H8WNrV4/Sa9bnFmew3CGEQYwCx2ZLhg21GKvAgSjLHLTReeIDRms594QxvTfz CzkFy9GDK7+hQ4AYCW/Ov/xzBEk44APcLJ49bMVqcwgxGtm6P7Z9S6fN7XqDpDE/cTNQ Jt+FkBdhHd4ZlYCaVJ55DgTzJPX46eqV6GcCkLD4X9jtVJmSEHMpiRhJiwFertP+K7aS lV4Q== X-Forwarded-Encrypted: i=1; AJvYcCW6/wJy4zPx4bUb3LJvfpVZqjYpVlkPhNTkNLp6iCDxLgLo9gUkhtmIei2bTCpoSgFcMu2LHTbA9JJC/9ZeBMFBjAo= X-Gm-Message-State: AOJu0YxV3ZOXNJTgQ2K+LV0tvzeP3XuljEh3pH/OLRR4Lk/FsKfkV13f wdPshHu7lky7H6pb7dYW7qF7r6z6jJ5uGU6ON1VFftxNJIC5kmmqTQe2DUtu4iZAr1yJGrsgMPQ IKtfwRxs0nuQ594KesSLLfQUs8m0= X-Google-Smtp-Source: AGHT+IHf5Mmnm9eokPIC+RAuWPaLLdKydE4R+EnGXpUBogywCJzE1P3gWMX/3a9TW1dhq8iJu2ZHc9ZPPPwwSNBRvz4= X-Received: by 2002:a50:d71b:0:b0:567:504e:e779 with SMTP id t27-20020a50d71b000000b00567504ee779mr1210099edi.25.1710247448377; Tue, 12 Mar 2024 05:44:08 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a05:6f02:8506:b0:65:b649:35ec with HTTP; Tue, 12 Mar 2024 05:44:07 -0700 (PDT) In-Reply-To: <20240312120658.os72hvnk5jedwbaw@quack3> References: <000000000000c74d44060334d476@google.com> <000000000000f67b790613665d7a@google.com> <20240311184800.d7nuzahhz36rlxpg@quack3> <20240312120658.os72hvnk5jedwbaw@quack3> From: Mateusz Guzik Date: Tue, 12 Mar 2024 13:44:07 +0100 Message-ID: Subject: Re: [syzbot] [ntfs3?] WARNING in do_open_execat To: Jan Kara Cc: syzbot , almaz.alexandrovich@paragon-software.com, anton@tuxera.com, axboe@kernel.dk, brauner@kernel.org, ebiederm@xmission.com, keescook@chromium.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, syzkaller-bugs@googlegroups.com, tytso@mit.edu, viro@zeniv.linux.org.uk, willy@infradead.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 1BEAB40006 X-Rspam-User: X-Stat-Signature: 5wbgzewwit1m6ctmxpz75o5m6wgr6zbb X-Rspamd-Server: rspam03 X-HE-Tag: 1710247449-623977 X-HE-Meta: U2FsdGVkX18xf1os5Vwn933N0EUOAJmAjXPbBb1PgI0tFjFWP/TEQI7swN2vHx+sYr/N1RZqc1G2Qbr1rk8UBPv8icEE347YmOpRE9cdLCFPxFOZRXpenxgY811+5PZIlpJpqKFy5v1FnR99JzdEiebzmbSWRK8LaImgLRb4yUAaqut8mjjjcAx2K3sbaAMCnujqVajiKmIIfoMjSlZTT1yfpDaYwdIeqnAjJodJhUwTPHDBHiZvYlcTPrzEoHrr5iA24RGDGE43Fy25r7Hp1kcBOi0s4coTdmIapZtlDVINJWazRcKH71R5owCKDHhfgXcoI5D2ODTWO6lT3QyqCSKjmAoky4bi5ZP2QN+KO9qLrR83CCxOXjlMc0D6HonymxShJ5zNb3n5LUecR0oqt0YGyzfSBxanUB5uQsvTIrUzkGBxc7lR2yfeJrHyka1QyaZOsEMXBRotmCR5P3s56nC4FdxYXHjseSviFCYi3P5WWjutEE2Wu80aj5s+iFM4CVBr1GNS7r+SrHjQRi4t6lhKCY1YX7bTjM5DwrVBDPJdhWss5PJjlDiN3SrwI6RkktkIX3dhA/5kSiDdZmbG6mSYEB0jiF/eevi/sBQvQcvbsBU4/FMH+vMlTLa+LnSBybvS6WkPQ6PfuV4bdO6JmCHt+7lqkE2uMPgGnacDUmiUSzSCV0HOz0tylyVQTI5t368X0ViDS0tUV4mxRHv50iGvPaoHSr/zhNWuTYr/jSH0fZhC7Iuonk9mxy8CTdPuI4rQe/WDccquX7cukE/dGmUbQRrfXBUeKp/ltkChJvbVWNO7BCWtKCDbYMd4Y2RqdOJo4kNWmicO+bbFW++wy63tpNoBDCHh5L1qgTEzEF+iOVR6ijTA4C3IfxP8+ZfXI2NS/wCBMF35wKABxYzQG/M26xEsUarkjyaeUmozyn7qsRAWOGRkV3EHxdrEeb4HeZC+ApXuUoFlFFxM6P2 E0cqytna Cjf/2qmsitH74LdKz/gq4oFre0gRM7WgzJ43V8cgQXA0i8Kb1rn54Cgd6KacSj/ZvC9ezwKjEzRhcVd/q4F35LEMNTRJKDgBQqISooQZISRh4bMJiPTipTqXnh8OwKbiUXNmA4EptExROJ7MTtZvoMmxQm5U0+WIiIgVpXK5DEJItEGLu4fFbTbYxdGjDl0atzcmZxSow4TyMvdGnr4cxj7pFPbMCTd17Nel0RuewdykfBJKG5MMTgDNcCuvXmC5tXPZ9NaoXzcZ4NNMOr+V4Ci09fZOYf51NHl9mc7UukOjjn2CfnTFfLdQjccr9fSDm33OH2nVEvmdmSWpkWQ3NRpIbg5OS+wMKFvgVRvrFPoyTQafvJMXtA36JlZI0Dzc+5o1xumI1V2yNK1Wij2G4H0sFyHR+Ja1Hcp6YBxjD+oJdpSC6itfCJvdgM6AH7cr1HYA0YmHngeISz+uCPthDxkEqYX4+QQ/k2o0hUcODbeAhyktPdrKPs27emGRaB5K0m5fQogDMIYAdGVDuU9A1nk4IH6J7CYZ7pPgR2Pp1ebQOpQSjruw6EswnBz5QtAvyMk9uhj8z1XZmvQ0M7BgmyXMKhHaBWzhrDDArgHNBabrlwXk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/12/24, Jan Kara wrote: > On Mon 11-03-24 20:01:14, Mateusz Guzik wrote: >> On 3/11/24, Jan Kara wrote: >> > On Mon 11-03-24 11:04:04, syzbot wrote: >> >> syzbot suspects this issue was fixed by commit: >> >> >> >> commit 6f861765464f43a71462d52026fbddfc858239a5 >> >> Author: Jan Kara >> >> Date: Wed Nov 1 17:43:10 2023 +0000 >> >> >> >> fs: Block writes to mounted block devices >> >> >> >> bisection log: >> >> https://syzkaller.appspot.com/x/bisect.txt?x=17e3f58e180000 >> >> start commit: eb3479bc23fa Merge tag 'kbuild-fixes-v6.7' of >> >> git://git.ke.. >> >> git tree: upstream >> >> kernel config: >> >> https://syzkaller.appspot.com/x/.config?x=bdf178b2f20f99b0 >> >> dashboard link: >> >> https://syzkaller.appspot.com/bug?extid=6ec38f7a8db3b3fb1002 >> >> syz repro: >> >> https://syzkaller.appspot.com/x/repro.syz?x=15073fd4e80000 >> >> C reproducer: >> >> https://syzkaller.appspot.com/x/repro.c?x=17b20b8f680000 >> >> >> >> If the result looks correct, please mark the issue as fixed by >> >> replying >> >> with: >> > >> > #syz fix: fs: Block writes to mounted block devices >> > >> >> I don't think that's correct. >> >> The bug is ntfs instantiating an inode with bogus type (based on an >> intentionally corrupted filesystem), violating the api contract with >> vfs, which in turn results in the warning way later. >> >> It may be someone sorted out ntfs doing this in the meantime, I have >> not checked. >> >> With this in mind I don't believe your patch fixed it, at best it >> happened to neuter the reproducer. > > OK, I didn't dig deep into the bug. I've just seen there are no working > reproducers and given this is ntfs3 which doesn't really have great > maintenance effort put into it, I've opted for closing the bug. If there's > a way to tickle the bug without writing to mounted block device, syzbot > should eventually find it and create a new issue... But if you want to look > into this feel free to :) Thanks for sharing the info. > Maybe I'll get around to future-proofing by adding validation before the inode escapes the filesystem code, but I'm definitely NOT patching ntfs. 8-> -- Mateusz Guzik