From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94045C021B3 for ; Fri, 21 Feb 2025 16:51:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D274B280019; Fri, 21 Feb 2025 11:51:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CD669280016; Fri, 21 Feb 2025 11:51:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4FE4280019; Fri, 21 Feb 2025 11:51:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 91008280016 for ; Fri, 21 Feb 2025 11:51:54 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 37DD71619C0 for ; Fri, 21 Feb 2025 16:51:54 +0000 (UTC) X-FDA: 83144543748.25.AC2302F Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf03.hostedemail.com (Postfix) with ESMTP id 3DD1B2000C for ; Fri, 21 Feb 2025 16:51:51 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XFwbzo2A; spf=pass (imf03.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740156712; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L3GfVBZPNIG5qDKUks2BtPgtADXfzW3N1roYhgf4YM0=; b=wqp39pZT/NybXL0RXhs9IlFDgzzA+aMuyDkPUnV9s0g4LPV6LYi4f/mSIhPNoLlhKuCLkY yVsBJi7tKvON0Z0z66xQeD56UplAcoYRMdTkTaLFwErL7ot56imJc6zNFwrjsNtPB0rFxd ZdHBUnXxtBctYhFZKTbfnoPAyopI+Y8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XFwbzo2A; spf=pass (imf03.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740156712; a=rsa-sha256; cv=none; b=FReIKKCA1dP4lNZEivtV+4KwMBBmMiS6bg3+UQ3toWDNpIH3CBzmYWPjJoUqeeyJWMY6tf BP2p9Rv90ISSVUPK90o3Bb5PG8kLz5J2/WMXAt4J86Zwv2ha9ZTWp/+ZzRFHpqL0c4WJca r/mOq4mULsPbOtZGAB+cM875T5QB16A= Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5ded46f323fso3244746a12.1 for ; Fri, 21 Feb 2025 08:51:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740156710; x=1740761510; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=L3GfVBZPNIG5qDKUks2BtPgtADXfzW3N1roYhgf4YM0=; b=XFwbzo2AbRQ53OeFSMdwaM5p6Bwo6JGryNxeOVDoYXQSzXbfL3On7UhQ4b+YLS/4nh 8tzbFDeidjHAaR5d5Uok5hLg5//QEN0V/2RHdlmMvbrTRAXL4Cqktim0DkRHj4NZCAfA GXrIP1yvj5PwbwvA5//JtNaTUiSxjnEkmwn4zJgYojcUg5Bchi7WJ5Gk8+d3O4dhL+SO EN6KNOqb814VvvzPartrZRq3GBeKDc182mjPoLOvABmiuQF7RZwx3YCwDDdh23WJxsRo 69/FEe7yQo6/7Derhlp/RVgYpP0BoAYpDj2qmGvWjJjrjRXTOyCbSpgfGDh3OUQe1Dvw wbQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740156710; x=1740761510; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L3GfVBZPNIG5qDKUks2BtPgtADXfzW3N1roYhgf4YM0=; b=m9w+flak2jRRfWcAc246NjWtH4XmaV1xL7tLUtzylbvw3HsRec9K+46TfFzsMtShxY g6tOjK/HvFHqo781Y7/k8/UssYjHhte/rfloRj4oO+lvs6BJLl2sMVpb0EtzEQK4zPJ3 yV92VfLRwijMX7PLA1i3gc3EOPggm35yaRl8ZAc81KWVUOvfiP2U9ScBuOodf3GqarBo /fMOxNXI+pXlulNxk7bnqY9dbqPF3MnRgQ84x3ZkWay6AOL0oz9rCMGXwVdFSDX72wll OWvgtjqXlHwUgGZQ9LnvNORDnXa+dqt4EGSkqUW3D8DcecFMvXtuH16DfoJ+pCXCuyge 5MNQ== X-Forwarded-Encrypted: i=1; AJvYcCW2Tx5w4z/jyJXVEwDIAHNDV2T2A6pBojViRLKIUOGfrCYNdOsXX54CS0+xGDmbaUYpcwsimTxNCw==@kvack.org X-Gm-Message-State: AOJu0YyG/XaxnNp9zM73jkBcXdXox63gvaT38DTDppie3liW8B6Yy1cV Y7Qx6ix9w+fQtJlLMs6X8PFR6xTst31eVyc7mGeRulMxag1vXpcLIvocSJbwxY+TOQ4BTrKjhDt B8YcAoi0NYBeZfSx6qcmM6nXupj0= X-Gm-Gg: ASbGncscO6MLAxh+E8F6NJiEGZ6KopNKGud52OD1rUrCysHqVPeZS6Ew8GgevsSvcXj mMZWurSbQIh0p2jQU+Um39yZmNur8OC3IqJLXIA8KC+UoEzNFAfiZxSwTHjkgBPx52TDJF5Nu7f gpNxhYuQ== X-Google-Smtp-Source: AGHT+IH9RKxj/U5zpI3JA7hDcdGZ6v0ycbSRxZnemxlkZtExRwiejOddMUWgeNEe0/MCt6WbW7V94i7UPAID+ZQRr5A= X-Received: by 2002:a05:6402:5246:b0:5de:dc08:9cc5 with SMTP id 4fb4d7f45d1cf-5e0b70ccd99mr3708605a12.7.1740156710272; Fri, 21 Feb 2025 08:51:50 -0800 (PST) MIME-Version: 1.0 References: <20240807-b4-slab-kfree_rcu-destroy-v2-0-ea79102f428c@suse.cz> <20240807-b4-slab-kfree_rcu-destroy-v2-6-ea79102f428c@suse.cz> In-Reply-To: From: Mateusz Guzik Date: Fri, 21 Feb 2025 17:51:37 +0100 X-Gm-Features: AWEUYZnfVYIJxHkGF1zZWtSz2bHpYaGIafeC21mOa_0SYKWj9c3lZDabKwAoH5U Message-ID: Subject: Re: [PATCH v2 6/7] mm, slab: call kvfree_rcu_barrier() from kmem_cache_destroy() To: Keith Busch Cc: Vlastimil Babka , "Paul E. McKenney" , Joel Fernandes , Josh Triplett , Boqun Feng , Christoph Lameter , David Rientjes , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Julia Lawall , Jakub Kicinski , "Jason A. Donenfeld" , "Uladzislau Rezki (Sony)" , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org, Alexander Potapenko , Marco Elver , Dmitry Vyukov , kasan-dev@googlegroups.com, Jann Horn , linux-nvme@lists.infradead.org, leitao@debian.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3DD1B2000C X-Stat-Signature: wufwyo6p3crdy7zn33ug8ybo6d55iswo X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1740156711-655017 X-HE-Meta: U2FsdGVkX19Swvcd/i4+jov3cNnqmP+Dq93ofBBEdsMhZXU3L6/QgNAcop1NCzTz5soO+0q1paKwLlSm514A/HYpvvqw4N7KZxvC7RKUEAN0NZqdKdjfqidWshaT/PNhVgXVCGIh3uAcHxNi+mGrglGI1n4TGIqtM8jMHz3948DXlxjIqce0I2r2zfMr/FEfngJTdR/uyDVZ5JQDpUxavicDiSwCxLnqwnNnANJqxpTK1J3g4VedckA62wbMsUoqVTegdFiCgeyaYp+BKRZay3DdTwukmN9fecCnzaCedhosNNd7wo40tmwXid3jQ7iN73UaQfwFmZLh/7Wfm9NtGF3ClzVFhtEalEkNdUvRgD09Wbm2A2ArZxVT6wyR9QGX/Yyd/ihd3ZaqwYZRD3LnPFQawADQOz4HTVySdt95AifTM71w2QS+ru9rS6uIABzq8UuYf93WLBkCJqcvBKJwl8yMKhuhtQKLr27qnV4i+az/blYB+HBHRCcJ9u7z1vl3YsCQMYy1i1iS1sDVMkKEKik21AA2bw+c5OAit1rHP8ThapDBedb14krX6zKBG4/3LnhyR8T27jiMsfZaG3vBkFgs350ajhx1na9JBo2rowcmON8AIZxupsWayw6WwJ47dv6f9bpDu4/tWKRgF2qTstOLdx8sJOpvIkdgNwDBs+1XFqg7SNDuY+xrKSAeoQoBdo+iY/IqViEwz44eAtJMfsb70EvbEO3r+Tzcz9YFjq6vFjgDOVuNfEYkTZWVsZuw/yQzELJVX0xIUdIKUkirDcXRSGsqgTGt7unexw/mENZ51IdcuoOxfaWjWEjIvREAgLUzrWh6sWO6mMZLxTGelPg99wKIeeCroYOoSPR+hz8HEAiIdKO+bglAFP9nuuitXPLsQuqByPGb4G8QXrTu3JDSlWqwGLDQn9XlNKMNaDkQJYN5rEl38ab56JERKRsNOCzgYB7S+1XyOliOmLN EjrhTJpA wpOFpKIaOlp5kOCogAYFBmCqlET53QIV5b4kH3XpMGmO8qOTeYd6lpImMk4R0wGt4zBLFCtwdvyATm/ziZ4i1kO6gn4unAp/9xMFmf0KlJTnczfbQDMjEdB7W9NsRgRbmknJPrX/BAIqakHLAiJK/gnRQ3MuqoXy424fva3jm1dg9sti8mspmUUdbolXObd8yFcva3RDD9gi9EBbjK5HahhEmngT42f1pogPXXCYXa4k0cywM8HDYFgJ45rmfLAKrh8OcXgOtSDFZWjl3kN0W3u5WuS8iFxTAdCHeJUpA9w6TWu0+uVRTw99ZgOx/U8OaNWF7yPsAPGCVeFE2PlCZzTcm+dI8hGhWrdLy8Tl1IR1MupQaZCNWRzOeyHRTyhOnX/IuixhsA+2fELHXEG+1KxQ5333EiXEBRK0zvMWxU8NL6II034W3/lngvVmjI24/NV/niaaYStZkxdNPuSyVX1lKtA6GfcyS4XEmHo0j5Ccn1Ng= X-Bogosity: Ham, tests=bogofilter, spamicity=0.006151, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 21, 2025 at 5:30=E2=80=AFPM Keith Busch wro= te: > This patch appears to be triggering a new warning in certain conditions > when tearing down an nvme namespace's block device. Stack trace is at > the end. > > The warning indicates that this shouldn't be called from a > WQ_MEM_RECLAIM workqueue. This workqueue is responsible for bringing up > and tearing down block devices, so this is a memory reclaim use AIUI. > I'm a bit confused why we can't tear down a disk from within a memory > reclaim workqueue. Is the recommended solution to simply remove the WQ > flag when creating the workqueue? > This ends up calling into bioset_exit -> bio_put_slab -> kmem_cache_destroy Sizes of the bio- slabs are off the beaten path, so it may be they make sense to exist. With the assumption that caches should be there, this can instead invoke kmem_cache_destroy from a queue where it is safe to do it. This is not supposed to be a frequent operation. --=20 Mateusz Guzik