From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A59DCC54E58 for ; Mon, 11 Mar 2024 19:01:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30ED76B0108; Mon, 11 Mar 2024 15:01:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BEE56B0109; Mon, 11 Mar 2024 15:01:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 187136B010A; Mon, 11 Mar 2024 15:01:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 07A3A6B0108 for ; Mon, 11 Mar 2024 15:01:20 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C3E8DC0948 for ; Mon, 11 Mar 2024 19:01:19 +0000 (UTC) X-FDA: 81885676278.15.AA2DBF4 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf07.hostedemail.com (Postfix) with ESMTP id 9DEB840018 for ; Mon, 11 Mar 2024 19:01:17 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mD997QU8; spf=pass (imf07.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710183677; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EuECgiC6YMc7b0Edc0Kt2KDyl4Um6oShzEC+/b9iZLE=; b=YMPjvbPfi37SwW5fP4Bt06kj/Pt+yv7+MKSxIl5acW4byGpLFsO/S3rIOcAGZ6fUMtejkO Rzu6XF8PDPrQI79PA2rhtEy5jmMyKwTwpGcU1F76BPsSMMqxEitXnpFXVv0qPd07s+GJ3U +CdKl5Z1ANBtDVVJr7YJzZ8naWvcsqY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mD997QU8; spf=pass (imf07.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710183677; a=rsa-sha256; cv=none; b=pOwTbjj3ZACrNk14voD9KrWdP4ZJBddhTDj86qzgzEuw67kW4vpnJf1znRRyv/jblw8F8g /dgDJ5G8U/sjgojYHvN84U5IZ3J4VzamizNVqV+WajsVmbKmktwltO2OF8RL9v1BwYXKx4 pkNX8M7JkmJC+FGzgh8DaApohaBWBIM= Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a461c50deccso205684266b.0 for ; Mon, 11 Mar 2024 12:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710183676; x=1710788476; darn=kvack.org; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=EuECgiC6YMc7b0Edc0Kt2KDyl4Um6oShzEC+/b9iZLE=; b=mD997QU8O6y8ITqd61Vmhc+nYiUBScM4wUdaVL3BCNOFWLRSEN1oypznBuMqfM8TgR WR2zPIyB084ZWh/7I0FNOBBwfBLEZ/nfrk/115nWhLttwdcRQRNqbA12Mm5isjhT47u9 6pgMhT65PoRh2hvXKO2j6DpVlGKQmgYTDXj9UbOM4JD4DtwID3zxD/fCzv6o+xSV1YoV JNh3eSFziA5rIAMZx5B6wRmNnRlgaPrGHdxSNtQY1qY3WDJ5cWiyJ4+JmIwCKOrXRN4s Io3gcSDunTv3wwipCSCSgtPuwzptOU8wygglV1oeY+3UtEHgdMre0BufQsSw1i/PJKci 6uQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710183676; x=1710788476; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EuECgiC6YMc7b0Edc0Kt2KDyl4Um6oShzEC+/b9iZLE=; b=hHJySoURQSk0EO1+URikkEExiwwQYEAX9lFXE9gaHSg+TDnlxhzZhYw5p9MkrPSoXU PaKI/nztAbUvApy39li7Y1gYOIMys1so6xR+NBCcPWDS8qOWaNmBO46dTg4GO60mzzhX R1X1OWUa5RZtxCntoLPTJLASSIzOIPiQx5Kfd/a9MetK8HN2iz9WC4RgU8u5m4Ftpm1E 8MVg+fZHiN/eSW4Bm06MEMDZAauTp/6SQXh2T6I+IwMWDdspy/C0jbgM+tDV/kqMZXO8 HiK+4b0Ae0ozMYjsMCr9Pa3PJ8Tnd7uHly70Hgx9Mn0O4oYQ9J3hsPutAjckHpohqt3k hP8w== X-Forwarded-Encrypted: i=1; AJvYcCWqKtQ+Mko/Y3tLZdWGJaAVE3aBejHeJwFofIbw8jacdUl5AQ7PFASsklv/QZsZyKz95jIeRMo9Fpw9YEpf/xIdHsw= X-Gm-Message-State: AOJu0YzHjlJsdAiYZuckUAiXy4nDjyaJVWegnRijI9NjwbREJO1DXCq8 dY9HjZAj5vd+qOxXqefGGpeM2rqIQhtrQXS2q3QgoCCy2KzWL6XBv/BticNogdHUbm4KtGimOAc Q3rM50CAmmzXoU4BfFPCB3oDwEv4= X-Google-Smtp-Source: AGHT+IHJ0O15Wf5Z2bUjYqjgmX08pg1z5eDQTDE216uygC9BNgkF8rcTIvSKcoh4XNj8NWUD8NKETARv77vkcti1LEc= X-Received: by 2002:a17:906:52ca:b0:a43:6146:a4df with SMTP id w10-20020a17090652ca00b00a436146a4dfmr4237847ejn.21.1710183675559; Mon, 11 Mar 2024 12:01:15 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a05:6f02:f0d:b0:65:b649:35ec with HTTP; Mon, 11 Mar 2024 12:01:14 -0700 (PDT) In-Reply-To: <20240311184800.d7nuzahhz36rlxpg@quack3> References: <000000000000c74d44060334d476@google.com> <000000000000f67b790613665d7a@google.com> <20240311184800.d7nuzahhz36rlxpg@quack3> From: Mateusz Guzik Date: Mon, 11 Mar 2024 20:01:14 +0100 Message-ID: Subject: Re: [syzbot] [ntfs3?] WARNING in do_open_execat To: Jan Kara Cc: syzbot , almaz.alexandrovich@paragon-software.com, anton@tuxera.com, axboe@kernel.dk, brauner@kernel.org, ebiederm@xmission.com, keescook@chromium.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, syzkaller-bugs@googlegroups.com, tytso@mit.edu, viro@zeniv.linux.org.uk, willy@infradead.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 9DEB840018 X-Rspam-User: X-Stat-Signature: qfmgg573n5d43cgnmup3tjyf7wtp7opu X-Rspamd-Server: rspam01 X-HE-Tag: 1710183677-426900 X-HE-Meta: U2FsdGVkX1+qWex6swlCWW3St27Nc+o8Pw1eSXV8xH90P6LpUZSaqiOP3P1t99p8Na9x/eyEWqDfsrpbORlmKDfJ3FX2j/KuEBNgx6gr7OWsw47c8iVOu6JXuATHJrX2aYtt/n+6sA5cYCMhhK2ewwiZZPF7fHVLEAMQGwVGVQfCb6i6ZPKiPH8H8jCDn5pHup5JTTHNdTfB8rStPm7k/mGDDIWmWvoKnV+pXIKrz1Oik/bxeJnxVzVXKy7oFFvehzUceevPUNiO6cNe0B42fRCR2Z1pwAkjPguzW46xsa9H5ZK3vaurOEm6+tAuibBOD7cnJ2eWq0nzCO7m1jOUkGhXnrZISW1ZvBJIzYZhdYTXHdjIVjx0ZHZ8IJaeCgnNmVyfi5S7Irhzfo0pikHnP6wA7uy5wF4AWnXGqx4QM+m8sKx+Fd2gKX4sIjfLeRX5U/F3YlJ7QC8zwdi5YBPk0dohQrRN6mbSmXvVonck7vvthnwGRUBxoGeouKgiyHAomiYw7f102we20ukYNGzdzx9bRfc5x07LhHaC2dQxHraHbjvqWFDQiHJHPBMhPm8dqN9YZyYswb1bJHRWDS4wHHCxYKb28okS/7PHKaXAeqkbRj199PtpfZNrW+UtmuCfH3KJ5sxkSWugedTbssH3vF4IedcMNAj4DC5iee+Zlmw47rXAYeYtckrt5OdRDZON1HHhIM39R63uJTrgrcfeLbq2Ex2BB51NDbiar4Iztu0nQW2Zsaza1kuWa+lqirctMhTj//ycn2cFZKRzg1ujqw3JV/9h5N4EOSgLef6pLvfBgNc8dNrxOp3uURnunh0rNTO7rjJVcJnoECO4PWrcWfpO7TYXnwyAY7ybUOpzeQX4JaM9CTTPziYclURJ04BKd5B2PtP2ag5p+7fOYJUWq2k7zz9AudUH7Q4DtLRbv2PgKK8EtZytdbE8P45kFJD5lTzvucb9B/kDZVseuZq mwc++7CW +/i6NbVZi4159Jx2xm3RhGEh5OJenXR3LfH3BhSZr7rs7Vew7UxO4nes5vvciJ3Sta2cS8/IynwivLloQQqT8mV/FlOx/qyR+gBQhc2TXMdOvcEuX1HOsM7XlkXZjh+7fl6bANYCFw7SCdpJRFpgdJoZBRoo/nPAyRyUnmXcP4mmznMje2CP4aKb0U+0Lq1PBEdR63++KVyrAF9e4E6Ye94n/TXyZUs89Bg0SbfYybPTP02G8IXr8uEk+yVWohfxIkdyzBY/LTmIP+Oi96z0MkgUIHSEFqXJko7gEhVoM9L07emgISJ78U6UFPtDrZ2+PaUOkD88MNc6RZHXRBuSZ12rkrA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/11/24, Jan Kara wrote: > On Mon 11-03-24 11:04:04, syzbot wrote: >> syzbot suspects this issue was fixed by commit: >> >> commit 6f861765464f43a71462d52026fbddfc858239a5 >> Author: Jan Kara >> Date: Wed Nov 1 17:43:10 2023 +0000 >> >> fs: Block writes to mounted block devices >> >> bisection log: >> https://syzkaller.appspot.com/x/bisect.txt?x=17e3f58e180000 >> start commit: eb3479bc23fa Merge tag 'kbuild-fixes-v6.7' of >> git://git.ke.. >> git tree: upstream >> kernel config: >> https://syzkaller.appspot.com/x/.config?x=bdf178b2f20f99b0 >> dashboard link: >> https://syzkaller.appspot.com/bug?extid=6ec38f7a8db3b3fb1002 >> syz repro: >> https://syzkaller.appspot.com/x/repro.syz?x=15073fd4e80000 >> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17b20b8f680000 >> >> If the result looks correct, please mark the issue as fixed by replying >> with: > > #syz fix: fs: Block writes to mounted block devices > I don't think that's correct. The bug is ntfs instantiating an inode with bogus type (based on an intentionally corrupted filesystem), violating the api contract with vfs, which in turn results in the warning way later. It may be someone sorted out ntfs doing this in the meantime, I have not checked. With this in mind I don't believe your patch fixed it, at best it happened to neuter the reproducer. vfs could definitely be patched to catch this when I_NEW is getting cleared (only when running with debug), not in the spot which generates the warn. -- Mateusz Guzik