From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90D40C02192 for ; Sat, 1 Feb 2025 18:42:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E74E56B0082; Sat, 1 Feb 2025 13:42:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E24026B0083; Sat, 1 Feb 2025 13:42:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D125D6B0085; Sat, 1 Feb 2025 13:42:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B55AD6B0082 for ; Sat, 1 Feb 2025 13:42:48 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0E5F4A19DB for ; Sat, 1 Feb 2025 18:42:47 +0000 (UTC) X-FDA: 83072247216.09.698E161 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf03.hostedemail.com (Postfix) with ESMTP id 1782420004 for ; Sat, 1 Feb 2025 18:42:45 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OaUKS+r3; spf=pass (imf03.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738435366; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CUiqIP2vhap9xFxDdBSTnK/sJOpuqGpUB8RqzKZ8M2U=; b=FoUayWOfW2q8NvYMf0tNk0gR9HLvvfSSzX7Kshbi0Bz67UrX2BpfWl39jAokuw5/7MSkSK TuW7Ym2S4uJmNJR4ZS3KKXvWNeqR5vCQRmi8bNynY1bdbUTOs8fDAINjLbS9hbUPBLMieE 6eT9nOs1Kj0QKEMcKq8crnpVuJXswtc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738435366; a=rsa-sha256; cv=none; b=jrxAWdQHtdhF90/QPsHPfWZIOunOnYo9z0LPPYjRjhSWtMe72jDK8ERFcc/sVSF1IMXBpg QfHy4abugKkJtier0JAIh3PHIazKClWmUvl6thvAkQ11ru1DI9dKA/w8P9rTTIxZ5iFrJA +TKXOGe1AjtgeM+ZrwGCe64nkGuWKII= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OaUKS+r3; spf=pass (imf03.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5d3bdccba49so5159553a12.1 for ; Sat, 01 Feb 2025 10:42:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738435364; x=1739040164; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=CUiqIP2vhap9xFxDdBSTnK/sJOpuqGpUB8RqzKZ8M2U=; b=OaUKS+r3OlZfPwl8K4QJrFpORRN6degZuUNh138B/HMgaslueBsO1QdNRFmfYhuHaV KcEpCSY34L+hya6ax/HMTqhkzOOVZAZg8Y0XgvCmgxx6TlwTitbO9ADLdMIF3HAawIlY t0gKSMq6i+QiHv3rudJIUD/QVzlnSOMKxPUI1miIVBw2555xM0T+SCRZz0vXNlB2WaA7 7PDzWPpIGD7CGPZZ7ifW0H1jlksQ97Uu3D4juL8MLrHcSiJKmU52nu6u1JAY6bAWx9zw UIYfHPwA9AgoHqdpLxYCrGR2R67t9P6BZFZZ+Z/cHaYGyr1g1SGMFUR/edW7lbbv5yh5 SvNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738435364; x=1739040164; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CUiqIP2vhap9xFxDdBSTnK/sJOpuqGpUB8RqzKZ8M2U=; b=dW0YcbeThozbiocoGDdX79oH9Rlptj2OdXzrggG6MuSpGTR2uOLbLfOCtwMAMoANSC WwwGrKEsWtOdfPmlOV3sefDi4xN8+tkBa3bPxw92mdPaIBrgjGBi3r027I9r6/tOf1f0 tODNYL4HEy6S6albtZhXV4Wu2+rOaN3pSwOaIsgZ84+WearGVIL+haUp3LdKUoJpZ7XO HMpSTOD2cWbzKruA+M8+TkTus2xgHqylFEOJC56CNnGcEEmC6d8P2bZmEflTze2ONS2e 9tomMG5o0T0sp33iYv+gWApLOG3Sb8FQrL4NGijUQvvzbMkh60GllAGsib5jnLex7T3c 0Afw== X-Forwarded-Encrypted: i=1; AJvYcCXDCmuE+z8+pucPggRU3HQp8O0b8RZcceBDH/tVgM1TgFxtQ25SPoqme/gndYQcw8dKHMt3AjGfgQ==@kvack.org X-Gm-Message-State: AOJu0YxnX3jN2c1LNxe1v1KU7Yu5r7UwbZ6Lf+ksjBwngeyqg2YEfLUc WrXKpJTtvi5Pcia3ji6c16qLKOygdlaQGSvechoayOm/ZLWUfmWrj59Qki9EQEQ5UTUmzA62Elm /gwpjldFfa6U1+kcmvj1ImS2nUCo= X-Gm-Gg: ASbGncvsNjLptSwN8P5lCG4IMfXSsW9+FXiNIYA8N72TyEWwauG0gFwb4ADolCnl6zO LstXFd7odUCg0wlw/mpsFpW2aNGcJzdlp3D3PVJzM5PN5Dw5bJxLmHnq+AdvyDv7z2VfG6tp3 X-Google-Smtp-Source: AGHT+IH9WOq2E8EYGLLj3CEPsYYcn9PdroifBEXuueOBDVI8+v8aRxyxBPaHGOhX/Jjj6ikmS9o3+MYm98Qg4NgNI6I= X-Received: by 2002:a05:6402:4406:b0:5dc:5a2f:a726 with SMTP id 4fb4d7f45d1cf-5dc5efec212mr17241581a12.22.1738435364257; Sat, 01 Feb 2025 10:42:44 -0800 (PST) MIME-Version: 1.0 References: <20250201163106.28912-1-mjguzik@gmail.com> <20250201163106.28912-7-mjguzik@gmail.com> <20250201181933.07a3e7e2@pumpkin> In-Reply-To: <20250201181933.07a3e7e2@pumpkin> From: Mateusz Guzik Date: Sat, 1 Feb 2025 19:42:32 +0100 X-Gm-Features: AWEUYZmD7n1XmQbjWEcB08JM2uCO0EHuoLzDc68hOqOAuYm8dqiuxxFK2WsQ9dM Message-ID: Subject: Re: [PATCH v3 6/6] pid: drop irq disablement around pidmap_lock To: David Laight Cc: ebiederm@xmission.com, oleg@redhat.com, brauner@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: mz7i3fj7afca531of8ipjsbozhs197n7 X-Rspam-User: X-Rspamd-Queue-Id: 1782420004 X-Rspamd-Server: rspam03 X-HE-Tag: 1738435365-176317 X-HE-Meta: U2FsdGVkX1/v0SJsZer3GO6D7I1mzYwnwOkCvt4hgwjiMvxoDyivkXOAYvwQGMrHeTscdo+Vk7eBy93ZrU5zHhVn1xzhNMdsHBqa6hKESeXRLM8rDklszTWg1W74F3PA3SjY+NM7UHqO5mushPnyhLb2Ky4QuTPNOydkNHrbblMM9rAugOGYiqIQkmg8A3rl4DE9P2X3iEuXUE6Zus2Z2UIkOYpB23370MhCcVB86IkgEnZdo8lwGz9NubDLgnRydyoZFPvbJ00UvQS8tvhlXJxCp1ox+aP/N02CJQykUP17qQH8dfaGQlTFHKsL4ilmf5lqJBZcr9p4eQlNuNYAyBthY+yvcsgta+UPsh/JUZNHOHhsb4mVtiJM2jWumMqTglLbCaRNzAWiJETlph6uT4olLj9nEBpR2FuLUtw6TonTk/CRGzUG2H+E5ob/6NyUDuqeEg7lrN8XdoQhYG0lJvep+HR41376Oek0PN4oGHwtLiKA5F7dmr0g02h56u9wNuacol97qHQ4L/GRKCR4MK6nRv/RsABHqkXZxQ4mZ11QR0TRqgXuXdyVj1LqPsDeuRS8xZ60DaOVLMWJZqTHT2s9BErxJP99R1aY/l8oNoC3uMCbuwRG8JjTIQJqo82O1OrXLhfK91nG+z9pVKILJBMkMOuyL5YsGWP3WAP9rDSAt6DtwsvvZSgJCTQu/AXklwgNcRNphpEFT/JzD9eMyp5bIQp56yROLFDwhPiwVMz70qKqWsLZcaKEzigMKAPP2JjzqbyyV0dxpZiQVr/x86i6au+Kuu6OlmyQbY+TmjQYuoL+SVAquJ59KFyHM3fkbqZS8M9aNaeZcie4QCG7cnTTZqXpZoUQT39NwSKfnmSt1l/8dz0NsYsigDjvQ9Q8grlBHnDJ5+hhzwhgkYNOEGlYwWbTl9MLbew39ScBksEtZTfAstZmSOgDtgohRVWI9MXP6wBN6Tmcw8Cj3HG 1x8tI0e1 7pJ8g/Utu2xcntMr9o13QZLfTDzGGSFwfcmxnnP1P0624N+d9rAmUgWmR2/oTtq1a8ePRORyYKcVi2bHnxnVRIfaIXIB4nBiCfwCFT+fCUnrCauURRKQr2WqJvbnj0lgu0c024w+VXgwjstESEZAuxlg27H5bYllEGQc39yBkF0f9c4zPK9ZqtS3CJogp3lOYk8xYrF69K4cIMAGcdnL+W1Ib+2I6uF4FvUyU5j31imAepyKZ6Hn9jDydNkBF1BvNzHEt8CcpwRO0bfNs7gb6DkkBLjMyLrrENKb0WnjXwD/NU6EnKeeBMYcb2J8wsfiRaaDlybAmT+WwfOP8t7Cacskrf1axNvOGbc/YUjxavjpL1Zmqh1hpKiWkINgzsYJCBko/mGWjVD37kY9rXnCygc1p/70x2uxoyyWt8JDO3Fr1LjnbiOGC1IsutruQfnPEXS9udthvPipf9lg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000069, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 1, 2025 at 7:19=E2=80=AFPM David Laight wrote: > > On Sat, 1 Feb 2025 17:31:06 +0100 > Mateusz Guzik wrote: > > > It no longer serves any purpose now that the tasklist_lock -> > > pidmap_lock ordering got eliminated. > > Not disabling interrupts may make thing worse. > It is a trade off between 'interrupt latency' and 'lock hold time'. > > If interrupts are disabled then (clearly) they can get delayed because > the lock is held. > Provided the lock is only held for a short time it probably doesn't matte= r. > Indeed, unless it is the worst one, it probably doesn't matter at all. > After all spin locks shouldn't really be held for significant periods. > > OTOH if the lock doesn't disable interrupts then an interrupt will > increase the length of time a lock is held for. > This can be significant - and I mean upwards of 1ms. > Network interrupts can tale a while - and then the work that is deferred > to 'softint' context happens as well (I don't think a spinlock stops > the softint code). > > I've a feeling that unless a spin lock is held for 'far longer than one > should ever be held for' then you really want to disable interrupts. > Note that taking the interrupt trip increases single-threaded overhead. Per your own description, if the lock is contested and interrupts are disabled, handling them also get delayed by CPUs which are busy just waiting (and which would otherwise take care of them). So while this is indeed a tradeoff, as I understand the sane default is to *not* disable interrupts unless necessary. --=20 Mateusz Guzik