From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DDC7C02193 for ; Mon, 3 Feb 2025 19:31:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1200F6B007B; Mon, 3 Feb 2025 14:31:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 082E06B0082; Mon, 3 Feb 2025 14:31:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3CEC6B0085; Mon, 3 Feb 2025 14:31:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AB3666B007B for ; Mon, 3 Feb 2025 14:31:38 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0355E1A0410 for ; Mon, 3 Feb 2025 19:31:37 +0000 (UTC) X-FDA: 83079627876.23.1B9B5F6 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf14.hostedemail.com (Postfix) with ESMTP id 62C0D100026 for ; Mon, 3 Feb 2025 19:31:35 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CAG41FRP; spf=pass (imf14.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738611095; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+YhUjuHcIBhGO0WgJf+TIvW0IcxDITAUqyLknQcp0Bo=; b=A2H88lZoiYi5ECBTZn7VnVnpu64yUT6zj2ayfQ6zaVDlFTqyyiwKJaxMLxlWCtYbOB7V7i 2lfVggx5HDve+SeMrlSZcgKx6f8YKnKL2DLfWwZZ0j7Tu/4JlmACO7yWHHZF5uKqyB3nqL 08Sk31i7AaoCiyTS+IRj9CnpOyttWmc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CAG41FRP; spf=pass (imf14.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738611095; a=rsa-sha256; cv=none; b=JPUlx8CkCcxnsxrewexUIR17J3bkEqjrwyvS8SJJ5shrScLoxsyN0h3RCpdWdIc06mdgG/ Y6yC3X1EMddAGFtAuTkjyWR4tQrAGIO0E3pP3BkkcmewU7+KwmxwVRSnDsbt+xQZBexdwU PMHPbuFSm4MiayIlo1JfbqzJK0xa+/Y= Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5d41848901bso9484705a12.0 for ; Mon, 03 Feb 2025 11:31:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738611094; x=1739215894; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+YhUjuHcIBhGO0WgJf+TIvW0IcxDITAUqyLknQcp0Bo=; b=CAG41FRPAf6fRVAciA0B3EE2gSpXo37VNDC8EfLxxLiL5zDrOyNP+hTpZ+WoD2kYfl 066aVBGoEkiOPPGp1anvMB3RDLpFDiBzu2r/gN4Q1w7IMaRNWovbUJtdJl+4o8bQuaxJ s3oXQFtBPP9aCPZX7dP9qyKUkGumxGDS9TbFlKWU3KC3vLCC5Vd8haXofDIuA7yyOWz5 C+KAlruon6qYkTfphayoPqe5+/Ti9LPPKe0C2qCSp1sdqeVPIgT2y3fhGxHSLldvLV5o V998z7MWeF7LOI4sSYv/SAbMOOFFOl3g5+CCdLwF5AmClgl9NzkOUQlyUnxsft5TL1yt NKgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738611094; x=1739215894; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+YhUjuHcIBhGO0WgJf+TIvW0IcxDITAUqyLknQcp0Bo=; b=WUFpMfMxoDL1zNdwYtTNQp6BxlFnlMWLqA/l86WNEI5uJT2CuHbLDtSXOud4We+YZK BIUSGkvXkImn2vuga1CvG6svT2N2YLGQjCD5aa1GEs0Dgy/fNexf/9JEaJMp44hqEHiJ qIHYZotAM1IlnqP1O29MWKlFKHxk+pIBfgoapErPwLaZCxB2Wf0sTyzI3UarHs5vSguX /HOowoxr0kDq71Lqv2Up8lf281eCbDO8E8oqUtPha/LjljfZBfAN6Zil7X2RaPyI9hEy DF5U3kkfjpQjfUR4IypxZA8LuqtmDEmSLDC1ipileE1Mdjwk8De70R5qhBb0b0xrRY01 JFiw== X-Forwarded-Encrypted: i=1; AJvYcCWofolCV+vq5ZweESJPIzoC/clgIxT64EPL5QCNeBLHJm5NkVSwoVkEsT8cC1VOAk4RgXoLKxoHuw==@kvack.org X-Gm-Message-State: AOJu0Yx5SxMcYvS1quSZiM7acjJYJruWniVRpwavdHlQiaIDpjCI3Quv dpUHTgVyqd4TJznTZBP747XHjq6R8ZxgbFjYkQTWErR1GA7DnbWAOESGam6ub9rMdcbXvBsME4h 7XAgqmemrO/p+ocrxuVpcCk/lSks= X-Gm-Gg: ASbGncvxkQG/FFKaaBYmJNhkRNiucb7Wv01l1oIffwRtXdtRhhjq+3qtKGC4cuIu5pT m0IHllnHJknBExLQ/59S4OUKYTrYTCAxxKycMf5hL9pE27pBg8I/SXkGs2fGvRpjgB9AEbLI= X-Google-Smtp-Source: AGHT+IHdIs+qhBF7hDdnYCwsSNBq7iUSnHJqZy8iBI2ejAeyM0QfkcrVHgZC8YYWJ4XiiEOGYow5soi9yNt5HDeLbyg= X-Received: by 2002:a05:6402:13d2:b0:5db:7353:2b5c with SMTP id 4fb4d7f45d1cf-5dcc14db066mr509769a12.11.1738611093385; Mon, 03 Feb 2025 11:31:33 -0800 (PST) MIME-Version: 1.0 References: <20250201163106.28912-1-mjguzik@gmail.com> <20250201163106.28912-6-mjguzik@gmail.com> <20250203184908.GD1003@redhat.com> In-Reply-To: <20250203184908.GD1003@redhat.com> From: Mateusz Guzik Date: Mon, 3 Feb 2025 20:31:20 +0100 X-Gm-Features: AWEUYZkFHoUrKav1KigJ2FrDpijHpcrtKiqpr4ux3k8oGy48RfWED0jcFkWLbj4 Message-ID: Subject: Re: [PATCH v3 5/6] pid: perform free_pid() calls outside of tasklist_lock To: Oleg Nesterov Cc: ebiederm@xmission.com, brauner@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 62C0D100026 X-Stat-Signature: aen33hiodsjoorx6zksigfxamu7gkigh X-Rspam-User: X-HE-Tag: 1738611095-50573 X-HE-Meta: U2FsdGVkX188mRXhRlwvxH5Ux5fZ8RA6Ig4x1KtioRcBr8scQWXeOCXYVrPQ0gQDQcWkyblia0UUCZyKdTsc0mJVvTmTorLyDAsJe2bEXg3bI47XpiWkELajZBthsEP1wOYHC1czy5s8wDyaspU7lhySE+IvkbWpQAoxZUI4ylhjKTVosYBRyi19Qt1C9aKTJ06mLVUkng6QeHSn3O80VCALKmzi7Qds3DJijQOID569bBjTTLmcwU/RyNY8tq1pHLNxfYcbwJJ9+PTe2sUM7dbz6r9A6y4oGcmwpYG2cjqRknJWTySnt90T9xHaXr4CLhGqTAe3BQ/6Pc0hMDbfffm2NxQ9j08Ikd0oEY0iT3gyDA1TwRenopZJ8cQanLF6P3DToHeyipafcN16GSTP6vSjWJQn3LSbVuoJ6BiRjMrm1uPyHdpwykfIqBj+uEIyvnOrScwp7v4aL6Ko94sTxsWSClLOgFBwvL3t2V75qQ1zZ22cCWq+dw+Q3WnUVtTqv7mryqfXlQhg6UFPwG4FhlocDr4X2s9f34xnFWwrEedaAAwRG8Z0IR5WStRfGzYOpSXKcLcPMoFJVHyLzGRF+yg5bT6HOxFWQNTRejzwgB9LfPq0Y//7SiVg4/iPMUwqG0b6qM0uT6iAL6+X5mig4Lbnj7Sy9i69z1YV/UHy8pzDFD+sJJUljViohtToqZwNmtqeG3zUx5+tuJRcsDrBY0AVOd3kcvqizqoqSfPo0nWJ/3Aie6nHXxzzpkseiIy/dJQ1Q4hm1aLUEoZwgkWfaSWpORrq5P3GtFC3o20Ag8E37b+8VfixCGtbV02NbsyLKaWv5gH0BFTtbE9p7qtXgXXADRYdH61HFhC/1xgNuTjZdDoGKSu/06KamG6caNkDnSYaxivxyrvKJ6DEPd2FbMYNu1gaDPW6Q2jMXSb5+ELsTbJXgMgTSQJUfgG8zDtCoWo3GFDd1+oRGVG75Hl J+h2uMm9 Gy07tKYzWwIjAl+UdgUira5nDPsjGbCyMJ3Y9LG190m8NeMu07XsKVeqCVNRBDlLxUTjx1aHINxAHj442C4v7SfMAixZGJ5+ekSDrJL5XC9T9vJkQVVDpxG4tEimvahR0zY/CN7BqN4jhakKahrkl4ZUyhIcp2q3hCQB52e7GwtKfUj7CINqLEVoA1svSInQutsmNF+n4WfthSpVe8x+SM4KHXt9SGVlX188m6rTplX27zs17dg/hnUMBLgSqTQ126jzhpZ2kKs31WYn5W7Rh8ShgRVlmGd6zm8u2ZS5BlUVoCDS1a0ODFlfyzQ+xNYCWWlhU7kyyWrloBME+l+Igx9nOE0GHZjqoBAvtMG6wQ6TN6dwBUBYXFPyadby9essjeqzXdpK+aKrPYE843sHguwOL4B5rMQ+/R+KovGFgCd2vPzf9I3ulaea7pA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.019780, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 3, 2025 at 7:49=E2=80=AFPM Oleg Nesterov wrot= e: > > To avoid the confusion, my question and a note are absolutely offtopic. > > On 02/01, Mateusz Guzik wrote: > > > > @@ -1085,6 +1085,7 @@ SYSCALL_DEFINE2(setpgid, pid_t, pid, pid_t, pgid) > > { > > struct task_struct *p; > > struct task_struct *group_leader =3D current->group_leader; > > + struct pid *pids[PIDTYPE_MAX] =3D { 0 }; > > Could you remind me why > > struct pid *pids[PIDTYPE_MAX] =3D {}; > > is not right? I seem to knew it some time before, but can't recall... > as far as I know this is merely a matter of convention, fwiw a naive grep: $ git grep '=3D { }' | wc -l 1273 $ git grep '=3D { 0 }' | wc -l 2031 $ git grep '=3D {}' | wc -l 5626 that said i can change it to whatever you see fit --=20 Mateusz Guzik