From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D73C1E95A80 for ; Sun, 8 Oct 2023 20:26:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 647B56B018B; Sun, 8 Oct 2023 16:26:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F7956B018C; Sun, 8 Oct 2023 16:26:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E67F6B018D; Sun, 8 Oct 2023 16:26:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 36D076B018B for ; Sun, 8 Oct 2023 16:26:44 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E68ECA0176 for ; Sun, 8 Oct 2023 20:26:43 +0000 (UTC) X-FDA: 81323427486.15.694348F Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) by imf30.hostedemail.com (Postfix) with ESMTP id 3B8A480012 for ; Sun, 8 Oct 2023 20:26:42 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Z5YuwcbK; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.167.177 as permitted sender) smtp.mailfrom=mjguzik@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696796802; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8zBwTiFmOyiSrWi8kowYs1L9nr5J7WpIdPVf6xKDyZ4=; b=Gw1BSqA+LKD7Zg//n7aHFIcA4f23opDRBzCvVf4GaabqnHYiQ9jLS6mW5nJDL0660sTa88 aVPx6SLYHgaZc/40ktuPC9YZYUtrM7gL8IgQjbXbYcPl8/16q0IT5hfvtkGky3/1Qb8uyv H/6+v1BZhAhx/zJKTbGWIovoihxPGlc= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Z5YuwcbK; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.167.177 as permitted sender) smtp.mailfrom=mjguzik@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696796802; a=rsa-sha256; cv=none; b=Mf0myyKz8TEYWj1vpQRNfHWfg9m6HCmpzXZ66dPLLJPnM+zbu3qiiFFCWxqo86TlSm+2K7 9US+23ucYHtJngyo1vBqONpiBVMjSHC/8uiCmESqyk8uUM1qUx9tJ8fNM7+V9Tz1Cfwn+g nm+HGDgfwAo0l1gxNwtUIUbAyaMCCJ0= Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3ae388eb437so2576865b6e.0 for ; Sun, 08 Oct 2023 13:26:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696796801; x=1697401601; darn=kvack.org; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8zBwTiFmOyiSrWi8kowYs1L9nr5J7WpIdPVf6xKDyZ4=; b=Z5YuwcbK7tLmTZqJS+l2HyUwO11oev+8hdeowZ3AE7IvGNXLE/99EFL9OMzP2GcEXx HRO92SzQTZBjAgiBZTyeQSLZYG1vvoAAV4Ih1fOUWH7FjDt4txispOE+MYd0LBNpJNQf M6bH7qAILQYKWdLqFxLompO3iLNxzy/0U8bY9VrRFrw6GKvtmMTGsDzqr8c9NlaF59wD uv60dojuJAif5rSxxm3TlH75RCTOIutC28h4vuxS933a6sYvbxrRVEDRuRTB3EZaHhHF 2O+fha5+Zc6DFSZvDLkzqdy7dj/RVQf8Q2bDjfd8+zPrKZJSBOBBUbaW0jYvgUwd8Xjs n+eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696796801; x=1697401601; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8zBwTiFmOyiSrWi8kowYs1L9nr5J7WpIdPVf6xKDyZ4=; b=nEJjgbv3s1cx9rZsmT1eBnhGGnktrcVeIch+WiQJR8CBuRw8s23ARsfgx9cgDJd0QV d8hypsEALkz5s5HXk052Dse9JUFbm/qsi3Riv3dhk2P35u+uZUWop567vTCCyBeVzGcF RDu413uBqkSE8RGSBNXQdZIvWsGD39OrtVP8bMGkb07kLxX8QnTeAe0WNNYEMuye1g2p kIccmWKj0oiqUTm8ua5NiuOsadUZv56JwAJzf/2529FOD1yXA4xWFN3fWMw5Q079uY9c /QUazIc8GIfkgMzGh6MIhI7kuilstFw3yorZgk/vGEUiJpM2O3f42pUb8MQa/J3YWcNq KgVA== X-Gm-Message-State: AOJu0YyRIdJurgXjpzsYR/tEGZLkXb4DMXIp7+38JPIsIGGeSP4GyHyA ND8r3zpTwSFcYQ5TZjHouPs3NjUjlzDV5IGG4Bs= X-Google-Smtp-Source: AGHT+IGXFZMVUUj33ZMCd2lgToLfK0JancQcV+OpfZX/S6PlohpbaFOPRHkSWgTIzdgUA7UG4Vn8i/zScfqA4jMEThw= X-Received: by 2002:a05:6808:aaa:b0:3a7:e779:7fc1 with SMTP id r10-20020a0568080aaa00b003a7e7797fc1mr4913920oij.7.1696796801341; Sun, 08 Oct 2023 13:26:41 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac9:5786:0:b0:4f0:1250:dd51 with HTTP; Sun, 8 Oct 2023 13:26:40 -0700 (PDT) In-Reply-To: <20231007203543.1377452-6-willy@infradead.org> References: <20231007203543.1377452-1-willy@infradead.org> <20231007203543.1377452-6-willy@infradead.org> From: Mateusz Guzik Date: Sun, 8 Oct 2023 22:26:40 +0200 Message-ID: Subject: Re: [PATCH v2 5/5] fs: Add inode_assert_locked() and inode_assert_locked_excl() To: "Matthew Wilcox (Oracle)" Cc: Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chandan Babu R , "Darrick J . Wong" , linux-xfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 3B8A480012 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: d8xudubk7s9irib7ftprji4n7aoh9eff X-HE-Tag: 1696796802-586925 X-HE-Meta: U2FsdGVkX19gY8+lPiEJ7TOovuC8HPEly2S3X/BZK2owLI0/5IYsSoew+FwLyzWiAZn7a76kCHILq3W9Ebwc7OFyMn5D5F5fXqdF4CjLVFAQoCnpzFr6YOy7i/ap2rlb0kIEa3G3h6rL8641xrutzbcIA7B4SIeG9eChPux1+rIvXDbpInkoty+MCUOVnY/TSB7V/WDcAfCeBFLrZjnubdJ7GDmEKJp5ef2Eca3OSbd8URBa0ZititO3zkfUgSmUB2XcQ+PTthekUKRpF0PVjMEAV6YyK66PS+iZwkPurUEl6forQGNEVG2PAgSlVU3W1SXSPbohwrCCHfFyRBWgXYENDfV4QspUPdiWktJyFKkr07ngrbmcsFRr1C0OBx8QkfQSFNcgJzoQ9p3lg+n0cuTWhW2QX+S/2vjAod7Shh18H9ScUgs6epZ/g3SVJdTOhcHUvRYxwHO5QreWDkeZObsd0v6E212MGlulZWGO8NMH0F3MB/T5xTrPlZArLw8UHUicZFo5Lx/JwnP1M2eHVkMVym+p5brTeNere0j4gDYbMsMi7t7ujf5IVgH09+55a5r6g7ohJVg6B8uLhJnqwAq+TozuOqu6+mEw3GTLw2EQw1id/AY0HcuyOkEfboM21BqeRJWc2KbX8T6ndNljrvm5nj4zUIsmiLjMxar3/d6D+YyJGVQOE22E6BC101skkMhSziUqGZ6JpPvCFzioyK9AArM9+EdGehh5S2Vn+TURDLTs2iT7U7BFVey16wKaJIidKtGqVpuNZLTpOYgLnWr+hX58DEbeUkpo+gdzpNzdj24ZUbwsefl4RG2WuQNlHETya+m+vNjqZVx/p6dtWAOxVHwuDRbUIBy+dh1JpbCkMaLaKH8MaQ0rgoHm6TDtiWzbZeF99EactoikGzLeffmKR/S/3HKZM31z+KdoWWgsfTouIku+RPyTG9nqpTEKZjokjbtSW4bETKZZzJK Fa3/NNu4 XmMc4jsVcb94Fl393tIwWmb2nWC4EteqCmmWaim+NlhZt+cb2J2E5HqNw9QHcOmdw2WcQmNMgRpBs49s/hwxRJqRvVIeHxdkx2A6UnZFPAkLCi0PNgOnuifi2DRCcPVBvOWagDdaUBU7HDKFsZD/9lgawUsPA2MTngOq1Wr433cuynKktJaPVb7O5bsisy0bjWEjNNUbyrl4VgEGilll6LKvX/8pjA42D6IzP44tGgcSz20GsmGIkL1wCe50vlaw/zB6bpJhKksFYTI9zXIrtffaiMkg8iqWqCGqr9TNJDDq8cXBSDDJZSUYO+13YrUsSJBWa4+6omyJlfhdBYaylcAyX144QgcgNo9iiTFoL83ow8Zf1Ps51jIUsN14sbBebds3IJ4Y/QMa1dgWIzDIN9Tu03kQbG210x2WhhCdJj8+Oa1WAjXSxHro+wkcXVfWTd6e6K6JNxqGYyp9EHyNcLo/dTAkfjflfKiebNAzIks3T4hYLxpNo5aAeVfbcqwPv6qao X-Bogosity: Ham, tests=bogofilter, spamicity=0.001861, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/7/23, Matthew Wilcox (Oracle) wrote: > +static inline void inode_assert_locked_excl(const struct inode *inode) > +{ > + rwsem_assert_held_write(&inode->i_rwsem); > +} > + > static inline void inode_lock_nested(struct inode *inode, unsigned > subclass) > { > down_write_nested(&inode->i_rwsem, subclass); Why "excl" instead of "write"? Apart from looking weird, it is inconsistent with "prior art" in the file: i_mmap_assert_write_locked. -- Mateusz Guzik