From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6991E95A8E for ; Sun, 8 Oct 2023 20:31:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B4026B0143; Sun, 8 Oct 2023 16:31:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 364276B014C; Sun, 8 Oct 2023 16:31:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22C176B014D; Sun, 8 Oct 2023 16:31:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0F5106B0143 for ; Sun, 8 Oct 2023 16:31:52 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D22AD1401D1 for ; Sun, 8 Oct 2023 20:31:51 +0000 (UTC) X-FDA: 81323440422.07.613541A Received: from mail-oo1-f50.google.com (mail-oo1-f50.google.com [209.85.161.50]) by imf08.hostedemail.com (Postfix) with ESMTP id 25EA5160015 for ; Sun, 8 Oct 2023 20:31:49 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=laMR+QmF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.161.50 as permitted sender) smtp.mailfrom=mjguzik@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696797110; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eO0wrsZ4W7mLGWyOWo1L1ds455g3zsEhPxWE1R/flK0=; b=Wub5hu6GgkRVmBEddmRT1jQJIVUeEyGYKO10NC0rW2W9dAEPBqq8RQKD+721ylIK66UhyJ vBGRBCCYTSmOj6lWJ+MuJqsHWRNl60D+c4l5ca2w2EU2q6FfF0WG8mcUx8EkCQ27g8/STe acSZdlN2NCwJZZtEgCTsIFSGPf8sBZ4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=laMR+QmF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.161.50 as permitted sender) smtp.mailfrom=mjguzik@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696797110; a=rsa-sha256; cv=none; b=tpyOkrp9rGQ1ntpKd/0RdPyhpg8F6pBfD3SCv9J44XmNyF/pC3F8k2Tg/p2KbCZephz9pw niVoUbWqIDoBlvoIyQzUqdxBsvFhDm6O3F7M+ylETpdpoiy/JiwtioTmEJsjEB4SpKIWwX bugojUvbT0YGvgqDBRbEEZ0hmhm9cH0= Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-57bc2c2f13dso2120440eaf.2 for ; Sun, 08 Oct 2023 13:31:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696797109; x=1697401909; darn=kvack.org; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=eO0wrsZ4W7mLGWyOWo1L1ds455g3zsEhPxWE1R/flK0=; b=laMR+QmFBrXFl3z3+aZM8cvKnDQXaRg8VJ0LAsK0QpAGgotRZ3hTEvL2t/Dj8O3elw 8Za6elv1GtuyxNISwX9F8FNTRHZd1wBuU3qzMCNncl9tyO/d2JybplAVR/i9BBgj35xv 6i36kYAXM5U0bcusxMiI2/cmP+sa6KLBiSHdrWKIdfuZd22AePxpbIxtbYWc5gnKB8nH G6BhAPwKSEX/qhLRBbatwOXnUXLicqwQBa+51oRzkUr85Ec4tC2qyOOg2GGsK6Jh9xzl 9YE771a7JMKHtiqroMv0OlRmtmbe3L7GBsuj3iUSp+haSzngTp1WxA1N87Pp4yR9fxHW qL9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696797109; x=1697401909; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eO0wrsZ4W7mLGWyOWo1L1ds455g3zsEhPxWE1R/flK0=; b=SMji1sTF65KERnc6XjROzqgUS0etw7rhQ+QggCvAWerM49UKCp22TxPnFSnxbbReqt ykdeBYBBpoXOu6k2n5M68YabLqUNPNXffhwnbdxxLpskDW37QGRJJKqBPyhG+ukKJMeG DNlDaVIPILj9FVYjv854Ot0E9Bh7L/H6KR7kWD2qYaERUowu9RTe0z0JBykwYMAJ4tQj JmEwoNeuB1yAkf6SYaw8yDbt/yNrwi2bRZoL3X5Ra7ja7aBUZ1rjsENsLI0/LnE+44Yb UnsFTrijdoZLkle2Af2a2sSdyuHnByh97Q6rirASQdps4nccDM66B61jjdvwu+blnVKW grbA== X-Gm-Message-State: AOJu0YxChwDxY4/gBrZ28/A7+5uGwrYYhmK/P1fSSJk0TLmccAKjiExb FIw4BjfAX3P4XAZlMCXEA118qMfl1CpFi8lXOtY= X-Google-Smtp-Source: AGHT+IHMTXJfWvMuR6oznb5qGqDLVX/IA7uJCid1OAV7BHG9/LxbKCHJUdFrpndXzyGXCLxjzqUe8AgJi/bxF+VkDPs= X-Received: by 2002:a4a:9b0b:0:b0:57e:cc93:892d with SMTP id a11-20020a4a9b0b000000b0057ecc93892dmr12747411ook.3.1696797109302; Sun, 08 Oct 2023 13:31:49 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac9:5786:0:b0:4f0:1250:dd51 with HTTP; Sun, 8 Oct 2023 13:31:48 -0700 (PDT) In-Reply-To: <20231007203543.1377452-1-willy@infradead.org> References: <20231007203543.1377452-1-willy@infradead.org> From: Mateusz Guzik Date: Sun, 8 Oct 2023 22:31:48 +0200 Message-ID: Subject: Re: [PATCH v2 0/5] Remove the XFS mrlock To: "Matthew Wilcox (Oracle)" Cc: Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chandan Babu R , "Darrick J . Wong" , linux-xfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 25EA5160015 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: zp5okuuyc61m5ri6oid5q4ebsajer9o8 X-HE-Tag: 1696797109-168300 X-HE-Meta: U2FsdGVkX18sGE3Oyown6Hd+orjJJFrO7v91U7ognw6AuTZ9B0JbfHi01hw1HJkxGd8vWUDTwK+TDzA++c5fAYBkaDPeRFDK12KvAmDmO8Hsb0wmsC1Cb/E60PWX7jiDJW5ulSC8WUu96TZV9urqj6UxMczz3QhW82u7yFk1wRoNq9z3Xsk6ZNv+tNSbSaeEQ8XHlsVuqDEPKm+9GVyx2rzuTiVlZylho0fPg5mkVnuU3DeWPQj91f6f5bGp74kmtRvOIDvX0CxW2zF8+ZZIehpc9KCA/0G6AQLayx0YbCfq4kkLIeyHjkEs2gPBkEHr5kCLzNFtSBnCatAqNXsZZxgmzVoI1U5AhRtRdKeUrNPLMKHEwW+c3DS1t9qNhnvIZHaDeMloBbwSJiRrOdB96UtJMBuUcqah2ueXzzZ2PumvI4B++xjg6u2w0qGKatNIuXaqCw4qpIxmMzmpmyPZ2+A87G4F57W92/ml5HxOdTkcagkZEcbOUWwkyKGVS19exUCPi9+kLLGXwiqrbe2BN7fX30kQGrE2CxkTBAIhJ31FbYoyIcDyt1xk6pg3+tUWwfGLg4UDmN1l2DCYoAekDcjvSetbjpOD+A/gCyYbIV06gq+skttHWD0m1Zu4g/QboBPWmcvXFFBk1H9MmmVXNLdc7xdYTFQRER8VrJDi219riqaO5P/A6+9ZsIKLn/uJTEy6DbFxf8Eg+TC5Frj2acZoidMnK6YlL4n9HVVK0oydn4GfV37Pu4GzKGz8AILk2urm8IDsHVlwsj770GNISJDiLS465dDwYv2qb8Ch9au2A823z80usH3tF7zIU+WuBUu0Nbvee39jZ9eykLtgoLydZN4Fu2CCrhbQyAWOmDtiPsGKb4TGtje3BD0ICHu+URz55ve6D5EBpDHXEDPhV2gNblt3LJ5ZGazjSno1TAYaYEmHtsEibrDcGyY0IYQJh1BwERQkAbvu1IM276S FuH8AVdf UxJJjLG7owsDVx9bADZp8kFhTKlhnjTVuDwbQKVAlo5RYVCX1R54C9coXIhlFKArBRzbLTBatDM6cJC6lnv2UzdU9aJUyGLFQ5JOa5or5cQsR2flk4zjdhXwfKwsP4iX1u6KNvowLjkjs0s66B7jiwko0VGKPG0YQq4jkhr22PVLcgTTTS/iLezNdhc6c22fjJaTuI8G9rC2FNxJop8bncf1VgSQ70scFuVOoDwjk+L8NKoPrR/pb/Whnrkb5SAIGll4iD0psXueSm5r2Gg4whhK1KvBSb1MX/KYeu6JgunmY43R9mR3saRnJyqjjLOVOACp0J/wxaJmab1yHhcHQjNeGASnZNqzZ2fowBt3psvchavm3oOkvFguQWi5YWIhVd/QIXLh/iRnw/cUktwvnBmQd+imO0S6D67Ae4+9kT6M+Tl2srlqYM2ADZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.020810, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/7/23, Matthew Wilcox (Oracle) wrote: > I'm sympathetic to "this will warn twice and dump much the same > information if you have lockdep enabled". Perhaps somebody has a > suggestion for not doing that? > Well the obvious idea is that lockdep could provide a macro indicating what's up. Then you would: static inline void rwsem_assert_held(const struct rw_semaphore *sem) { if (lockdep_works) lockdep_assert_held(sem); else __rwsem_assert_held(sem); } Am I missing something? If this is not feasible to achieve, then the proposed routines need a comment justifying the state. -- Mateusz Guzik