From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B6CED6ACC3 for ; Wed, 27 Nov 2024 12:28:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC2096B0089; Wed, 27 Nov 2024 07:28:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C71DC6B008C; Wed, 27 Nov 2024 07:28:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B39E86B0092; Wed, 27 Nov 2024 07:28:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 928716B0089 for ; Wed, 27 Nov 2024 07:28:25 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3D87BC161D for ; Wed, 27 Nov 2024 12:28:25 +0000 (UTC) X-FDA: 82831802676.01.D7355D4 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf12.hostedemail.com (Postfix) with ESMTP id D32564000C for ; Wed, 27 Nov 2024 12:28:20 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OIKxKHti; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=mjguzik@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732710500; a=rsa-sha256; cv=none; b=H611t4aajsziml9P1Flg6WPtND8knhyo3044CtGl+DctFRptkZKSL6rXTW5JUVKtk5ibXm BvVh4i0V8tqr+FkcZZuNswpd2alFwFiSdBz87ulOSa0P58JtVX4/mHMfU65TLh1RFEZMel qzT3bVb4KebjKmrRoHG9HDqA+D/Fhpc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OIKxKHti; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=mjguzik@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732710500; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uBuQtBr/HHW+O2FRD8SKWaOAbKa/8acp/47kK7p0Iao=; b=1LennCAxzwr0l/DhZ1M3Ul0qoVzzXeiiDSqvpntOpzmWy/24nuHKwoMxvBwUFLK9JSiHaN SryVq8Bee+CF4zX1K+WE5P6f6hGQhhAfCTPFMEEXUDU6mTRGtVKYit2KKYtFQSdi4muumB JiX40Nv/2s+58/SEB21P4im4FP9J/40= Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-53de8ecb39bso2100220e87.2 for ; Wed, 27 Nov 2024 04:28:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732710501; x=1733315301; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uBuQtBr/HHW+O2FRD8SKWaOAbKa/8acp/47kK7p0Iao=; b=OIKxKHtiLaFvjBY1Ll/L9jJwFD8QbwfMI3E7xa6k+alTrmdLfzf8lmBx86+ARcbDKe voEfObqqG/XUicNCfYoP11izxbpkhWGHGTNGA3f4SyZIybMI5I5hp3FIUhj2baR237NX skqn2xmBLqhWOWHKdN4lkxEh3auWasdy10ztIHdpe8y6zmXvXrqXAOqE1A+j7xiA1hj3 c/5U3JYSQA1JKJc2eRD079Kf11+uR+ltA2jVawBIY3s6L45aMwQaCEJ/+dB1DT3eCiWF VBK6OHtf0BoygTwdlLWqWyCUBP+UcTZETH72sNZJJaRWDVB6+Hlr6FrVQfbcgFaKEhZi Dh5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732710501; x=1733315301; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uBuQtBr/HHW+O2FRD8SKWaOAbKa/8acp/47kK7p0Iao=; b=KqQhhPcx5JxlQiZVBRqGr+5scPj2w21it+bSp75hsMXneA5KqtswEKVcwcFikNxLEM ednIuLuT1ktJSGETROsP5rhTYoWzulpRB3Fh4jTmLmcS2zEsI6dvXCy4gC7A1DBiRxTX omJ1aswASQ9m6tdlDBFULHJU2GZRApzH0N9r7Cox879fPyBx73AkhprcIKSKhXCKXgQp fPMJFurQeYDnY/+3rXmo+x+Wf62yzRvn6U5khYBKuS5ohIlFsbt/VhFejNCjC/hw0cE7 LroL0Q1IkuyBtdW2fd0Urzx4IjlZHTsjMkj6g/IXEVK+a4PlvBTw1767Eld5wGcHsXsz 7+2Q== X-Forwarded-Encrypted: i=1; AJvYcCV0U2kddzCP4qjwSQhooyXhN3FxsAIf5+erXbW6SRKvvmMsf0g/9R0kQtA4/fNYLTlXHv5fvb63+g==@kvack.org X-Gm-Message-State: AOJu0YwQ462pdBVbqeSX8pXTwm1kJBI88RLj1O2q9QXL1KIM+HAe5htk kAMHJLYVzFlbLFvSSOwV6fBDusvOwcL5ckGtpqmaCd/E9lxtwy70ZFC7x2i/Uu0unHGAY0K/cH7 mhnZtY9z3+oYcibVAzB8pdd6ndcw= X-Gm-Gg: ASbGncuYOwL2gerz7RCmP+CBiaopr+es2iDTRJjp00gzlcsneNOzSX+A4nwMQbmUvGM nWRVI4bvbZco0LFwp+jJdHMQenyzAYRw= X-Google-Smtp-Source: AGHT+IFwXubr7l0qYqnlgg97c6fsQlp+ICrOK0lCiQm2f0xBjXBzgLLDsS1wWMXHOIEQyFZAm6o1MSrETC7yopqdYTY= X-Received: by 2002:a05:6512:b98:b0:53d:ede3:3d5 with SMTP id 2adb3069b0e04-53df00d11c8mr1532012e87.22.1732710501089; Wed, 27 Nov 2024 04:28:21 -0800 (PST) MIME-Version: 1.0 References: <20241127054737.33351-1-bharata@amd.com> <3947869f-90d4-4912-a42f-197147fe64f0@amd.com> In-Reply-To: <3947869f-90d4-4912-a42f-197147fe64f0@amd.com> From: Mateusz Guzik Date: Wed, 27 Nov 2024 13:28:09 +0100 Message-ID: Subject: Re: [RFC PATCH 0/1] Large folios in block buffered IO path To: Bharata B Rao Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nikunj@amd.com, willy@infradead.org, vbabka@suse.cz, david@redhat.com, akpm@linux-foundation.org, yuzhao@google.com, axboe@kernel.dk, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, joshdon@google.com, clm@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D32564000C X-Stat-Signature: g3da84iumfnm9cxszjgw1sjeejtic18k X-HE-Tag: 1732710500-180247 X-HE-Meta: U2FsdGVkX19NIoKLm1JXWNy2lRapbEqg5snGsFHWDWt5DgdF0NlA/kkaqsg+B2/XKmjgXgrpQEckKVRt+AOmB+adZduEKsJ6Y6Sc4q+4roQrO+NxElNvqJyVJ/oBDFQvGlMTt/DcziujmNCCzb+dfu38AUs7SRr2VlIl/sBllCOLIxULZkh4QwqAe9cfeVt2VYMBJy92d9mGuThjBGpXmbY2oC0UFMaE1OD+zNcRlIHKH3E/LAXd/gNe3A7A+RT6GGTxC2pdYrlX3Co/SovxWMJBDP/4PeFRZSsL+tXnVN1tTuILsTKz97zurZaoTb3bslXYZUEwxBmhPpsg9D0YKljSTHSoTYRT8RcsGzrdmKZOTvAuE+yE4bfxIj4sUuIsL1d9mQa4K/NwuUpIBuQLYZoVbXGYaW6jEBN6RVkX8JRRCnseW3dZXwWbQqSVK862axR5urw9KC+iaQlCDJE8tyYzrIv7v7334JPJzsPbQ9YvLoUqoVhKqdeKiaSXG/GnmMNRYrKvvgDNkQzao6QlWXWixeRRBzWySg0SygFK8eGQ+9Sm+xuPgCDYI694pFOD5y+VZBsZkhRdHUKDqJSKNZaB3Wm0pw4kZ5OXnn8XXHHeujky4e9v2413D3QVT8HbbHB75kzkqV2pHAtnWa2UUd6yXllg1EiPXb4vc4k6IqgFNmDDX00OVJGbzjapZr4oQ9QN3GpGBrVyTRBjSF4Q0uOM0dBY59hjOM+NdlVO8SyjNTwxZ5DyQCPuwhobtZMlLhVzkrIEaXBMy2pskB61UTa/WKHCXpknY17jwDobfyV7shgEqVKrjfb8xclGdJIL5roTElfkj44E18WvTylyH0/6Y/zdz+iry0+ZiZzKrhpfiF1y2S1FZiqYx438sj1OivR8MxCvT/tdvXYS89GNTVgLgO39F5vANpCtTcJ13uP4x5UoH8Cq6zSUdyLuUl0nHr272sNrDzi3cIz3Bzj 0VpIMoXn AxUdR7MMyqIUVIOMH2yOciYrgjc4diOBZT+s8jpGH09VkgrZOw0BzcLOBFyShgb9uT3WW4iR319WUG/8eFQyOiFngzPrdA54cFjVs9xooEYUN267QTnuXlMFjBcarvXee2iOpRYXjZnBqQSSMoO4F7X6bBrQt6pBiDXobSargj1KUx45bSMFazMXvqf0fMx6VnHiiQx+jor4wD8TyAApj7mWB4ZkoXIpiRYnPczegPKZyQEUePE9dKD3GRjWBeWjwM+b5B6kIy7UNZGQhVbPDT/dulXdZ7mox/N/J1ngC2zIC2uzxsgMc0YJUixXazGjpO1hhFeKMYBUA7hf9psK5wt+Mj8ulOYmaYs4J8kgv3w3qzkK8jvWaDpFJYw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 27, 2024 at 1:18=E2=80=AFPM Bharata B Rao wro= te: > > On 27-Nov-24 11:49 AM, Mateusz Guzik wrote: > > That is to say bare minimum this needs to be benchmarked before/after > > with the lock removed from the picture, like so: > > > > diff --git a/block/fops.c b/block/fops.c > > index 2d01c9007681..7f9e9e2f9081 100644 > > --- a/block/fops.c > > +++ b/block/fops.c > > @@ -534,12 +534,8 @@ const struct address_space_operations def_blk_aops= =3D { > > static loff_t blkdev_llseek(struct file *file, loff_t offset, int whe= nce) > > { > > struct inode *bd_inode =3D bdev_file_inode(file); > > - loff_t retval; > > > > - inode_lock(bd_inode); > > - retval =3D fixed_size_llseek(file, offset, whence, i_size_read(= bd_inode)); > > - inode_unlock(bd_inode); > > - return retval; > > + return fixed_size_llseek(file, offset, whence, i_size_read(bd_i= node)); > > } > > > > static int blkdev_fsync(struct file *filp, loff_t start, loff_t end, > > > > To be aborted if it blows up (but I don't see why it would). > > Thanks for this fix, will try and get back with results. > Please make sure to have results just with this change, no messing with folio sizes so that I have something for the patch submission. --=20 Mateusz Guzik