From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C721C3DA4A for ; Wed, 14 Aug 2024 04:10:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2ABB6B0082; Wed, 14 Aug 2024 00:10:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDAD86B0083; Wed, 14 Aug 2024 00:10:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA2666B0085; Wed, 14 Aug 2024 00:10:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8C71B6B0082 for ; Wed, 14 Aug 2024 00:10:22 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 03C3AA0C14 for ; Wed, 14 Aug 2024 04:10:21 +0000 (UTC) X-FDA: 82449523884.15.364C0FB Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf07.hostedemail.com (Postfix) with ESMTP id 315594000D for ; Wed, 14 Aug 2024 04:10:18 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aS7n+87B; spf=pass (imf07.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723608547; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ISPW+Qx+7bzTu2MxU1tIs/xLNXoLPqwd8ac6oJ+C4UM=; b=jI7h7uIWXRBd3ivHvqo5aFN52+pbpV4FJyLku++M4mRhUSwXuDUG8yPTbshWAptkFmNuIW Tx8grbQpzlQravbfFMl++R/QtajGGzr9Vo6k5SlXSs7D+3PEDiqZaawbgE2Kik1NEEaUDB TqtopIKfvJljuqdxmo8YdUp/ug2t0vE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723608547; a=rsa-sha256; cv=none; b=nP713FX8lkAnSkoMCks4DO0EjrzXGr+FIaw2wkpwxtuwAnJ2qFrXpDg/gM/0YEsf/+ihpS rUJn7izor9vJLbGG4hXIYHrHNSapBBvNbK4x11f8aacKiIG0utPaLO4mtDUvbCBbzrFtTo rqd+uWTW3TylV91EDq14n1lZk6NTQV0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aS7n+87B; spf=pass (imf07.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a7aa4ca9d72so745037366b.0 for ; Tue, 13 Aug 2024 21:10:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723608618; x=1724213418; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ISPW+Qx+7bzTu2MxU1tIs/xLNXoLPqwd8ac6oJ+C4UM=; b=aS7n+87B2rom3jHBggOeN1VfWalqh6Ht6rd1GJ/dxMjmRij5ncfv4pTk8yMQLLjtbM J82Fc2uIMABWq8N7pzKNRUgVzwf3mvjIaxQoNYvON+osRUuaZeJKQ6nqeov8DObVPBVR GAk8uDW3NDrXwLFADN4Ue+vwsbvChc7T1MICmGWnfGAO6es9pwDVq+op+At7YMqsz1Bo ICd/JYVh0OjorZKEYW8ir+TiBsmlc4NvEEvGWFaVSHPqfDKJIXSmCJEOVonCKyk4UbYy ezK1uotbLq++D80CmwtJjTBJ2ms87kVFXZomLFMmo/Cp8UE9b/n1DdNfTdZ+codY0ugg S2kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723608618; x=1724213418; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ISPW+Qx+7bzTu2MxU1tIs/xLNXoLPqwd8ac6oJ+C4UM=; b=opwyn0uE2LqOV2SIgw7Ff/eMr8dptfS9DZ6A7pHju32e5gwIU39iwjFhsQrC3KrKYc xppRb7vEzkfLrbKg1mKSbli0ta0jbI8s45tmMqfO1GHSJ14JctLWgvYTbzVI8Adaz7gL /Eiq6jynv+zwvJ8FUZxWCDDnxAVI84BM75Xr2FPr11zeTyFF9yV4Yhyiy9I7jAC3rOJZ rG/XoMQerMRtNWF13mN6GuPebQXcSp5ZBKb7+9lXT/t7deVKCRh1UHGezmr8VaPAXjBv RSMglU9a3Vl8eVqIvmRkAdXMvviHF2VDoG+dFsdxnjY4TPqLSRbghdCffelRXfKZsZHn 1zrQ== X-Forwarded-Encrypted: i=1; AJvYcCXjPgtK2YVchC0G3KP1PU3XR58Zo4s8Xu+euClOlfglUMcrac3yreBMpy996ko4lc0HmDoR/TszhyYhWYEULQHwP34= X-Gm-Message-State: AOJu0YwL6WUH0hkNFYkQI8I9vRqRiN8C6f3RYEjPXzhsGiTYYkQJML4n d4EWItVDyrPHiPwtd/Fw6zQWlmdrJxO26FRkijNs8qMJd536065qjH0VuB7Y7KVqggjWGMRY7Lg TsQj0cqUVk5SSQTzq8nlMyVlxq/U= X-Google-Smtp-Source: AGHT+IGXnhXCugXZDWzTqqMcz2DmSHRI/XgexLfnEYCPoZj0QeDS1y/Gs2zevf9iRLZ1IZe2xv1pmV+KQD4StPMk76M= X-Received: by 2002:a17:906:c152:b0:a77:cdaa:88ab with SMTP id a640c23a62f3a-a8366c2fa92mr80675466b.15.1723608617270; Tue, 13 Aug 2024 21:10:17 -0700 (PDT) MIME-Version: 1.0 References: <202407301049.5051dc19-oliver.sang@intel.com> <193e302c-4401-4756-a552-9f1e07ecedcf@redhat.com> <439265d8-e71e-41db-8a46-55366fdd334e@intel.com> <90477952-fde2-41d7-8ff4-2102c45e341d@redhat.com> <6uxnuf2gysgabyai2r77xrqegb7t7cc2dlzjz6upwsgwrnfk3x@cjj6on3wqm4x> <5a67c103-1d9d-440d-8bed-bbfa7d3ecf71@redhat.com> <5c0979a2-9a56-4284-82d2-42da62bda4a5@redhat.com> <817150f2-abf7-430f-9973-540bd6cdd26f@intel.com> In-Reply-To: From: Mateusz Guzik Date: Wed, 14 Aug 2024 06:10:04 +0200 Message-ID: Subject: Re: [linus:master] [mm] c0bff412e6: stress-ng.clone.ops_per_sec -2.9% regression To: Yin Fengwei Cc: David Hildenbrand , kernel test robot , Peter Xu , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Huacai Chen , Jason Gunthorpe , Matthew Wilcox , Nathan Chancellor , Ryan Roberts , WANG Xuerui , linux-mm@kvack.org, ying.huang@intel.com, feng.tang@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: xydbbncbapaf93p3dargsxt4u6ct6ksd X-Rspamd-Queue-Id: 315594000D X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1723608618-970012 X-HE-Meta: U2FsdGVkX1+uldmnc74Yo3dekezzs0dlE527T3MFMgLsA0PPUswD2KV839rgyYgrcsO957bS5CJLnnOfgll+wbvnQmIqPt8O6Q6OQA0R3R2GfejHg8YVOPL2b+lZyxM5ghveC3/MAu4McOkEp8tIGjB6k/fxGOveIA67anSOvH8ALQID6SRsYgYK/oMkz63B5DV2xNVvDIBg/losyttGMu5XmOji29YcsNK/bsO9+lWjxPD321VVaPj3/ymJ7xscp/i7oZYnCKl4R3KhCaLG9qwFTWF+AiB718g5h7Ax3rEhu7pWfHC8KEFcKxiDmHbzdHKhfBQVL1VxCRunW8cLh3k5JMNMs8Fad0uKUNF56zgWtGi+pyll+LRLjEh/EVdHOtl8DARPrV0dgQhktdKDN6hA8JIN9+WV1BNI1tgYr7jUjkoUAeATppa9UZ7N4L+g+u0G05PxH47Iy7HoUYiaaNX0qysZTpMwYidw7nSA/3RyHt40i5Yt94UG0t9nuDwvFecElIOZ9iMOQvkGEoDMoHd16LRnSA2v+9SXk5j0CRCEpmvT/01EZDsez1CkNziHtYbAZYFmHEXDCfWfvIwNDIRN67WcmyfF5sON7Pd476TuQ9+apBGF/codCkwxDKhyKb/cs42rr8iGMLyxZaDnjKNmqZe67c0Gpi/PXXPizWT3rup7I46Nqfkb2aLlXV/8OQrZEg0oe2brp0cuArQywY62zakCy4ZPwB0nouUwDFMLhL8rxJt1WyT4dK2R2BsJbz+Z7ivqZvAcyv44zMaMWyHKBwWkXEkGDkYKZRPF5pLFuP1bQXTkOCv0HOeHRB+QGxJg4PM0TL1x/1R5eQ4+MELuGXqIrM30mPVTjBaLfl1e6TcwLFEzHHnvI6+L7S2QQgSbhffEdJQaodlQcGO1DnaZFmePq6Jv0FGEssh6NuP1hzQ0w0ncqUezkrH8oufyRDK1F5KWxWvvIoB1u6j k5dKHmE2 LJB/J7spwV1khjml5CV94tPu4/6/3mATGQPREwNwE4M+CBVpr7Z0sJii0VLvIMSnhEpYpDQP1ss+oWD3GBI2cksfpm+KGzSLaSOsjUAS6DHkYYgvrTCWyGcBfIGYM/0gn/qoXSres7G7eevFciW0UoVnJdJVreXUtefBoQoufpZpUFtjlc8RmH9RPJUEZHhYZN3JiYEDirZ9Y+wJqq3DWLUkQyQXOmovKdCaHq2mWnbdwYZxwwMgOJq0rwxRgh45ssTif+PqiM33xCcjlDHdAA4iaKFqnzc4zQwUd/31FetEgWIkO/wCCrYWzWMdiLDWxAkm04Bu9iGD+CHIrgjRfECtReshHHikJ3YDStmcS2XevM5KOhNaQ6ipE5ikOPOGaXzYeQrPqtjLvDQkrL2luf3Q0wP6eW5CCa8KWktPs8mNkXX2ZAcPZ75QoHIh9XJVg2N+6uPFCL20nQ/Jq4T5QS61D2Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001254, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 5:02=E2=80=AFAM Yin Fengwei = wrote: > > On 8/13/24 03:14, Mateusz Guzik wrote: > > would you mind benchmarking the change which merely force-inlines _comp= und_page? > > > > https://lore.kernel.org/linux-mm/66c4fcc5-47f6-438c-a73a-3af6e19c3200@r= edhat.com/ > This change can resolve the regression also: Great, thanks. David, I guess this means it would be fine to inline the entire thing at least from this bench standpoint. Given that this is your idea I guess you should do the needful(tm)? :) > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > tbox_group/testcase/rootfs/kconfig/compiler/nr_threads/testtime/test/cpuf= req_governor/debug-setup: > > lkp-icl-2sp8/stress-ng/debian-12-x86_64-20240206.cgz/x86_64-rhel-8.3/gcc-= 12/100%/60s/clone/performance/yfw_test2 > > commit: > 9cb28da54643ad464c47585cd5866c30b0218e67 parent commit > c0bff412e67b781d761e330ff9578aa9ed2be79e commit introduced regression > 450b96d2c4f740152e03c6b79b484a10347b3ea9 the change proposed by David > in above link > > 9cb28da54643ad46 c0bff412e67b781d761e330ff95 450b96d2c4f740152e03c6b79b4 > ---------------- --------------------------- --------------------------- > %stddev %change %stddev %change %stddev > \ | \ | \ > 2906 +3.5% 3007 +0.4% 2919 > stress-ng.clone.microsecs_per_clone > 562884 -2.9% 546575 -0.6% 559718 > stress-ng.clone.ops > 9295 -2.9% 9028 -0.5% 9248 > stress-ng.clone.ops_per_sec > > > > Regards > Yin, Fengwei > --=20 Mateusz Guzik