From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 687DEC32771 for ; Fri, 19 Aug 2022 19:37:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E23B26B0072; Fri, 19 Aug 2022 15:37:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DAB6A8D0003; Fri, 19 Aug 2022 15:37:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C25008D0001; Fri, 19 Aug 2022 15:37:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AF5E86B0072 for ; Fri, 19 Aug 2022 15:37:55 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 888F4408C6 for ; Fri, 19 Aug 2022 19:37:55 +0000 (UTC) X-FDA: 79817352510.12.4AC5AF9 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf10.hostedemail.com (Postfix) with ESMTP id 1F714C0010 for ; Fri, 19 Aug 2022 19:37:54 +0000 (UTC) Received: by mail-pj1-f45.google.com with SMTP id s36-20020a17090a69a700b001faad0a7a34so8435722pjj.4 for ; Fri, 19 Aug 2022 12:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=k9KpOd9i/ZNi1t1K9tR8np0p9gkpfM3VrD2lfsO25Mo=; b=HC3bATKO80CNvgZPBl3R//G0TK0r3ngVuJktWYhEP8NaHJnXH6/HXfP142vc4oH9Aw oJyeetzADSpgcohe210zCSh8DQfsxcwVcf8c/0gFINaAT23hmdkT8TGnAAdrxDmHlKGf fctMqKyKBGj1alfGcbKBQ2/gLlX44if/PwK0HhdyLICbvLdbiwe2vlRz/1zOJjoePZzP pxHe9IuraDvzqkDJ8J71BHT2b3xfBrXGMv+aVkONLXSJx4ZIfmskklMmsRvcCwUvoOUK TVCUXOcQ5kN8i0t/EAZeKwJMG0HSZvtVvquJlnRoYjq4V1P98OEYU5jvAIbcSHYlInUs Kn4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=k9KpOd9i/ZNi1t1K9tR8np0p9gkpfM3VrD2lfsO25Mo=; b=rF3wWfBSRSMgyyoDPZ5DDzJfVWs9aaKQh5OuUKzDjKuEBr178oQXsW5SJZx64pqakn T9Nd0fKvL1Yer8ayCo23PskmyTxywuu6Svg1AFoJBtH7WJgisRme886axN96p40sJDnW H7vxgpkhf46aYS7baLRpHnASlYFkI7NBamU8pCA5rmpJAxYSGaOidb5m6nR9SiKW7FG5 vcTiIk20zo3ZT1I8xTDIEVid8J70Z37yOaD6Z8tflYznRs0V6kH5/trikzMvRriN22Kt 517ZQDnml0+kd19nUmnOYRUR4W9acXAVeX9uhfgqMCPkgk5TaqG3mr8J697XRO8LItbT Ftog== X-Gm-Message-State: ACgBeo1/OeHLIb2wJLXbs/20fZDtT5eNoSH0NcaAWrGVGRCBcYR3Jc7i D8oiUReBjqaqG7sqvhmdWZNWkQwq+x+xhiX/JRf/Kg== X-Google-Smtp-Source: AA6agR6k/DAzQx9qRqaoRc0DfYUeZpNmDFrlAHfGRBtmhp/IGDr8OXnmdkj2tKhP7ciJU8phJ2DTP7DaAQ0zqKSGHws= X-Received: by 2002:a17:90b:4b91:b0:1f4:e116:8f1 with SMTP id lr17-20020a17090b4b9100b001f4e11608f1mr10112497pjb.121.1660937873970; Fri, 19 Aug 2022 12:37:53 -0700 (PDT) MIME-Version: 1.0 References: <20220706082016.2603916-1-chao.p.peng@linux.intel.com> <20220706082016.2603916-12-chao.p.peng@linux.intel.com> In-Reply-To: <20220706082016.2603916-12-chao.p.peng@linux.intel.com> From: Vishal Annapurve Date: Fri, 19 Aug 2022 12:37:42 -0700 Message-ID: Subject: Re: [PATCH v7 11/14] KVM: Register/unregister the guest private memory regions To: Chao Peng Cc: kvm list , LKML , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, linux-kselftest@vger.kernel.org, Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86 , "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Yu Zhang , "Kirill A . Shutemov" , Andy Lutomirski , Jun Nakajima , Dave Hansen , Andi Kleen , David Hildenbrand , aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , Michael Roth , mhocko@suse.com, Muchun Song Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660937875; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k9KpOd9i/ZNi1t1K9tR8np0p9gkpfM3VrD2lfsO25Mo=; b=jzQGgFT8GLxrj3x6GzV2BmzwfnOBYo5yuFBSm9HqrGlloqXtYiroVDfB1QvA2XILU52pEQ Gs0M4BLyXglbNhjdS/S5iM1SikKumzaUnW80pBZEozdkhZm3lP6ygxOfu1/cqFLQNoz8rd ZOUw8d62GGrjj/EsX9EDYMrErNgcTM8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=HC3bATKO; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of vannapurve@google.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=vannapurve@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660937875; a=rsa-sha256; cv=none; b=UygpPkiKXzsF3ePLjmGm5jMH3mYdopnyzASzdM8bDuCWaTy77u87BfYX5RgL25/A5HBMCK HkPYiS3stOfvE90N6xrr0hwbX6G6HtTM/rLY/R27jMuR+LuNKgaF3UZx+h+6Qp4yJ66a4T 76O7zVxG3FX7F4dtZtfj5gJOe5FEa6I= X-Rspamd-Queue-Id: 1F714C0010 X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=HC3bATKO; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of vannapurve@google.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=vannapurve@google.com X-Rspamd-Server: rspam04 X-Stat-Signature: ddg63zmkcfwqo9bb5urw3yq1s9cpob79 X-HE-Tag: 1660937874-221787 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > ... > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 230c8ff9659c..bb714c2a4b06 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -914,6 +914,35 @@ static int kvm_init_mmu_notifier(struct kvm *kvm) > > #endif /* CONFIG_MMU_NOTIFIER && KVM_ARCH_WANT_MMU_NOTIFIER */ > > +#ifdef CONFIG_HAVE_KVM_PRIVATE_MEM > +#define KVM_MEM_ATTR_PRIVATE 0x0001 > +static int kvm_vm_ioctl_set_encrypted_region(struct kvm *kvm, unsigned int ioctl, > + struct kvm_enc_region *region) > +{ > + unsigned long start, end; > + void *entry; > + int r; > + > + if (region->size == 0 || region->addr + region->size < region->addr) > + return -EINVAL; > + if (region->addr & (PAGE_SIZE - 1) || region->size & (PAGE_SIZE - 1)) > + return -EINVAL; > + > + start = region->addr >> PAGE_SHIFT; > + end = (region->addr + region->size - 1) >> PAGE_SHIFT; > + > + entry = ioctl == KVM_MEMORY_ENCRYPT_REG_REGION ? > + xa_mk_value(KVM_MEM_ATTR_PRIVATE) : NULL; > + > + r = xa_err(xa_store_range(&kvm->mem_attr_array, start, end, > + entry, GFP_KERNEL_ACCOUNT)); xa_store_range seems to create multi-index entries by default. Subsequent xa_store_range call changes all the entries stored previously. xa_store needs to be used here instead of xa_store_range to achieve the intended behavior. > + > + kvm_zap_gfn_range(kvm, start, end + 1); > + > + return r; > +} > +#endif /* CONFIG_HAVE_KVM_PRIVATE_MEM */ > + > ...