From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F43CCF58F4 for ; Fri, 20 Sep 2024 09:18:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8ED96B0085; Fri, 20 Sep 2024 05:18:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3F1D6B0088; Fri, 20 Sep 2024 05:18:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A068D6B0089; Fri, 20 Sep 2024 05:18:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 81F346B0085 for ; Fri, 20 Sep 2024 05:18:03 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F406FA7BA2 for ; Fri, 20 Sep 2024 09:18:02 +0000 (UTC) X-FDA: 82584564804.26.7F5F6F8 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf26.hostedemail.com (Postfix) with ESMTP id 2312C140005 for ; Fri, 20 Sep 2024 09:18:00 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=okI5Osdh; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of vannapurve@google.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=vannapurve@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726823788; a=rsa-sha256; cv=none; b=spiNjh5MFNjSFRsw+Q6SQLgC8lGcxlX25HU2xNXGkzL1k6zoNxDuGGy5mEGkKd5PO2n6D3 pznrcJoj1cvAk6SK/Zsh2rlNhY+vCJZ3TvmXVzt9OERhECBM/3hJFTCQWKe4DdtBbINvzv ZvQ+fIcj/XgyxknAURAzeLzZhSpE7kI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=okI5Osdh; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of vannapurve@google.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=vannapurve@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726823788; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+lFk8tXQAtRWRov+FyUw+DOlND+znAP6uIhHjKMCkOc=; b=QXAtGwvlf9/oTYpss3YxoKh+1GBhk3MeFpy665aSLozU3GN79+6nPYBa785qCnOvmYzJ6+ KqRdsgCNWCc6uxmuY3UK2Aoosqfcy6e7MJEZj3zIMujiR7HU2gdCe2JpqJhOSRsMV++AhN bYj1DfZW1dS2Jg7/HTsIKtTdxJ+BmYU= Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-53690eb134bso19302e87.0 for ; Fri, 20 Sep 2024 02:18:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1726823879; x=1727428679; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+lFk8tXQAtRWRov+FyUw+DOlND+znAP6uIhHjKMCkOc=; b=okI5OsdhMxXlFrQpD2ERxHUJq/lACBs94LTQ05wI4Kl1va/g4tQqCGY1CxbhI/bDdP s+NNYQAbbS4CthqGF/NdMGj7lp9JB3Av5qE6Dys3ytpFCIorD8Pz9m8uPef6tHbGc2fW Cl/OexV/6yPZxan6kzW4wKwVgUnH6FtU4R5H42Sj4s8yLwHT1OiqbMJfB6hFX0K7XyTV ILcipgYBUbv1tfT8o2Nh2WEb51o51mYiTx99pNm4J/gKf/7nbtSxLHZO0EW+WdGbb3vY e6ToOLBpz3K5CkPK1OxqCk4lbXDLFwOETxtZNK9eXNvClSy9u6LyTnbKkX7O9MSHSMzN 2XOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726823879; x=1727428679; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+lFk8tXQAtRWRov+FyUw+DOlND+znAP6uIhHjKMCkOc=; b=DsLk7zMDCYI+MgzVo7HzHt4xgbiijQgHgzV4wngENNRd/CGevaJSlCr7jg5P385200 BpeSO4fHkzvKWSTUZwnDammQoHeE87KAjdHAf/vcANjdjXqlT/dGUs92C0NCLMTG22nk UBHOdY4QIBZ29gsz0T++b8ab92gEeceNImMD0s/XR6/UvKMcW4xS/vQpnQY8nK2NFGG6 wmyBDTEu+AiLjpzzYWgG9v/F5DVRQbMmqvB+wqR9ieoMHMUnomXf1IEc+1MIM67QYmqM a4HcYRgO0I9FbRM0m4AL2xV3u/06YiQUntkbwHAeyEHN7A20lJkrlmrTh3RYZYThrPGj zr2w== X-Forwarded-Encrypted: i=1; AJvYcCVnAwIfcvURvgTpH9bL1zDX2OpzAymHDK95Gz3zZAsmQ6EmK1GpzpnVO6bcjPJgWDyD3F7D8TuX5A==@kvack.org X-Gm-Message-State: AOJu0YzoyHQWcQReNZ8z2u89YRdDjUmfkKdj5aUw/z7MrULMBW1+10uw ceCd4yJf3wcEtcRpJ9zhxw7JwVrMDIvIB8NEKAdmIcLm/rg46gIaGhltvbv3+DEso/YAE1vIg6b a0LGN22H3eRs7l9y+h0dLkB5xmvJMNOYGXJf/ X-Google-Smtp-Source: AGHT+IGUyIDlL02SNNAcH/QvRLTVV1cCj4Jx4XR/xAOmRuwfotB2Vg+l7WNmIIRqJTSsmPZsLrQ01b0WIBQsdccc7K0= X-Received: by 2002:a05:6512:1192:b0:535:6a42:90f2 with SMTP id 2adb3069b0e04-536ac6a8cc5mr341346e87.6.1726823879081; Fri, 20 Sep 2024 02:17:59 -0700 (PDT) MIME-Version: 1.0 References: <3fec11d8a007505405eadcf2b3e10ec9051cf6bf.1726009989.git.ackerleytng@google.com> In-Reply-To: <3fec11d8a007505405eadcf2b3e10ec9051cf6bf.1726009989.git.ackerleytng@google.com> From: Vishal Annapurve Date: Fri, 20 Sep 2024 11:17:45 +0200 Message-ID: Subject: Re: [RFC PATCH 14/39] KVM: guest_memfd: hugetlb: initialization and cleanup To: Ackerley Tng Cc: tabba@google.com, quic_eberman@quicinc.com, roypat@amazon.co.uk, jgg@nvidia.com, peterx@redhat.com, david@redhat.com, rientjes@google.com, fvdl@google.com, jthoughton@google.com, seanjc@google.com, pbonzini@redhat.com, zhiquan1.li@intel.com, fan.du@intel.com, jun.miao@intel.com, isaku.yamahata@intel.com, muchun.song@linux.dev, mike.kravetz@oracle.com, erdemaktas@google.com, qperret@google.com, jhubbard@nvidia.com, willy@infradead.org, shuah@kernel.org, brauner@kernel.org, bfoster@redhat.com, kent.overstreet@linux.dev, pvorel@suse.cz, rppt@kernel.org, richard.weiyang@gmail.com, anup@brainfault.org, haibo1.xu@intel.com, ajones@ventanamicro.com, vkuznets@redhat.com, maciej.wieczor-retman@intel.com, pgonda@google.com, oliver.upton@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-fsdevel@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2312C140005 X-Stat-Signature: iu88wjzzarwew1z9frw66mozdrcib3ma X-Rspam-User: X-HE-Tag: 1726823880-817671 X-HE-Meta: U2FsdGVkX1/QYeCS6FL2a7XWdwI9KE3b2/1w4ywA4BrqtabTkYuYKSxP3mAD8hnKoYeEPgn32Lt4C7xJv2q1W+/RzVkOj+a2Fi8lG9ffuoFoplwXvQJP69zlubWAsshKIVV2L+tS2UnNDS5mYTYEUMgrpJuaRyKi6wVgk105oszsvvvF0xRoWx4Ef3wX+8hoOYxvQGsd0i9/5tjvOlnxJ9i2cepQ3hE71yLiBsNIPlj5Cur9Ctm4C2uVP8EZN/uPfQ/3+QFZ2/GEPNYYFDEgGUFXX6PmgwIPnBBW/o/JkHZ4fA/xVvTpzqdeP4vWWY/idzL7GKF5MWOHTiKp3zZ63lY1QbvTVuYP1/xQAj2whnPRRLmM0goko8LqVetYkVl1ydkbn9oDhaB2Tj58ieTXdm39Mo49lOTXq0Ir/2f/wxEXE/eWnWMO/r8yKtT5qONQ1aLslOaj5eEbOSNFKOtd6dUfS9brrtBOmaYnwj4Z2uZBWG1L7YFKXb0E8JoojRTX8WRg5r374z0fmDogfa0fLyWsDQuWVRrVb2B+pN/ufO1pS8VDvQD30Yq6llRgj8DUjPzhsVuh0m+IGvOxGLevqTZlkIevUUiDKcVNaJucMdmWyc1jkbGgH9/VDJqaDTqNrdYvS7Zi6hVkAjdPt550BWFl1QfvU/OeZnAJxdp+Ok1LpEgSOJif7cv5nNKOJivBmvlmwobZsWPzBQcxJVUE1ZPykW9wkjAwUkOLMQuK6u6gKwNoZmg7WRwj1IoogRQ4xpQ5FlSCajlmpWvgvp/tvYCVNZ4W6mRPhtZi1qHCQDGyXq8y/xvshfDyn+HKpI8QM1TxmaBcApcDn6Hco80JjY8Ey8nM7k9SFB02d8Dc6sXCLjgvx2wLJgTbIUHHTag4ij9IhfmTzkpgMyV41HNCHMQVJg/n1WRyT/WfMz4U/Viict49Jj0dM4jv9TdIj8lCNbz5pi2r389UKBDfFKt 7mKFHF69 ABUzRnuMMH3sPPHmWnLQQgxZusmmqzLoBsZnckdN6vKSsSNhUdiae8tgXsyZqd2Q0Bf3dxqpVJQsmOHprGww0mDwXyY/ZbFu3gUY0t6XJrNHAP/znBo29zIqKutWdWM3RkFjU2njQi2h7hzhXIb7zf+dYE9i4idUI0+VpB0GOdZjjUz/ZUfMjlpXDcpX+EEaxT1wrqAEx8iwZIpGemdAwXhlYUCe4QlPf+BggaE4qTvvug2JVPHfZ/DLQZA75XZefpJjKM95f6IfJvfCegUPIYYgOrfKIG1hC90l8Bp0xIvuDy4AGtz7i9P4r+J2hELXP6miksKr7XbhY4xxXkh70WrBqS8haCojHcETxPZVMttqsWX4WLQ3eKau1kjwdmEHgr8K3VaZ/SgatPc4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000250, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 11, 2024 at 1:44=E2=80=AFAM Ackerley Tng wrote: > > ... > +} > + > +static void kvm_gmem_evict_inode(struct inode *inode) > +{ > + u64 flags =3D (u64)inode->i_private; > + > + if (flags & KVM_GUEST_MEMFD_HUGETLB) > + kvm_gmem_hugetlb_teardown(inode); > + else > + truncate_inode_pages_final(inode->i_mapping); > + > + clear_inode(inode); > +} > + > static const struct super_operations kvm_gmem_super_operations =3D { > .statfs =3D simple_statfs, > + .evict_inode =3D kvm_gmem_evict_inode, Ackerley, can we use free_inode[1] callback to free any special metadata associated with the inode instead of relying on super_operations? [1] https://elixir.bootlin.com/linux/v6.11/source/include/linux/fs.h#L719 > ... > > if (size <=3D 0 || !PAGE_ALIGNED(size)) > return -EINVAL; > -- > 2.46.0.598.g6f2099f65c-goog >