From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26D45C02193 for ; Wed, 5 Feb 2025 00:51:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87E1A28000B; Tue, 4 Feb 2025 19:51:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 82C4D280001; Tue, 4 Feb 2025 19:51:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A5D728000B; Tue, 4 Feb 2025 19:51:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 47A30280001 for ; Tue, 4 Feb 2025 19:51:34 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D1E2980409 for ; Wed, 5 Feb 2025 00:51:33 +0000 (UTC) X-FDA: 83084062866.03.2732E42 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf29.hostedemail.com (Postfix) with ESMTP id E8C89120008 for ; Wed, 5 Feb 2025 00:51:31 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=nXPhJT6w; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of vannapurve@google.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=vannapurve@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738716692; a=rsa-sha256; cv=none; b=WVleQwAfqPKiNccjLrZ5btexHu6OzX7JdjJ+pTM0En0J7k3TFwENeG/52LhCckd6gBW9b/ tMQymOrsKkZT8dwGdKLi2pMygb1SaCq+QDowlkEEB+MesJMEdribbGoSSMfae4x0ZI1IJt sRM20odBU1yZFIOKoNW+XgPKn9Lzc94= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=nXPhJT6w; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of vannapurve@google.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=vannapurve@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738716692; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Hc8Lcys0yC2tF2+f+cOwe8ZYx1K/RKZrOMNcRMYC5p4=; b=knWb/FNF8J86CsY+T3l33R5d3TQTKKuyjQJ0RqC/p2LijWxykCA2LdcrFne6lwNy9hAxtG IOiuOyGO/RdTc9YTJYn4UCdnTlJLR9YZxnpOeQReu/J4kI6KsNzdmkH4o3Bmfc0z2GIO6u vAyW+8tONUxxcEF/ayG641oHXFpoqi0= Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5401af8544bso9687e87.1 for ; Tue, 04 Feb 2025 16:51:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738716690; x=1739321490; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Hc8Lcys0yC2tF2+f+cOwe8ZYx1K/RKZrOMNcRMYC5p4=; b=nXPhJT6wrt3K2nZCQMjYI7Oy+q1p7f9w8/0Tgpe1Pz2JPLpXOnIP8lmwe/XNd58Xoc MR80lnF1+t9+xwD+QORPt5TyKBsmr2HthH2IcYOteotqnB5OtzC8Inns361C8ptKVrr3 SDTguPRP/pyp4Y35FnnGaLFScOY9oBBZEZeKKElv7OskIXEvFWPRLLVI1nfdSuqbF2z3 N/13sRh79BX0qJnbagAiOAU4g5L2fbu9q0kQHmZlfeM3Mm0xQ3cgwtIztuAXUYsIPkYO 7baEMTGDW3751cn/GYrpZ0mX6bcIuG+PLJOZlsnRvFNepkMr7Kkn9ucaaIhkGlb0iSkQ +7jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738716690; x=1739321490; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hc8Lcys0yC2tF2+f+cOwe8ZYx1K/RKZrOMNcRMYC5p4=; b=o0C7u5zKDJjhtS7vIN+p9OiH1QpfU3UiFyuk3Vp/CBFxqIJZRQsseY/5hCDcpiDWBz XGdjS2CgRvLHCX7UPALXwv7bngCd9hBOgiycPorZuLftQGZCD4PsKfkEyjDgGhNczt7W Fi8G43/VZHgDzbmDpT86NmYkznhRf7HoV/r4/FtJkH/swJ/vIBMY4U7owg1utGWDe/vW QyA3SwD605NecEZtjCS7aN7OYwAG+IlvgimqsvYLR/5ShWWx0hsf1gVzLS9HNztlRjh8 d977TpdEPsUm9nC+F9p2m6739/MfCFXdDNfE7Zu4+j1nujw+3oI8MX+3IL5jU19uRcX3 P+ZQ== X-Forwarded-Encrypted: i=1; AJvYcCV0SfXGqn9UwKIv+z5OVkwV6ulqrwniLbCQkF3qKGNL7588oAlwWJu/gUm3jfRtynS86ABR85y4iQ==@kvack.org X-Gm-Message-State: AOJu0YzlUZG056kV1g9f1P6JorVuu6gZl12/VjFhTcUF+cqCugt8jb2t k0sHO87eUr2JHduuq1EV/yvPM0bYyVKE8FLSH2sSsLMjtKsSgSnWkFN/Gt2BynVJQKBQvZb7qNl 47kis/qm7U7+sGkPHPrwg0IRoSosCy9F4bIPsArZo2qKaY+L7yE7YKEXzdw== X-Gm-Gg: ASbGncvLKlWvzk7jWprmJcvCryfW7udgSU01ok7vhZ1/1/RckESQtmQtl7yEn1R1eXR PUh9Sh87qwZInCPEKbglNf4V9dRYSUD+zu1+eWM1U1MM7v13U7h/g4w4Oq4tOjQIWD/cLpGHNUZ WRQGGLY4dA0NkGfqCZLSNYWgA/ X-Google-Smtp-Source: AGHT+IGFQO7s55x3biW/18h8H5HRUzXB3NHyKRsEz3BGUxgrIoIQVnI5qZd01OD1ZeF2iLwQJ+MGR/VRwInf18RB54k= X-Received: by 2002:a05:6512:220d:b0:543:e5ac:8ba9 with SMTP id 2adb3069b0e04-54400262b09mr447679e87.6.1738716689955; Tue, 04 Feb 2025 16:51:29 -0800 (PST) MIME-Version: 1.0 References: <20250117163001.2326672-1-tabba@google.com> <20250117163001.2326672-7-tabba@google.com> In-Reply-To: <20250117163001.2326672-7-tabba@google.com> From: Vishal Annapurve Date: Tue, 4 Feb 2025 16:51:18 -0800 X-Gm-Features: AWEUYZkuSE-sHTWcu7LlcMXcBbzwY2ZrjgMl2ba1jEXbdckTrns-xOC5624jTFM Message-ID: Subject: Re: [RFC PATCH v5 06/15] KVM: guest_memfd: Handle final folio_put() of guestmem pages To: Fuad Tabba Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, yu.c.zhang@linux.intel.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E8C89120008 X-Stat-Signature: 4fxms8qtp9xw6k6d17u35f8xbspj1mjp X-Rspam-User: X-HE-Tag: 1738716691-891066 X-HE-Meta: U2FsdGVkX1+5QZfN4JbtfirB+kqP+QO1oRwVlNIkaWHjZgWXRqUiA+nd/oT+ZLbVyBfJLBTu6x18PK9Uw9lVvB5Vk/YL84h8LxYV4eS6HUrm3XQLX0st0xGXzK90//PazAssEqUiMNvUxrZMQrXrVzPAS8lc0NvPoTKQFBcdEonahwvfAwNs7ak/vBZmVWEcfaPJOz7JgNLFAuFLpIAB8EcizYthHb9Mne8WL1J2wHuXIhqFOyrZYrV4B5yofGliFowW9dUh6AbLLOJBktlKfBRpemNnH61atGDKdAKlEDCTyLmZbROca9qUHD+KIMBHcgFoAfjEp22cB+roSP2ShuJInQ9hE2CnT0OEUwWVE5x7ztWcqWR1d16q+b/HvWH/AA1tT6zOr+6OI7UerX9cGdY2lkyA5n36bXB+uoyjGTlHr11OBlQ2SAc4VKJiyXKI7zrIC98rYiLaqz23uDTdfS2CkyXOohCKTd02NTE3tRyWypJvwrgxMa3RK4QzQIATC6LdT56/4tX1m2fU6F/WTUqebv4PPgDOHjtKeZvlqQ1vX0axAJ4B1ZRbz72FtsPGZ2yyPN7hc4Y3o32u/mRdwU3WffK7x7+0KlcZrSS5iePMV0VLF+vhN4+u/1nBp8inqeOJbs6OAxzulyhCAfATw45oUBjsquLwguxJSHnSVBj7iIBGWNvY9vTfNy4+hVqGEXll7iOXI8gwpcD3av8GKQdVf1NDQuqdNVL6A87vxEpXtprBiDA0pPuoOeKVqcxmKJ2cNfRQhQU7RlhqLZZOLyBgSZcTFpp6wsVfmrC50L32FbuBTmFtbII3gWjNhkB8GHOi+eKXDg7lxCLK9UhNxNkbfiSHnsWMJVkINy+/5A2PNpemR5ijAnSdIXUCfWLgpE7ochs1MIw3fmFV8sQ5UmX48AZf98x8iqZ+nrj0enJl17dGh+4WAmJ9CxnvtBH7+JtQtDCDbpC1hv5B7ls 2Xd69Znj hmQwhWvK2xEGBDT4lEUpxrflwwQ3243VzdDehbPtjCg1jjlA8YmmN0qCahymimKxdmGu12THxXPDNJoI8JTR98LTU0H+B7XFq+h4nieBXtBMHb9i8rzd4TsXTD4oXVuQJEGafxynqp1Te2Stcqd6d8+lewhgVlp27MVqPaydA2j+loliK2SrFSh00GUbMHAbvqzjGa8RBQoKIfTV4hIVNz1WR4X8xYaUr3baVfYEsyidcao4L7XdNVUFr/fukGVhZCza49zGhQ8wlHbW+GACPiBo953uPO5HWROHi+PGAezHQ6DwzgmHMfmZXMzAEvNle/zJL1HfwdAJ+vOwj6rIfONm7D4v7heuvFdTfFC6T4M9lSdyF48aoeXT4hszAqt4yJnrGlvS0+zpWIPmGuYorKqXNFMNOxq3fz4JrxDno7dtb7lJiLow3OF1rI5LZB88tbvEu1H+kiU4rl2A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 17, 2025 at 8:30=E2=80=AFAM Fuad Tabba wrote= : > > > static const char *page_type_name(unsigned int page_type) > diff --git a/mm/swap.c b/mm/swap.c > index 6f01b56bce13..15220eaabc86 100644 > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -37,6 +37,7 @@ > #include > #include > #include > +#include > > #include "internal.h" > > @@ -103,6 +104,9 @@ static void free_typed_folio(struct folio *folio) > case PGTY_offline: > /* Nothing to do, it's offline. */ > return; > + case PGTY_guestmem: > + kvm_gmem_handle_folio_put(folio); > + return; Unless it's discussed before, kvm_gmem_handle_folio_put() needs to be implemented outside KVM code which could be unloaded at runtime. Eliott's plan [1] to implement a guest_memfd library can handle this scenario in future. [1] https://patches.linaro.org/project/linux-arm-msm/patch/20240829-guest-m= emfd-lib-v2-1-b9afc1ff3656@quicinc.com/