From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F505C3A59D for ; Fri, 5 Apr 2024 22:04:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98AF56B0087; Fri, 5 Apr 2024 18:04:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93AE16B0088; Fri, 5 Apr 2024 18:04:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82AAA6B008A; Fri, 5 Apr 2024 18:04:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6B4FD6B0087 for ; Fri, 5 Apr 2024 18:04:15 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F265980280 for ; Fri, 5 Apr 2024 22:04:14 +0000 (UTC) X-FDA: 81976857228.16.3B2AEE6 Received: from mail-oo1-f43.google.com (mail-oo1-f43.google.com [209.85.161.43]) by imf21.hostedemail.com (Postfix) with ESMTP id 5CCCB1C0012 for ; Fri, 5 Apr 2024 22:04:13 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SNlbCuDw; spf=pass (imf21.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.161.43 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712354653; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nvvf4g26OzQ7AjS7BC0DWpau/lYPZIFPXocYGg3AheM=; b=U8T8HWJdHIQb4rs9FBkUhII5feNRVd6iVTX18wasLea+ihn75A1NH4CR8CsFKn2OAFBZqg lF/V1k/RX2kAfitcjqMLfzs2h2guJ3q7ngHqp2+DV4j+ZSxKVT0T4wYZX/L8gVcVsO7TjU kaRP+tVrAuac8lctJrHKkdtA+j4s2wM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712354653; a=rsa-sha256; cv=none; b=DxBe7d240NOaNoRqjlPk9snHlHpSi6DN65GxPSvVWoJgHleAin5/IUpka/+zsL3bDHX4rl RmlXFLOvDPa3z2nIlcquKfHfpjmMMyMOeJ29UYw0Qhfog1ypmdQSUXe3qfm/oyh/QHS7RQ 84O5049ILoNOD3sh8FfQHm6r0LWHxo4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SNlbCuDw; spf=pass (imf21.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.161.43 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-oo1-f43.google.com with SMTP id 006d021491bc7-5a480985625so1544182eaf.0 for ; Fri, 05 Apr 2024 15:04:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712354652; x=1712959452; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nvvf4g26OzQ7AjS7BC0DWpau/lYPZIFPXocYGg3AheM=; b=SNlbCuDwFW042Vnhik5PVZpiizCRmETWrESDzuSalC477swctRGlUqK7KTERmmVuhG gJsyAaWxQDyH+KhAAPmiAogsZ3HrXm7DmFS/i/E6AulUS7T9nY3B/NdZNbF9ipC8wKfB EUkn1ABpg1LNoequxoPbjxzHMMVUTrPXpef+Iw4M+URhYlYsvYYOPeVhyxfvbePCTKwP gZRZ6oPtdnErdJtgKToAPNbHDCDyG64pygdA/yabJ/pOy4jGl3/OR5MwuKpDkQI9TqbC Cvf/722EqRSFgWP5NpnOF71lATBS8I8eSXK4t6VpJEUoWu+6MDYLYJBvCEgt3ohQZSKX Y5Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712354652; x=1712959452; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nvvf4g26OzQ7AjS7BC0DWpau/lYPZIFPXocYGg3AheM=; b=hEMtM3/qpfRdFVBBARpQvQpcpcHzQ+/xX/qDPIy1z1CzzKgR2/3dpPYrrB0xWkCW2M WdLHCFFr6AcMP4DXTbtSny7WZhEO6z+QwJS2fX1naVESTEKPWUK6RQ2gWEJTShda5ygz Lf/6Z0UieA88w5vg6Fs7P+bV9485H7luHNOEjBxOufcn1GNDMIvdBuotqWaqZiky7SQH FHEMYFmYJva5iMKsUhWHvptzBZaNz2BC45lM5R2Sj2R2WJiZyYDHkQ7YPj5+/NSSiKiB MIsoB1iGUA1Sm6SSjgleJI1kzFTo28XgXMVSpjlox9FMDLnxLUYjsyokZZbUQ38qmw3Y YEVg== X-Gm-Message-State: AOJu0YyeVB5O8s2z+cgRPr47yvutbAiWa1o8E5AiZ+vhKjdcz+seB5jX iWglKZwYnCCOJVWK1pF8Any1TC9WuIgh6q8zqvQGovD60xbVeE3J2MWr5l3gm+DLwMK8IlZLFYk l7yZve+Arkgz0p4YlnR2U/PkC1ZU= X-Google-Smtp-Source: AGHT+IHvjFxH0+jgB0lMROHxOkAjg9FGDRQxW2XIaxWhyBPsgkgcaFWFHZcxsEAJoN8TKZL0gINjC0BfClmWG0dCcoo= X-Received: by 2002:a05:6359:4194:b0:183:fb08:7fcf with SMTP id ki20-20020a056359419400b00183fb087fcfmr2743281rwc.7.1712354652248; Fri, 05 Apr 2024 15:04:12 -0700 (PDT) MIME-Version: 1.0 References: <20240405102704.77559-1-21cnbao@gmail.com> <20240405131140.8881aae1af0d877dc70c8ea9@linux-foundation.org> In-Reply-To: <20240405131140.8881aae1af0d877dc70c8ea9@linux-foundation.org> From: Barry Song <21cnbao@gmail.com> Date: Sat, 6 Apr 2024 11:04:01 +1300 Message-ID: Subject: Re: [PATCH v4 0/2] mm: add per-order mTHP alloc and swpout counters To: Andrew Morton , david@redhat.com, ryan.roberts@arm.com Cc: linux-mm@kvack.org, cerasuolodomenico@gmail.com, chrisl@kernel.org, kasong@tencent.com, peterx@redhat.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, yosryahmed@google.com, yuzhao@google.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5CCCB1C0012 X-Rspam-User: X-Stat-Signature: 7fi8uy34sndbfhcx3thefsskiowmq9o5 X-Rspamd-Server: rspam03 X-HE-Tag: 1712354653-51456 X-HE-Meta: U2FsdGVkX1+fBCp911CXDefEt+sEN+J/amKV0Hz+0LuQiRhTypesS7wIjGZeYngdVVzuJhBqTLa9mELFyO+xVup661NGCepoH6MzwcWk2YeXi+lum3HiKKQ2x8k7UsjBJv1XTR7XegDkuFPmllLNQ74Zqb9nA8Ad1AlWBAbdfALNGReDwwrOoODpNsuqYpZ9QJCDaf2fyV/wwZWSlOXE+5FFJiAyyUcXmdUU3FGwCeFq4RtMU3eMbUckaLvGqkub1+1wqtak3kaE3JS2RkP1oifrQ5SjpgyIvi6zgSrvOI6A7ubxMVKk5qTl4Qx+k6e4hOktKkCt8qkdR+yArsoF/8Z2Q6Y42SQe3n2V/Zq6+6SrEqWkFc1aIMk1IQZYwTZ5uSsZiEsxFQ9biJP+VYX6ZvryabjcjCirGg7oTcccQS7QnCMQz+0R2Xr6e/UbTreyAUy2lsP/bN7bcn8Np289BL7LOYilhmPvGMSW10kLwFlIescUL0V7jhzKPe71GDcXhzQAZ9cHln+yjlj1fBo/FG4e1eIaogW1OWv1S2H4pi5yfWcnBUbwqt8FAO6DZP/SRf9gidrNgafA7mQzT1ggA7k2NAHnl93iXFtWd//EGNJ71bYOcK+UjnHo/sLyI19yVfeaIB0q1dtiESRceRxoFwMQ2KqO8XgSeneFqE0sFDwR/JnbUhfkqqFBWH0kBeq08Ae9VEg4ZZUImysOvuZF54ekejx6dF2ZdiDyVMH4C6KS6Eu0vFfWi+nbq9D7JuzmonTChCa5zAg7JQTSEqrMN9zMWxc65mzUYW0EZ37HZ/Ve5RChK4fDQhM5CSxuWvR0FIDnHpL63whNhIdE9+C22fLbbyFCTUGXP0zDIZxHNmvakBFatGoCMIYB2Xl44nG2V1NTAFJlyYKWJn9yLdze/nJyE/blM3WF2aZKiWOQ3Y0DmTl4JgF3cpuYqcp3Ar36cpXDiAJpHGVAUNVcucf SQolicbj Tq3UiGA+Dp47otR1F5RZ+o92dos2CXZ+6oB5Q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Apr 6, 2024 at 9:11=E2=80=AFAM Andrew Morton wrote: > > On Fri, 5 Apr 2024 23:27:02 +1300 Barry Song <21cnbao@gmail.com> wrote: > > > The patchset introduces a framework to facilitate mTHP counters, starti= ng > > with the allocation and swap-out counters. Currently, only four new nod= es > > are appended to the stats directory for each mTHP size. > > > > /sys/kernel/mm/transparent_hugepage/hugepages-/stats > > anon_alloc > > anon_alloc_fallback > > anon_swpout > > anon_swpout_fallback > > Please let's get these documented? Sure, I will do it. Furthermore, after careful consideration, I suggest renaming anon_alloc to anon_fault_alloc and anon_alloc_fallback to anon_fault_fallback. This renaming is consistent with the naming convention observed in thp_fault_alloc and thp_fault_fallback in vmstat. Additionally, this modification will facilitate the handling of large folio swap-ins. /sys/kernel/mm/transparent_hugepage/hugepages-/stats anon_fault_alloc, anon_fault_fallback, anon_swpin_alloc, anon_swpin_fallback, Otherwise, without this renaming, it would be difficult to differentiate fault_alloc from swpin_alloc. Hi David, Ryan, I would also appreciate your input on the modification I am considering. > Documentation/admin-guide/mm/transhuge.rst seems to be the place, and > under Documentation/ABI. Thanks Barry