From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 414F6C5AD49 for ; Tue, 3 Jun 2025 01:06:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D65D26B037E; Mon, 2 Jun 2025 21:06:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D15B66B0380; Mon, 2 Jun 2025 21:06:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C05006B0381; Mon, 2 Jun 2025 21:06:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 978C36B037E for ; Mon, 2 Jun 2025 21:06:29 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 56A1881747 for ; Tue, 3 Jun 2025 01:06:29 +0000 (UTC) X-FDA: 83512298898.21.92BCF47 Received: from mail-ua1-f45.google.com (mail-ua1-f45.google.com [209.85.222.45]) by imf21.hostedemail.com (Postfix) with ESMTP id 7E5C21C000B for ; Tue, 3 Jun 2025 01:06:27 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ixcD7rtR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.45 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748912787; a=rsa-sha256; cv=none; b=GRHVkTpEBML80CpcmYhB9vPolKcBv/C5bDUrcjuyFBIouqCuxO1AqZLkMYzJW09vewNi7w CEMcX6IcXKNvZDe5xktT0/dpCfJ6iy7glUp0UeKBCLcqMwmbaQibdTVXc1aPj69RIlddID EYy1jWvjoa0I3EEuZX5yjRww3/mRJWU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ixcD7rtR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.45 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748912787; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RMWJOZogaV2etWlkqjrll2es/GxO7IMRXY6bKWAVxg8=; b=BW64sywqe1jmQTfbv1NSE5iOj918fR6iCDh7n6GhcVxNZTERXHuOn63b2aZ+JTRbizMA0N 8Tq1TsqJt8EACEWswlDue5kvyGXjrF1P++v4LlYvoOkhg3HX+qv5f9HTYwkwd/sO+Kd1WA vQkZWzDsRXBzrg3OFyttMaSBj41LIaw= Received: by mail-ua1-f45.google.com with SMTP id a1e0cc1a2514c-87df943b6dcso1078628241.1 for ; Mon, 02 Jun 2025 18:06:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748912786; x=1749517586; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RMWJOZogaV2etWlkqjrll2es/GxO7IMRXY6bKWAVxg8=; b=ixcD7rtRLvjEe2a3N3bLjFxC0pluOUKMP/GcoE0tWxB4f7DurlZ93pWXIQtEQyTMV8 aW0EMDydcXTXb5I+NtK8xhTV20OY5tn2k0arWUp6X46X+3HaPqaivvT9AbDsKcbpQHQt gtSBg5gpEhkcUWPZWx5CkkprWyvDldv5Yv9zud94S6SW8MX8RKxLxz5zt3Q8pY1HuPvq ++XDa0W7iDsv13t8abuPlGlKW3GsPADKrfFHCYzcfn3Bgyn4K5aeO9/DFN3tAgofLBdB 52pYe3ZkdkN4bsszcUuu+nNfKKPPe2ksgZmt2RUYIxXdSweopPO//9mGgcmg5Ijj3rIq LMvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748912786; x=1749517586; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RMWJOZogaV2etWlkqjrll2es/GxO7IMRXY6bKWAVxg8=; b=RYDcttW45pwx7MDxQFqmI014vgjGE9z/oMwByAMTA2Wt635EYZEJwFqSGw6QW3kjZd wUNR2YQroGtJunmDhZw3vqZLSs9QQjLmU1kpHQH1iaZcPou2adsRUQqh2Aah5UDcIE2h RLWIoTg7y9wgVlgRPRxl5VnhZ4LRo/YCshZEX4q4Ij2ZB59N2lcYDrSmtlbNWEF9bU/A /eUHXuFQMS3vJcY0VJk3EuSc3jK+UO7EQaWXwpUedFufvhC6txHkY+TJYlsnysVS96TF PZPnfYNh9/wI/LEoVCGZGoNYUy5X19ZkDWs+NQJd8wSBNeewJzoENXMpLBLROsDTdJH4 2F/w== X-Forwarded-Encrypted: i=1; AJvYcCUs7v6dBCA1aZpBHhNIxtCbqrnBrUXz2BtW9gb/7YY8mCrFwKiTZKIblAqj4YEKz4osM0l9Sdxziw==@kvack.org X-Gm-Message-State: AOJu0YyRrcuuv93zDsC6RMgJLtIDWr2On6AxjTfyt2vxyco6nS+g9sqI Am+LELbcAyI1Cm72ve5/fzLn8fHs4ZgG5AiqukA3pSCU9XPa0ATV8U2a1Gjg2f1o6zSuYRFlH46 wGmpkdj6c+nyCmIKGJ9wpONSaBh7Cr4I= X-Gm-Gg: ASbGncsHNrkiqBwOAFYGcMx55xWa3vT8i1Isks8ElnMwm6rLvHKDWRgvPIdNZ1wdW3Z HMhKGNK5IwdPf413jUU9o4+F8njdX4umhRlV3YtB6JARwhV6qNdCJjtHh6uSr8PuOOz3oFo/bVJ 7X68P8giHEU/1Y9RzO6pvUDZZvkeEogB9SSQ== X-Google-Smtp-Source: AGHT+IFv1DDQlBCn1QAD/Dswpbv0WSJDOOcrkdSUJ0DqRBgPDUm+GITEq9c9Vmq3Itwa3dtZJOKBJZi7cMsZkgXSbWg= X-Received: by 2002:a05:6102:dd0:b0:4e5:997a:748f with SMTP id ada2fe7eead31-4e6ece6d01fmr11278344137.22.1748912786462; Mon, 02 Jun 2025 18:06:26 -0700 (PDT) MIME-Version: 1.0 References: <20250530104439.64841-1-21cnbao@gmail.com> <002aa917-d952-491d-800c-88a0476ac02f@lucifer.local> <23edf435-7cfe-49d1-9432-aee64c0096ab@lucifer.local> In-Reply-To: <23edf435-7cfe-49d1-9432-aee64c0096ab@lucifer.local> From: Barry Song <21cnbao@gmail.com> Date: Tue, 3 Jun 2025 13:06:15 +1200 X-Gm-Features: AX0GCFvkC_IF6P1FnyYJWeX09mDj2GXyu33xJdbnsR1KIBqWnbKfL868T9IukPE Message-ID: Subject: Re: [PATCH RFC v2] mm: use per_vma lock for MADV_DONTNEED To: Lorenzo Stoakes Cc: Jann Horn , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , "Liam R. Howlett" , David Hildenbrand , Vlastimil Babka , Suren Baghdasaryan , Lokesh Gidra , Tangquan Zheng Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7E5C21C000B X-Stat-Signature: 5pfw1ira93pssh56wxcxo6e1tyy8zwjp X-Rspam-User: X-HE-Tag: 1748912787-517928 X-HE-Meta: U2FsdGVkX18r39c01uCQvyKg2QSM2NacU2z252uTPq6ucsFN+SDBvmV46wH9Z/GZ5rJEYk4w09Ag4eqaqN3YnOfl1GQ1OBwkrhnb6BDbvb9eS5Maa2CFaerXRHFfkW3mR6Wb8nA+qF2cRa+byD9flSazU36xkeKaqCFIb6nv1zS042wBvlhV7ehbeUyxwp4qqd9NSI7YkQ6xRnCZ3UbYkVQIofWISFYXZNnhIkXuNOGPyrabne/zvPFlngbZNKuDSWezMNvxc12DtSm/W9lH4VeSxxy0kqHn+4XsCTTTenOnLTGQAWS99LC3XENpuo0Zp3HpAR918PIlDj/SXFAhIVhGayC6/ffNRNCkLvP8eS+wdPl2QGq/Oq7q+lMyGTPYLI3MnO8P2wLeYpGuhaW2pieHvMxGYSyESq0QETeCM0Iwk3RESsO3AGLyb4Usjhx2iQ99oGODk69H7wqhKQxfCblp/eRQkOuQB/L58BR/zz9iY/PWQTqy/CsFZKBbuz7yt1H/F+ZSvk2lSF/2MHGdGk+wnDuHqc3fYI9UvgWB6XSyYCwF+YDyB4F6tHp1mxK2nSK3gP/rOdlsMbnlZM47Fwh1AjkY+SERsn7CCMAq2pNJzJd+Kfno+0hqgge/ymbM6Zwovopw/+6ZxeXxHdH+N2huNXiFiugfGK3J4903KDiQ87PQRvkUm1/b3Gl+JN+J0xf1/jLzY96LOxsqGK1jj8qm21zLH9t9dx/SZbvObufIobHs8n/4Zf0wrF9x1aj8FSr2v73PQDJbLPXrCH5gR0i9fQBkwpmPAUG8RkB8RVZBp54yhvPwhuDt2DIiZQSQWoIhvOWIEzXYdQk9Uxg99KEjRzYFYh/WyYsojE3UmC3wL1FdJdOotNuP8CORb/uztyN+ft0UktKu3CvI1e3GFz5RPIwM6LQR00d7tgkQKOEAn4vwOCymlBDFls/KTpLN6sGp9IBFv4gfuhFtKi8 QRkT8xSf nrZOpcisFIbvgIN74jyrjd3sWHtYybUYVjYHCv3GoZPQTWOEsB8e4tnuRl0OQqkAHJ9fZ0tD2n/rUaDiimCxtjP5fsya0vT6NIPqbfylE/Kvp2rzLNRgYkSP3cYJbZFry1vRIqe4KrzR+uUAJPfqePXr+cLkCXMNQzDI8eoPF3bX6e25aNUuGPNpwQIQ8kCsf1ERqCYHtZZuvE3HQuJtoXSLXmFizZ1Y1XX3AQJxOrM4Pnq2Wm2b52+zqOQOBqaQgty3zRbOnSluOH/lcHv2wcH3Bh4KcUElesQMa46NomKCyJPvAObfQ3t+OQECClY04qlvKkd0QZBjVFgFSbwQroqizteizNULa+lApXSv/AR0pSRXtXKIRIbozs2x2eYJXv/EDQtmKEYtXGmY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Lorenzo, On Mon, Jun 2, 2025 at 11:50=E2=80=AFPM Lorenzo Stoakes wrote: > > Barry - would you mind if I went off and wrote a quick patch to separate > walk_page_range_novma() into walk_page_range_kernel() and > walk_page_range_user_novma()? > > I realise this is a pain, but I feel strongly that having them together i= s > a source of confusion and having us special case a -only used in ptdump- > case like this is not great. > > It wouldn't include any VMA locking stuff from this patch, which you coul= d > then rebase on that. > > I think it'd make sense as a separate series and I can throw that out > fairly quickly... > > But I don't want to step on any toes so just let me know! Feel free to proceed with the patch. I can rebase on top of your walk_page_range_kernel() changes. Thanks Barry